All of
 help / color / mirror / Atom feed
From: Bjorn Helgaas <>
To: kbuild test robot <>
Cc: Alexandru Gagniuc <>,,
Subject: Re: [pci:pci/hotplug 4/5] (.text+0x3454): multiple definition of `pci_acpi_program_hp_params'
Date: Tue, 23 Apr 2019 12:57:28 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Apr 23, 2019 at 08:09:08AM +0800, kbuild test robot wrote:
> tree: pci/hotplug
> head:   c098676c4df695cc8f430bfa5fa803f41c8584f4
> commit: 8c76b06f58183e15f31d6660c9bd049cbba9e4f6 [4/5] PCI / ACPI: Remove the need for 'struct hotplug_params'
> config: riscv-allyesconfig (attached as .config)
> compiler: riscv64-linux-gcc (GCC) 8.1.0
> reproduce:
>         wget -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 8c76b06f58183e15f31d6660c9bd049cbba9e4f6
>         # save the attached .config to linux build tree
>         GCC_VERSION=8.1.0 make.cross ARCH=riscv 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <>
> All errors (new ones prefixed by >>):
>    drivers/pci/pci.o: In function `pci_acpi_program_hp_params':
> >> (.text+0x3454): multiple definition of `pci_acpi_program_hp_params'
>    drivers/pci/probe.o:(.text+0x864): first defined here

I fixed this by making the non-ACPI stub of
pci_acpi_program_hp_params() a "static inline" function:

diff --git a/include/linux/pci_hotplug.h b/include/linux/pci_hotplug.h
index 352c5169c256..f694eb2ca978 100644
--- a/include/linux/pci_hotplug.h
+++ b/include/linux/pci_hotplug.h
@@ -188,8 +188,8 @@ bool shpchp_is_native(struct pci_dev *bridge);
 int acpi_pci_check_ejectable(struct pci_bus *pbus, acpi_handle handle);
 int acpi_pci_detect_ejectable(acpi_handle handle);
-int pci_acpi_program_hp_params(struct pci_dev *dev,
-			       const struct hotplug_program_ops *hp_ops)
+static inline int pci_acpi_program_hp_params(struct pci_dev *dev,
+				    const struct hotplug_program_ops *hp_ops)
 	return -ENODEV;

      reply	other threads:[~2019-04-23 17:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-23  0:09 [pci:pci/hotplug 4/5] (.text+0x3454): multiple definition of `pci_acpi_program_hp_params' kbuild test robot
2019-04-23 17:57 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.