* [pci:pci/hotplug 4/5] (.text+0x3454): multiple definition of `pci_acpi_program_hp_params'
@ 2019-04-23 0:09 kbuild test robot
2019-04-23 17:57 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2019-04-23 0:09 UTC (permalink / raw)
To: Alexandru Gagniuc; +Cc: kbuild-all, linux-pci, Bjorn Helgaas
[-- Attachment #1: Type: text/plain, Size: 3824 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/hotplug
head: c098676c4df695cc8f430bfa5fa803f41c8584f4
commit: 8c76b06f58183e15f31d6660c9bd049cbba9e4f6 [4/5] PCI / ACPI: Remove the need for 'struct hotplug_params'
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 8.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 8c76b06f58183e15f31d6660c9bd049cbba9e4f6
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/pci/pci.o: In function `pci_acpi_program_hp_params':
>> (.text+0x3454): multiple definition of `pci_acpi_program_hp_params'
drivers/pci/probe.o:(.text+0x864): first defined here
drivers/pci/slot.o: In function `pci_acpi_program_hp_params':
(.text+0x792): multiple definition of `pci_acpi_program_hp_params'
drivers/pci/probe.o:(.text+0x864): first defined here
drivers/pci/hotplug/pci_hotplug_core.o: In function `pci_acpi_program_hp_params':
(.text+0xa0e): multiple definition of `pci_acpi_program_hp_params'
drivers/pci/probe.o:(.text+0x864): first defined here
drivers/pci/hotplug/cpci_hotplug_core.o: In function `pci_acpi_program_hp_params':
(.text+0x1282): multiple definition of `pci_acpi_program_hp_params'
drivers/pci/probe.o:(.text+0x864): first defined here
drivers/pci/hotplug/cpci_hotplug_pci.o: In function `pci_acpi_program_hp_params':
(.text+0x0): multiple definition of `pci_acpi_program_hp_params'
drivers/pci/probe.o:(.text+0x864): first defined here
drivers/pci/hotplug/pciehp_core.o: In function `pci_acpi_program_hp_params':
(.text+0x622): multiple definition of `pci_acpi_program_hp_params'
drivers/pci/probe.o:(.text+0x864): first defined here
drivers/pci/hotplug/pciehp_ctrl.o: In function `pci_acpi_program_hp_params':
(.text+0xde): multiple definition of `pci_acpi_program_hp_params'
drivers/pci/probe.o:(.text+0x864): first defined here
drivers/pci/hotplug/pciehp_pci.o: In function `pci_acpi_program_hp_params':
(.text+0x46): multiple definition of `pci_acpi_program_hp_params'
drivers/pci/probe.o:(.text+0x864): first defined here
drivers/pci/hotplug/pciehp_hpc.o: In function `pci_acpi_program_hp_params':
(.text+0x5d4): multiple definition of `pci_acpi_program_hp_params'
drivers/pci/probe.o:(.text+0x864): first defined here
drivers/pci/hotplug/shpchp_core.o: In function `pci_acpi_program_hp_params':
(.text+0x39a): multiple definition of `pci_acpi_program_hp_params'
drivers/pci/probe.o:(.text+0x864): first defined here
drivers/pci/hotplug/shpchp_ctrl.o: In function `pci_acpi_program_hp_params':
(.text+0xc56): multiple definition of `pci_acpi_program_hp_params'
drivers/pci/probe.o:(.text+0x864): first defined here
drivers/pci/hotplug/shpchp_pci.o: In function `pci_acpi_program_hp_params':
(.text+0x0): multiple definition of `pci_acpi_program_hp_params'
drivers/pci/probe.o:(.text+0x864): first defined here
drivers/pci/hotplug/shpchp_sysfs.o: In function `pci_acpi_program_hp_params':
(.text+0x1be): multiple definition of `pci_acpi_program_hp_params'
drivers/pci/probe.o:(.text+0x864): first defined here
drivers/pci/hotplug/shpchp_hpc.o: In function `pci_acpi_program_hp_params':
(.text+0xe00): multiple definition of `pci_acpi_program_hp_params'
drivers/pci/probe.o:(.text+0x864): first defined here
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 56171 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [pci:pci/hotplug 4/5] (.text+0x3454): multiple definition of `pci_acpi_program_hp_params'
2019-04-23 0:09 [pci:pci/hotplug 4/5] (.text+0x3454): multiple definition of `pci_acpi_program_hp_params' kbuild test robot
@ 2019-04-23 17:57 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2019-04-23 17:57 UTC (permalink / raw)
To: kbuild test robot; +Cc: Alexandru Gagniuc, kbuild-all, linux-pci
On Tue, Apr 23, 2019 at 08:09:08AM +0800, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/hotplug
> head: c098676c4df695cc8f430bfa5fa803f41c8584f4
> commit: 8c76b06f58183e15f31d6660c9bd049cbba9e4f6 [4/5] PCI / ACPI: Remove the need for 'struct hotplug_params'
> config: riscv-allyesconfig (attached as .config)
> compiler: riscv64-linux-gcc (GCC) 8.1.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 8c76b06f58183e15f31d6660c9bd049cbba9e4f6
> # save the attached .config to linux build tree
> GCC_VERSION=8.1.0 make.cross ARCH=riscv
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
>
> All errors (new ones prefixed by >>):
>
> drivers/pci/pci.o: In function `pci_acpi_program_hp_params':
> >> (.text+0x3454): multiple definition of `pci_acpi_program_hp_params'
> drivers/pci/probe.o:(.text+0x864): first defined here
I fixed this by making the non-ACPI stub of
pci_acpi_program_hp_params() a "static inline" function:
diff --git a/include/linux/pci_hotplug.h b/include/linux/pci_hotplug.h
index 352c5169c256..f694eb2ca978 100644
--- a/include/linux/pci_hotplug.h
+++ b/include/linux/pci_hotplug.h
@@ -188,8 +188,8 @@ bool shpchp_is_native(struct pci_dev *bridge);
int acpi_pci_check_ejectable(struct pci_bus *pbus, acpi_handle handle);
int acpi_pci_detect_ejectable(acpi_handle handle);
#else
-int pci_acpi_program_hp_params(struct pci_dev *dev,
- const struct hotplug_program_ops *hp_ops)
+static inline int pci_acpi_program_hp_params(struct pci_dev *dev,
+ const struct hotplug_program_ops *hp_ops)
{
return -ENODEV;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-23 17:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-23 0:09 [pci:pci/hotplug 4/5] (.text+0x3454): multiple definition of `pci_acpi_program_hp_params' kbuild test robot
2019-04-23 17:57 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.