[PATCH] platform/x86: alienware-wmi: printing the wrong error code

[PATCH] platform/x86: alienware-wmi: printing the wrong error code

[Dan Carpenter]

The "out_data" variable is uninitialized at the point.  Originally, this
used to print "status" instead and that seems like the correct thing to
print.

Fixes: bc2ef884320b ("alienware-wmi: For WMAX HDMI method, introduce a way to query HDMI cable status")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/platform/x86/alienware-wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c
index c0d1555735cd..83fd7677af24 100644
--- a/drivers/platform/x86/alienware-wmi.c
+++ b/drivers/platform/x86/alienware-wmi.c
@@ -587,7 +587,7 @@ static ssize_t show_hdmi_source(struct device *dev,
 			return scnprintf(buf, PAGE_SIZE,
 					 "input [gpu] unknown\n");
 	}
-	pr_err("alienware-wmi: unknown HDMI source status: %d\n", out_data);
+	pr_err("alienware-wmi: unknown HDMI source status: %u\n", status);
 	return scnprintf(buf, PAGE_SIZE, "input gpu [unknown]\n");
 }
 
-- 
2.18.0

Re: [PATCH] platform/x86: alienware-wmi: printing the wrong error code

[Mario.Limonciello]

>Fixes: bc2ef884320b ("alienware-wmi: For WMAX HDMI method, introduce a way to query HDMI cable status")
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>---
> drivers/platform/x86/alienware-wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c
>index c0d1555735cd..83fd7677af24 100644
>--- a/drivers/platform/x86/alienware-wmi.c
>+++ b/drivers/platform/x86/alienware-wmi.c
>@@ -587,7 +587,7 @@ static ssize_t show_hdmi_source(struct device *dev,
>                        return scnprintf(buf, PAGE_SIZE,
>                                         "input [gpu] unknown\n");
>        }
>-       pr_err("alienware-wmi: unknown HDMI source status: %d\n", out_data);
>+       pr_err("alienware-wmi: unknown HDMI source status: %u\n", status);
>        return scnprintf(buf, PAGE_SIZE, "input gpu [unknown]\n");
> }
>
>--
>2.18.0

Yes, thanks.
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>

Re: [PATCH] platform/x86: alienware-wmi: printing the wrong error code

[Andy Shevchenko]

On Wed, Apr 24, 2019 at 3:43 PM <Mario.Limonciello@dell.com> wrote:
>
> >Fixes: bc2ef884320b ("alienware-wmi: For WMAX HDMI method, introduce a way to query HDMI cable status")
> >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Pushed to my review and testing queue, thanks!


> >---
> > drivers/platform/x86/alienware-wmi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c
> >index c0d1555735cd..83fd7677af24 100644
> >--- a/drivers/platform/x86/alienware-wmi.c
> >+++ b/drivers/platform/x86/alienware-wmi.c
> >@@ -587,7 +587,7 @@ static ssize_t show_hdmi_source(struct device *dev,
> >                        return scnprintf(buf, PAGE_SIZE,
> >                                         "input [gpu] unknown\n");
> >        }
> >-       pr_err("alienware-wmi: unknown HDMI source status: %d\n", out_data);
> >+       pr_err("alienware-wmi: unknown HDMI source status: %u\n", status);
> >        return scnprintf(buf, PAGE_SIZE, "input gpu [unknown]\n");
> > }
> >
> >--
> >2.18.0
>
> Yes, thanks.
> Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
>


-- 
With Best Regards,
Andy Shevchenko