All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: Jiada Wang <jiada_wang@mentor.com>
Cc: <rui.zhang@intel.com>, <edubezval@gmail.com>,
	<daniel.lezcano@linaro.org>, <linux-pm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <horms+renesas@verge.net.au>,
	<niklas.soderlund+renesas@ragnatech.se>,
	<geert+renesas@glider.be>, <sergei.shtylyov@cogentembedded.com>,
	<marek.vasut+renesas@gmail.com>,
	<kuninori.morimoto.gx@renesas.com>, <hien.dang.eb@renesas.com>,
	<fabrizio.castro@bp.renesas.com>, <dien.pham.ry@renesas.com>,
	<biju.das@bp.renesas.com>, <george_davis@mentor.com>,
	<joshua_frkuska@mentor.com>,
	Eugeniu Rosca <erosca@de.adit-jv.com>,
	Eugeniu Rosca <roscaeugeniu@gmail.com>
Subject: Re: [PATCH v4 1/2] thermal: rcar_gen3_thermal: fix interrupt type
Date: Wed, 24 Apr 2019 14:28:05 +0200	[thread overview]
Message-ID: <20190424122805.GA22366@vmlxhi-102.adit-jv.com> (raw)
In-Reply-To: <20190424051145.23072-2-jiada_wang@mentor.com>

On Wed, Apr 24, 2019 at 02:11:44PM +0900, Jiada Wang wrote:
> Currently IRQF_SHARED type interrupt line is allocated, but it
> is not appropriate, as the interrupt line isn't shared between
> different devices, instead IRQF_ONESHOT is the proper type.
> 
> By changing interrupt type to IRQF_ONESHOT, now irq handler is
> no longer needed, as clear of interrupt status can be done in
> threaded interrupt context.
> 
> Because IRQF_ONESHOT type interrupt line is kept disabled until
> the threaded handler has been run, so there is no need to protect
> read/write of REG_GEN3_IRQSTR with lock.
> 
> Fixes: 7d4b269776ec6 ("enable hardware interrupts for trip points")
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>

Based on https://patchwork.kernel.org/cover/10914079/#22603533 :

Reviewed-and-Tested-by: Eugeniu Rosca <erosca@de.adit-jv.com>

Thanks!

-- 
Best regards,
Eugeniu.

WARNING: multiple messages have this Message-ID (diff)
From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: Jiada Wang <jiada_wang@mentor.com>
Cc: rui.zhang@intel.com, edubezval@gmail.com,
	daniel.lezcano@linaro.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, horms+renesas@verge.net.au,
	niklas.soderlund+renesas@ragnatech.se, geert+renesas@glider.be,
	sergei.shtylyov@cogentembedded.com,
	marek.vasut+renesas@gmail.com, kuninori.morimoto.gx@renesas.com,
	hien.dang.eb@renesas.com, fabrizio.castro@bp.renesas.com,
	dien.pham.ry@renesas.com, biju.das@bp.renesas.com,
	george_davis@mentor.com, joshua_frkuska@mentor.com,
	Eugeniu Rosca <erosca@de.adit-jv.com>,
	Eugeniu Rosca <roscaeugeniu@gmail.com>
Subject: Re: [PATCH v4 1/2] thermal: rcar_gen3_thermal: fix interrupt type
Date: Wed, 24 Apr 2019 14:28:05 +0200	[thread overview]
Message-ID: <20190424122805.GA22366@vmlxhi-102.adit-jv.com> (raw)
In-Reply-To: <20190424051145.23072-2-jiada_wang@mentor.com>

On Wed, Apr 24, 2019 at 02:11:44PM +0900, Jiada Wang wrote:
> Currently IRQF_SHARED type interrupt line is allocated, but it
> is not appropriate, as the interrupt line isn't shared between
> different devices, instead IRQF_ONESHOT is the proper type.
> 
> By changing interrupt type to IRQF_ONESHOT, now irq handler is
> no longer needed, as clear of interrupt status can be done in
> threaded interrupt context.
> 
> Because IRQF_ONESHOT type interrupt line is kept disabled until
> the threaded handler has been run, so there is no need to protect
> read/write of REG_GEN3_IRQSTR with lock.
> 
> Fixes: 7d4b269776ec6 ("enable hardware interrupts for trip points")
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>

Based on https://patchwork.kernel.org/cover/10914079/#22603533 :

Reviewed-and-Tested-by: Eugeniu Rosca <erosca@de.adit-jv.com>

Thanks!

-- 
Best regards,
Eugeniu.

  parent reply	other threads:[~2019-04-24 12:28 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24  5:11 [PATCH v4 0/2] thermal: rcar_gen3_thermal: fix IRQ issues Jiada Wang
2019-04-24  5:11 ` Jiada Wang
2019-04-24  5:11 ` [PATCH v4 1/2] thermal: rcar_gen3_thermal: fix interrupt type Jiada Wang
2019-04-24  5:11   ` Jiada Wang
2019-04-24  9:23   ` Simon Horman
2019-04-24  9:31   ` Daniel Lezcano
2019-04-24 12:28   ` Eugeniu Rosca [this message]
2019-04-24 12:28     ` Eugeniu Rosca
2019-04-24  5:11 ` [PATCH v4 2/2] thermal: rcar_gen3_thermal: disable interrupt in .remove Jiada Wang
2019-04-24  5:11   ` Jiada Wang
2019-04-24  9:23   ` Simon Horman
2019-04-24  9:38   ` Daniel Lezcano
2019-04-24 12:31   ` Eugeniu Rosca
2019-04-24 12:31     ` Eugeniu Rosca
2019-04-24  6:51 ` [PATCH v4 0/2] thermal: rcar_gen3_thermal: fix IRQ issues Niklas Söderlund
2019-04-24 12:09 ` Eugeniu Rosca
2019-04-24 12:09   ` Eugeniu Rosca
2019-05-07 23:54 ` Niklas Söderlund
2019-05-10 10:42   ` Eugeniu Rosca
2019-05-10 10:42     ` Eugeniu Rosca
2019-05-10 11:36     ` Niklas Söderlund
2019-05-10 15:50       ` Eugeniu Rosca
2019-05-10 15:50         ` Eugeniu Rosca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190424122805.GA22366@vmlxhi-102.adit-jv.com \
    --to=erosca@de.adit-jv.com \
    --cc=biju.das@bp.renesas.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dien.pham.ry@renesas.com \
    --cc=edubezval@gmail.com \
    --cc=fabrizio.castro@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=george_davis@mentor.com \
    --cc=hien.dang.eb@renesas.com \
    --cc=horms+renesas@verge.net.au \
    --cc=jiada_wang@mentor.com \
    --cc=joshua_frkuska@mentor.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=roscaeugeniu@gmail.com \
    --cc=rui.zhang@intel.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.