* [PATCH net-next] tipc: remove rcu_read_unlock() left in tipc_udp_recv()
@ 2019-04-25 0:21 Eric Dumazet
2019-04-26 16:01 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2019-04-25 0:21 UTC (permalink / raw)
To: David S . Miller; +Cc: netdev, Eric Dumazet, Eric Dumazet, kbuild test robot
I forgot to remove one rcu_read_unlock() before a return statement.
Joy of mixing goto and return styles in a function :)
Fixes: 4109a2c3b91e ("tipc: tipc_udp_recv() cleanup vs rcu verbs")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: kbuild test robot <lkp@intel.com>
---
net/tipc/udp_media.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c
index 7413cbc9b638af492d6a592df957a3229fa6a3fa..0884a1b8ad12595cabca71229789c55a14f24659 100644
--- a/net/tipc/udp_media.c
+++ b/net/tipc/udp_media.c
@@ -360,7 +360,6 @@ static int tipc_udp_recv(struct sock *sk, struct sk_buff *skb)
if (b && test_bit(0, &b->up)) {
tipc_rcv(sock_net(sk), skb, b);
- rcu_read_unlock();
return 0;
}
--
2.21.0.593.g511ec345e18-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] tipc: remove rcu_read_unlock() left in tipc_udp_recv()
2019-04-25 0:21 [PATCH net-next] tipc: remove rcu_read_unlock() left in tipc_udp_recv() Eric Dumazet
@ 2019-04-26 16:01 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-04-26 16:01 UTC (permalink / raw)
To: edumazet; +Cc: netdev, eric.dumazet, lkp
From: Eric Dumazet <edumazet@google.com>
Date: Wed, 24 Apr 2019 17:21:40 -0700
> I forgot to remove one rcu_read_unlock() before a return statement.
>
> Joy of mixing goto and return styles in a function :)
>
> Fixes: 4109a2c3b91e ("tipc: tipc_udp_recv() cleanup vs rcu verbs")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: kbuild test robot <lkp@intel.com>
Applied, thanks Eric.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-26 16:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-25 0:21 [PATCH net-next] tipc: remove rcu_read_unlock() left in tipc_udp_recv() Eric Dumazet
2019-04-26 16:01 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.