All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] HID: logitech-dj: check return value of hid_hw_raw_request()
@ 2019-04-25  2:36 YueHaibing
  0 siblings, 0 replies; only message in thread
From: YueHaibing @ 2019-04-25  2:36 UTC (permalink / raw)
  To: kernel-janitors

hid_hw_raw_request may fails, we should return the
return value to callers.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/hid/hid-logitech-dj.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
index 64e68ac871cb..a3e94f15213a 100644
--- a/drivers/hid/hid-logitech-dj.c
+++ b/drivers/hid/hid-logitech-dj.c
@@ -1131,7 +1131,7 @@ static int logi_dj_recv_query_hidpp_devices(struct dj_receiver_dev *djrcv_dev)
 				    HID_REQ_SET_REPORT);
 
 	kfree(hidpp_report);
-	return 0;
+	return retval;
 }
 
 static int logi_dj_recv_query_paired_devices(struct dj_receiver_dev *djrcv_dev)

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-04-25  2:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-25  2:36 [PATCH -next] HID: logitech-dj: check return value of hid_hw_raw_request() YueHaibing

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.