[PATCH] [v8, 1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel

[PATCH] [v8, 1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel

[Jerry Han]

The Boe Himax8279d is a 8.0" panel with a 1200x1920 resolution and
connected to DSI using four lanes.

V8:
- Modify communication address

V7:
- Add the information of the reviewer

V6:
- Add the information of the reviewer

V5:
- Added changelog

V4:
- None

V3:
- None

V2:
- Add compatible device "boe,himax8279d10p" (Sam)
- Add the necessary property descriptions (Sam)

Signed-off-by: Jerry Han <jerry.han.hq@gmail.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Derek Basehore <dbasehore@chromium.org>
Cc: Jitao Shi <jitao.shi@mediatek.com>
Cc: Rock wang <rock_wang@himax.com.cn>
---
 .../bindings/display/panel/boe,himax8279d.txt | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt

diff --git a/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt b/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
new file mode 100644
index 000000000000..3caea2172b1b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
@@ -0,0 +1,24 @@
+Boe Himax8279d 1200x1920 TFT LCD panel
+
+Required properties:
+- compatible: should be "boe,himax8279d8p" and one of: "boe,himax8279d10p"
+- reg: DSI virtual channel of the peripheral
+- enable-gpios: panel enable gpio
+- pp33-gpios: a GPIO phandle for the 3.3v pin that provides the supply voltage
+- pp18-gpios: a GPIO phandle for the 1.8v pin that provides the supply voltage
+
+Optional properties:
+- backlight: phandle of the backlight device attached to the panel
+
+Example:
+
+	&mipi_dsi {
+		panel {
+			compatible = "boe,himax8279d8p", "boe,himax8279d10p";
+			reg = <0>;
+			backlight = <&backlight>;
+			enable-gpios = <&gpio 45 GPIO_ACTIVE_HIGH>;
+			pp33-gpios = <&gpio 35 GPIO_ACTIVE_HIGH>;
+			pp18-gpios = <&gpio 36 GPIO_ACTIVE_HIGH>;
+		};
+	};
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] [v8,1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel

[Jerry Han]

[-- Attachment #1.1: Type: text/plain, Size: 2475 bytes --]

Hi Thierry Reding：

*Could you please help to check whether there is any problem with the
sign-off identity**?*


*Thanks*

Jerry Han <jerry.han.hq@gmail.com> 于2019年4月25日周四 上午11:18写道：

> The Boe Himax8279d is a 8.0" panel with a 1200x1920 resolution and
> connected to DSI using four lanes.
>
> V8:
> - Modify communication address
>
> V7:
> - Add the information of the reviewer
>
> V6:
> - Add the information of the reviewer
>
> V5:
> - Added changelog
>
> V4:
> - None
>
> V3:
> - None
>
> V2:
> - Add compatible device "boe,himax8279d10p" (Sam)
> - Add the necessary property descriptions (Sam)
>
> Signed-off-by: Jerry Han <jerry.han.hq@gmail.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> Reviewed-by: Derek Basehore <dbasehore@chromium.org>
> Cc: Jitao Shi <jitao.shi@mediatek.com>
> Cc: Rock wang <rock_wang@himax.com.cn>
> ---
>  .../bindings/display/panel/boe,himax8279d.txt | 24 +++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
>
> diff --git
> a/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
> b/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
> new file mode 100644
> index 000000000000..3caea2172b1b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
> @@ -0,0 +1,24 @@
> +Boe Himax8279d 1200x1920 TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "boe,himax8279d8p" and one of: "boe,himax8279d10p"
> +- reg: DSI virtual channel of the peripheral
> +- enable-gpios: panel enable gpio
> +- pp33-gpios: a GPIO phandle for the 3.3v pin that provides the supply
> voltage
> +- pp18-gpios: a GPIO phandle for the 1.8v pin that provides the supply
> voltage
> +
> +Optional properties:
> +- backlight: phandle of the backlight device attached to the panel
> +
> +Example:
> +
> +       &mipi_dsi {
> +               panel {
> +                       compatible = "boe,himax8279d8p",
> "boe,himax8279d10p";
> +                       reg = <0>;
> +                       backlight = <&backlight>;
> +                       enable-gpios = <&gpio 45 GPIO_ACTIVE_HIGH>;
> +                       pp33-gpios = <&gpio 35 GPIO_ACTIVE_HIGH>;
> +                       pp18-gpios = <&gpio 36 GPIO_ACTIVE_HIGH>;
> +               };
> +       };
> --
> 2.17.1
>
>

[-- Attachment #1.2: Type: text/html, Size: 4836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] [v8, 1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel

[Sam Ravnborg]

On Thu, Apr 25, 2019 at 11:18:42AM +0800, Jerry Han wrote:
> The Boe Himax8279d is a 8.0" panel with a 1200x1920 resolution and
> connected to DSI using four lanes.
> 
> V8:
> - Modify communication address
> 
> V7:
> - Add the information of the reviewer
> 
> V6:
> - Add the information of the reviewer
> 
> V5:
> - Added changelog
> 
> V4:
> - None
> 
> V3:
> - None
> 
> V2:
> - Add compatible device "boe,himax8279d10p" (Sam)
> - Add the necessary property descriptions (Sam)
> 
> Signed-off-by: Jerry Han <jerry.han.hq@gmail.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> Reviewed-by: Derek Basehore <dbasehore@chromium.org>
> Cc: Jitao Shi <jitao.shi@mediatek.com>
> Cc: Rock wang <rock_wang@himax.com.cn>

Thanks,
patch applied to drm-misc-next and will be pushed out soon.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] [v8, 1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel

[Emil Velikov]

On Wed, 26 Jun 2019 at 13:55, Sam Ravnborg <sam@ravnborg.org> wrote:
>
> On Thu, Apr 25, 2019 at 11:18:42AM +0800, Jerry Han wrote:
> > The Boe Himax8279d is a 8.0" panel with a 1200x1920 resolution and
> > connected to DSI using four lanes.
> >
> > V8:
> > - Modify communication address
> >
> > V7:
> > - Add the information of the reviewer
> >
> > V6:
> > - Add the information of the reviewer
> >
> > V5:
> > - Added changelog
> >
> > V4:
> > - None
> >
> > V3:
> > - None
> >
> > V2:
> > - Add compatible device "boe,himax8279d10p" (Sam)
> > - Add the necessary property descriptions (Sam)
> >
> > Signed-off-by: Jerry Han <jerry.han.hq@gmail.com>
> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> > Reviewed-by: Derek Basehore <dbasehore@chromium.org>
> > Cc: Jitao Shi <jitao.shi@mediatek.com>
> > Cc: Rock wang <rock_wang@himax.com.cn>
>
> Thanks,
> patch applied to drm-misc-next and will be pushed out soon.
>
Isn't an ack/rb from a DT maintainer a requirement before being picked
via the DRM trees?
It used to be a thing, although it could have changed recently.

AFAICT there are no users for this binding, yet I'm not sure if that
is a requirement.

Rob H, can you please share some light?
Perhaps it's worth documenting these somewhere under Documentation/
and adding a link to those in the DRM documentation.

Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] [v8, 1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel

[Sam Ravnborg]

Hi Emil.

> >
> > Thanks,
> > patch applied to drm-misc-next and will be pushed out soon.
> >
> Isn't an ack/rb from a DT maintainer a requirement before being picked
> via the DRM trees?
> It used to be a thing, although it could have changed recently.
I got OK via irc to take some simple panel bindings patches.
Which explains the lack of a-b or r-b on this patch from any DT folks.

So I processed what was in queue.
Maybe the OK was only for a smaller set of patches but I did process
only panel-bindings that I was ready to add my r-b on.

> 
> AFAICT there are no users for this binding, yet I'm not sure if that
> is a requirement.
To my best knowledge a kernel user is not a requirement.
In this case there is a patch in-the-works and I considered to
wait until the patch was ready. But decided to process the DT-binding
as the binding is a prerequisite for the panel driver,
but not the other way around. Again to my understanding.

So everything was done to avoid having panel patches hanging in
dri-devel for excessive amount of time.
One could say that this was already the case that they had waited for
too long.

Another - not so obvious thing . was that having all patches in
drm-misc-next allows us to have an easier time migrating all panel
patches to yaml which I hope will take place in the next month or two.
I am waiting for the inital patch-set by Rob to land, and then there
is some janitorial job to migrate remainign panel bindings to yaml.
This is easier to do with everyting in drm-misc-next rather than asking
several different persons to do it.
Once done there will be lot of examples to work from, so for new panel
bindings it should be easier.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] [v8, 1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel

[Emil Velikov]

On Wed, 26 Jun 2019 at 15:29, Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Emil.
>
> > >
> > > Thanks,
> > > patch applied to drm-misc-next and will be pushed out soon.
> > >
> > Isn't an ack/rb from a DT maintainer a requirement before being picked
> > via the DRM trees?
> > It used to be a thing, although it could have changed recently.
> I got OK via irc to take some simple panel bindings patches.
> Which explains the lack of a-b or r-b on this patch from any DT folks.
>
> So I processed what was in queue.
> Maybe the OK was only for a smaller set of patches but I did process
> only panel-bindings that I was ready to add my r-b on.
>
Fair enough. I've seen people add the "ok" in the commit itself and
the line ending with "# over IRC" or alike.

> >
> > AFAICT there are no users for this binding, yet I'm not sure if that
> > is a requirement.
> To my best knowledge a kernel user is not a requirement.
> In this case there is a patch in-the-works and I considered to
> wait until the patch was ready. But decided to process the DT-binding
> as the binding is a prerequisite for the panel driver,
> but not the other way around. Again to my understanding.
>
> So everything was done to avoid having panel patches hanging in
> dri-devel for excessive amount of time.
> One could say that this was already the case that they had waited for
> too long.
>
> Another - not so obvious thing . was that having all patches in
> drm-misc-next allows us to have an easier time migrating all panel
> patches to yaml which I hope will take place in the next month or two.
> I am waiting for the inital patch-set by Rob to land, and then there
> is some janitorial job to migrate remainign panel bindings to yaml.
> This is easier to do with everyting in drm-misc-next rather than asking
> several different persons to do it.
> Once done there will be lot of examples to work from, so for new panel
> bindings it should be easier.
>
Ooh shiny. Thanks Sam.

-Emil
P.S. From a non-native speaker to another, spell check FTW.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel