All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] board: am335x: Drop duplicate pinmux configuration
@ 2019-04-25 14:12 paul at betafive.co.uk
  2019-05-03 18:20 ` Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: paul at betafive.co.uk @ 2019-04-25 14:12 UTC (permalink / raw)
  To: u-boot

From: Paul Barker <paul.barker@sancloud.co.uk>

In commit ad6054f1fe128f797b6eb2964afca6674b584785 where support for the
Sancloud BeagleBone Enhanced (BBE) was added, new conditional
configuration of either MII pin muxing or RGMII pin muxing is done
depending on the board type. However, the old call to set up MII pin
muxing was not removed.

This may result in misconfiguration of the pin muxing for the BBE or
duplicate configuration for other boards and so we remove this obsolete
call.

Signed-off-by: Paul Barker <paul.barker@sancloud.co.uk>
---
 board/ti/am335x/mux.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/board/ti/am335x/mux.c b/board/ti/am335x/mux.c
index 04f4b8e6934..37a599768b1 100644
--- a/board/ti/am335x/mux.c
+++ b/board/ti/am335x/mux.c
@@ -399,7 +399,6 @@ void enable_board_pin_mux(void)
 			configure_module_pin_mux(mii1_pin_mux);
 		}
 		/* Beaglebone LT pinmux */
-		configure_module_pin_mux(mii1_pin_mux);
 		configure_module_pin_mux(mmc0_pin_mux);
 #if defined(CONFIG_NAND) && defined(CONFIG_EMMC_BOOT)
 		configure_module_pin_mux(nand_pin_mux);
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] board: am335x: Drop duplicate pinmux configuration
  2019-04-25 14:12 [U-Boot] [PATCH] board: am335x: Drop duplicate pinmux configuration paul at betafive.co.uk
@ 2019-05-03 18:20 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2019-05-03 18:20 UTC (permalink / raw)
  To: u-boot

On Thu, Apr 25, 2019 at 03:12:00PM +0100, paul at betafive.co.uk wrote:

> From: Paul Barker <paul.barker@sancloud.co.uk>
> 
> In commit ad6054f1fe128f797b6eb2964afca6674b584785 where support for the
> Sancloud BeagleBone Enhanced (BBE) was added, new conditional
> configuration of either MII pin muxing or RGMII pin muxing is done
> depending on the board type. However, the old call to set up MII pin
> muxing was not removed.
> 
> This may result in misconfiguration of the pin muxing for the BBE or
> duplicate configuration for other boards and so we remove this obsolete
> call.
> 
> Signed-off-by: Paul Barker <paul.barker@sancloud.co.uk>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190503/ed156fc1/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-03 18:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-25 14:12 [U-Boot] [PATCH] board: am335x: Drop duplicate pinmux configuration paul at betafive.co.uk
2019-05-03 18:20 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.