All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>
Cc: qemu-devel@nongnu.org, mprivozn@redhat.com,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] qapi: SupportStatusInfo struct
Date: Thu, 25 Apr 2019 14:42:08 -0300	[thread overview]
Message-ID: <20190425174208.GO18406@habkost.net> (raw)
In-Reply-To: <b8a8e3fb-281a-7252-4899-859959a97a1d@redhat.com>

On Thu, Apr 25, 2019 at 11:20:58AM -0300, Wainer dos Santos Moschetta wrote:
> Hi Eduardo,
> 
> 
> On 04/23/2019 06:22 PM, Eduardo Habkost wrote:
> > This struct will be used to represent support and deprecation
> > status of QEMU features.
> > 
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> >   qapi/common.json | 24 ++++++++++++++++++++++++
> >   1 file changed, 24 insertions(+)
> > 
> > diff --git a/qapi/common.json b/qapi/common.json
> > index 99d313ef3b..b59d0dc66b 100644
> > --- a/qapi/common.json
> > +++ b/qapi/common.json
> > @@ -193,3 +193,27 @@
> >                'ppc64', 'riscv32', 'riscv64', 's390x', 'sh4',
> >                'sh4eb', 'sparc', 'sparc64', 'tricore', 'unicore32',
> >                'x86_64', 'xtensa', 'xtensaeb' ] }
> > +
> > +##
> > +# @SupportStatusInfo:
> > +#
> > +# Information on support status of a given feature
> > +# (e.g. machine type)
> > +#
> > +# @deprecated: if true, the given feature is deprecated and may be removed
> > +#              in future versions of QEMU according to the QEMU deprecation
> > +#              policy.
> 
> Eventually management software will need the know the QEMU version the
> feature is planed for removal. So makes sense to include a field to capture
> that information as well or do you expect it to be added (as a good
> practice) in the 'status-message'?

If we really want to provide extra information like version
numbers, adding a separate field sounds better than using
status-message.

But I'm not sure we really want to include this amount of detail
in the API.  Mentioning explicit version numbers could make
things more complex for downstream distributions of QEMU that
include backports and/or have a different deprecation policy.

I'd like to hear opinions from others.

-- 
Eduardo

WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>
Cc: mprivozn@redhat.com, qemu-devel@nongnu.org,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] qapi: SupportStatusInfo struct
Date: Thu, 25 Apr 2019 14:42:08 -0300	[thread overview]
Message-ID: <20190425174208.GO18406@habkost.net> (raw)
Message-ID: <20190425174208.Kt8QlsRmoXiQ1NaX8c_qO2Pal17VDdnp5a9joP8_0qs@z> (raw)
In-Reply-To: <b8a8e3fb-281a-7252-4899-859959a97a1d@redhat.com>

On Thu, Apr 25, 2019 at 11:20:58AM -0300, Wainer dos Santos Moschetta wrote:
> Hi Eduardo,
> 
> 
> On 04/23/2019 06:22 PM, Eduardo Habkost wrote:
> > This struct will be used to represent support and deprecation
> > status of QEMU features.
> > 
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> >   qapi/common.json | 24 ++++++++++++++++++++++++
> >   1 file changed, 24 insertions(+)
> > 
> > diff --git a/qapi/common.json b/qapi/common.json
> > index 99d313ef3b..b59d0dc66b 100644
> > --- a/qapi/common.json
> > +++ b/qapi/common.json
> > @@ -193,3 +193,27 @@
> >                'ppc64', 'riscv32', 'riscv64', 's390x', 'sh4',
> >                'sh4eb', 'sparc', 'sparc64', 'tricore', 'unicore32',
> >                'x86_64', 'xtensa', 'xtensaeb' ] }
> > +
> > +##
> > +# @SupportStatusInfo:
> > +#
> > +# Information on support status of a given feature
> > +# (e.g. machine type)
> > +#
> > +# @deprecated: if true, the given feature is deprecated and may be removed
> > +#              in future versions of QEMU according to the QEMU deprecation
> > +#              policy.
> 
> Eventually management software will need the know the QEMU version the
> feature is planed for removal. So makes sense to include a field to capture
> that information as well or do you expect it to be added (as a good
> practice) in the 'status-message'?

If we really want to provide extra information like version
numbers, adding a separate field sounds better than using
status-message.

But I'm not sure we really want to include this amount of detail
in the API.  Mentioning explicit version numbers could make
things more complex for downstream distributions of QEMU that
include backports and/or have a different deprecation policy.

I'd like to hear opinions from others.

-- 
Eduardo


  reply	other threads:[~2019-04-25 17:42 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-23 21:22 [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP Eduardo Habkost
2019-04-23 21:22 ` Eduardo Habkost
2019-04-23 21:22 ` [Qemu-devel] [PATCH 1/3] qapi: SupportStatusInfo struct Eduardo Habkost
2019-04-23 21:22   ` Eduardo Habkost
2019-04-23 22:23   ` Philippe Mathieu-Daudé
2019-04-24 18:24     ` Eduardo Habkost
2019-04-24 18:24       ` Eduardo Habkost
2019-04-24  8:26   ` Daniel P. Berrangé
2019-04-24  8:26     ` Daniel P. Berrangé
2019-04-24 18:20     ` Eduardo Habkost
2019-04-24 18:20       ` Eduardo Habkost
2019-04-30 10:10       ` Daniel P. Berrangé
2019-04-30 10:10         ` Daniel P. Berrangé
2019-04-30 12:42         ` Eduardo Habkost
2019-04-30 12:42           ` Eduardo Habkost
2019-04-30 12:47           ` Daniel P. Berrangé
2019-04-30 12:47             ` Daniel P. Berrangé
2019-04-25 14:20   ` Wainer dos Santos Moschetta
2019-04-25 17:42     ` Eduardo Habkost [this message]
2019-04-25 17:42       ` Eduardo Habkost
2019-04-30 10:03       ` Daniel P. Berrangé
2019-04-30 10:03         ` Daniel P. Berrangé
2019-04-23 21:22 ` [Qemu-devel] [PATCH 2/3] machine: Use SupportStatusInfo for deprecation info Eduardo Habkost
2019-04-23 21:22   ` Eduardo Habkost
2019-04-23 22:26   ` Philippe Mathieu-Daudé
2019-04-23 22:26     ` Philippe Mathieu-Daudé
2019-04-24  1:37   ` David Gibson
2019-04-24  1:37     ` David Gibson
2019-04-24  8:23   ` Daniel P. Berrangé
2019-04-24  8:23     ` Daniel P. Berrangé
2019-04-24 18:29     ` Eduardo Habkost
2019-04-24 18:29       ` Eduardo Habkost
2019-04-23 21:22 ` [Qemu-devel] [PATCH 3/3] qmp: Add deprecation information to query-machines Eduardo Habkost
2019-04-23 21:22   ` Eduardo Habkost
2019-04-24  8:28   ` Daniel P. Berrangé
2019-04-24  8:28     ` Daniel P. Berrangé
2019-04-25 14:54   ` Wainer dos Santos Moschetta
2019-04-25 17:43     ` Eduardo Habkost
2019-04-25 17:43       ` Eduardo Habkost
2019-04-23 21:28 ` [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP no-reply
2019-04-23 21:28   ` no-reply
2019-04-24  7:56 ` Thomas Huth
2019-04-24  8:31   ` Daniel P. Berrangé
2019-04-24  8:31     ` Daniel P. Berrangé
2019-04-24 18:14     ` Eduardo Habkost
2019-04-24 18:14       ` Eduardo Habkost
2019-04-24 18:10   ` Eduardo Habkost
2019-04-24 18:10     ` Eduardo Habkost
2019-04-25  7:38     ` Thomas Huth
2019-04-25  7:38       ` Thomas Huth
2019-04-30 10:11     ` Daniel P. Berrangé
2019-04-30 10:11       ` Daniel P. Berrangé
2019-04-24  8:23 ` Michal Privoznik
2019-04-24  8:23   ` Michal Privoznik
2019-05-07  5:07 ` Markus Armbruster
2019-05-07 16:18   ` Eduardo Habkost
2019-05-08  9:16     ` Markus Armbruster
2019-05-08 20:28       ` Eduardo Habkost
2019-05-09  8:31         ` Markus Armbruster
2019-05-09  9:14           ` Daniel P. Berrangé
2019-05-09 15:52             ` Eduardo Habkost
2019-05-09 16:08               ` Daniel P. Berrangé
2019-05-09 17:44                 ` Eduardo Habkost
2019-05-10  6:28                   ` Markus Armbruster
2019-05-10 17:03                     ` Eduardo Habkost
2019-05-10  6:19               ` Markus Armbruster
2019-05-10 17:00                 ` Eduardo Habkost
2019-05-09 18:19           ` Eduardo Habkost
2019-05-10  9:29             ` Markus Armbruster
2019-05-10 17:17               ` Eduardo Habkost
2019-05-10 17:26                 ` Daniel P. Berrangé
2019-05-13 11:49                 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190425174208.GO18406@habkost.net \
    --to=ehabkost@redhat.com \
    --cc=armbru@redhat.com \
    --cc=mprivozn@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.