All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
	Keith Busch <keith.busch@intel.com>,
	linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>,
	James Smart <james.smart@broadcom.com>,
	Dongli Zhang <dongli.zhang@oracle.com>,
	Bart Van Assche <bart.vanassche@wdc.com>,
	linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>
Subject: Re: [PATCH V7 9/9] nvme: hold request queue's refcount in ns's whole lifetime
Date: Sat, 27 Apr 2019 07:54:53 +0200	[thread overview]
Message-ID: <20190427055453.GA21483@lst.de> (raw)
In-Reply-To: <20190426224542.GD31470@ming.t460p>

On Sat, Apr 27, 2019 at 06:45:43AM +0800, Ming Lei wrote:
> Still no difference between your suggestion and the way in this patch, given
> driver specific change is a must. Even it is more clean to hold the
> queue refocunt by drivers explicitly because we usually do the get/put pair
> in one place, instead that getting refcnt in one subsystem, and doing put in
> another place.
> 
> I am going to drop this patch in V8 since my original plan is to fix block
> layer's race in this patchset.

Doing the untegistration and final reference drop is just a bad pattern,
leading to possible bugs.  I'm fine with you just dropping it for now,
I guess I'll just send a scripted conversion moving the put to the drivers
to Jens after -rc1 to sort it out.  Probably including a rename
of blk_cleanup_queue so that everyone notices the difference.

WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH V7 9/9] nvme: hold request queue's refcount in ns's whole lifetime
Date: Sat, 27 Apr 2019 07:54:53 +0200	[thread overview]
Message-ID: <20190427055453.GA21483@lst.de> (raw)
In-Reply-To: <20190426224542.GD31470@ming.t460p>

On Sat, Apr 27, 2019@06:45:43AM +0800, Ming Lei wrote:
> Still no difference between your suggestion and the way in this patch, given
> driver specific change is a must. Even it is more clean to hold the
> queue refocunt by drivers explicitly because we usually do the get/put pair
> in one place, instead that getting refcnt in one subsystem, and doing put in
> another place.
> 
> I am going to drop this patch in V8 since my original plan is to fix block
> layer's race in this patchset.

Doing the untegistration and final reference drop is just a bad pattern,
leading to possible bugs.  I'm fine with you just dropping it for now,
I guess I'll just send a scripted conversion moving the put to the drivers
to Jens after -rc1 to sort it out.  Probably including a rename
of blk_cleanup_queue so that everyone notices the difference.

  reply	other threads:[~2019-04-27  5:55 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24 11:02 [PATCH V7 0/9] blk-mq: fix races related with freeing queue Ming Lei
2019-04-24 11:02 ` Ming Lei
2019-04-24 11:02 ` [PATCH V7 1/9] blk-mq: grab .q_usage_counter when queuing request from plug code path Ming Lei
2019-04-24 11:02   ` Ming Lei
2019-04-24 16:18   ` Christoph Hellwig
2019-04-24 16:18     ` Christoph Hellwig
2019-04-25  0:53     ` Ming Lei
2019-04-25  0:53       ` Ming Lei
2019-04-25  5:32       ` Christoph Hellwig
2019-04-25  5:32         ` Christoph Hellwig
2019-04-25  7:35         ` Ming Lei
2019-04-25  7:35           ` Ming Lei
2019-04-24 11:02 ` [PATCH V7 2/9] blk-mq: move cancel of requeue_work into blk_mq_release Ming Lei
2019-04-24 11:02   ` Ming Lei
2019-04-24 16:18   ` Christoph Hellwig
2019-04-24 16:18     ` Christoph Hellwig
2019-04-24 11:02 ` [PATCH V7 3/9] blk-mq: free hw queue's resource in hctx's release handler Ming Lei
2019-04-24 11:02   ` Ming Lei
2019-04-24 16:19   ` Christoph Hellwig
2019-04-24 16:19     ` Christoph Hellwig
2019-04-24 11:02 ` [PATCH V7 4/9] blk-mq: move all hctx alloction & initialization into __blk_mq_alloc_and_init_hctx Ming Lei
2019-04-24 11:02   ` Ming Lei
2019-04-24 16:22   ` Christoph Hellwig
2019-04-24 16:22     ` Christoph Hellwig
2019-04-25  0:55     ` Ming Lei
2019-04-25  0:55       ` Ming Lei
2019-04-26 15:09       ` Christoph Hellwig
2019-04-26 15:09         ` Christoph Hellwig
2019-04-25  1:02     ` Ming Lei
2019-04-25  1:02       ` Ming Lei
2019-04-24 11:02 ` [PATCH V7 5/9] blk-mq: split blk_mq_alloc_and_init_hctx into two parts Ming Lei
2019-04-24 11:02   ` Ming Lei
2019-04-24 11:02 ` [PATCH V7 6/9] blk-mq: always free hctx after request queue is freed Ming Lei
2019-04-24 11:02   ` Ming Lei
2019-04-24 11:15   ` Hannes Reinecke
2019-04-24 11:15     ` Hannes Reinecke
2019-04-24 11:02 ` [PATCH V7 7/9] blk-mq: move cancel of hctx->run_work into blk_mq_hw_sysfs_release Ming Lei
2019-04-24 11:02   ` Ming Lei
2019-04-24 11:02 ` [PATCH V7 8/9] block: don't drain in-progress dispatch in blk_cleanup_queue() Ming Lei
2019-04-24 11:02   ` Ming Lei
2019-04-24 11:02 ` [PATCH V7 9/9] nvme: hold request queue's refcount in ns's whole lifetime Ming Lei
2019-04-24 11:02   ` Ming Lei
2019-04-24 16:27   ` Christoph Hellwig
2019-04-24 16:27     ` Christoph Hellwig
2019-04-25  1:00     ` Ming Lei
2019-04-25  1:00       ` Ming Lei
2019-04-26 15:11       ` Christoph Hellwig
2019-04-26 15:11         ` Christoph Hellwig
2019-04-26 17:04         ` Bart Van Assche
2019-04-26 17:04           ` Bart Van Assche
2019-04-26 22:49           ` Ming Lei
2019-04-26 22:49             ` Ming Lei
2019-04-26 22:45         ` Ming Lei
2019-04-26 22:45           ` Ming Lei
2019-04-27  5:54           ` Christoph Hellwig [this message]
2019-04-27  5:54             ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190427055453.GA21483@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=bart.vanassche@wdc.com \
    --cc=dongli.zhang@oracle.com \
    --cc=hare@suse.com \
    --cc=james.smart@broadcom.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.