From: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> To: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, Philipp Tomsich <philipp.tomsich-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>, Kever Yang <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>, Akash Gajjar <akash-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>, Tom Rini <trini-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>, Manivannan Sadhasivam <manivannan.sadhasivam-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Cc: Paul Kocialkowski <paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-amarula-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org, Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>, u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org Subject: [PATCH v6 07/13] rockchip: dts: rk3399: nanopi4: Use CD pin as RK_FUNC_1 Date: Sat, 27 Apr 2019 17:18:50 +0530 [thread overview] Message-ID: <20190427114852.7608-8-jagan@amarulasolutions.com> (raw) In-Reply-To: <20190427114852.7608-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> sdmmc cd pin is configured as RK_FUNC_GPIO which is wrong and indeed failed to detect the sdcard on the board with below error Card did not respond to voltage select! So, fix it by replacing RK_FUNC_GPIO with RK_FUNC_1 which is already defined in rk3399.dts so make use of same like other boards. Add these changes in -u-boot.dtsi to make Linux sync easy for future changes. Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> --- arch/arm/dts/rk3399-nanopi4-u-boot.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 arch/arm/dts/rk3399-nanopi4-u-boot.dtsi diff --git a/arch/arm/dts/rk3399-nanopi4-u-boot.dtsi b/arch/arm/dts/rk3399-nanopi4-u-boot.dtsi new file mode 100644 index 0000000000..20db99c0b8 --- /dev/null +++ b/arch/arm/dts/rk3399-nanopi4-u-boot.dtsi @@ -0,0 +1,9 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2019 Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> + */ + +&sdmmc { + pinctrl-names = "default"; + pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd &sdmmc_cd>; +}; -- 2.18.0.321.gffc6fa0e3
WARNING: multiple messages have this Message-ID (diff)
From: Jagan Teki <jagan@amarulasolutions.com> To: u-boot@lists.denx.de Subject: [U-Boot] [PATCH v6 07/13] rockchip: dts: rk3399: nanopi4: Use CD pin as RK_FUNC_1 Date: Sat, 27 Apr 2019 17:18:50 +0530 [thread overview] Message-ID: <20190427114852.7608-8-jagan@amarulasolutions.com> (raw) In-Reply-To: <20190427114852.7608-1-jagan@amarulasolutions.com> sdmmc cd pin is configured as RK_FUNC_GPIO which is wrong and indeed failed to detect the sdcard on the board with below error Card did not respond to voltage select! So, fix it by replacing RK_FUNC_GPIO with RK_FUNC_1 which is already defined in rk3399.dts so make use of same like other boards. Add these changes in -u-boot.dtsi to make Linux sync easy for future changes. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- arch/arm/dts/rk3399-nanopi4-u-boot.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 arch/arm/dts/rk3399-nanopi4-u-boot.dtsi diff --git a/arch/arm/dts/rk3399-nanopi4-u-boot.dtsi b/arch/arm/dts/rk3399-nanopi4-u-boot.dtsi new file mode 100644 index 0000000000..20db99c0b8 --- /dev/null +++ b/arch/arm/dts/rk3399-nanopi4-u-boot.dtsi @@ -0,0 +1,9 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com> + */ + +&sdmmc { + pinctrl-names = "default"; + pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd &sdmmc_cd>; +}; -- 2.18.0.321.gffc6fa0e3
next prev parent reply other threads:[~2019-04-27 11:48 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-27 11:48 [PATCH v6 00/13] rockchip: Add new rk3399 boards Jagan Teki 2019-04-27 11:48 ` [U-Boot] " Jagan Teki [not found] ` <20190427114852.7608-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-04-27 11:48 ` [PATCH v6 01/13] rockchip: dts: rk3399: Sync rk3399-opp from Linux Jagan Teki 2019-04-27 11:48 ` [U-Boot] " Jagan Teki 2019-04-27 11:48 ` [PATCH v6 02/13] rockchip: dts: rk3399: Sync pwm2_pin_pull_down from Linux 5.1-rc2 Jagan Teki 2019-04-27 11:48 ` [U-Boot] " Jagan Teki 2019-04-27 11:48 ` [PATCH v6 03/13] Kconfig: Add default SPL_FIT_GENERATOR for rockchip Jagan Teki 2019-04-27 11:48 ` [U-Boot] " Jagan Teki 2019-05-07 4:05 ` Kever Yang 2019-05-07 4:05 ` [U-Boot] " Kever Yang [not found] ` <7bd53b02-2a0f-d242-31bc-2baba0a69405-TNX95d0MmH7DzftRWevZcw@public.gmane.org> 2019-05-07 6:42 ` Jagan Teki 2019-05-07 6:42 ` [U-Boot] " Jagan Teki 2019-04-27 11:48 ` [PATCH v6 04/13] arm: rockchip: rk3399: Move common configs in Kconfig Jagan Teki 2019-04-27 11:48 ` [U-Boot] " Jagan Teki 2019-05-07 7:13 ` Kever Yang 2019-05-07 7:13 ` [U-Boot] " Kever Yang [not found] ` <17edf8e7-9c00-21ab-b2a0-cc4c80e57f0c-TNX95d0MmH7DzftRWevZcw@public.gmane.org> 2019-05-07 7:18 ` Jagan Teki 2019-05-07 7:18 ` [U-Boot] " Jagan Teki 2019-04-27 11:48 ` [PATCH v6 05/13] rockchip: rk3399: Add Orangepi RK3399 support Jagan Teki 2019-04-27 11:48 ` [U-Boot] " Jagan Teki 2019-04-27 11:48 ` [PATCH v6 06/13] rockchip: dts: rk3399: Sync rk3399-nanopi4.dtsi from Linux Jagan Teki 2019-04-27 11:48 ` [U-Boot] " Jagan Teki 2019-04-27 11:48 ` Jagan Teki [this message] 2019-04-27 11:48 ` [U-Boot] [PATCH v6 07/13] rockchip: dts: rk3399: nanopi4: Use CD pin as RK_FUNC_1 Jagan Teki 2019-04-27 11:48 ` [PATCH v6 08/13] rockchip: rk3399: Add Nanopi M4 board support Jagan Teki 2019-04-27 11:48 ` [U-Boot] " Jagan Teki 2019-04-27 11:48 ` [PATCH v6 09/13] rockchip: rk3399: Add Nanopc T4 " Jagan Teki 2019-04-27 11:48 ` [U-Boot] " Jagan Teki [not found] ` <20190427114852.7608-10-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-04-28 8:53 ` Jagan Teki 2019-04-28 8:53 ` [U-Boot] " Jagan Teki 2019-05-07 9:12 ` Paul Kocialkowski 2019-05-07 9:12 ` [U-Boot] " Paul Kocialkowski 2019-05-07 12:28 ` Jagan Teki 2019-05-07 12:28 ` [U-Boot] " Jagan Teki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190427114852.7608-8-jagan@amarulasolutions.com \ --to=jagan-dyjbcgdgk7pe9whmmfpqlfatqe2ktcn/@public.gmane.org \ --cc=akash-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org \ --cc=kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org \ --cc=linux-amarula-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org \ --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=manivannan.sadhasivam-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org \ --cc=philipp.tomsich-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org \ --cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=trini-OWPKS81ov/FWk0Htik3J/w@public.gmane.org \ --cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.