* [PATCH] libext2fs: remove unused variable 'buff'
@ 2019-04-22 21:08 Eric Biggers
2019-04-23 4:06 ` Gabriel Krisman Bertazi
0 siblings, 1 reply; 3+ messages in thread
From: Eric Biggers @ 2019-04-22 21:08 UTC (permalink / raw)
To: linux-ext4; +Cc: Gabriel Krisman Bertazi
From: Eric Biggers <ebiggers@google.com>
In ext2fs_dirhash2(), the outer 'buff' variable is never used.
Cc: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
lib/ext2fs/dirhash.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/ext2fs/dirhash.c b/lib/ext2fs/dirhash.c
index f1e7734d..97fd2431 100644
--- a/lib/ext2fs/dirhash.c
+++ b/lib/ext2fs/dirhash.c
@@ -279,7 +279,6 @@ errcode_t ext2fs_dirhash2(int version, const char *name, int len,
{
errcode_t r;
int dlen;
- unsigned char *buff;
if (len && charset) {
char buff[PATH_MAX];
--
2.21.0.593.g511ec345e18-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libext2fs: remove unused variable 'buff'
2019-04-22 21:08 [PATCH] libext2fs: remove unused variable 'buff' Eric Biggers
@ 2019-04-23 4:06 ` Gabriel Krisman Bertazi
2019-04-29 0:36 ` Theodore Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Gabriel Krisman Bertazi @ 2019-04-23 4:06 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-ext4, Gabriel Krisman Bertazi
Eric Biggers <ebiggers@kernel.org> writes:
> From: Eric Biggers <ebiggers@google.com>
>
> In ext2fs_dirhash2(), the outer 'buff' variable is never used.
>
> Cc: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>
--
Gabriel Krisman Bertazi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libext2fs: remove unused variable 'buff'
2019-04-23 4:06 ` Gabriel Krisman Bertazi
@ 2019-04-29 0:36 ` Theodore Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2019-04-29 0:36 UTC (permalink / raw)
To: Gabriel Krisman Bertazi; +Cc: Eric Biggers, linux-ext4, Gabriel Krisman Bertazi
On Tue, Apr 23, 2019 at 12:06:35AM -0400, Gabriel Krisman Bertazi wrote:
> Eric Biggers <ebiggers@kernel.org> writes:
>
> > From: Eric Biggers <ebiggers@google.com>
> >
> > In ext2fs_dirhash2(), the outer 'buff' variable is never used.
> >
> > Cc: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
>
> Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-29 0:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-22 21:08 [PATCH] libext2fs: remove unused variable 'buff' Eric Biggers
2019-04-23 4:06 ` Gabriel Krisman Bertazi
2019-04-29 0:36 ` Theodore Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.