[PATCH] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable()

* [PATCH] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable()
@ 2019-04-29 14:56 Petr Mladek
  0 siblings, 0 replies; only message in thread
From: Petr Mladek @ 2019-04-29 14:56 UTC (permalink / raw)
  To: Thomas Gleixner
  Cc: Ingo Molnar, Jiri Kosina, Josh Poimboeuf, Miroslav Benes,
	Jason Baron, Joe Lawrence, Evgenii Shatokhin, live-patching,
	linux-kernel, Petr Mladek

WARN_ONCE() in the generic save_stack_trace_tsk_reliable() is superfluous.
The only current user klp_check_stack() writes its own warning when
-ENOSYS is returned.

Signed-off-by: Petr Mladek <pmladek@suse.com>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Miroslav Benes <mbenes@suse.cz>
Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
---
 kernel/stacktrace.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/stacktrace.c b/kernel/stacktrace.c
index f8edee9c792d..83ac0ac5ffd9 100644
--- a/kernel/stacktrace.c
+++ b/kernel/stacktrace.c
@@ -74,6 +74,5 @@ __weak int
 save_stack_trace_tsk_reliable(struct task_struct *tsk,
 			      struct stack_trace *trace)
 {
-	WARN_ONCE(1, KERN_INFO "save_stack_tsk_reliable() not implemented yet.\n");
 	return -ENOSYS;
 }
-- 
2.16.4


^ permalink raw reply related	[flat|nested] only message in thread