[igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Limit cursor size based platform capability.

[igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Limit cursor size based platform capability.

[Karthik B S]

Limiting the maximum cursor size being used in subtests based on
platform capability, to avoid skipping of subtests.

Karthik B S (1):
  tests/kms_cursor_crc: Limit cursor size based platform capability.

 tests/kms_cursor_crc.c | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Limit cursor size based platform capability.

[Karthik B S]

Limiting the cursor size of subtests to the maximum size listed as per
the platform capability, so that we can avoid skipping of subtests.

Also moving the platform capability fetch outside igt_fixture,
so that all the valid subtests are listed during --list-subtests.

Signed-off-by: Karthik B S <karthik.b.s@intel.com>
---
 tests/kms_cursor_crc.c | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index fd74fda..6fb33a1 100644
--- a/tests/kms_cursor_crc.c
+++ b/tests/kms_cursor_crc.c
@@ -642,7 +642,8 @@ static void test_rapid_movement(data_t *data)
 static void run_test_generic(data_t *data)
 {
 	int cursor_size;
-	for (cursor_size = 64; cursor_size <= 512; cursor_size *= 2) {
+	for (cursor_size = 64; cursor_size <= data->cursor_max_w;
+	     cursor_size *= 2) {
 		int w = cursor_size;
 		int h = cursor_size;
 
@@ -719,18 +720,19 @@ igt_main
 
 	igt_skip_on_simulation();
 
-	igt_fixture {
-		data.drm_fd = drm_open_driver_master(DRIVER_ANY);
+	data.drm_fd = drm_open_driver_master(DRIVER_ANY);
+
+	ret = drmGetCap(data.drm_fd, DRM_CAP_CURSOR_WIDTH, &cursor_width);
+	igt_assert(ret == 0 || errno == EINVAL);
 
-		ret = drmGetCap(data.drm_fd, DRM_CAP_CURSOR_WIDTH, &cursor_width);
-		igt_assert(ret == 0 || errno == EINVAL);
-		/* Not making use of cursor_height since it is same as width, still reading */
-		ret = drmGetCap(data.drm_fd, DRM_CAP_CURSOR_HEIGHT, &cursor_height);
-		igt_assert(ret == 0 || errno == EINVAL);
+	/* Not making use of cursor_height since it is same as width, still reading */
+	ret = drmGetCap(data.drm_fd, DRM_CAP_CURSOR_HEIGHT, &cursor_height);
+	igt_assert(ret == 0 || errno == EINVAL);
 
-		/* We assume width and height are same so max is assigned width */
-		igt_assert_eq(cursor_width, cursor_height);
+	/* We assume width and height are same so max is assigned width */
+	igt_assert_eq(cursor_width, cursor_height);
 
+	igt_fixture {
 		kmstest_set_vt_graphics_mode();
 
 		igt_require_pipe_crc(data.drm_fd);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_cursor_crc: Limit cursor size based platform capability.

[Patchwork]

== Series Details ==

Series: tests/kms_cursor_crc: Limit cursor size based platform capability.
URL   : https://patchwork.freedesktop.org/series/60099/
State : failure

== Summary ==

IGT patchset build failed on latest successful build
fc5e0467eb6913d21ad932aa8a31c77fdb5a9c77 tests/kms_cursor_legacy: Don't stop cursor_vs_flip early

261/267 assembler: test/rndu                    OK       0.06 s 
262/267 assembler: test/rnde                    OK       0.05 s 
263/267 assembler: test/rnde-intsrc             OK       0.03 s 
264/267 assembler: test/rndz                    OK       0.04 s 
265/267 assembler: test/lzd                     OK       0.04 s 
266/267 assembler: test/not                     OK       0.04 s 
267/267 assembler: test/immediate               OK       0.02 s 

OK:       266
FAIL:       1
SKIP:       0
TIMEOUT:    0


The output from the failed tests:

 39/267 testcase check: kms_cursor_crc          FAIL     0.29 s (exit status 1)

--- command ---
/home/cidrm/igt-gpu-tools/tests/igt_command_line.sh kms_cursor_crc
--- stdout ---
tests/kms_cursor_crc:
  Checking invalid option handling...
  Checking valid option handling...
  Checking subtest enumeration...
FAIL: tests/kms_cursor_crc
--- stderr ---
kms_cursor_crc: ../lib/igt_core.c:1047: igt_skip: Assertion `in_fixture' failed.
Received signal SIGABRT.
Stack trace: 
 #0 [fatal_sig_handler+0xd5]
 #1 [killpg+0x40]
 #2 [gsignal+0xc7]
 #3 [abort+0x141]
 #4 [uselocale+0x33a]
 #5 [__assert_fail+0x42]
 #6 [igt_skip+0x14b]
 #7 [__igt_skip_check+0x242]
 #8 [drm_open_driver+0x61]
 #9 [drm_open_driver_master+0x15]
 #10 [__real_main716+0x3f]
 #11 [main+0x44]
 #12 [__libc_start_main+0xe7]
 #13 [_start+0x2a]
-------

Full log written to /home/cidrm/igt-gpu-tools/build/meson-logs/testlog.txt
FAILED: meson-test 
/usr/bin/python3 -u /usr/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed.

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Limit cursor size based platform capability.

[Petri Latvala]

On Tue, Apr 30, 2019 at 03:07:12PM +0530, Karthik B S wrote:
> Also moving the platform capability fetch outside igt_fixture,
> so that all the valid subtests are listed during --list-subtests.


That's exactly what you can't do. Subtests are enumerated on the build
machine in CI.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev