All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] testcases.mk: Fix libs/ path for out-of-tree build
Date: Tue, 30 Apr 2019 15:51:59 +0200	[thread overview]
Message-ID: <20190430135159.GA7752@dell5510> (raw)
In-Reply-To: <20190430133836.28400-1-chrubis@suse.cz>

Hi,

> The path to the Makefile was not correct for the out-of-tree build
> because it was pointing to the build directory rather than to the source
> directory.

> Apparently this also caused random failures for out-of-tree build. For
> some reason when building syscalls/set_mempolicy/ testcases the rebuild
> of the libltpnuma.a library is triggered for out-of-tree build for about
> 10% of the cases on massively parallel build. Which as far as I can tell
> shouldn't happen since we build everything in the libs/ directory as a
> prerequisite of the testcases/ directory. So there is likely some
> strange race condition happening and while this does not fix the actual
> race it makes it quite harmless since the target was already build and
> the make in the libs/libltpnuma/ directory will be no-op.

> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> CC: Petr Vorel <pvorel@suse.cz>
> CC: Jan Stancek <jstancek@redhat.com>
> ---
Tested-by: Petr Vorel <pvorel@suse.cz>
On 32 core machine, running for several hours (now 66 builds without failure).


Kind regards,
Petr

>  include/mk/testcases.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/include/mk/testcases.mk b/include/mk/testcases.mk
> index 131854ec7..684655fbf 100644
> --- a/include/mk/testcases.mk
> +++ b/include/mk/testcases.mk
> @@ -49,7 +49,7 @@ LTPLIBS_FILES = $(addsuffix .a, $(addprefix $(abs_top_builddir)/libs/, $(foreach
>  MAKE_DEPS += $(LTPLIBS_FILES)

>  $(LTPLIBS_FILES): $(LTPLIBS_DIRS)
> -	$(MAKE) -C "$^" -f "$^/Makefile" all
> +	$(MAKE) -C "$^" -f "$(subst $(abs_top_builddir),$(abs_top_srcdir),$^)/Makefile" all

>  LDFLAGS += $(addprefix -L$(top_builddir)/libs/lib, $(LTPLIBS))

  parent reply	other threads:[~2019-04-30 13:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30 13:38 [LTP] [PATCH 1/2] testcases.mk: Fix libs/ path for out-of-tree build Cyril Hrubis
2019-04-30 13:38 ` [LTP] [PATCH 2/2] Makefile: Fix target redefinition Cyril Hrubis
2019-04-30 13:52   ` Petr Vorel
2019-04-30 13:51 ` [LTP] [PATCH 1/2] testcases.mk: Fix libs/ path for out-of-tree build Jan Stancek
2019-04-30 13:51 ` Petr Vorel [this message]
2019-04-30 14:16 ` Cyril Hrubis
2019-05-01  0:01   ` Enji Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190430135159.GA7752@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.