All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] Makefile: Fix target redefinition
Date: Tue, 30 Apr 2019 15:52:29 +0200	[thread overview]
Message-ID: <20190430135229.GB7752@dell5510> (raw)
In-Reply-To: <20190430133836.28400-2-chrubis@suse.cz>

Hi,

> There is no need to add a rule for the libs directory because there is a
> generic rule for directory creation already. All we need to do is to
> make the libs-all target depend on the directory path, which we do
> already so that the directory is created before we attempt to execute
> make there.

> Fixes: 17a5b0fb63bf65eff433bdee3bf5f73826a50e0f

> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> CC: Petr Vorel <pvorel@suse.cz>
> CC: Jan Stancek <jstancek@redhat.com>
> ---
Tested-by: Petr Vorel <pvorel@suse.cz>
The same as previous patch (testing both together).

Kind regards,
Petr

>  Makefile | 3 ---
>  1 file changed, 3 deletions(-)

> diff --git a/Makefile b/Makefile
> index c46d050ce..768ca4606 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -102,9 +102,6 @@ $(sort $(addprefix $(abs_top_builddir)/,$(BOOTSTRAP_TARGETS)) $(INSTALL_DIR) $(D
>  ## Pattern based subtarget rules.
>  lib-install: lib-all

> -$(abs_top_builddir)/libs:
> -	mkdir -m 00755 -p "$@"
> -
>  libs-all: $(abs_top_builddir)/libs

>  $(MAKE_TARGETS) include-all lib-all libs-all:

  reply	other threads:[~2019-04-30 13:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30 13:38 [LTP] [PATCH 1/2] testcases.mk: Fix libs/ path for out-of-tree build Cyril Hrubis
2019-04-30 13:38 ` [LTP] [PATCH 2/2] Makefile: Fix target redefinition Cyril Hrubis
2019-04-30 13:52   ` Petr Vorel [this message]
2019-04-30 13:51 ` [LTP] [PATCH 1/2] testcases.mk: Fix libs/ path for out-of-tree build Jan Stancek
2019-04-30 13:51 ` Petr Vorel
2019-04-30 14:16 ` Cyril Hrubis
2019-05-01  0:01   ` Enji Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190430135229.GB7752@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.