* [PATCH 1/2] drm/i915: Don't skip audio enable if ELD is bogus
@ 2019-04-30 14:29 Ville Syrjala
2019-04-30 14:29 ` [PATCH 2/2] drm/i915: hsw+ audio regs are per-transocder Ville Syrjala
` (6 more replies)
0 siblings, 7 replies; 10+ messages in thread
From: Ville Syrjala @ 2019-04-30 14:29 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
We've already committed to enabling audio when intel_audio_codec_enable()
is called. We can't back out even if the ELD has turned sour in the
meantime. So just spew some debug log and plow ahead. Otherwise the
state checker gets unhappy when audio isn't enabled when it is
expected to be.
I suppose we really ought to precompute the ELD as well, but
let's just toss in a FIXME for the future.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103841
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_audio.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index bca4cc025d3d..68a24dada44c 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -644,8 +644,10 @@ void intel_audio_codec_enable(struct intel_encoder *encoder,
enum port port = encoder->port;
enum pipe pipe = crtc->pipe;
+ /* FIXME precompute the ELD in .compute_config() */
if (!connector->eld[0])
- return;
+ DRM_DEBUG_KMS("Bogus ELD on [CONNECTOR:%d:%s]\n",
+ connector->base.id, connector->name);
DRM_DEBUG_DRIVER("ELD on [CONNECTOR:%d:%s], [ENCODER:%d:%s]\n",
connector->base.id,
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] drm/i915: hsw+ audio regs are per-transocder
2019-04-30 14:29 [PATCH 1/2] drm/i915: Don't skip audio enable if ELD is bogus Ville Syrjala
@ 2019-04-30 14:29 ` Ville Syrjala
2019-05-02 12:16 ` Jani Nikula
2019-04-30 15:06 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Don't skip audio enable if ELD is bogus Patchwork
` (5 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjala @ 2019-04-30 14:29 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
s/pipe/transcoder/ when dealing with hsw+ audio registers. This
won't actually make any real difference since there is no audio
on the EDP transcoder. But this should avoid a bit of confusion
when cross checking against the spec.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 12 +++----
drivers/gpu/drm/i915/intel_audio.c | 55 ++++++++++++++----------------
2 files changed, 32 insertions(+), 35 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 6f0a0866c802..926e058d09ee 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -9010,32 +9010,32 @@ enum {
/* HSW Audio */
#define _HSW_AUD_CONFIG_A 0x65000
#define _HSW_AUD_CONFIG_B 0x65100
-#define HSW_AUD_CFG(pipe) _MMIO_PIPE(pipe, _HSW_AUD_CONFIG_A, _HSW_AUD_CONFIG_B)
+#define HSW_AUD_CFG(trans) _MMIO_TRANS(trans, _HSW_AUD_CONFIG_A, _HSW_AUD_CONFIG_B)
#define _HSW_AUD_MISC_CTRL_A 0x65010
#define _HSW_AUD_MISC_CTRL_B 0x65110
-#define HSW_AUD_MISC_CTRL(pipe) _MMIO_PIPE(pipe, _HSW_AUD_MISC_CTRL_A, _HSW_AUD_MISC_CTRL_B)
+#define HSW_AUD_MISC_CTRL(trans) _MMIO_TRANS(trans, _HSW_AUD_MISC_CTRL_A, _HSW_AUD_MISC_CTRL_B)
#define _HSW_AUD_M_CTS_ENABLE_A 0x65028
#define _HSW_AUD_M_CTS_ENABLE_B 0x65128
-#define HSW_AUD_M_CTS_ENABLE(pipe) _MMIO_PIPE(pipe, _HSW_AUD_M_CTS_ENABLE_A, _HSW_AUD_M_CTS_ENABLE_B)
+#define HSW_AUD_M_CTS_ENABLE(trans) _MMIO_TRANS(trans, _HSW_AUD_M_CTS_ENABLE_A, _HSW_AUD_M_CTS_ENABLE_B)
#define AUD_M_CTS_M_VALUE_INDEX (1 << 21)
#define AUD_M_CTS_M_PROG_ENABLE (1 << 20)
#define AUD_CONFIG_M_MASK 0xfffff
#define _HSW_AUD_DIP_ELD_CTRL_ST_A 0x650b4
#define _HSW_AUD_DIP_ELD_CTRL_ST_B 0x651b4
-#define HSW_AUD_DIP_ELD_CTRL(pipe) _MMIO_PIPE(pipe, _HSW_AUD_DIP_ELD_CTRL_ST_A, _HSW_AUD_DIP_ELD_CTRL_ST_B)
+#define HSW_AUD_DIP_ELD_CTRL(trans) _MMIO_TRANS(trans, _HSW_AUD_DIP_ELD_CTRL_ST_A, _HSW_AUD_DIP_ELD_CTRL_ST_B)
/* Audio Digital Converter */
#define _HSW_AUD_DIG_CNVT_1 0x65080
#define _HSW_AUD_DIG_CNVT_2 0x65180
-#define AUD_DIG_CNVT(pipe) _MMIO_PIPE(pipe, _HSW_AUD_DIG_CNVT_1, _HSW_AUD_DIG_CNVT_2)
+#define AUD_DIG_CNVT(trans) _MMIO_TRANS(trans, _HSW_AUD_DIG_CNVT_1, _HSW_AUD_DIG_CNVT_2)
#define DIP_PORT_SEL_MASK 0x3
#define _HSW_AUD_EDID_DATA_A 0x65050
#define _HSW_AUD_EDID_DATA_B 0x65150
-#define HSW_AUD_EDID_DATA(pipe) _MMIO_PIPE(pipe, _HSW_AUD_EDID_DATA_A, _HSW_AUD_EDID_DATA_B)
+#define HSW_AUD_EDID_DATA(trans) _MMIO_TRANS(trans, _HSW_AUD_EDID_DATA_A, _HSW_AUD_EDID_DATA_B)
#define HSW_AUD_PIPE_CONV_CFG _MMIO(0x6507c)
#define HSW_AUD_PIN_ELD_CP_VLD _MMIO(0x650c0)
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index 68a24dada44c..5c0b73f63843 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -319,9 +319,8 @@ hsw_dp_audio_config_update(struct intel_encoder *encoder,
{
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
struct i915_audio_component *acomp = dev_priv->audio_component;
- struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc);
+ enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
enum port port = encoder->port;
- enum pipe pipe = crtc->pipe;
const struct dp_aud_n_m *nm;
int rate;
u32 tmp;
@@ -333,7 +332,7 @@ hsw_dp_audio_config_update(struct intel_encoder *encoder,
else
DRM_DEBUG_KMS("using automatic Maud, Naud\n");
- tmp = I915_READ(HSW_AUD_CFG(pipe));
+ tmp = I915_READ(HSW_AUD_CFG(cpu_transcoder));
tmp &= ~AUD_CONFIG_N_VALUE_INDEX;
tmp &= ~AUD_CONFIG_PIXEL_CLOCK_HDMI_MASK;
tmp &= ~AUD_CONFIG_N_PROG_ENABLE;
@@ -345,9 +344,9 @@ hsw_dp_audio_config_update(struct intel_encoder *encoder,
tmp |= AUD_CONFIG_N_PROG_ENABLE;
}
- I915_WRITE(HSW_AUD_CFG(pipe), tmp);
+ I915_WRITE(HSW_AUD_CFG(cpu_transcoder), tmp);
- tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(pipe));
+ tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(cpu_transcoder));
tmp &= ~AUD_CONFIG_M_MASK;
tmp &= ~AUD_M_CTS_M_VALUE_INDEX;
tmp &= ~AUD_M_CTS_M_PROG_ENABLE;
@@ -358,7 +357,7 @@ hsw_dp_audio_config_update(struct intel_encoder *encoder,
tmp |= AUD_M_CTS_M_PROG_ENABLE;
}
- I915_WRITE(HSW_AUD_M_CTS_ENABLE(pipe), tmp);
+ I915_WRITE(HSW_AUD_M_CTS_ENABLE(cpu_transcoder), tmp);
}
static void
@@ -367,15 +366,14 @@ hsw_hdmi_audio_config_update(struct intel_encoder *encoder,
{
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
struct i915_audio_component *acomp = dev_priv->audio_component;
- struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc);
+ enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
enum port port = encoder->port;
- enum pipe pipe = crtc->pipe;
int n, rate;
u32 tmp;
rate = acomp ? acomp->aud_sample_rate[port] : 0;
- tmp = I915_READ(HSW_AUD_CFG(pipe));
+ tmp = I915_READ(HSW_AUD_CFG(cpu_transcoder));
tmp &= ~AUD_CONFIG_N_VALUE_INDEX;
tmp &= ~AUD_CONFIG_PIXEL_CLOCK_HDMI_MASK;
tmp &= ~AUD_CONFIG_N_PROG_ENABLE;
@@ -392,16 +390,16 @@ hsw_hdmi_audio_config_update(struct intel_encoder *encoder,
DRM_DEBUG_KMS("using automatic N\n");
}
- I915_WRITE(HSW_AUD_CFG(pipe), tmp);
+ I915_WRITE(HSW_AUD_CFG(cpu_transcoder), tmp);
/*
* Let's disable "Enable CTS or M Prog bit"
* and let HW calculate the value
*/
- tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(pipe));
+ tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(cpu_transcoder));
tmp &= ~AUD_M_CTS_M_PROG_ENABLE;
tmp &= ~AUD_M_CTS_M_VALUE_INDEX;
- I915_WRITE(HSW_AUD_M_CTS_ENABLE(pipe), tmp);
+ I915_WRITE(HSW_AUD_M_CTS_ENABLE(cpu_transcoder), tmp);
}
static void
@@ -419,28 +417,28 @@ static void hsw_audio_codec_disable(struct intel_encoder *encoder,
const struct drm_connector_state *old_conn_state)
{
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
- struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->base.crtc);
- enum pipe pipe = crtc->pipe;
+ enum transcoder cpu_transcoder = old_crtc_state->cpu_transcoder;
u32 tmp;
- DRM_DEBUG_KMS("Disable audio codec on pipe %c\n", pipe_name(pipe));
+ DRM_DEBUG_KMS("Disable audio codec on transcoder %s\n",
+ transcoder_name(cpu_transcoder));
mutex_lock(&dev_priv->av_mutex);
/* Disable timestamps */
- tmp = I915_READ(HSW_AUD_CFG(pipe));
+ tmp = I915_READ(HSW_AUD_CFG(cpu_transcoder));
tmp &= ~AUD_CONFIG_N_VALUE_INDEX;
tmp |= AUD_CONFIG_N_PROG_ENABLE;
tmp &= ~AUD_CONFIG_UPPER_N_MASK;
tmp &= ~AUD_CONFIG_LOWER_N_MASK;
if (intel_crtc_has_dp_encoder(old_crtc_state))
tmp |= AUD_CONFIG_N_VALUE_INDEX;
- I915_WRITE(HSW_AUD_CFG(pipe), tmp);
+ I915_WRITE(HSW_AUD_CFG(cpu_transcoder), tmp);
/* Invalidate ELD */
tmp = I915_READ(HSW_AUD_PIN_ELD_CP_VLD);
- tmp &= ~AUDIO_ELD_VALID(pipe);
- tmp &= ~AUDIO_OUTPUT_ENABLE(pipe);
+ tmp &= ~AUDIO_ELD_VALID(cpu_transcoder);
+ tmp &= ~AUDIO_OUTPUT_ENABLE(cpu_transcoder);
I915_WRITE(HSW_AUD_PIN_ELD_CP_VLD, tmp);
mutex_unlock(&dev_priv->av_mutex);
@@ -451,22 +449,21 @@ static void hsw_audio_codec_enable(struct intel_encoder *encoder,
const struct drm_connector_state *conn_state)
{
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
- struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc);
struct drm_connector *connector = conn_state->connector;
- enum pipe pipe = crtc->pipe;
+ enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
const u8 *eld = connector->eld;
u32 tmp;
int len, i;
- DRM_DEBUG_KMS("Enable audio codec on pipe %c, %u bytes ELD\n",
- pipe_name(pipe), drm_eld_size(eld));
+ DRM_DEBUG_KMS("Enable audio codec on transcoder %s, %u bytes ELD\n",
+ transcoder_name(cpu_transcoder), drm_eld_size(eld));
mutex_lock(&dev_priv->av_mutex);
/* Enable audio presence detect, invalidate ELD */
tmp = I915_READ(HSW_AUD_PIN_ELD_CP_VLD);
- tmp |= AUDIO_OUTPUT_ENABLE(pipe);
- tmp &= ~AUDIO_ELD_VALID(pipe);
+ tmp |= AUDIO_OUTPUT_ENABLE(cpu_transcoder);
+ tmp &= ~AUDIO_ELD_VALID(cpu_transcoder);
I915_WRITE(HSW_AUD_PIN_ELD_CP_VLD, tmp);
/*
@@ -477,18 +474,18 @@ static void hsw_audio_codec_enable(struct intel_encoder *encoder,
*/
/* Reset ELD write address */
- tmp = I915_READ(HSW_AUD_DIP_ELD_CTRL(pipe));
+ tmp = I915_READ(HSW_AUD_DIP_ELD_CTRL(cpu_transcoder));
tmp &= ~IBX_ELD_ADDRESS_MASK;
- I915_WRITE(HSW_AUD_DIP_ELD_CTRL(pipe), tmp);
+ I915_WRITE(HSW_AUD_DIP_ELD_CTRL(cpu_transcoder), tmp);
/* Up to 84 bytes of hw ELD buffer */
len = min(drm_eld_size(eld), 84);
for (i = 0; i < len / 4; i++)
- I915_WRITE(HSW_AUD_EDID_DATA(pipe), *((const u32 *)eld + i));
+ I915_WRITE(HSW_AUD_EDID_DATA(cpu_transcoder), *((const u32 *)eld + i));
/* ELD valid */
tmp = I915_READ(HSW_AUD_PIN_ELD_CP_VLD);
- tmp |= AUDIO_ELD_VALID(pipe);
+ tmp |= AUDIO_ELD_VALID(cpu_transcoder);
I915_WRITE(HSW_AUD_PIN_ELD_CP_VLD, tmp);
/* Enable timestamps */
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Don't skip audio enable if ELD is bogus
2019-04-30 14:29 [PATCH 1/2] drm/i915: Don't skip audio enable if ELD is bogus Ville Syrjala
2019-04-30 14:29 ` [PATCH 2/2] drm/i915: hsw+ audio regs are per-transocder Ville Syrjala
@ 2019-04-30 15:06 ` Patchwork
2019-04-30 15:08 ` ✗ Fi.CI.SPARSE: " Patchwork
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-04-30 15:06 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Don't skip audio enable if ELD is bogus
URL : https://patchwork.freedesktop.org/series/60119/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e685e5944a53 drm/i915: Don't skip audio enable if ELD is bogus
b8472fe8ca94 drm/i915: hsw+ audio regs are per-transocder
-:30: WARNING:LONG_LINE: line over 100 characters
#30: FILE: drivers/gpu/drm/i915/i915_reg.h:9017:
+#define HSW_AUD_MISC_CTRL(trans) _MMIO_TRANS(trans, _HSW_AUD_MISC_CTRL_A, _HSW_AUD_MISC_CTRL_B)
-:35: WARNING:LONG_LINE: line over 100 characters
#35: FILE: drivers/gpu/drm/i915/i915_reg.h:9021:
+#define HSW_AUD_M_CTS_ENABLE(trans) _MMIO_TRANS(trans, _HSW_AUD_M_CTS_ENABLE_A, _HSW_AUD_M_CTS_ENABLE_B)
-:43: WARNING:LONG_LINE: line over 100 characters
#43: FILE: drivers/gpu/drm/i915/i915_reg.h:9028:
+#define HSW_AUD_DIP_ELD_CTRL(trans) _MMIO_TRANS(trans, _HSW_AUD_DIP_ELD_CTRL_ST_A, _HSW_AUD_DIP_ELD_CTRL_ST_B)
-:55: WARNING:LONG_LINE: line over 100 characters
#55: FILE: drivers/gpu/drm/i915/i915_reg.h:9038:
+#define HSW_AUD_EDID_DATA(trans) _MMIO_TRANS(trans, _HSW_AUD_EDID_DATA_A, _HSW_AUD_EDID_DATA_B)
total: 0 errors, 4 warnings, 0 checks, 195 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Don't skip audio enable if ELD is bogus
2019-04-30 14:29 [PATCH 1/2] drm/i915: Don't skip audio enable if ELD is bogus Ville Syrjala
2019-04-30 14:29 ` [PATCH 2/2] drm/i915: hsw+ audio regs are per-transocder Ville Syrjala
2019-04-30 15:06 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Don't skip audio enable if ELD is bogus Patchwork
@ 2019-04-30 15:08 ` Patchwork
2019-04-30 15:26 ` ✓ Fi.CI.BAT: success " Patchwork
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-04-30 15:08 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Don't skip audio enable if ELD is bogus
URL : https://patchwork.freedesktop.org/series/60119/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Don't skip audio enable if ELD is bogus
Okay!
Commit: drm/i915: hsw+ audio regs are per-transocder
-O:drivers/gpu/drm/i915/intel_audio.c:485:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:482:15: warning: expression using sizeof(void)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Don't skip audio enable if ELD is bogus
2019-04-30 14:29 [PATCH 1/2] drm/i915: Don't skip audio enable if ELD is bogus Ville Syrjala
` (2 preceding siblings ...)
2019-04-30 15:08 ` ✗ Fi.CI.SPARSE: " Patchwork
@ 2019-04-30 15:26 ` Patchwork
2019-05-01 8:08 ` ✗ Fi.CI.IGT: failure " Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-04-30 15:26 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Don't skip audio enable if ELD is bogus
URL : https://patchwork.freedesktop.org/series/60119/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6017 -> Patchwork_12912
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/60119/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_12912:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_pm_backlight@basic-brightness:
- {fi-cml-u2}: NOTRUN -> [SKIP][1] +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/fi-cml-u2/igt@i915_pm_backlight@basic-brightness.html
Known issues
------------
Here are the changes found in Patchwork_12912 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_contexts:
- fi-icl-y: [PASS][2] -> [INCOMPLETE][3] ([fdo#107713] / [fdo#108569])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/fi-icl-y/igt@i915_selftest@live_contexts.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/fi-icl-y/igt@i915_selftest@live_contexts.html
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: [PASS][4] -> [INCOMPLETE][5] ([fdo#108602] / [fdo#108744])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][6] -> [FAIL][7] ([fdo#109485])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [DMESG-FAIL][8] ([fdo#110235]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
- fi-skl-gvtdvm: [DMESG-FAIL][10] ([fdo#110235]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
* igt@kms_chamelium@dp-crc-fast:
- {fi-cml-u2}: [DMESG-WARN][12] ([fdo#103841]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103841]: https://bugs.freedesktop.org/show_bug.cgi?id=103841
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (53 -> 46)
------------------------------
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper
Build changes
-------------
* Linux: CI_DRM_6017 -> Patchwork_12912
CI_DRM_6017: 69c3a37af9430650d1fc2a5555d4d0786898694d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4971: fc5e0467eb6913d21ad932aa8a31c77fdb5a9c77 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12912: b8472fe8ca94a9efbe9689f0c9ad6a6d875c809a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b8472fe8ca94 drm/i915: hsw+ audio regs are per-transocder
e685e5944a53 drm/i915: Don't skip audio enable if ELD is bogus
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Don't skip audio enable if ELD is bogus
2019-04-30 14:29 [PATCH 1/2] drm/i915: Don't skip audio enable if ELD is bogus Ville Syrjala
` (3 preceding siblings ...)
2019-04-30 15:26 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-05-01 8:08 ` Patchwork
2019-05-02 8:07 ` ✓ Fi.CI.IGT: success " Patchwork
2019-05-02 12:16 ` [PATCH 1/2] " Jani Nikula
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-05-01 8:08 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Don't skip audio enable if ELD is bogus
URL : https://patchwork.freedesktop.org/series/60119/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6017_full -> Patchwork_12912_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_12912_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_12912_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_12912_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_tiled_blits@normal:
- shard-skl: NOTRUN -> [INCOMPLETE][1] +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl9/igt@gem_tiled_blits@normal.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-wc:
- shard-skl: [PASS][2] -> [INCOMPLETE][3] +2 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl9/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-wc.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-wc.html
Known issues
------------
Here are the changes found in Patchwork_12912_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-iclb: [PASS][4] -> [INCOMPLETE][5] ([fdo#107713] / [fdo#108840])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb7/igt@i915_pm_rpm@system-suspend-modeset.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb4/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][6] -> [DMESG-WARN][7] ([fdo#108566]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-apl6/igt@i915_suspend@debugfs-reader.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-apl7/igt@i915_suspend@debugfs-reader.html
* igt@kms_cursor_crc@cursor-128x42-offscreen:
- shard-iclb: [PASS][8] -> [INCOMPLETE][9] ([fdo#107713])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb2/igt@kms_cursor_crc@cursor-128x42-offscreen.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb3/igt@kms_cursor_crc@cursor-128x42-offscreen.html
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-hsw: [PASS][10] -> [INCOMPLETE][11] ([fdo#103540])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-hsw1/igt@kms_cursor_crc@cursor-256x256-sliding.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-hsw1/igt@kms_cursor_crc@cursor-256x256-sliding.html
* igt@kms_draw_crc@draw-method-xrgb2101010-render-xtiled:
- shard-skl: [PASS][12] -> [FAIL][13] ([fdo#103184] / [fdo#103232])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl9/igt@kms_draw_crc@draw-method-xrgb2101010-render-xtiled.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl4/igt@kms_draw_crc@draw-method-xrgb2101010-render-xtiled.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: [PASS][14] -> [FAIL][15] ([fdo#102887] / [fdo#105363])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-glk8/igt@kms_flip@flip-vs-expired-vblank.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-glk4/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
- shard-skl: [PASS][16] -> [FAIL][17] ([fdo#108040]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-skl: [PASS][18] -> [FAIL][19] ([fdo#103167])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl9/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: [PASS][20] -> [FAIL][21] ([fdo#103167]) +5 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][22] -> [FAIL][23] ([fdo#108145])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][24] -> [SKIP][25] ([fdo#109441]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb2/igt@kms_psr@psr2_basic.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb6/igt@kms_psr@psr2_basic.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][26] -> [FAIL][27] ([fdo#99912])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-apl1/igt@kms_setmode@basic.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-apl8/igt@kms_setmode@basic.html
* igt@kms_sysfs_edid_timing:
- shard-iclb: [PASS][28] -> [FAIL][29] ([fdo#100047])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb8/igt@kms_sysfs_edid_timing.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb2/igt@kms_sysfs_edid_timing.html
#### Possible fixes ####
* igt@gem_eio@in-flight-suspend:
- shard-kbl: [DMESG-WARN][30] ([fdo#103313]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-kbl3/igt@gem_eio@in-flight-suspend.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-kbl5/igt@gem_eio@in-flight-suspend.html
- shard-skl: [INCOMPLETE][32] ([fdo#104108] / [fdo#107773]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl1/igt@gem_eio@in-flight-suspend.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl7/igt@gem_eio@in-flight-suspend.html
* igt@i915_pm_rpm@debugfs-forcewake-user:
- shard-skl: [INCOMPLETE][34] ([fdo#107807]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl1/igt@i915_pm_rpm@debugfs-forcewake-user.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl2/igt@i915_pm_rpm@debugfs-forcewake-user.html
* igt@i915_selftest@mock_fence:
- shard-iclb: [INCOMPLETE][36] ([fdo#107713]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb7/igt@i915_selftest@mock_fence.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb8/igt@i915_selftest@mock_fence.html
* igt@i915_selftest@mock_requests:
- shard-skl: [INCOMPLETE][38] ([fdo#110550]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl8/igt@i915_selftest@mock_requests.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl3/igt@i915_selftest@mock_requests.html
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [DMESG-WARN][40] ([fdo#108566]) -> [PASS][41] +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-apl2/igt@i915_suspend@fence-restore-untiled.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-apl6/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-skl: [INCOMPLETE][42] -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl3/igt@kms_cursor_crc@cursor-128x128-onscreen.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl9/igt@kms_cursor_crc@cursor-128x128-onscreen.html
* igt@kms_cursor_crc@cursor-alpha-transparent:
- shard-skl: [FAIL][44] ([fdo#109350]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl7/igt@kms_cursor_crc@cursor-alpha-transparent.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl1/igt@kms_cursor_crc@cursor-alpha-transparent.html
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [INCOMPLETE][46] ([fdo#109507]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl4/igt@kms_flip@flip-vs-suspend.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl5/igt@kms_flip@flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt:
- shard-iclb: [FAIL][48] ([fdo#103167]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html
* igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
- shard-skl: [FAIL][50] ([fdo#103191]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl7/igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl1/igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence.html
* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-glk: [SKIP][52] ([fdo#109271]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-glk2/igt@kms_plane@pixel-format-pipe-c-planes.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-glk9/igt@kms_plane@pixel-format-pipe-c-planes.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][54] ([fdo#108145] / [fdo#110403]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
- shard-glk: [SKIP][56] ([fdo#109271] / [fdo#109278]) -> [PASS][57] +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-glk1/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-glk9/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][58] ([fdo#108341]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb1/igt@kms_psr@no_drrs.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb5/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][60] ([fdo#109441]) -> [PASS][61] +4 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb3/igt@kms_psr@psr2_cursor_plane_onoff.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@perf_pmu@enable-race-rcs0:
- shard-glk: [INCOMPLETE][62] ([fdo#103359] / [k.org#198133]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-glk2/igt@perf_pmu@enable-race-rcs0.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-glk3/igt@perf_pmu@enable-race-rcs0.html
#### Warnings ####
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-apl: [SKIP][64] ([fdo#109271]) -> [INCOMPLETE][65] ([fdo#103927])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-apl3/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-apl5/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110550]: https://bugs.freedesktop.org/show_bug.cgi?id=110550
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_6017 -> Patchwork_12912
CI_DRM_6017: 69c3a37af9430650d1fc2a5555d4d0786898694d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4971: fc5e0467eb6913d21ad932aa8a31c77fdb5a9c77 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12912: b8472fe8ca94a9efbe9689f0c9ad6a6d875c809a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Don't skip audio enable if ELD is bogus
2019-04-30 14:29 [PATCH 1/2] drm/i915: Don't skip audio enable if ELD is bogus Ville Syrjala
` (4 preceding siblings ...)
2019-05-01 8:08 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-05-02 8:07 ` Patchwork
2019-05-02 12:16 ` [PATCH 1/2] " Jani Nikula
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-05-02 8:07 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Don't skip audio enable if ELD is bogus
URL : https://patchwork.freedesktop.org/series/60119/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6017_full -> Patchwork_12912_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12912_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#108840])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb7/igt@i915_pm_rpm@system-suspend-modeset.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb4/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-apl6/igt@i915_suspend@debugfs-reader.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-apl7/igt@i915_suspend@debugfs-reader.html
* igt@kms_cursor_crc@cursor-128x42-offscreen:
- shard-iclb: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb2/igt@kms_cursor_crc@cursor-128x42-offscreen.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb3/igt@kms_cursor_crc@cursor-128x42-offscreen.html
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-hsw: [PASS][7] -> [INCOMPLETE][8] ([fdo#103540])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-hsw1/igt@kms_cursor_crc@cursor-256x256-sliding.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-hsw1/igt@kms_cursor_crc@cursor-256x256-sliding.html
* igt@kms_draw_crc@draw-method-xrgb2101010-render-xtiled:
- shard-skl: [PASS][9] -> [FAIL][10] ([fdo#103184] / [fdo#103232])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl9/igt@kms_draw_crc@draw-method-xrgb2101010-render-xtiled.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl4/igt@kms_draw_crc@draw-method-xrgb2101010-render-xtiled.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: [PASS][11] -> [FAIL][12] ([fdo#102887] / [fdo#105363])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-glk8/igt@kms_flip@flip-vs-expired-vblank.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-glk4/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
- shard-skl: [PASS][13] -> [FAIL][14] ([fdo#108040]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-wc:
- shard-skl: [PASS][15] -> [INCOMPLETE][16] ([fdo#110581]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl9/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-wc.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-skl: [PASS][17] -> [FAIL][18] ([fdo#103167])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl9/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#103167]) +5 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][21] -> [FAIL][22] ([fdo#108145])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109441]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb2/igt@kms_psr@psr2_basic.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb6/igt@kms_psr@psr2_basic.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][25] -> [FAIL][26] ([fdo#99912])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-apl1/igt@kms_setmode@basic.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-apl8/igt@kms_setmode@basic.html
* igt@kms_sysfs_edid_timing:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#100047])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb8/igt@kms_sysfs_edid_timing.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb2/igt@kms_sysfs_edid_timing.html
#### Possible fixes ####
* igt@gem_eio@in-flight-suspend:
- shard-kbl: [DMESG-WARN][29] ([fdo#103313]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-kbl3/igt@gem_eio@in-flight-suspend.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-kbl5/igt@gem_eio@in-flight-suspend.html
- shard-skl: [INCOMPLETE][31] ([fdo#104108] / [fdo#107773]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl1/igt@gem_eio@in-flight-suspend.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl7/igt@gem_eio@in-flight-suspend.html
* igt@i915_pm_rpm@debugfs-forcewake-user:
- shard-skl: [INCOMPLETE][33] ([fdo#107807]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl1/igt@i915_pm_rpm@debugfs-forcewake-user.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl2/igt@i915_pm_rpm@debugfs-forcewake-user.html
* igt@i915_selftest@mock_fence:
- shard-iclb: [INCOMPLETE][35] ([fdo#107713]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb7/igt@i915_selftest@mock_fence.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb8/igt@i915_selftest@mock_fence.html
* igt@i915_selftest@mock_requests:
- shard-skl: [INCOMPLETE][37] ([fdo#110550]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl8/igt@i915_selftest@mock_requests.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl3/igt@i915_selftest@mock_requests.html
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [DMESG-WARN][39] ([fdo#108566]) -> [PASS][40] +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-apl2/igt@i915_suspend@fence-restore-untiled.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-apl6/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-skl: [INCOMPLETE][41] ([fdo#110581]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl3/igt@kms_cursor_crc@cursor-128x128-onscreen.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl9/igt@kms_cursor_crc@cursor-128x128-onscreen.html
* igt@kms_cursor_crc@cursor-alpha-transparent:
- shard-skl: [FAIL][43] ([fdo#109350]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl7/igt@kms_cursor_crc@cursor-alpha-transparent.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl1/igt@kms_cursor_crc@cursor-alpha-transparent.html
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [INCOMPLETE][45] ([fdo#109507]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl4/igt@kms_flip@flip-vs-suspend.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl5/igt@kms_flip@flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt:
- shard-iclb: [FAIL][47] ([fdo#103167]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html
* igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
- shard-skl: [FAIL][49] ([fdo#103191]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl7/igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl1/igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence.html
* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-glk: [SKIP][51] ([fdo#109271]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-glk2/igt@kms_plane@pixel-format-pipe-c-planes.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-glk9/igt@kms_plane@pixel-format-pipe-c-planes.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][53] ([fdo#108145] / [fdo#110403]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
- shard-glk: [SKIP][55] ([fdo#109271] / [fdo#109278]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-glk1/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-glk9/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][57] ([fdo#108341]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb1/igt@kms_psr@no_drrs.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb5/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][59] ([fdo#109441]) -> [PASS][60] +4 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-iclb3/igt@kms_psr@psr2_cursor_plane_onoff.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@perf_pmu@enable-race-rcs0:
- shard-glk: [INCOMPLETE][61] ([fdo#103359] / [k.org#198133]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-glk2/igt@perf_pmu@enable-race-rcs0.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-glk3/igt@perf_pmu@enable-race-rcs0.html
#### Warnings ####
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-apl: [SKIP][63] ([fdo#109271]) -> [INCOMPLETE][64] ([fdo#103927])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6017/shard-apl3/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/shard-apl5/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110550]: https://bugs.freedesktop.org/show_bug.cgi?id=110550
[fdo#110581]: https://bugs.freedesktop.org/show_bug.cgi?id=110581
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_6017 -> Patchwork_12912
CI_DRM_6017: 69c3a37af9430650d1fc2a5555d4d0786898694d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4971: fc5e0467eb6913d21ad932aa8a31c77fdb5a9c77 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12912: b8472fe8ca94a9efbe9689f0c9ad6a6d875c809a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12912/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] drm/i915: Don't skip audio enable if ELD is bogus
2019-04-30 14:29 [PATCH 1/2] drm/i915: Don't skip audio enable if ELD is bogus Ville Syrjala
` (5 preceding siblings ...)
2019-05-02 8:07 ` ✓ Fi.CI.IGT: success " Patchwork
@ 2019-05-02 12:16 ` Jani Nikula
6 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2019-05-02 12:16 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On Tue, 30 Apr 2019, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We've already committed to enabling audio when intel_audio_codec_enable()
> is called. We can't back out even if the ELD has turned sour in the
> meantime. So just spew some debug log and plow ahead. Otherwise the
> state checker gets unhappy when audio isn't enabled when it is
> expected to be.
>
> I suppose we really ought to precompute the ELD as well, but
> let's just toss in a FIXME for the future.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103841
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_audio.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index bca4cc025d3d..68a24dada44c 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -644,8 +644,10 @@ void intel_audio_codec_enable(struct intel_encoder *encoder,
> enum port port = encoder->port;
> enum pipe pipe = crtc->pipe;
>
> + /* FIXME precompute the ELD in .compute_config() */
> if (!connector->eld[0])
> - return;
> + DRM_DEBUG_KMS("Bogus ELD on [CONNECTOR:%d:%s]\n",
> + connector->base.id, connector->name);
>
> DRM_DEBUG_DRIVER("ELD on [CONNECTOR:%d:%s], [ENCODER:%d:%s]\n",
> connector->base.id,
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] drm/i915: hsw+ audio regs are per-transocder
2019-04-30 14:29 ` [PATCH 2/2] drm/i915: hsw+ audio regs are per-transocder Ville Syrjala
@ 2019-05-02 12:16 ` Jani Nikula
2019-05-02 14:11 ` Ville Syrjälä
0 siblings, 1 reply; 10+ messages in thread
From: Jani Nikula @ 2019-05-02 12:16 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On Tue, 30 Apr 2019, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> s/pipe/transcoder/ when dealing with hsw+ audio registers. This
> won't actually make any real difference since there is no audio
> on the EDP transcoder. But this should avoid a bit of confusion
> when cross checking against the spec.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 12 +++----
> drivers/gpu/drm/i915/intel_audio.c | 55 ++++++++++++++----------------
> 2 files changed, 32 insertions(+), 35 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 6f0a0866c802..926e058d09ee 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -9010,32 +9010,32 @@ enum {
> /* HSW Audio */
> #define _HSW_AUD_CONFIG_A 0x65000
> #define _HSW_AUD_CONFIG_B 0x65100
> -#define HSW_AUD_CFG(pipe) _MMIO_PIPE(pipe, _HSW_AUD_CONFIG_A, _HSW_AUD_CONFIG_B)
> +#define HSW_AUD_CFG(trans) _MMIO_TRANS(trans, _HSW_AUD_CONFIG_A, _HSW_AUD_CONFIG_B)
>
> #define _HSW_AUD_MISC_CTRL_A 0x65010
> #define _HSW_AUD_MISC_CTRL_B 0x65110
> -#define HSW_AUD_MISC_CTRL(pipe) _MMIO_PIPE(pipe, _HSW_AUD_MISC_CTRL_A, _HSW_AUD_MISC_CTRL_B)
> +#define HSW_AUD_MISC_CTRL(trans) _MMIO_TRANS(trans, _HSW_AUD_MISC_CTRL_A, _HSW_AUD_MISC_CTRL_B)
>
> #define _HSW_AUD_M_CTS_ENABLE_A 0x65028
> #define _HSW_AUD_M_CTS_ENABLE_B 0x65128
> -#define HSW_AUD_M_CTS_ENABLE(pipe) _MMIO_PIPE(pipe, _HSW_AUD_M_CTS_ENABLE_A, _HSW_AUD_M_CTS_ENABLE_B)
> +#define HSW_AUD_M_CTS_ENABLE(trans) _MMIO_TRANS(trans, _HSW_AUD_M_CTS_ENABLE_A, _HSW_AUD_M_CTS_ENABLE_B)
> #define AUD_M_CTS_M_VALUE_INDEX (1 << 21)
> #define AUD_M_CTS_M_PROG_ENABLE (1 << 20)
> #define AUD_CONFIG_M_MASK 0xfffff
>
> #define _HSW_AUD_DIP_ELD_CTRL_ST_A 0x650b4
> #define _HSW_AUD_DIP_ELD_CTRL_ST_B 0x651b4
> -#define HSW_AUD_DIP_ELD_CTRL(pipe) _MMIO_PIPE(pipe, _HSW_AUD_DIP_ELD_CTRL_ST_A, _HSW_AUD_DIP_ELD_CTRL_ST_B)
> +#define HSW_AUD_DIP_ELD_CTRL(trans) _MMIO_TRANS(trans, _HSW_AUD_DIP_ELD_CTRL_ST_A, _HSW_AUD_DIP_ELD_CTRL_ST_B)
>
> /* Audio Digital Converter */
> #define _HSW_AUD_DIG_CNVT_1 0x65080
> #define _HSW_AUD_DIG_CNVT_2 0x65180
> -#define AUD_DIG_CNVT(pipe) _MMIO_PIPE(pipe, _HSW_AUD_DIG_CNVT_1, _HSW_AUD_DIG_CNVT_2)
> +#define AUD_DIG_CNVT(trans) _MMIO_TRANS(trans, _HSW_AUD_DIG_CNVT_1, _HSW_AUD_DIG_CNVT_2)
> #define DIP_PORT_SEL_MASK 0x3
>
> #define _HSW_AUD_EDID_DATA_A 0x65050
> #define _HSW_AUD_EDID_DATA_B 0x65150
> -#define HSW_AUD_EDID_DATA(pipe) _MMIO_PIPE(pipe, _HSW_AUD_EDID_DATA_A, _HSW_AUD_EDID_DATA_B)
> +#define HSW_AUD_EDID_DATA(trans) _MMIO_TRANS(trans, _HSW_AUD_EDID_DATA_A, _HSW_AUD_EDID_DATA_B)
>
> #define HSW_AUD_PIPE_CONV_CFG _MMIO(0x6507c)
> #define HSW_AUD_PIN_ELD_CP_VLD _MMIO(0x650c0)
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index 68a24dada44c..5c0b73f63843 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -319,9 +319,8 @@ hsw_dp_audio_config_update(struct intel_encoder *encoder,
> {
> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> struct i915_audio_component *acomp = dev_priv->audio_component;
> - struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc);
> + enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
> enum port port = encoder->port;
> - enum pipe pipe = crtc->pipe;
> const struct dp_aud_n_m *nm;
> int rate;
> u32 tmp;
> @@ -333,7 +332,7 @@ hsw_dp_audio_config_update(struct intel_encoder *encoder,
> else
> DRM_DEBUG_KMS("using automatic Maud, Naud\n");
>
> - tmp = I915_READ(HSW_AUD_CFG(pipe));
> + tmp = I915_READ(HSW_AUD_CFG(cpu_transcoder));
> tmp &= ~AUD_CONFIG_N_VALUE_INDEX;
> tmp &= ~AUD_CONFIG_PIXEL_CLOCK_HDMI_MASK;
> tmp &= ~AUD_CONFIG_N_PROG_ENABLE;
> @@ -345,9 +344,9 @@ hsw_dp_audio_config_update(struct intel_encoder *encoder,
> tmp |= AUD_CONFIG_N_PROG_ENABLE;
> }
>
> - I915_WRITE(HSW_AUD_CFG(pipe), tmp);
> + I915_WRITE(HSW_AUD_CFG(cpu_transcoder), tmp);
>
> - tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(pipe));
> + tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(cpu_transcoder));
> tmp &= ~AUD_CONFIG_M_MASK;
> tmp &= ~AUD_M_CTS_M_VALUE_INDEX;
> tmp &= ~AUD_M_CTS_M_PROG_ENABLE;
> @@ -358,7 +357,7 @@ hsw_dp_audio_config_update(struct intel_encoder *encoder,
> tmp |= AUD_M_CTS_M_PROG_ENABLE;
> }
>
> - I915_WRITE(HSW_AUD_M_CTS_ENABLE(pipe), tmp);
> + I915_WRITE(HSW_AUD_M_CTS_ENABLE(cpu_transcoder), tmp);
> }
>
> static void
> @@ -367,15 +366,14 @@ hsw_hdmi_audio_config_update(struct intel_encoder *encoder,
> {
> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> struct i915_audio_component *acomp = dev_priv->audio_component;
> - struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc);
> + enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
> enum port port = encoder->port;
> - enum pipe pipe = crtc->pipe;
> int n, rate;
> u32 tmp;
>
> rate = acomp ? acomp->aud_sample_rate[port] : 0;
>
> - tmp = I915_READ(HSW_AUD_CFG(pipe));
> + tmp = I915_READ(HSW_AUD_CFG(cpu_transcoder));
> tmp &= ~AUD_CONFIG_N_VALUE_INDEX;
> tmp &= ~AUD_CONFIG_PIXEL_CLOCK_HDMI_MASK;
> tmp &= ~AUD_CONFIG_N_PROG_ENABLE;
> @@ -392,16 +390,16 @@ hsw_hdmi_audio_config_update(struct intel_encoder *encoder,
> DRM_DEBUG_KMS("using automatic N\n");
> }
>
> - I915_WRITE(HSW_AUD_CFG(pipe), tmp);
> + I915_WRITE(HSW_AUD_CFG(cpu_transcoder), tmp);
>
> /*
> * Let's disable "Enable CTS or M Prog bit"
> * and let HW calculate the value
> */
> - tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(pipe));
> + tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(cpu_transcoder));
> tmp &= ~AUD_M_CTS_M_PROG_ENABLE;
> tmp &= ~AUD_M_CTS_M_VALUE_INDEX;
> - I915_WRITE(HSW_AUD_M_CTS_ENABLE(pipe), tmp);
> + I915_WRITE(HSW_AUD_M_CTS_ENABLE(cpu_transcoder), tmp);
> }
>
> static void
> @@ -419,28 +417,28 @@ static void hsw_audio_codec_disable(struct intel_encoder *encoder,
> const struct drm_connector_state *old_conn_state)
> {
> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> - struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->base.crtc);
> - enum pipe pipe = crtc->pipe;
> + enum transcoder cpu_transcoder = old_crtc_state->cpu_transcoder;
> u32 tmp;
>
> - DRM_DEBUG_KMS("Disable audio codec on pipe %c\n", pipe_name(pipe));
> + DRM_DEBUG_KMS("Disable audio codec on transcoder %s\n",
> + transcoder_name(cpu_transcoder));
>
> mutex_lock(&dev_priv->av_mutex);
>
> /* Disable timestamps */
> - tmp = I915_READ(HSW_AUD_CFG(pipe));
> + tmp = I915_READ(HSW_AUD_CFG(cpu_transcoder));
> tmp &= ~AUD_CONFIG_N_VALUE_INDEX;
> tmp |= AUD_CONFIG_N_PROG_ENABLE;
> tmp &= ~AUD_CONFIG_UPPER_N_MASK;
> tmp &= ~AUD_CONFIG_LOWER_N_MASK;
> if (intel_crtc_has_dp_encoder(old_crtc_state))
> tmp |= AUD_CONFIG_N_VALUE_INDEX;
> - I915_WRITE(HSW_AUD_CFG(pipe), tmp);
> + I915_WRITE(HSW_AUD_CFG(cpu_transcoder), tmp);
>
> /* Invalidate ELD */
> tmp = I915_READ(HSW_AUD_PIN_ELD_CP_VLD);
> - tmp &= ~AUDIO_ELD_VALID(pipe);
> - tmp &= ~AUDIO_OUTPUT_ENABLE(pipe);
> + tmp &= ~AUDIO_ELD_VALID(cpu_transcoder);
> + tmp &= ~AUDIO_OUTPUT_ENABLE(cpu_transcoder);
> I915_WRITE(HSW_AUD_PIN_ELD_CP_VLD, tmp);
>
> mutex_unlock(&dev_priv->av_mutex);
> @@ -451,22 +449,21 @@ static void hsw_audio_codec_enable(struct intel_encoder *encoder,
> const struct drm_connector_state *conn_state)
> {
> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> - struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc);
> struct drm_connector *connector = conn_state->connector;
> - enum pipe pipe = crtc->pipe;
> + enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
> const u8 *eld = connector->eld;
> u32 tmp;
> int len, i;
>
> - DRM_DEBUG_KMS("Enable audio codec on pipe %c, %u bytes ELD\n",
> - pipe_name(pipe), drm_eld_size(eld));
> + DRM_DEBUG_KMS("Enable audio codec on transcoder %s, %u bytes ELD\n",
> + transcoder_name(cpu_transcoder), drm_eld_size(eld));
>
> mutex_lock(&dev_priv->av_mutex);
>
> /* Enable audio presence detect, invalidate ELD */
> tmp = I915_READ(HSW_AUD_PIN_ELD_CP_VLD);
> - tmp |= AUDIO_OUTPUT_ENABLE(pipe);
> - tmp &= ~AUDIO_ELD_VALID(pipe);
> + tmp |= AUDIO_OUTPUT_ENABLE(cpu_transcoder);
> + tmp &= ~AUDIO_ELD_VALID(cpu_transcoder);
> I915_WRITE(HSW_AUD_PIN_ELD_CP_VLD, tmp);
>
> /*
> @@ -477,18 +474,18 @@ static void hsw_audio_codec_enable(struct intel_encoder *encoder,
> */
>
> /* Reset ELD write address */
> - tmp = I915_READ(HSW_AUD_DIP_ELD_CTRL(pipe));
> + tmp = I915_READ(HSW_AUD_DIP_ELD_CTRL(cpu_transcoder));
> tmp &= ~IBX_ELD_ADDRESS_MASK;
> - I915_WRITE(HSW_AUD_DIP_ELD_CTRL(pipe), tmp);
> + I915_WRITE(HSW_AUD_DIP_ELD_CTRL(cpu_transcoder), tmp);
>
> /* Up to 84 bytes of hw ELD buffer */
> len = min(drm_eld_size(eld), 84);
> for (i = 0; i < len / 4; i++)
> - I915_WRITE(HSW_AUD_EDID_DATA(pipe), *((const u32 *)eld + i));
> + I915_WRITE(HSW_AUD_EDID_DATA(cpu_transcoder), *((const u32 *)eld + i));
>
> /* ELD valid */
> tmp = I915_READ(HSW_AUD_PIN_ELD_CP_VLD);
> - tmp |= AUDIO_ELD_VALID(pipe);
> + tmp |= AUDIO_ELD_VALID(cpu_transcoder);
> I915_WRITE(HSW_AUD_PIN_ELD_CP_VLD, tmp);
>
> /* Enable timestamps */
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] drm/i915: hsw+ audio regs are per-transocder
2019-05-02 12:16 ` Jani Nikula
@ 2019-05-02 14:11 ` Ville Syrjälä
0 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjälä @ 2019-05-02 14:11 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Thu, May 02, 2019 at 03:16:37PM +0300, Jani Nikula wrote:
> On Tue, 30 Apr 2019, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > s/pipe/transcoder/ when dealing with hsw+ audio registers. This
> > won't actually make any real difference since there is no audio
> > on the EDP transcoder. But this should avoid a bit of confusion
> > when cross checking against the spec.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Thanks. Series pushed to dinq.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-05-02 14:11 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-30 14:29 [PATCH 1/2] drm/i915: Don't skip audio enable if ELD is bogus Ville Syrjala
2019-04-30 14:29 ` [PATCH 2/2] drm/i915: hsw+ audio regs are per-transocder Ville Syrjala
2019-05-02 12:16 ` Jani Nikula
2019-05-02 14:11 ` Ville Syrjälä
2019-04-30 15:06 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Don't skip audio enable if ELD is bogus Patchwork
2019-04-30 15:08 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-04-30 15:26 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-01 8:08 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-05-02 8:07 ` ✓ Fi.CI.IGT: success " Patchwork
2019-05-02 12:16 ` [PATCH 1/2] " Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.