* [Linux-kernel-mentees] [PATCH] Staging: rtl8192u: ieee80211: Fix coding style warning
@ 2019-05-02 5:59 ` Puranjay Mohan
0 siblings, 0 replies; 4+ messages in thread
From: puranjay12 @ 2019-05-02 5:59 UTC (permalink / raw)
Remove braces around a single if statement to fix following
checkpatch.pl warning.
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Puranjay Mohan <puranjay12 at gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
index 0e762e559675..c3433ade7144 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
@@ -2577,9 +2577,9 @@ static inline void ieee80211_process_probe_response(
spin_unlock_irqrestore(&ieee->lock, flags);
if (is_beacon(beacon->header.frame_ctl)&&is_same_network(&ieee->current_network, network, ieee)&&\
(ieee->state == IEEE80211_LINKED)) {
- if (ieee->handle_beacon != NULL) {
+ if (ieee->handle_beacon != NULL)
ieee->handle_beacon(ieee->dev,beacon,&ieee->current_network);
- }
+
}
out:
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Linux-kernel-mentees] [PATCH] Staging: rtl8192u: ieee80211: Fix coding style warning
@ 2019-05-02 5:59 ` Puranjay Mohan
0 siblings, 0 replies; 4+ messages in thread
From: Puranjay Mohan @ 2019-05-02 5:59 UTC (permalink / raw)
Remove braces around a single if statement to fix following
checkpatch.pl warning.
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Puranjay Mohan <puranjay12 at gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
index 0e762e559675..c3433ade7144 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
@@ -2577,9 +2577,9 @@ static inline void ieee80211_process_probe_response(
spin_unlock_irqrestore(&ieee->lock, flags);
if (is_beacon(beacon->header.frame_ctl)&&is_same_network(&ieee->current_network, network, ieee)&&\
(ieee->state == IEEE80211_LINKED)) {
- if (ieee->handle_beacon != NULL) {
+ if (ieee->handle_beacon != NULL)
ieee->handle_beacon(ieee->dev,beacon,&ieee->current_network);
- }
+
}
out:
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Linux-kernel-mentees] [PATCH] Staging: rtl8192u: ieee80211: Fix coding style warning
@ 2019-05-02 17:43 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: greg @ 2019-05-02 17:43 UTC (permalink / raw)
On Thu, May 02, 2019 at 11:29:23AM +0530, Puranjay Mohan wrote:
> Remove braces around a single if statement to fix following
> checkpatch.pl warning.
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Puranjay Mohan <puranjay12 at gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> index 0e762e559675..c3433ade7144 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> @@ -2577,9 +2577,9 @@ static inline void ieee80211_process_probe_response(
> spin_unlock_irqrestore(&ieee->lock, flags);
> if (is_beacon(beacon->header.frame_ctl)&&is_same_network(&ieee->current_network, network, ieee)&&\
> (ieee->state == IEEE80211_LINKED)) {
> - if (ieee->handle_beacon != NULL) {
> + if (ieee->handle_beacon != NULL)
> ieee->handle_beacon(ieee->dev,beacon,&ieee->current_network);
> - }
> +
Again you added trailing whitespace.
Git even complains when you try to apply this :(
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Linux-kernel-mentees] [PATCH] Staging: rtl8192u: ieee80211: Fix coding style warning
@ 2019-05-02 17:43 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-05-02 17:43 UTC (permalink / raw)
On Thu, May 02, 2019 at 11:29:23AM +0530, Puranjay Mohan wrote:
> Remove braces around a single if statement to fix following
> checkpatch.pl warning.
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Puranjay Mohan <puranjay12 at gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> index 0e762e559675..c3433ade7144 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> @@ -2577,9 +2577,9 @@ static inline void ieee80211_process_probe_response(
> spin_unlock_irqrestore(&ieee->lock, flags);
> if (is_beacon(beacon->header.frame_ctl)&&is_same_network(&ieee->current_network, network, ieee)&&\
> (ieee->state == IEEE80211_LINKED)) {
> - if (ieee->handle_beacon != NULL) {
> + if (ieee->handle_beacon != NULL)
> ieee->handle_beacon(ieee->dev,beacon,&ieee->current_network);
> - }
> +
Again you added trailing whitespace.
Git even complains when you try to apply this :(
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-02 17:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-02 5:59 [Linux-kernel-mentees] [PATCH] Staging: rtl8192u: ieee80211: Fix coding style warning puranjay12
2019-05-02 5:59 ` Puranjay Mohan
2019-05-02 17:43 ` greg
2019-05-02 17:43 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.