All of lore.kernel.org
 help / color / mirror / Atom feed
* [bug report] fpga manager: Adding FPGA Manager support for Xilinx zynqmp
@ 2019-05-02  7:31 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2019-05-02  7:31 UTC (permalink / raw)
  To: nava.manne; +Cc: linux-fpga

Hello Nava kishore Manne,

The patch c09f7471127e: "fpga manager: Adding FPGA Manager support
for Xilinx zynqmp" from Apr 15, 2019, leads to the following static
checker warning:

	drivers/fpga/zynqmp-fpga.c:50 zynqmp_fpga_ops_write()
	error: 'eemi_ops' dereferencing possible ERR_PTR()

drivers/fpga/zynqmp-fpga.c
    40  static int zynqmp_fpga_ops_write(struct fpga_manager *mgr,
    41                                   const char *buf, size_t size)
    42  {
    43          const struct zynqmp_eemi_ops *eemi_ops = zynqmp_pm_get_eemi_ops();
    44          struct zynqmp_fpga_priv *priv;
    45          dma_addr_t dma_addr;
    46          u32 eemi_flags = 0;
    47          char *kbuf;
    48          int ret;
    49  
    50          if (!eemi_ops || !eemi_ops->fpga_load)
                     ^^^^^^^^
This is an error pointer.  Possibly you want to handle EPROBE_DEFER in
a special way?

    51                  return -ENXIO;
    52  

See also:

drivers/fpga/zynqmp-fpga.c:84 zynqmp_fpga_ops_state() error: 'eemi_ops' dereferencing possible ERR_PTR()

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-05-02  7:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-02  7:31 [bug report] fpga manager: Adding FPGA Manager support for Xilinx zynqmp Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.