[dpdk-dev] [PATCH v1 1/3] doc/distributor: add SST-BF enhancement info

[dpdk-dev] [PATCH v1 1/3] doc/distributor: add SST-BF enhancement info

[David Hunt]

The distributor sample application has been enhanced to be aware of
Intel SST-BF high frequency cores. Docs also contain a link to
the Intel SST-BF application note.

Signed-off-by: David Hunt <david.hunt@intel.com>
---
 doc/guides/sample_app_ug/dist_app.rst | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/doc/guides/sample_app_ug/dist_app.rst b/doc/guides/sample_app_ug/dist_app.rst
index abfdd2c5e..90270e3a5 100644
--- a/doc/guides/sample_app_ug/dist_app.rst
+++ b/doc/guides/sample_app_ug/dist_app.rst
@@ -5,7 +5,9 @@ Distributor Sample Application
 ==============================
 
 The distributor sample application is a simple example of packet distribution
-to cores using the Data Plane Development Kit (DPDK).
+to cores using the Data Plane Development Kit (DPDK). It also makes use of
+Intel Speed Select Technology - Base Frequency (Intel SST-BF) to pin the
+distributor to the higher frequency core if available.
 
 Overview
 --------
@@ -101,6 +103,22 @@ final statistics to the user.
    Distributor Sample Application Layout
 
 
+Intel SST-BF Support
+--------------------
+
+In DPDK 19.05, support was added to the power management library for
+Intel-SST-BF, a technology that allows some cores to run at a higher
+frequency than others. An application note for Intel SST-BF is available,
+and is entitled
+`Intel Speed Select Technology – Base Frequency - Enhancing Performance <https://builders.intel.com/docs/networkbuilders/intel-speed-select-technology-base-frequency-enhancing-performance.pdf>`_
+
+The distributor application was also enhanced to be aware of these higher
+frequency SST-BF cores, and when starting the application, if high frequency
+SST-BF cores are present in the core mask, the application will identify these
+cores and pin the workloads appropriately. The distributor core is usually
+the bottleneck, so this is given first choice of the high frequency SST-BF
+cores, followed by the rx core and the tx core.
+
 Debug Logging Support
 ---------------------
 
-- 
2.17.1

[dpdk-dev] [PATCH v1 2/3] doc: add release note for power changes

[David Hunt]

In the Power Library, a new bit has been added to the mask returned by
rte_power_get_capabilities which indicates whether the core is an
Intel SST-BF high frequency core.

The Distributor sample app has also been enhanced to make use of SST-BF
cores, and pin relevant workloads to the higher frequency cores, if
available in the core mask provided to the application.

Signed-off-by: David Hunt <david.hunt@intel.com>
---
 doc/guides/rel_notes/release_19_05.rst | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst
index d5ed564ab..b0b71dc7b 100644
--- a/doc/guides/rel_notes/release_19_05.rst
+++ b/doc/guides/rel_notes/release_19_05.rst
@@ -187,6 +187,17 @@ New Features
   Improved testpmd application performance on ARM platform. For ``macswap``
   forwarding mode, NEON intrinsics were used to do swap to save CPU cycles.
 
+* **Updated power management library.**
+
+  Added support for Intel Speed Select Technology - Base Frequency (SST-BF).
+  ``rte_power_get_capabilities`` now has a bit in it's returned mask
+  indicating it's a high frequency core.
+
+* **Updated distributor sample application.**
+
+  Added support for Intel SST-BF feature so that the distributor core is
+  pinned to a high frequency core if available.
+
 
 Removed Items
 -------------
-- 
2.17.1

[dpdk-dev] [PATCH v1 3/3] lib/power: clarify comment on priority core

[David Hunt]

As part of the documentation update on the changes made to the power
library for 19.05, information on SST-BF was added. This patch updates
the comment to clarify that a priority core is an SST-BF high
frequency core.

Signed-off-by: David Hunt <david.hunt@intel.com>
---
 lib/librte_power/rte_power.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_power/rte_power.h b/lib/librte_power/rte_power.h
index 0650112ad..01f88588b 100644
--- a/lib/librte_power/rte_power.h
+++ b/lib/librte_power/rte_power.h
@@ -259,7 +259,7 @@ struct rte_power_core_capabilities {
 		RTE_STD_C11
 		struct {
 			uint64_t turbo:1;	/**< Turbo can be enabled. */
-			uint64_t priority:1;	/**< Priority core */
+			uint64_t priority:1;	/**< SST-BF high freq core */
 		};
 	};
 };
-- 
2.17.1

Re: [dpdk-dev] [PATCH v1 1/3] doc/distributor: add SST-BF enhancement info

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt
> Sent: Thursday, May 2, 2019 12:18 PM
> To: dev@dpdk.org
> Cc: Hunt, David <david.hunt@intel.com>
> Subject: [dpdk-dev] [PATCH v1 1/3] doc/distributor: add SST-BF enhancement
> info
> 
> The distributor sample application has been enhanced to be aware of Intel
> SST-BF high frequency cores. Docs also contain a link to the Intel SST-BF
> application note.

Acked-by: John McNamara <john.mcnamara@intel.com>

Re: [dpdk-dev] [PATCH v1 2/3] doc: add release note for power changes

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt
> Sent: Thursday, May 2, 2019 12:18 PM
> To: dev@dpdk.org
> Cc: Hunt, David <david.hunt@intel.com>
> Subject: [dpdk-dev] [PATCH v1 2/3] doc: add release note for power changes
> 
> In the Power Library, a new bit has been added to the mask returned by
> rte_power_get_capabilities which indicates whether the core is an Intel
> SST-BF high frequency core.
> 
> The Distributor sample app has also been enhanced to make use of SST-BF
> cores, and pin relevant workloads to the higher frequency cores, if
> available in the core mask provided to the application.
> 

Acked-by: John McNamara <john.mcnamara@intel.com>

Re: [dpdk-dev] [PATCH v1 3/3] lib/power: clarify comment on priority core

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt
> Sent: Thursday, May 2, 2019 12:18 PM
> To: dev@dpdk.org
> Cc: Hunt, David <david.hunt@intel.com>
> Subject: [dpdk-dev] [PATCH v1 3/3] lib/power: clarify comment on priority
> core
> 
> As part of the documentation update on the changes made to the power
> library for 19.05, information on SST-BF was added. This patch updates the
> comment to clarify that a priority core is an SST-BF high frequency core.


Acked-by: John McNamara <john.mcnamara@intel.com>

Re: [dpdk-dev] [PATCH v1 2/3] doc: add release note for power changes

[Thomas Monjalon]

02/05/2019 17:55, Mcnamara, John:
> From: David Hunt
> > In the Power Library, a new bit has been added to the mask returned by
> > rte_power_get_capabilities which indicates whether the core is an Intel
> > SST-BF high frequency core.
> > 
> > The Distributor sample app has also been enhanced to make use of SST-BF
> > cores, and pin relevant workloads to the higher frequency cores, if
> > available in the core mask provided to the application.
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied. Please try to update the release notes at the same time
as the code. Thanks