From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, michal.kalderon@marvell.com,
ariel.elior@marvell.com, davem@davemloft.net, jgg@ziepe.ca,
dledford@redhat.com, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH net-next 02/10] qed: Add llh ppfid interface and 100g support for offload protocols
Date: Thu, 2 May 2019 20:29:40 +0800 [thread overview]
Message-ID: <201905022034.5Vq0Y0M3%lkp@intel.com> (raw)
In-Reply-To: <20190501095722.6902-3-michal.kalderon@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 3795 bytes --]
Hi Michal,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Michal-Kalderon/qed-Improve-performance-on-100G-link-for-offload-protocols/20190502-143528
config: x86_64-randconfig-b0-05021924 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/net/ethernet/qlogic/qed/qed_dev.c: In function 'qed_llh_add_mac_filter':
>> drivers/net/ethernet/qlogic/qed/qed_dev.c:981:8: warning: missing braces around initializer [-Wmissing-braces]
union qed_llh_filter filter = {0};
^
drivers/net/ethernet/qlogic/qed/qed_dev.c:981:8: warning: (near initialization for 'filter.mac') [-Wmissing-braces]
drivers/net/ethernet/qlogic/qed/qed_dev.c: In function 'qed_llh_add_protocol_filter':
drivers/net/ethernet/qlogic/qed/qed_dev.c:1115:8: warning: missing braces around initializer [-Wmissing-braces]
union qed_llh_filter filter = {0};
^
drivers/net/ethernet/qlogic/qed/qed_dev.c:1115:8: warning: (near initialization for 'filter.mac') [-Wmissing-braces]
drivers/net/ethernet/qlogic/qed/qed_dev.c: In function 'qed_llh_remove_mac_filter':
drivers/net/ethernet/qlogic/qed/qed_dev.c:1181:8: warning: missing braces around initializer [-Wmissing-braces]
union qed_llh_filter filter = {0};
^
drivers/net/ethernet/qlogic/qed/qed_dev.c:1181:8: warning: (near initialization for 'filter.mac') [-Wmissing-braces]
drivers/net/ethernet/qlogic/qed/qed_dev.c: In function 'qed_llh_remove_protocol_filter':
drivers/net/ethernet/qlogic/qed/qed_dev.c:1232:8: warning: missing braces around initializer [-Wmissing-braces]
union qed_llh_filter filter = {0};
^
drivers/net/ethernet/qlogic/qed/qed_dev.c:1232:8: warning: (near initialization for 'filter.mac') [-Wmissing-braces]
vim +981 drivers/net/ethernet/qlogic/qed/qed_dev.c
975
976 int qed_llh_add_mac_filter(struct qed_dev *cdev,
977 u8 ppfid, u8 mac_addr[ETH_ALEN])
978 {
979 struct qed_hwfn *p_hwfn = QED_LEADING_HWFN(cdev);
980 struct qed_ptt *p_ptt = qed_ptt_acquire(p_hwfn);
> 981 union qed_llh_filter filter = {0};
982 u8 filter_idx, abs_ppfid;
983 u32 high, low, ref_cnt;
984 int rc = 0;
985
986 if (!p_ptt)
987 return -EAGAIN;
988
989 if (!test_bit(QED_MF_LLH_MAC_CLSS, &cdev->mf_bits))
990 goto out;
991
992 memcpy(filter.mac.addr, mac_addr, ETH_ALEN);
993 rc = qed_llh_shadow_add_filter(cdev, ppfid,
994 QED_LLH_FILTER_TYPE_MAC,
995 &filter, &filter_idx, &ref_cnt);
996 if (rc)
997 goto err;
998
999 /* Configure the LLH only in case of a new the filter */
1000 if (ref_cnt == 1) {
1001 rc = qed_llh_abs_ppfid(cdev, ppfid, &abs_ppfid);
1002 if (rc)
1003 goto err;
1004
1005 high = mac_addr[1] | (mac_addr[0] << 8);
1006 low = mac_addr[5] | (mac_addr[4] << 8) | (mac_addr[3] << 16) |
1007 (mac_addr[2] << 24);
1008 rc = qed_llh_add_filter(p_hwfn, p_ptt, abs_ppfid, filter_idx,
1009 0, high, low);
1010 if (rc)
1011 goto err;
1012 }
1013
1014 DP_VERBOSE(cdev,
1015 QED_MSG_SP,
1016 "LLH: Added MAC filter [%pM] to ppfid %hhd [abs %hhd] at idx %hhd [ref_cnt %d]\n",
1017 mac_addr, ppfid, abs_ppfid, filter_idx, ref_cnt);
1018
1019 goto out;
1020
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32094 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Michal Kalderon <michal.kalderon@marvell.com>
Cc: kbuild-all@01.org, michal.kalderon@marvell.com,
ariel.elior@marvell.com, davem@davemloft.net, jgg@ziepe.ca,
dledford@redhat.com, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH net-next 02/10] qed: Add llh ppfid interface and 100g support for offload protocols
Date: Thu, 2 May 2019 20:29:40 +0800 [thread overview]
Message-ID: <201905022034.5Vq0Y0M3%lkp@intel.com> (raw)
In-Reply-To: <20190501095722.6902-3-michal.kalderon@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 3795 bytes --]
Hi Michal,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Michal-Kalderon/qed-Improve-performance-on-100G-link-for-offload-protocols/20190502-143528
config: x86_64-randconfig-b0-05021924 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/net/ethernet/qlogic/qed/qed_dev.c: In function 'qed_llh_add_mac_filter':
>> drivers/net/ethernet/qlogic/qed/qed_dev.c:981:8: warning: missing braces around initializer [-Wmissing-braces]
union qed_llh_filter filter = {0};
^
drivers/net/ethernet/qlogic/qed/qed_dev.c:981:8: warning: (near initialization for 'filter.mac') [-Wmissing-braces]
drivers/net/ethernet/qlogic/qed/qed_dev.c: In function 'qed_llh_add_protocol_filter':
drivers/net/ethernet/qlogic/qed/qed_dev.c:1115:8: warning: missing braces around initializer [-Wmissing-braces]
union qed_llh_filter filter = {0};
^
drivers/net/ethernet/qlogic/qed/qed_dev.c:1115:8: warning: (near initialization for 'filter.mac') [-Wmissing-braces]
drivers/net/ethernet/qlogic/qed/qed_dev.c: In function 'qed_llh_remove_mac_filter':
drivers/net/ethernet/qlogic/qed/qed_dev.c:1181:8: warning: missing braces around initializer [-Wmissing-braces]
union qed_llh_filter filter = {0};
^
drivers/net/ethernet/qlogic/qed/qed_dev.c:1181:8: warning: (near initialization for 'filter.mac') [-Wmissing-braces]
drivers/net/ethernet/qlogic/qed/qed_dev.c: In function 'qed_llh_remove_protocol_filter':
drivers/net/ethernet/qlogic/qed/qed_dev.c:1232:8: warning: missing braces around initializer [-Wmissing-braces]
union qed_llh_filter filter = {0};
^
drivers/net/ethernet/qlogic/qed/qed_dev.c:1232:8: warning: (near initialization for 'filter.mac') [-Wmissing-braces]
vim +981 drivers/net/ethernet/qlogic/qed/qed_dev.c
975
976 int qed_llh_add_mac_filter(struct qed_dev *cdev,
977 u8 ppfid, u8 mac_addr[ETH_ALEN])
978 {
979 struct qed_hwfn *p_hwfn = QED_LEADING_HWFN(cdev);
980 struct qed_ptt *p_ptt = qed_ptt_acquire(p_hwfn);
> 981 union qed_llh_filter filter = {0};
982 u8 filter_idx, abs_ppfid;
983 u32 high, low, ref_cnt;
984 int rc = 0;
985
986 if (!p_ptt)
987 return -EAGAIN;
988
989 if (!test_bit(QED_MF_LLH_MAC_CLSS, &cdev->mf_bits))
990 goto out;
991
992 memcpy(filter.mac.addr, mac_addr, ETH_ALEN);
993 rc = qed_llh_shadow_add_filter(cdev, ppfid,
994 QED_LLH_FILTER_TYPE_MAC,
995 &filter, &filter_idx, &ref_cnt);
996 if (rc)
997 goto err;
998
999 /* Configure the LLH only in case of a new the filter */
1000 if (ref_cnt == 1) {
1001 rc = qed_llh_abs_ppfid(cdev, ppfid, &abs_ppfid);
1002 if (rc)
1003 goto err;
1004
1005 high = mac_addr[1] | (mac_addr[0] << 8);
1006 low = mac_addr[5] | (mac_addr[4] << 8) | (mac_addr[3] << 16) |
1007 (mac_addr[2] << 24);
1008 rc = qed_llh_add_filter(p_hwfn, p_ptt, abs_ppfid, filter_idx,
1009 0, high, low);
1010 if (rc)
1011 goto err;
1012 }
1013
1014 DP_VERBOSE(cdev,
1015 QED_MSG_SP,
1016 "LLH: Added MAC filter [%pM] to ppfid %hhd [abs %hhd] at idx %hhd [ref_cnt %d]\n",
1017 mac_addr, ppfid, abs_ppfid, filter_idx, ref_cnt);
1018
1019 goto out;
1020
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32094 bytes --]
next prev parent reply other threads:[~2019-05-02 12:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 9:57 [PATCH net-next 00/10] qed*: Improve performance on 100G link for offload protocols Michal Kalderon
2019-05-01 9:57 ` Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 01/10] qed: Modify api for performing a dmae to another PF Michal Kalderon
2019-05-01 9:57 ` Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 02/10] qed: Add llh ppfid interface and 100g support for offload protocols Michal Kalderon
2019-05-01 9:57 ` Michal Kalderon
2019-05-02 12:29 ` kbuild test robot [this message]
2019-05-02 12:29 ` kbuild test robot
2019-05-01 9:57 ` [PATCH net-next 03/10] qed: Change hwfn used for sb initialization Michal Kalderon
2019-05-01 9:57 ` Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 04/10] qed: Modify offload protocols to use the affined engine Michal Kalderon
2019-05-01 9:57 ` Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 05/10] qedr: Change the MSI-X vectors selection to be based on " Michal Kalderon
2019-05-01 9:57 ` Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 06/10] qed: Set the doorbell address correctly Michal Kalderon
2019-05-01 9:57 ` Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 07/10] qed*: Add iWARP 100g support Michal Kalderon
2019-05-01 9:57 ` Michal Kalderon
2019-05-02 0:35 ` David Miller
2019-05-02 5:13 ` Leon Romanovsky
2019-05-02 12:10 ` [EXT] " Michal Kalderon
2019-05-02 12:31 ` Leon Romanovsky
2019-05-02 20:38 ` Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 08/10] Revert "scsi: qedi: Allocate IRQs based on msix_cnt" Michal Kalderon
2019-05-01 9:57 ` Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 09/10] qedi: Use hwfns and affin_hwfn_idx to get MSI-X vector index Michal Kalderon
2019-05-01 9:57 ` Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 10/10] qedf: Use hwfns and affin_hwfn_idx to get MSI-X vector index to use Michal Kalderon
2019-05-01 9:57 ` Michal Kalderon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201905022034.5Vq0Y0M3%lkp@intel.com \
--to=lkp@intel.com \
--cc=ariel.elior@marvell.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kbuild-all@01.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michal.kalderon@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.