[tip:sched/core 24/27] kernel/power/suspend.c:431:10: error: implicit declaration of function 'suspend_disable_secondary_cpus'

* [tip:sched/core 24/27] kernel/power/suspend.c:431:10: error: implicit declaration of function 'suspend_disable_secondary_cpus'
@ 2019-05-03 12:34 kbuild test robot
  2019-05-03 16:04 ` Peter Zijlstra
  0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2019-05-03 12:34 UTC (permalink / raw)
  To: Nicholas Piggin
  Cc: kbuild-all, linux-kernel, tipbuild, Ingo Molnar, Peter Zijlstra (Intel)

[-- Attachment #1: Type: text/plain, Size: 3989 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core
head:   65874bd36e6ae3028539e989bfb5c28ad457368e
commit: c2cb30bfceceba8a2a0d5713230a250dd6140e22 [24/27] power/suspend: Add function to disable secondaries for suspend
config: x86_64-randconfig-l3-05031806 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
        git checkout c2cb30bfceceba8a2a0d5713230a250dd6140e22
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   kernel/power/suspend.c: In function 'suspend_enter':
>> kernel/power/suspend.c:431:10: error: implicit declaration of function 'suspend_disable_secondary_cpus' [-Werror=implicit-function-declaration]
     error = suspend_disable_secondary_cpus();
             ^
>> kernel/power/suspend.c:461:2: error: implicit declaration of function 'suspend_enable_secondary_cpus' [-Werror=implicit-function-declaration]
     suspend_enable_secondary_cpus();
     ^
   cc1: some warnings being treated as errors

vim +/suspend_disable_secondary_cpus +431 kernel/power/suspend.c

   389	
   390	/**
   391	 * suspend_enter - Make the system enter the given sleep state.
   392	 * @state: System sleep state to enter.
   393	 * @wakeup: Returns information that the sleep state should not be re-entered.
   394	 *
   395	 * This function should be called after devices have been suspended.
   396	 */
   397	static int suspend_enter(suspend_state_t state, bool *wakeup)
   398	{
   399		int error;
   400	
   401		error = platform_suspend_prepare(state);
   402		if (error)
   403			goto Platform_finish;
   404	
   405		error = dpm_suspend_late(PMSG_SUSPEND);
   406		if (error) {
   407			pr_err("late suspend of devices failed\n");
   408			goto Platform_finish;
   409		}
   410		error = platform_suspend_prepare_late(state);
   411		if (error)
   412			goto Devices_early_resume;
   413	
   414		if (state == PM_SUSPEND_TO_IDLE && pm_test_level != TEST_PLATFORM) {
   415			s2idle_loop();
   416			goto Platform_early_resume;
   417		}
   418	
   419		error = dpm_suspend_noirq(PMSG_SUSPEND);
   420		if (error) {
   421			pr_err("noirq suspend of devices failed\n");
   422			goto Platform_early_resume;
   423		}
   424		error = platform_suspend_prepare_noirq(state);
   425		if (error)
   426			goto Platform_wake;
   427	
   428		if (suspend_test(TEST_PLATFORM))
   429			goto Platform_wake;
   430	
 > 431		error = suspend_disable_secondary_cpus();
   432		if (error || suspend_test(TEST_CPUS))
   433			goto Enable_cpus;
   434	
   435		arch_suspend_disable_irqs();
   436		BUG_ON(!irqs_disabled());
   437	
   438		system_state = SYSTEM_SUSPEND;
   439	
   440		error = syscore_suspend();
   441		if (!error) {
   442			*wakeup = pm_wakeup_pending();
   443			if (!(suspend_test(TEST_CORE) || *wakeup)) {
   444				trace_suspend_resume(TPS("machine_suspend"),
   445					state, true);
   446				error = suspend_ops->enter(state);
   447				trace_suspend_resume(TPS("machine_suspend"),
   448					state, false);
   449			} else if (*wakeup) {
   450				error = -EBUSY;
   451			}
   452			syscore_resume();
   453		}
   454	
   455		system_state = SYSTEM_RUNNING;
   456	
   457		arch_suspend_enable_irqs();
   458		BUG_ON(irqs_disabled());
   459	
   460	 Enable_cpus:
 > 461		suspend_enable_secondary_cpus();
   462	
   463	 Platform_wake:
   464		platform_resume_noirq(state);
   465		dpm_resume_noirq(PMSG_RESUME);
   466	
   467	 Platform_early_resume:
   468		platform_resume_early(state);
   469	
   470	 Devices_early_resume:
   471		dpm_resume_early(PMSG_RESUME);
   472	
   473	 Platform_finish:
   474		platform_resume_finish(state);
   475		return error;
   476	}
   477	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32942 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread