* Re: [PATCH -next] KVM: s390: fix typo in parameter description
2019-05-04 6:51 [PATCH -next] KVM: s390: fix typo in parameter description Wei Yongjun
@ 2019-05-05 11:19 ` Cornelia Huck
2019-05-06 6:26 ` Christian Borntraeger
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Cornelia Huck @ 2019-05-05 11:19 UTC (permalink / raw)
To: kernel-janitors
On Sat, 4 May 2019 06:51:45 +0000
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> Fix typo in parameter description.
>
> Fixes: 8b905d28ee17 ("KVM: s390: provide kvm_arch_no_poll function")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> arch/s390/kvm/kvm-s390.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 8d6d75db8de6..ac6163c334d6 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -181,7 +181,7 @@ MODULE_PARM_DESC(hpage, "1m huge page backing support");
> /* maximum percentage of steal time for polling. >100 is treated like 100 */
> static u8 halt_poll_max_steal = 10;
> module_param(halt_poll_max_steal, byte, 0644);
> -MODULE_PARM_DESC(hpage, "Maximum percentage of steal time to allow polling");
> +MODULE_PARM_DESC(halt_poll_max_steal, "Maximum percentage of steal time to allow polling");
>
> /*
> * For now we handle at most 16 double words as this is what the s390 base
>
>
>
Whoops.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH -next] KVM: s390: fix typo in parameter description
2019-05-04 6:51 [PATCH -next] KVM: s390: fix typo in parameter description Wei Yongjun
2019-05-05 11:19 ` Cornelia Huck
@ 2019-05-06 6:26 ` Christian Borntraeger
2019-05-06 7:52 ` Christian Borntraeger
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Christian Borntraeger @ 2019-05-06 6:26 UTC (permalink / raw)
To: kernel-janitors
Paolo, Radim,
can you pick this up directly?
On 05.05.19 13:19, Cornelia Huck wrote:
> On Sat, 4 May 2019 06:51:45 +0000
> Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
>> Fix typo in parameter description.
>>
>> Fixes: 8b905d28ee17 ("KVM: s390: provide kvm_arch_no_poll function")
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> ---
>> arch/s390/kvm/kvm-s390.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>> index 8d6d75db8de6..ac6163c334d6 100644
>> --- a/arch/s390/kvm/kvm-s390.c
>> +++ b/arch/s390/kvm/kvm-s390.c
>> @@ -181,7 +181,7 @@ MODULE_PARM_DESC(hpage, "1m huge page backing support");
>> /* maximum percentage of steal time for polling. >100 is treated like 100 */
>> static u8 halt_poll_max_steal = 10;
>> module_param(halt_poll_max_steal, byte, 0644);
>> -MODULE_PARM_DESC(hpage, "Maximum percentage of steal time to allow polling");
>> +MODULE_PARM_DESC(halt_poll_max_steal, "Maximum percentage of steal time to allow polling");
>>
>> /*
>> * For now we handle at most 16 double words as this is what the s390 base
>>
>>
>>
>
> Whoops.
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH -next] KVM: s390: fix typo in parameter description
2019-05-04 6:51 [PATCH -next] KVM: s390: fix typo in parameter description Wei Yongjun
2019-05-05 11:19 ` Cornelia Huck
2019-05-06 6:26 ` Christian Borntraeger
@ 2019-05-06 7:52 ` Christian Borntraeger
2019-05-06 9:40 ` David Hildenbrand
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Christian Borntraeger @ 2019-05-06 7:52 UTC (permalink / raw)
To: kernel-janitors
On 04.05.19 08:51, Wei Yongjun wrote:
> Fix typo in parameter description.
>
> Fixes: 8b905d28ee17 ("KVM: s390: provide kvm_arch_no_poll function")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> arch/s390/kvm/kvm-s390.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 8d6d75db8de6..ac6163c334d6 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -181,7 +181,7 @@ MODULE_PARM_DESC(hpage, "1m huge page backing support");
> /* maximum percentage of steal time for polling. >100 is treated like 100 */
> static u8 halt_poll_max_steal = 10;
> module_param(halt_poll_max_steal, byte, 0644);
> -MODULE_PARM_DESC(hpage, "Maximum percentage of steal time to allow polling");
> +MODULE_PARM_DESC(halt_poll_max_steal, "Maximum percentage of steal time to allow polling");
>
> /*
> * For now we handle at most 16 double words as this is what the s390 base
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH -next] KVM: s390: fix typo in parameter description
2019-05-04 6:51 [PATCH -next] KVM: s390: fix typo in parameter description Wei Yongjun
` (2 preceding siblings ...)
2019-05-06 7:52 ` Christian Borntraeger
@ 2019-05-06 9:40 ` David Hildenbrand
2019-05-14 8:44 ` Christian Borntraeger
2019-05-20 7:41 ` Christian Borntraeger
5 siblings, 0 replies; 8+ messages in thread
From: David Hildenbrand @ 2019-05-06 9:40 UTC (permalink / raw)
To: kernel-janitors
On 04.05.19 08:51, Wei Yongjun wrote:
> Fix typo in parameter description.
>
> Fixes: 8b905d28ee17 ("KVM: s390: provide kvm_arch_no_poll function")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> arch/s390/kvm/kvm-s390.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 8d6d75db8de6..ac6163c334d6 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -181,7 +181,7 @@ MODULE_PARM_DESC(hpage, "1m huge page backing support");
> /* maximum percentage of steal time for polling. >100 is treated like 100 */
> static u8 halt_poll_max_steal = 10;
> module_param(halt_poll_max_steal, byte, 0644);
> -MODULE_PARM_DESC(hpage, "Maximum percentage of steal time to allow polling");
> +MODULE_PARM_DESC(halt_poll_max_steal, "Maximum percentage of steal time to allow polling");
>
> /*
> * For now we handle at most 16 double words as this is what the s390 base
>
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH -next] KVM: s390: fix typo in parameter description
2019-05-04 6:51 [PATCH -next] KVM: s390: fix typo in parameter description Wei Yongjun
` (3 preceding siblings ...)
2019-05-06 9:40 ` David Hildenbrand
@ 2019-05-14 8:44 ` Christian Borntraeger
2019-05-20 7:41 ` Christian Borntraeger
5 siblings, 0 replies; 8+ messages in thread
From: Christian Borntraeger @ 2019-05-14 8:44 UTC (permalink / raw)
To: kernel-janitors
On 06.05.19 08:26, Christian Borntraeger wrote:
> Paolo, Radim,
>
> can you pick this up directly?
ping.
>
>
> On 05.05.19 13:19, Cornelia Huck wrote:
>> On Sat, 4 May 2019 06:51:45 +0000
>> Wei Yongjun <weiyongjun1@huawei.com> wrote:
>>
>>> Fix typo in parameter description.
>>>
>>> Fixes: 8b905d28ee17 ("KVM: s390: provide kvm_arch_no_poll function")
>>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>>> ---
>>> arch/s390/kvm/kvm-s390.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>>> index 8d6d75db8de6..ac6163c334d6 100644
>>> --- a/arch/s390/kvm/kvm-s390.c
>>> +++ b/arch/s390/kvm/kvm-s390.c
>>> @@ -181,7 +181,7 @@ MODULE_PARM_DESC(hpage, "1m huge page backing support");
>>> /* maximum percentage of steal time for polling. >100 is treated like 100 */
>>> static u8 halt_poll_max_steal = 10;
>>> module_param(halt_poll_max_steal, byte, 0644);
>>> -MODULE_PARM_DESC(hpage, "Maximum percentage of steal time to allow polling");
>>> +MODULE_PARM_DESC(halt_poll_max_steal, "Maximum percentage of steal time to allow polling");
>>>
>>> /*
>>> * For now we handle at most 16 double words as this is what the s390 base
>>>
>>>
>>>
>>
>> Whoops.
>>
>> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH -next] KVM: s390: fix typo in parameter description
2019-05-04 6:51 [PATCH -next] KVM: s390: fix typo in parameter description Wei Yongjun
` (4 preceding siblings ...)
2019-05-14 8:44 ` Christian Borntraeger
@ 2019-05-20 7:41 ` Christian Borntraeger
2019-05-20 10:40 ` Paolo Bonzini
5 siblings, 1 reply; 8+ messages in thread
From: Christian Borntraeger @ 2019-05-20 7:41 UTC (permalink / raw)
To: kernel-janitors
On 06.05.19 09:52, Christian Borntraeger wrote:
>
>
> On 04.05.19 08:51, Wei Yongjun wrote:
>> Fix typo in parameter description.
>>
>> Fixes: 8b905d28ee17 ("KVM: s390: provide kvm_arch_no_poll function")
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Since I have another fix pending, I now picked this up myself and
this will be in my next pull request for 5.2-rc2.
>
>> ---
>> arch/s390/kvm/kvm-s390.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>> index 8d6d75db8de6..ac6163c334d6 100644
>> --- a/arch/s390/kvm/kvm-s390.c
>> +++ b/arch/s390/kvm/kvm-s390.c
>> @@ -181,7 +181,7 @@ MODULE_PARM_DESC(hpage, "1m huge page backing support");
>> /* maximum percentage of steal time for polling. >100 is treated like 100 */
>> static u8 halt_poll_max_steal = 10;
>> module_param(halt_poll_max_steal, byte, 0644);
>> -MODULE_PARM_DESC(hpage, "Maximum percentage of steal time to allow polling");
>> +MODULE_PARM_DESC(halt_poll_max_steal, "Maximum percentage of steal time to allow polling");
>>
>> /*
>> * For now we handle at most 16 double words as this is what the s390 base
>>
>>
>>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH -next] KVM: s390: fix typo in parameter description
2019-05-20 7:41 ` Christian Borntraeger
@ 2019-05-20 10:40 ` Paolo Bonzini
0 siblings, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2019-05-20 10:40 UTC (permalink / raw)
To: linux-s390, kernel-janitors
On 20/05/19 09:41, Christian Borntraeger wrote:
> On 06.05.19 09:52, Christian Borntraeger wrote:
>>
>>
>> On 04.05.19 08:51, Wei Yongjun wrote:
>>> Fix typo in parameter description.
>>>
>>> Fixes: 8b905d28ee17 ("KVM: s390: provide kvm_arch_no_poll function")
>>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>>
>> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
>
> Since I have another fix pending, I now picked this up myself and
> this will be in my next pull request for 5.2-rc2.
Ok, I'll wait for it before sending my own pending fixes to Linus.
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread