All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/icl: Fix setting 10 bit deep color mode
@ 2019-04-30  0:00 Aditya Swarup
  2019-04-30  8:43 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 12+ messages in thread
From: Aditya Swarup @ 2019-04-30  0:00 UTC (permalink / raw)
  To: intel-gfx; +Cc: Jani Nikula

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

There is a bug in hdmi_deep_color_possible() - we compare pipe_bpp
<= 8*3 which returns true every time for hdmi_deep_color_possible 12 bit
deep color mode test in intel_hdmi_compute_config().(Even when the
requested color mode is 10 bit through max bpc property)

Comparing pipe_bpp with bpc * 3 takes care of this condition where
requested max bpc is 10 bit, so hdmi_deep_color_possible with 12 bit
returns false when requested max bpc is 10.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: Clinton Taylor <Clinton.A.Taylor@intel.com>
---
 drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index 991eb362ef4f..74f2dcb8b1ad 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -2159,7 +2159,7 @@ static bool hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,
 	if (bpc == 10 && INTEL_GEN(dev_priv) < 11)
 		return false;
 
-	if (crtc_state->pipe_bpp <= 8*3)
+	if (crtc_state->pipe_bpp < bpc * 3)
 		return false;
 
 	if (!crtc_state->has_hdmi_sink)
-- 
2.17.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2019-05-08  4:53 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-30  0:00 [PATCH] drm/i915/icl: Fix setting 10 bit deep color mode Aditya Swarup
2019-04-30  8:43 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-04-30 14:36 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-04-30 15:05 ` [PATCH] " Ville Syrjälä
2019-04-30 21:12   ` Aditya Swarup
2019-05-07 10:12     ` Ville Syrjälä
2019-05-06 18:43 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Fix setting 10 bit deep color mode (rev2) Patchwork
2019-05-06 20:24 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-07 18:18 ` [PATCH v2] drm/i915/icl: Fix setting 10 bit deep color mode Aditya Swarup
2019-05-07 18:53   ` Ville Syrjälä
2019-05-07 19:12 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Fix setting 10 bit deep color mode (rev3) Patchwork
2019-05-08  4:53 ` ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.