[PULL] gvt-next-fixes

[PULL] gvt-next-fixes

[Zhenyu Wang]

[-- Attachment #1.1: Type: text/plain, Size: 2335 bytes --]


Hi,

Here's gvt-next-fixes for 5.2-rc, which includes one revert for BXT
regression, one missed context mmio reg after RCS renaming, sanitize
display buffer size calculation and some klocwork warning/error fixes.

Thanks
--
The following changes since commit 447811a686e8da7325516a78069ccfbd139ef1a7:

  drm/i915/icl: Fix MG_DP_MODE() register programming (2019-04-24 09:39:11 +0300)

are available in the Git repository at:

  https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2019-05-07

for you to fetch changes up to 75fdb811d93c8aa4a9f73b63db032b1e6a8668ef:

  drm/i915/gvt: Add in context mmio 0x20D8 to gen9 mmio list (2019-05-05 17:02:25 +0800)

----------------------------------------------------------------
gvt-next-fixes-2019-05-07

- Revert MCHBAR save range change for BXT regression (Yakui)
- Align display dmabuf size for bytes instead of error-prone pages (Xiong)
- Fix one context MMIO save/restore after RCS0 name change (Colin)
- Misc klocwork warning/errors fixes (Aleksei)

----------------------------------------------------------------
Aleksei Gimbitskii (4):
      drm/i915/gvt: Remove typedef and let the enumeration starts from zero
      drm/i915/gvt: Do not copy the uninitialized pointer from fb_info
      drm/i915/gvt: Use snprintf() to prevent possible buffer overflow.
      drm/i915/gvt: Check if get_next_pt_type() always returns a valid value

Colin Xu (1):
      drm/i915/gvt: Add in context mmio 0x20D8 to gen9 mmio list

Xiong Zhang (1):
      drm/i915/gvt: Change fb_info->size from pages to bytes

Zhao Yakui (1):
      drm/i915/gvt: Revert "drm/i915/gvt: Refine the snapshort range of I915 MCHBAR to optimize gvt-g boot time"

 drivers/gpu/drm/i915/gvt/debugfs.c      |  4 ++--
 drivers/gpu/drm/i915/gvt/dmabuf.c       | 19 ++++++++-----------
 drivers/gpu/drm/i915/gvt/gtt.c          | 15 +++++++++------
 drivers/gpu/drm/i915/gvt/gtt.h          | 16 ++++++++--------
 drivers/gpu/drm/i915/gvt/handlers.c     |  4 ++--
 drivers/gpu/drm/i915/gvt/mmio_context.c |  1 +
 drivers/gpu/drm/i915/gvt/reg.h          |  3 ---
 drivers/gpu/drm/i915/gvt/scheduler.c    |  2 +-
 8 files changed, 31 insertions(+), 33 deletions(-)

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PULL] gvt-next-fixes

[Joonas Lahtinen]

Thanks, pulled this now.

Regards, Joonas

Quoting Zhenyu Wang (2019-05-07 12:05:58)
> 
> Hi,
> 
> Here's gvt-next-fixes for 5.2-rc, which includes one revert for BXT
> regression, one missed context mmio reg after RCS renaming, sanitize
> display buffer size calculation and some klocwork warning/error fixes.
> 
> Thanks
> --
> The following changes since commit 447811a686e8da7325516a78069ccfbd139ef1a7:
> 
>   drm/i915/icl: Fix MG_DP_MODE() register programming (2019-04-24 09:39:11 +0300)
> 
> are available in the Git repository at:
> 
>   https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2019-05-07
> 
> for you to fetch changes up to 75fdb811d93c8aa4a9f73b63db032b1e6a8668ef:
> 
>   drm/i915/gvt: Add in context mmio 0x20D8 to gen9 mmio list (2019-05-05 17:02:25 +0800)
> 
> ----------------------------------------------------------------
> gvt-next-fixes-2019-05-07
> 
> - Revert MCHBAR save range change for BXT regression (Yakui)
> - Align display dmabuf size for bytes instead of error-prone pages (Xiong)
> - Fix one context MMIO save/restore after RCS0 name change (Colin)
> - Misc klocwork warning/errors fixes (Aleksei)
> 
> ----------------------------------------------------------------
> Aleksei Gimbitskii (4):
>       drm/i915/gvt: Remove typedef and let the enumeration starts from zero
>       drm/i915/gvt: Do not copy the uninitialized pointer from fb_info
>       drm/i915/gvt: Use snprintf() to prevent possible buffer overflow.
>       drm/i915/gvt: Check if get_next_pt_type() always returns a valid value
> 
> Colin Xu (1):
>       drm/i915/gvt: Add in context mmio 0x20D8 to gen9 mmio list
> 
> Xiong Zhang (1):
>       drm/i915/gvt: Change fb_info->size from pages to bytes
> 
> Zhao Yakui (1):
>       drm/i915/gvt: Revert "drm/i915/gvt: Refine the snapshort range of I915 MCHBAR to optimize gvt-g boot time"
> 
>  drivers/gpu/drm/i915/gvt/debugfs.c      |  4 ++--
>  drivers/gpu/drm/i915/gvt/dmabuf.c       | 19 ++++++++-----------
>  drivers/gpu/drm/i915/gvt/gtt.c          | 15 +++++++++------
>  drivers/gpu/drm/i915/gvt/gtt.h          | 16 ++++++++--------
>  drivers/gpu/drm/i915/gvt/handlers.c     |  4 ++--
>  drivers/gpu/drm/i915/gvt/mmio_context.c |  1 +
>  drivers/gpu/drm/i915/gvt/reg.h          |  3 ---
>  drivers/gpu/drm/i915/gvt/scheduler.c    |  2 +-
>  8 files changed, 31 insertions(+), 33 deletions(-)
> 
> -- 
> Open Source Technology Center, Intel ltd.
> 
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PULL] gvt-next-fixes

[Zhenyu Wang]

[-- Attachment #1.1: Type: text/plain, Size: 1344 bytes --]


Hi,

More gvt fixes for 5.5-rc. One is MI_ATOMIC cmd parser fix which
missed 5.4 and another two for CFL non-priv reg access fixes.

Thanks
--
The following changes since commit 83faaf074e6d1ca4d1441aded0d3f01bce413479:

  drm/i915/gvt: Stop initializing pvinfo through reading mmio (2019-11-08 11:08:07 +0800)

are available in the Git repository at:

  https://github.com/intel/gvt-linux tags/gvt-next-fixes-2019-12-02

for you to fetch changes up to 92b1aa773fadb4e2a90ed5d3beecb422d568ad9a:

  drm/i915/gvt: Fix cmd length check for MI_ATOMIC (2019-12-02 11:06:49 +0800)

----------------------------------------------------------------
gvt-next-fixes-2019-12-02

- Fix cmd parser for MI_ATOMIC (Zhenyu)
- Fix non-priv register access warning on CFL (Fred)

----------------------------------------------------------------
Gao, Fred (2):
      drm/i915/gvt: Refine non privilege register address calucation
      drm/i915/gvt: Update force-to-nonpriv register whitelist

Zhenyu Wang (1):
      drm/i915/gvt: Fix cmd length check for MI_ATOMIC

 drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 +++---
 drivers/gpu/drm/i915/gvt/handlers.c   | 5 +++--
 2 files changed, 6 insertions(+), 5 deletions(-)


-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PULL] gvt-next-fixes

[Joonas Lahtinen]

Quoting Zhenyu Wang (2019-11-12 08:20:32)
> 
> Hi,
> 
> Here's one fix to remove PVINFO read in initial state for extra
> warning messages in debug.

Pulled now.

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PULL] gvt-next-fixes

[Zhenyu Wang]

[-- Attachment #1.1: Type: text/plain, Size: 1051 bytes --]


Hi,

Here's one fix to remove PVINFO read in initial state for extra
warning messages in debug.

Thanks
--
The following changes since commit d9dace9438945e7c13d91e62927c5c6c88a37ee5:

  drm/i915/selftests: Add intel_gt_suspend_prepare (2019-11-05 16:06:25 +0200)

are available in the Git repository at:

  https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2019-11-12

for you to fetch changes up to 83faaf074e6d1ca4d1441aded0d3f01bce413479:

  drm/i915/gvt: Stop initializing pvinfo through reading mmio (2019-11-08 11:08:07 +0800)

----------------------------------------------------------------
gvt-next-fixes-2019-11-12

- Remove PVINFO read for initial state (Tina)

----------------------------------------------------------------
Tina Zhang (1):
      drm/i915/gvt: Stop initializing pvinfo through reading mmio

 drivers/gpu/drm/i915/gvt/handlers.c | 4 ++++
 1 file changed, 4 insertions(+)


-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PULL] gvt-next-fixes

[Vetter, Daniel]

On Mon, 2019-09-09 at 15:35 -0700, Rodrigo Vivi wrote:
> On Mon, Sep 09, 2019 at 02:54:59PM -0700, Vetter, Daniel wrote:
> > On Mon, 2019-09-09 at 10:24 -0700, Rodrigo Vivi wrote:
> > > Hi guys,
> > > 
> > > On Fri, Sep 06, 2019 at 01:42:55PM +0800, Zhenyu Wang wrote:
> > > > Hi,
> > > > 
> > > > Here's gvt-next-fixes with two recent fixes, one for recent
> > > > guest hang regression and another for guest reset fix.
> > > > 
> > > > Thanks.
> > > > --
> > > > The following changes since commit
> > > > c36beba6b296b3c05a0f29753b04775e5ae23886:
> > > > 
> > > >   drm/i915: Seal races between async GPU cancellation,
> > > > retirement
> > > > and signaling (2019-05-13 13:53:35 +0300)
> > > > 
> > > > are available in the Git repository at:
> > > > 
> > > >   https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-
> > > > 2019-
> > > > 09-06
> > > > 
> > > > for you to fetch changes up to
> > > > 4a5322560aa235efa84c0aa34c00e5749a0792fd:
> > > > 
> > > >   drm/i915/gvt: update RING_START reg of vGPU when the context
> > > > is
> > > > submitted to i915 (2019-09-06 13:39:09 +0800)
> > > 
> > > $ dim pull-request-next-fixes
> > > Using drm/drm-next as the upstream
> > > dim: 4a5322560aa2 ("drm/i915/gvt: update RING_START reg of vGPU
> > > when
> > > the context is submitted to i915"): Link tag missing.
> > > dim: 0a3242bdb477 ("drm/i915/gvt: update vgpu workload head
> > > pointer
> > > correctly"): Link tag missing.
> > > dim: ERROR: issues in commits detected, aborting
> > > 
> > > I wonder how I should proceed here. In the past I was always
> > > bypasssing dim,
> > > but now that drm maintainers also use dim I'm sure this will blow
> > > up
> > > there anyways.
> > > 
> > > But gvt patches are not tracked on our CI individually hence they
> > > don't
> > > have Links.
> > > 
> > > Jani, Joonas, how are you guys handling this?
> > > 
> > > Daniel, Dave, ideas?
> > 
> > dim doesn't require Link: tags yet for pull requests (because most
> > drm
> > trees aren't managed by dim and so lack them).
> 
> I'm confused now.
> 
> function dim_pull_request
> calls
> checkpatch_commit_push_range 1 "$upstream..$branch"
> (except for drm-intel-next)
> 
> and checkpatch_commit_push checks for the link.
> 
> So if you also use dim for your pull request I'm wondering how you
> are not getting that....

On the push side we set dim_managed_branch (or whatever it's called) to
1, on the pull side it's side 0. That disables certain checks like the
Link: tag check. Also push should only check commits authored by you,
so this is only really an issue with cherry-picks.

That was at least the idea behind all this, maybe it stopped working.
-Daniel

> 
> In the past whenever I had this problem on dinf I commented out the
> link check but end up never coming back to solve the problem
> properly.
> I just wondering that now that dim is in use on drm level if I bypass
> here it becomes a problem for you.
> 
> thoughts?
> 
> > Until we change that,
> > with some doc patches and proper bikeshed on dri-devel I think it's
> > fine if gvt is missing them. At least from a drm.git pov.
> > 
> > What you guys want to do for drm-intel.git is entirely up to you.
> > -Daniel
> > > Thanks,
> > > Rodrigo.
> > > 
> > > > -------------------------------------------------------------
> > > > ---
> > > > gvt-next-fixes-2019-09-06
> > > > 
> > > > - Fix guest context head pointer update for hang (Xiaolin)
> > > > - Fix guest context ring state for reset (Weinan)
> > > > 
> > > > -------------------------------------------------------------
> > > > ---
> > > > Weinan Li (1):
> > > >       drm/i915/gvt: update RING_START reg of vGPU when the
> > > > context
> > > > is submitted to i915
> > > > 
> > > > Xiaolin Zhang (1):
> > > >       drm/i915/gvt: update vgpu workload head pointer correctly
> > > > 
> > > >  drivers/gpu/drm/i915/gvt/scheduler.c | 45
> > > > +++++++++++++++++++++++++-----------
> > > >  1 file changed, 32 insertions(+), 13 deletions(-)
> > > > 
> > > > 
> > > > -- 
> > > > Open Source Technology Center, Intel ltd.
> > > > 
> > > > $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
Intel Semiconductor AG
Registered No. 020.30.913.786-7
Registered Office: Badenerstrasse 549, 8048 Zurich, Switzerland
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PULL] gvt-next-fixes

[Zhenyu Wang]

[-- Attachment #1.1: Type: text/plain, Size: 4295 bytes --]

On 2019.09.09 15:35:10 -0700, Rodrigo Vivi wrote:
> On Mon, Sep 09, 2019 at 02:54:59PM -0700, Vetter, Daniel wrote:
> > On Mon, 2019-09-09 at 10:24 -0700, Rodrigo Vivi wrote:
> > > Hi guys,
> > > 
> > > On Fri, Sep 06, 2019 at 01:42:55PM +0800, Zhenyu Wang wrote:
> > > > Hi,
> > > > 
> > > > Here's gvt-next-fixes with two recent fixes, one for recent
> > > > guest hang regression and another for guest reset fix.
> > > > 
> > > > Thanks.
> > > > --
> > > > The following changes since commit
> > > > c36beba6b296b3c05a0f29753b04775e5ae23886:
> > > > 
> > > >   drm/i915: Seal races between async GPU cancellation, retirement
> > > > and signaling (2019-05-13 13:53:35 +0300)
> > > > 
> > > > are available in the Git repository at:
> > > > 
> > > >   https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2019-
> > > > 09-06
> > > > 
> > > > for you to fetch changes up to
> > > > 4a5322560aa235efa84c0aa34c00e5749a0792fd:
> > > > 
> > > >   drm/i915/gvt: update RING_START reg of vGPU when the context is
> > > > submitted to i915 (2019-09-06 13:39:09 +0800)
> > > 
> > > $ dim pull-request-next-fixes
> > > Using drm/drm-next as the upstream
> > > dim: 4a5322560aa2 ("drm/i915/gvt: update RING_START reg of vGPU when
> > > the context is submitted to i915"): Link tag missing.
> > > dim: 0a3242bdb477 ("drm/i915/gvt: update vgpu workload head pointer
> > > correctly"): Link tag missing.
> > > dim: ERROR: issues in commits detected, aborting
> > > 
> > > I wonder how I should proceed here. In the past I was always
> > > bypasssing dim,
> > > but now that drm maintainers also use dim I'm sure this will blow up
> > > there anyways.
> > > 
> > > But gvt patches are not tracked on our CI individually hence they
> > > don't
> > > have Links.
> > > 
> > > Jani, Joonas, how are you guys handling this?
> > > 
> > > Daniel, Dave, ideas?
> > 
> > dim doesn't require Link: tags yet for pull requests (because most drm
> > trees aren't managed by dim and so lack them).
> 
> I'm confused now.
> 
> function dim_pull_request
> calls
> checkpatch_commit_push_range 1 "$upstream..$branch"
> (except for drm-intel-next)
> 
> and checkpatch_commit_push checks for the link.
> 
> So if you also use dim for your pull request I'm wondering how you
> are not getting that....
> 
> In the past whenever I had this problem on dinf I commented out the
> link check but end up never coming back to solve the problem properly.
> I just wondering that now that dim is in use on drm level if I bypass
> here it becomes a problem for you.
> 
> thoughts?

Although gvt is not fully in CI yet, we do have patchwork that I can
add Link: tag, that should be easy for you. Sorry that I wasn't awared
it's required for dim.

> 
> > Until we change that,
> > with some doc patches and proper bikeshed on dri-devel I think it's
> > fine if gvt is missing them. At least from a drm.git pov.
> > 
> > What you guys want to do for drm-intel.git is entirely up to you.
> > -Daniel
> > > 
> > > Thanks,
> > > Rodrigo.
> > > 
> > > > ----------------------------------------------------------------
> > > > gvt-next-fixes-2019-09-06
> > > > 
> > > > - Fix guest context head pointer update for hang (Xiaolin)
> > > > - Fix guest context ring state for reset (Weinan)
> > > > 
> > > > ----------------------------------------------------------------
> > > > Weinan Li (1):
> > > >       drm/i915/gvt: update RING_START reg of vGPU when the context
> > > > is submitted to i915
> > > > 
> > > > Xiaolin Zhang (1):
> > > >       drm/i915/gvt: update vgpu workload head pointer correctly
> > > > 
> > > >  drivers/gpu/drm/i915/gvt/scheduler.c | 45
> > > > +++++++++++++++++++++++++-----------
> > > >  1 file changed, 32 insertions(+), 13 deletions(-)
> > > > 
> > > > 
> > > > -- 
> > > > Open Source Technology Center, Intel ltd.
> > > > 
> > > > $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
> > > 
> > > 
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PULL] gvt-next-fixes

[Rodrigo Vivi]

On Mon, Sep 09, 2019 at 02:54:59PM -0700, Vetter, Daniel wrote:
> On Mon, 2019-09-09 at 10:24 -0700, Rodrigo Vivi wrote:
> > Hi guys,
> > 
> > On Fri, Sep 06, 2019 at 01:42:55PM +0800, Zhenyu Wang wrote:
> > > Hi,
> > > 
> > > Here's gvt-next-fixes with two recent fixes, one for recent
> > > guest hang regression and another for guest reset fix.
> > > 
> > > Thanks.
> > > --
> > > The following changes since commit
> > > c36beba6b296b3c05a0f29753b04775e5ae23886:
> > > 
> > >   drm/i915: Seal races between async GPU cancellation, retirement
> > > and signaling (2019-05-13 13:53:35 +0300)
> > > 
> > > are available in the Git repository at:
> > > 
> > >   https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2019-
> > > 09-06
> > > 
> > > for you to fetch changes up to
> > > 4a5322560aa235efa84c0aa34c00e5749a0792fd:
> > > 
> > >   drm/i915/gvt: update RING_START reg of vGPU when the context is
> > > submitted to i915 (2019-09-06 13:39:09 +0800)
> > 
> > $ dim pull-request-next-fixes
> > Using drm/drm-next as the upstream
> > dim: 4a5322560aa2 ("drm/i915/gvt: update RING_START reg of vGPU when
> > the context is submitted to i915"): Link tag missing.
> > dim: 0a3242bdb477 ("drm/i915/gvt: update vgpu workload head pointer
> > correctly"): Link tag missing.
> > dim: ERROR: issues in commits detected, aborting
> > 
> > I wonder how I should proceed here. In the past I was always
> > bypasssing dim,
> > but now that drm maintainers also use dim I'm sure this will blow up
> > there anyways.
> > 
> > But gvt patches are not tracked on our CI individually hence they
> > don't
> > have Links.
> > 
> > Jani, Joonas, how are you guys handling this?
> > 
> > Daniel, Dave, ideas?
> 
> dim doesn't require Link: tags yet for pull requests (because most drm
> trees aren't managed by dim and so lack them).

I'm confused now.

function dim_pull_request
calls
checkpatch_commit_push_range 1 "$upstream..$branch"
(except for drm-intel-next)

and checkpatch_commit_push checks for the link.

So if you also use dim for your pull request I'm wondering how you
are not getting that....

In the past whenever I had this problem on dinf I commented out the
link check but end up never coming back to solve the problem properly.
I just wondering that now that dim is in use on drm level if I bypass
here it becomes a problem for you.

thoughts?

> Until we change that,
> with some doc patches and proper bikeshed on dri-devel I think it's
> fine if gvt is missing them. At least from a drm.git pov.
> 
> What you guys want to do for drm-intel.git is entirely up to you.
> -Daniel
> > 
> > Thanks,
> > Rodrigo.
> > 
> > > ----------------------------------------------------------------
> > > gvt-next-fixes-2019-09-06
> > > 
> > > - Fix guest context head pointer update for hang (Xiaolin)
> > > - Fix guest context ring state for reset (Weinan)
> > > 
> > > ----------------------------------------------------------------
> > > Weinan Li (1):
> > >       drm/i915/gvt: update RING_START reg of vGPU when the context
> > > is submitted to i915
> > > 
> > > Xiaolin Zhang (1):
> > >       drm/i915/gvt: update vgpu workload head pointer correctly
> > > 
> > >  drivers/gpu/drm/i915/gvt/scheduler.c | 45
> > > +++++++++++++++++++++++++-----------
> > >  1 file changed, 32 insertions(+), 13 deletions(-)
> > > 
> > > 
> > > -- 
> > > Open Source Technology Center, Intel ltd.
> > > 
> > > $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
> > 
> > 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PULL] gvt-next-fixes

[Vetter, Daniel]

On Mon, 2019-09-09 at 10:24 -0700, Rodrigo Vivi wrote:
> Hi guys,
> 
> On Fri, Sep 06, 2019 at 01:42:55PM +0800, Zhenyu Wang wrote:
> > Hi,
> > 
> > Here's gvt-next-fixes with two recent fixes, one for recent
> > guest hang regression and another for guest reset fix.
> > 
> > Thanks.
> > --
> > The following changes since commit
> > c36beba6b296b3c05a0f29753b04775e5ae23886:
> > 
> >   drm/i915: Seal races between async GPU cancellation, retirement
> > and signaling (2019-05-13 13:53:35 +0300)
> > 
> > are available in the Git repository at:
> > 
> >   https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2019-
> > 09-06
> > 
> > for you to fetch changes up to
> > 4a5322560aa235efa84c0aa34c00e5749a0792fd:
> > 
> >   drm/i915/gvt: update RING_START reg of vGPU when the context is
> > submitted to i915 (2019-09-06 13:39:09 +0800)
> 
> $ dim pull-request-next-fixes
> Using drm/drm-next as the upstream
> dim: 4a5322560aa2 ("drm/i915/gvt: update RING_START reg of vGPU when
> the context is submitted to i915"): Link tag missing.
> dim: 0a3242bdb477 ("drm/i915/gvt: update vgpu workload head pointer
> correctly"): Link tag missing.
> dim: ERROR: issues in commits detected, aborting
> 
> I wonder how I should proceed here. In the past I was always
> bypasssing dim,
> but now that drm maintainers also use dim I'm sure this will blow up
> there anyways.
> 
> But gvt patches are not tracked on our CI individually hence they
> don't
> have Links.
> 
> Jani, Joonas, how are you guys handling this?
> 
> Daniel, Dave, ideas?

dim doesn't require Link: tags yet for pull requests (because most drm
trees aren't managed by dim and so lack them). Until we change that,
with some doc patches and proper bikeshed on dri-devel I think it's
fine if gvt is missing them. At least from a drm.git pov.

What you guys want to do for drm-intel.git is entirely up to you.
-Daniel
> 
> Thanks,
> Rodrigo.
> 
> > ----------------------------------------------------------------
> > gvt-next-fixes-2019-09-06
> > 
> > - Fix guest context head pointer update for hang (Xiaolin)
> > - Fix guest context ring state for reset (Weinan)
> > 
> > ----------------------------------------------------------------
> > Weinan Li (1):
> >       drm/i915/gvt: update RING_START reg of vGPU when the context
> > is submitted to i915
> > 
> > Xiaolin Zhang (1):
> >       drm/i915/gvt: update vgpu workload head pointer correctly
> > 
> >  drivers/gpu/drm/i915/gvt/scheduler.c | 45
> > +++++++++++++++++++++++++-----------
> >  1 file changed, 32 insertions(+), 13 deletions(-)
> > 
> > 
> > -- 
> > Open Source Technology Center, Intel ltd.
> > 
> > $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
> 
> 
Intel Semiconductor AG
Registered No. 020.30.913.786-7
Registered Office: Badenerstrasse 549, 8048 Zurich, Switzerland
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PULL] gvt-next-fixes

[Rodrigo Vivi]

Hi guys,

On Fri, Sep 06, 2019 at 01:42:55PM +0800, Zhenyu Wang wrote:
> 
> Hi,
> 
> Here's gvt-next-fixes with two recent fixes, one for recent
> guest hang regression and another for guest reset fix.
> 
> Thanks.
> --
> The following changes since commit c36beba6b296b3c05a0f29753b04775e5ae23886:
> 
>   drm/i915: Seal races between async GPU cancellation, retirement and signaling (2019-05-13 13:53:35 +0300)
> 
> are available in the Git repository at:
> 
>   https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2019-09-06
> 
> for you to fetch changes up to 4a5322560aa235efa84c0aa34c00e5749a0792fd:
> 
>   drm/i915/gvt: update RING_START reg of vGPU when the context is submitted to i915 (2019-09-06 13:39:09 +0800)


$ dim pull-request-next-fixes
Using drm/drm-next as the upstream
dim: 4a5322560aa2 ("drm/i915/gvt: update RING_START reg of vGPU when the context is submitted to i915"): Link tag missing.
dim: 0a3242bdb477 ("drm/i915/gvt: update vgpu workload head pointer correctly"): Link tag missing.
dim: ERROR: issues in commits detected, aborting

I wonder how I should proceed here. In the past I was always bypasssing dim,
but now that drm maintainers also use dim I'm sure this will blow up
there anyways.

But gvt patches are not tracked on our CI individually hence they don't
have Links.

Jani, Joonas, how are you guys handling this?

Daniel, Dave, ideas?

Thanks,
Rodrigo.

> 
> ----------------------------------------------------------------
> gvt-next-fixes-2019-09-06
> 
> - Fix guest context head pointer update for hang (Xiaolin)
> - Fix guest context ring state for reset (Weinan)
> 
> ----------------------------------------------------------------
> Weinan Li (1):
>       drm/i915/gvt: update RING_START reg of vGPU when the context is submitted to i915
> 
> Xiaolin Zhang (1):
>       drm/i915/gvt: update vgpu workload head pointer correctly
> 
>  drivers/gpu/drm/i915/gvt/scheduler.c | 45 +++++++++++++++++++++++++-----------
>  1 file changed, 32 insertions(+), 13 deletions(-)
> 
> 
> -- 
> Open Source Technology Center, Intel ltd.
> 
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PULL] gvt-next-fixes

[Rodrigo Vivi]

On Fri, Sep 06, 2019 at 01:42:55PM +0800, Zhenyu Wang wrote:
> 
> Hi,
> 
> Here's gvt-next-fixes with two recent fixes, one for recent
> guest hang regression and another for guest reset fix.
> 
> Thanks.
> --
> The following changes since commit c36beba6b296b3c05a0f29753b04775e5ae23886:
> 
>   drm/i915: Seal races between async GPU cancellation, retirement and signaling (2019-05-13 13:53:35 +0300)
> 
> are available in the Git repository at:
> 
>   https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2019-09-06

pulled, thanks

> 
> for you to fetch changes up to 4a5322560aa235efa84c0aa34c00e5749a0792fd:
> 
>   drm/i915/gvt: update RING_START reg of vGPU when the context is submitted to i915 (2019-09-06 13:39:09 +0800)
> 
> ----------------------------------------------------------------
> gvt-next-fixes-2019-09-06
> 
> - Fix guest context head pointer update for hang (Xiaolin)
> - Fix guest context ring state for reset (Weinan)
> 
> ----------------------------------------------------------------
> Weinan Li (1):
>       drm/i915/gvt: update RING_START reg of vGPU when the context is submitted to i915
> 
> Xiaolin Zhang (1):
>       drm/i915/gvt: update vgpu workload head pointer correctly
> 
>  drivers/gpu/drm/i915/gvt/scheduler.c | 45 +++++++++++++++++++++++++-----------
>  1 file changed, 32 insertions(+), 13 deletions(-)
> 
> 
> -- 
> Open Source Technology Center, Intel ltd.
> 
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PULL] gvt-next-fixes

[Zhenyu Wang]

[-- Attachment #1.1: Type: text/plain, Size: 1351 bytes --]


Hi,

Here's gvt-next-fixes with two recent fixes, one for recent
guest hang regression and another for guest reset fix.

Thanks.
--
The following changes since commit c36beba6b296b3c05a0f29753b04775e5ae23886:

  drm/i915: Seal races between async GPU cancellation, retirement and signaling (2019-05-13 13:53:35 +0300)

are available in the Git repository at:

  https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2019-09-06

for you to fetch changes up to 4a5322560aa235efa84c0aa34c00e5749a0792fd:

  drm/i915/gvt: update RING_START reg of vGPU when the context is submitted to i915 (2019-09-06 13:39:09 +0800)

----------------------------------------------------------------
gvt-next-fixes-2019-09-06

- Fix guest context head pointer update for hang (Xiaolin)
- Fix guest context ring state for reset (Weinan)

----------------------------------------------------------------
Weinan Li (1):
      drm/i915/gvt: update RING_START reg of vGPU when the context is submitted to i915

Xiaolin Zhang (1):
      drm/i915/gvt: update vgpu workload head pointer correctly

 drivers/gpu/drm/i915/gvt/scheduler.c | 45 +++++++++++++++++++++++++-----------
 1 file changed, 32 insertions(+), 13 deletions(-)


-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PULL] gvt-next-fixes

[Rodrigo Vivi]

On Tue, Aug 14, 2018 at 03:31:40PM +0800, Zhenyu Wang wrote:
> 
> Hi,
> 
> This is initial gvt fixes for 4.19 with some accumulated fixes,
> pls check details below.

pulled, thanks.

> 
> Thanks
> --
> The following changes since commit 3237c0dbe21f8d2ca2feaa3891aff3619873cd30:
> 
>   drm/i915/kvmgt: Fix compilation error (2018-08-06 11:28:35 -0700)
> 
> are available in the Git repository at:
> 
>   https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2018-08-14
> 
> for you to fetch changes up to 7590ebb8b456464e48840a6d106a0c07de6d723a:
> 
>   drm/i915/gvt: fix memory leak in intel_vgpu_ioctl() (2018-08-14 15:27:12 +0800)
> 
> ----------------------------------------------------------------
> gvt-next-fixes-2018-08-14
> 
> - Fix an error code in gvt_dma_map_page() (Dan)
> - Fix off by one error in intel_vgpu_write_fence() (Dan)
> - Fix potential Spectre v1 (Gustavo)
> - Fix workload free in vgpu release (Henry)
> - Fix cleanup sequence in intel_gvt_clean_device (Henry)
> - dmabuf mutex init place fix (Henry)
> - possible memory leak in intel_vgpu_ioctl() err path (Yi)
> - return error on cmd access check failure (Yan)
> 
> ----------------------------------------------------------------
> Dan Carpenter (2):
>       drm/i915/kvmgt: fix an error code in gvt_dma_map_page()
>       drm/i915/gvt: Off by one in intel_vgpu_write_fence()
> 
> Gustavo A. R. Silva (1):
>       drm/i915/kvmgt: Fix potential Spectre v1
> 
> Hang Yuan (3):
>       drm/i915/gvt: free workload in vgpu release
>       drm/i915/gvt: fix cleanup sequence in intel_gvt_clean_device
>       drm/i915/gvt: initialize dmabuf mutex in vgpu_create
> 
> Yi Wang (1):
>       drm/i915/gvt: fix memory leak in intel_vgpu_ioctl()
> 
> Zhao Yan (1):
>       drm/i915/gvt: return error on cmd access
> 
>  drivers/gpu/drm/i915/gvt/aperture_gm.c |  2 +-
>  drivers/gpu/drm/i915/gvt/cmd_parser.c  |  2 +-
>  drivers/gpu/drm/i915/gvt/gvt.c         | 15 +++++++--------
>  drivers/gpu/drm/i915/gvt/gvt.h         |  4 +++-
>  drivers/gpu/drm/i915/gvt/kvmgt.c       | 26 ++++++++++++++++++--------
>  drivers/gpu/drm/i915/gvt/scheduler.c   |  7 ++++---
>  drivers/gpu/drm/i915/gvt/scheduler.h   |  3 +++
>  drivers/gpu/drm/i915/gvt/vgpu.c        | 23 +++++++++++++++++++++--
>  8 files changed, 58 insertions(+), 24 deletions(-)
> 
> -- 
> Open Source Technology Center, Intel ltd.
> 
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PULL] gvt-next-fixes

[Zhenyu Wang]

[-- Attachment #1.1: Type: text/plain, Size: 2280 bytes --]


Hi,

This is initial gvt fixes for 4.19 with some accumulated fixes,
pls check details below.

Thanks
--
The following changes since commit 3237c0dbe21f8d2ca2feaa3891aff3619873cd30:

  drm/i915/kvmgt: Fix compilation error (2018-08-06 11:28:35 -0700)

are available in the Git repository at:

  https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2018-08-14

for you to fetch changes up to 7590ebb8b456464e48840a6d106a0c07de6d723a:

  drm/i915/gvt: fix memory leak in intel_vgpu_ioctl() (2018-08-14 15:27:12 +0800)

----------------------------------------------------------------
gvt-next-fixes-2018-08-14

- Fix an error code in gvt_dma_map_page() (Dan)
- Fix off by one error in intel_vgpu_write_fence() (Dan)
- Fix potential Spectre v1 (Gustavo)
- Fix workload free in vgpu release (Henry)
- Fix cleanup sequence in intel_gvt_clean_device (Henry)
- dmabuf mutex init place fix (Henry)
- possible memory leak in intel_vgpu_ioctl() err path (Yi)
- return error on cmd access check failure (Yan)

----------------------------------------------------------------
Dan Carpenter (2):
      drm/i915/kvmgt: fix an error code in gvt_dma_map_page()
      drm/i915/gvt: Off by one in intel_vgpu_write_fence()

Gustavo A. R. Silva (1):
      drm/i915/kvmgt: Fix potential Spectre v1

Hang Yuan (3):
      drm/i915/gvt: free workload in vgpu release
      drm/i915/gvt: fix cleanup sequence in intel_gvt_clean_device
      drm/i915/gvt: initialize dmabuf mutex in vgpu_create

Yi Wang (1):
      drm/i915/gvt: fix memory leak in intel_vgpu_ioctl()

Zhao Yan (1):
      drm/i915/gvt: return error on cmd access

 drivers/gpu/drm/i915/gvt/aperture_gm.c |  2 +-
 drivers/gpu/drm/i915/gvt/cmd_parser.c  |  2 +-
 drivers/gpu/drm/i915/gvt/gvt.c         | 15 +++++++--------
 drivers/gpu/drm/i915/gvt/gvt.h         |  4 +++-
 drivers/gpu/drm/i915/gvt/kvmgt.c       | 26 ++++++++++++++++++--------
 drivers/gpu/drm/i915/gvt/scheduler.c   |  7 ++++---
 drivers/gpu/drm/i915/gvt/scheduler.h   |  3 +++
 drivers/gpu/drm/i915/gvt/vgpu.c        | 23 +++++++++++++++++++++--
 8 files changed, 58 insertions(+), 24 deletions(-)

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx