* [PATCH] systemd: enable portabled by default and install utilities in systemd-container
@ 2019-05-09 21:40 luca.boccassi
2019-05-10 5:23 ` Martin Hundebøll
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: luca.boccassi @ 2019-05-09 21:40 UTC (permalink / raw)
To: openembedded-core
From: Luca Boccassi <luca.boccassi@microsoft.com>
portable services have been declared production ready with v241, so enable
by default and install the files in the container package.
Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
meta/recipes-core/systemd/systemd_242.bb | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/meta/recipes-core/systemd/systemd_242.bb b/meta/recipes-core/systemd/systemd_242.bb
index 73e03c7a77..83b00ba785 100644
--- a/meta/recipes-core/systemd/systemd_242.bb
+++ b/meta/recipes-core/systemd/systemd_242.bb
@@ -81,6 +81,7 @@ PACKAGECONFIG ??= " \
nss \
nss-mymachines \
nss-resolve \
+ portabled \
quotacheck \
randomseed \
resolved \
@@ -403,8 +404,10 @@ SYSTEMD_SERVICE_${PN}-remote = "systemd-journal-remote.socket"
FILES_${PN}-container = "${sysconfdir}/dbus-1/system.d/org.freedesktop.import1.conf \
${sysconfdir}/dbus-1/system.d/org.freedesktop.machine1.conf \
+ ${sysconfdir}/dbus-1/system.d/org.freedesktop.portable1.conf \
${sysconfdir}/systemd/system/multi-user.target.wants/machines.target \
${base_bindir}/machinectl \
+ ${base_bindir}/portablectl \
${bindir}/systemd-nspawn \
${nonarch_libdir}/systemd/import-pubring.gpg \
${systemd_system_unitdir}/busnames.target.wants/org.freedesktop.import1.busname \
@@ -418,21 +421,28 @@ FILES_${PN}-container = "${sysconfdir}/dbus-1/system.d/org.freedesktop.import1.c
${systemd_system_unitdir}/org.freedesktop.machine1.busname \
${systemd_system_unitdir}/systemd-importd.service \
${systemd_system_unitdir}/systemd-machined.service \
+ ${systemd_system_unitdir}/systemd-portabled.service \
${systemd_system_unitdir}/dbus-org.freedesktop.machine1.service \
+ ${systemd_system_unitdir}/dbus-org.freedesktop.portable1.service \
${systemd_system_unitdir}/var-lib-machines.mount \
${rootlibexecdir}/systemd/systemd-import \
${rootlibexecdir}/systemd/systemd-importd \
${rootlibexecdir}/systemd/systemd-machined \
+ ${rootlibexecdir}/systemd/systemd-portabled \
${rootlibexecdir}/systemd/systemd-pull \
+ ${exec_prefix}/lib/tmpfiles.d/portables.conf \
${exec_prefix}/lib/tmpfiles.d/systemd-nspawn.conf \
${systemd_system_unitdir}/systemd-nspawn@.service \
${libdir}/libnss_mymachines.so.2 \
${datadir}/dbus-1/system-services/org.freedesktop.import1.service \
${datadir}/dbus-1/system-services/org.freedesktop.machine1.service \
+ ${datadir}/dbus-1/system-services/org.freedesktop.portable1.service \
${datadir}/dbus-1/system.d/org.freedesktop.import1.conf \
${datadir}/dbus-1/system.d/org.freedesktop.machine1.conf \
+ ${datadir}/dbus-1/system.d/org.freedesktop.portable1.conf \
${datadir}/polkit-1/actions/org.freedesktop.import1.policy \
${datadir}/polkit-1/actions/org.freedesktop.machine1.policy \
+ ${datadir}/polkit-1/actions/org.freedesktop.portable1.policy \
"
RRECOMMENDS_${PN}-container += "\
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] systemd: enable portabled by default and install utilities in systemd-container
2019-05-09 21:40 [PATCH] systemd: enable portabled by default and install utilities in systemd-container luca.boccassi
@ 2019-05-10 5:23 ` Martin Hundebøll
2019-05-10 10:45 ` Luca Boccassi
2019-05-10 12:09 ` [PATCH v2] systemd: enable portabled by default luca.boccassi
2019-05-21 12:34 ` [PATCH v3] python*-setuptools: add separate packages for pkg_resources module luca.boccassi
2 siblings, 1 reply; 11+ messages in thread
From: Martin Hundebøll @ 2019-05-10 5:23 UTC (permalink / raw)
To: luca.boccassi, openembedded-core
Hi Luca,
On 09/05/2019 23.40, luca.boccassi@gmail.com wrote:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> portable services have been declared production ready with v241, so enable
> by default and install the files in the container package.
The systemd portables feature is not really related to containers/VM's,
so I think it should stay in the primary package; or alternatively in a
separate package.
// Martin
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> meta/recipes-core/systemd/systemd_242.bb | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/meta/recipes-core/systemd/systemd_242.bb b/meta/recipes-core/systemd/systemd_242.bb
> index 73e03c7a77..83b00ba785 100644
> --- a/meta/recipes-core/systemd/systemd_242.bb
> +++ b/meta/recipes-core/systemd/systemd_242.bb
> @@ -81,6 +81,7 @@ PACKAGECONFIG ??= " \
> nss \
> nss-mymachines \
> nss-resolve \
> + portabled \
> quotacheck \
> randomseed \
> resolved \
> @@ -403,8 +404,10 @@ SYSTEMD_SERVICE_${PN}-remote = "systemd-journal-remote.socket"
>
> FILES_${PN}-container = "${sysconfdir}/dbus-1/system.d/org.freedesktop.import1.conf \
> ${sysconfdir}/dbus-1/system.d/org.freedesktop.machine1.conf \
> + ${sysconfdir}/dbus-1/system.d/org.freedesktop.portable1.conf \
> ${sysconfdir}/systemd/system/multi-user.target.wants/machines.target \
> ${base_bindir}/machinectl \
> + ${base_bindir}/portablectl \
> ${bindir}/systemd-nspawn \
> ${nonarch_libdir}/systemd/import-pubring.gpg \
> ${systemd_system_unitdir}/busnames.target.wants/org.freedesktop.import1.busname \
> @@ -418,21 +421,28 @@ FILES_${PN}-container = "${sysconfdir}/dbus-1/system.d/org.freedesktop.import1.c
> ${systemd_system_unitdir}/org.freedesktop.machine1.busname \
> ${systemd_system_unitdir}/systemd-importd.service \
> ${systemd_system_unitdir}/systemd-machined.service \
> + ${systemd_system_unitdir}/systemd-portabled.service \
> ${systemd_system_unitdir}/dbus-org.freedesktop.machine1.service \
> + ${systemd_system_unitdir}/dbus-org.freedesktop.portable1.service \
> ${systemd_system_unitdir}/var-lib-machines.mount \
> ${rootlibexecdir}/systemd/systemd-import \
> ${rootlibexecdir}/systemd/systemd-importd \
> ${rootlibexecdir}/systemd/systemd-machined \
> + ${rootlibexecdir}/systemd/systemd-portabled \
> ${rootlibexecdir}/systemd/systemd-pull \
> + ${exec_prefix}/lib/tmpfiles.d/portables.conf \
> ${exec_prefix}/lib/tmpfiles.d/systemd-nspawn.conf \
> ${systemd_system_unitdir}/systemd-nspawn@.service \
> ${libdir}/libnss_mymachines.so.2 \
> ${datadir}/dbus-1/system-services/org.freedesktop.import1.service \
> ${datadir}/dbus-1/system-services/org.freedesktop.machine1.service \
> + ${datadir}/dbus-1/system-services/org.freedesktop.portable1.service \
> ${datadir}/dbus-1/system.d/org.freedesktop.import1.conf \
> ${datadir}/dbus-1/system.d/org.freedesktop.machine1.conf \
> + ${datadir}/dbus-1/system.d/org.freedesktop.portable1.conf \
> ${datadir}/polkit-1/actions/org.freedesktop.import1.policy \
> ${datadir}/polkit-1/actions/org.freedesktop.machine1.policy \
> + ${datadir}/polkit-1/actions/org.freedesktop.portable1.policy \
> "
>
> RRECOMMENDS_${PN}-container += "\
>
--
Kind regards,
Martin Hundebøll
Embedded Linux Consultant
+45 61 65 54 61
martin@geanix.com
Geanix ApS
https://geanix.com
DK39600706
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] systemd: enable portabled by default and install utilities in systemd-container
2019-05-10 5:23 ` Martin Hundebøll
@ 2019-05-10 10:45 ` Luca Boccassi
2019-05-10 10:46 ` Martin Hundebøll
0 siblings, 1 reply; 11+ messages in thread
From: Luca Boccassi @ 2019-05-10 10:45 UTC (permalink / raw)
To: Martin Hundebøll, openembedded-core
On Fri, 2019-05-10 at 07:23 +0200, Martin Hundebøll wrote:
> Hi Luca,
>
> On 09/05/2019 23.40,
> luca.boccassi@gmail.com
> wrote:
> > From: Luca Boccassi <
> > luca.boccassi@microsoft.com
> > >
> >
> > portable services have been declared production ready with v241, so
> > enable
> > by default and install the files in the container package.
>
> The systemd portables feature is not really related to
> containers/VM's,
> so I think it should stay in the primary package; or alternatively in
> a
> separate package.
>
> // Martin
Hello Martin,
IMHO if VM tools and containers tool can go together in this package,
then portable services utilities can too - they are at different
positions on the same scale after all :-)
But I've got no strong opinion, so I'll send a v2 with them moved to
the main package.
> > Signed-off-by: Luca Boccassi <
> > luca.boccassi@microsoft.com
> > >
> > ---
> > meta/recipes-core/systemd/systemd_242.bb | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/meta/recipes-core/systemd/systemd_242.bb
> > b/meta/recipes-core/systemd/systemd_242.bb
> > index 73e03c7a77..83b00ba785 100644
> > --- a/meta/recipes-core/systemd/systemd_242.bb
> > +++ b/meta/recipes-core/systemd/systemd_242.bb
> > @@ -81,6 +81,7 @@ PACKAGECONFIG ??= " \
> > nss \
> > nss-mymachines \
> > nss-resolve \
> > + portabled \
> > quotacheck \
> > randomseed \
> > resolved \
> > @@ -403,8 +404,10 @@ SYSTEMD_SERVICE_${PN}-remote = "systemd-
> > journal-remote.socket"
> >
> > FILES_${PN}-container = "${sysconfdir}/dbus-
> > 1/system.d/org.freedesktop.import1.conf \
> > ${sysconfdir}/dbus-
> > 1/system.d/org.freedesktop.machine1.conf \
> > + ${sysconfdir}/dbus-
> > 1/system.d/org.freedesktop.portable1.conf \
> > ${sysconfdir}/systemd/system/multi-
> > user.target.wants/machines.target \
> > ${base_bindir}/machinectl \
> > + ${base_bindir}/portablectl \
> > ${bindir}/systemd-nspawn \
> > ${nonarch_libdir}/systemd/import-
> > pubring.gpg \
> > ${systemd_system_unitdir}/busnames.targe
> > t.wants/org.freedesktop.import1.busname \
> > @@ -418,21 +421,28 @@ FILES_${PN}-container = "${sysconfdir}/dbus-
> > 1/system.d/org.freedesktop.import1.c
> > ${systemd_system_unitdir}/org.freedeskto
> > p.machine1.busname \
> > ${systemd_system_unitdir}/systemd-
> > importd.service \
> > ${systemd_system_unitdir}/systemd-
> > machined.service \
> > + ${systemd_system_unitdir}/systemd-
> > portabled.service \
> > ${systemd_system_unitdir}/dbus-
> > org.freedesktop.machine1.service \
> > + ${systemd_system_unitdir}/dbus-
> > org.freedesktop.portable1.service \
> > ${systemd_system_unitdir}/var-lib-
> > machines.mount \
> > ${rootlibexecdir}/systemd/systemd-import
> > \
> > ${rootlibexecdir}/systemd/systemd-
> > importd \
> > ${rootlibexecdir}/systemd/systemd-
> > machined \
> > + ${rootlibexecdir}/systemd/systemd-
> > portabled \
> > ${rootlibexecdir}/systemd/systemd-pull \
> > + ${exec_prefix}/lib/tmpfiles.d/portables.c
> > onf \
> > ${exec_prefix}/lib/tmpfiles.d/systemd-
> > nspawn.conf \
> > ${systemd_system_unitdir}/systemd-
> > nspawn@.service \
> > ${libdir}/libnss_mymachines.so.2 \
> > ${datadir}/dbus-1/system-
> > services/org.freedesktop.import1.service \
> > ${datadir}/dbus-1/system-
> > services/org.freedesktop.machine1.service \
> > + ${datadir}/dbus-1/system-
> > services/org.freedesktop.portable1.service \
> > ${datadir}/dbus-
> > 1/system.d/org.freedesktop.import1.conf \
> > ${datadir}/dbus-
> > 1/system.d/org.freedesktop.machine1.conf \
> > + ${datadir}/dbus-
> > 1/system.d/org.freedesktop.portable1.conf \
> > ${datadir}/polkit-
> > 1/actions/org.freedesktop.import1.policy \
> > ${datadir}/polkit-
> > 1/actions/org.freedesktop.machine1.policy \
> > + ${datadir}/polkit-
> > 1/actions/org.freedesktop.portable1.policy \
> > "
> >
> > RRECOMMENDS_${PN}-container += "\
> >
>
>
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] systemd: enable portabled by default and install utilities in systemd-container
2019-05-10 10:45 ` Luca Boccassi
@ 2019-05-10 10:46 ` Martin Hundebøll
0 siblings, 0 replies; 11+ messages in thread
From: Martin Hundebøll @ 2019-05-10 10:46 UTC (permalink / raw)
To: Luca Boccassi, openembedded-core
Hi Luca,
On 10/05/2019 12.45, Luca Boccassi wrote:
> On Fri, 2019-05-10 at 07:23 +0200, Martin Hundebøll wrote:
>> Hi Luca,
>>
>> On 09/05/2019 23.40,
>> luca.boccassi@gmail.com
>> wrote:
>>> From: Luca Boccassi <
>>> luca.boccassi@microsoft.com
>>>>
>>>
>>> portable services have been declared production ready with v241, so
>>> enable
>>> by default and install the files in the container package.
>>
>> The systemd portables feature is not really related to
>> containers/VM's,
>> so I think it should stay in the primary package; or alternatively in
>> a
>> separate package.
>>
>> // Martin
>
> Hello Martin,
>
> IMHO if VM tools and containers tool can go together in this package,
> then portable services utilities can too - they are at different
> positions on the same scale after all :-)
>
> But I've got no strong opinion, so I'll send a v2 with them moved to
> the main package.
I am planning to use portable services instead of going full container,
so I would prefer not having the container/vm utils on target :)
// Martin
>>> Signed-off-by: Luca Boccassi <
>>> luca.boccassi@microsoft.com
>>>>
>>> ---
>>> meta/recipes-core/systemd/systemd_242.bb | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>>
>>> diff --git a/meta/recipes-core/systemd/systemd_242.bb
>>> b/meta/recipes-core/systemd/systemd_242.bb
>>> index 73e03c7a77..83b00ba785 100644
>>> --- a/meta/recipes-core/systemd/systemd_242.bb
>>> +++ b/meta/recipes-core/systemd/systemd_242.bb
>>> @@ -81,6 +81,7 @@ PACKAGECONFIG ??= " \
>>> nss \
>>> nss-mymachines \
>>> nss-resolve \
>>> + portabled \
>>> quotacheck \
>>> randomseed \
>>> resolved \
>>> @@ -403,8 +404,10 @@ SYSTEMD_SERVICE_${PN}-remote = "systemd-
>>> journal-remote.socket"
>>>
>>> FILES_${PN}-container = "${sysconfdir}/dbus-
>>> 1/system.d/org.freedesktop.import1.conf \
>>> ${sysconfdir}/dbus-
>>> 1/system.d/org.freedesktop.machine1.conf \
>>> + ${sysconfdir}/dbus-
>>> 1/system.d/org.freedesktop.portable1.conf \
>>> ${sysconfdir}/systemd/system/multi-
>>> user.target.wants/machines.target \
>>> ${base_bindir}/machinectl \
>>> + ${base_bindir}/portablectl \
>>> ${bindir}/systemd-nspawn \
>>> ${nonarch_libdir}/systemd/import-
>>> pubring.gpg \
>>> ${systemd_system_unitdir}/busnames.targe
>>> t.wants/org.freedesktop.import1.busname \
>>> @@ -418,21 +421,28 @@ FILES_${PN}-container = "${sysconfdir}/dbus-
>>> 1/system.d/org.freedesktop.import1.c
>>> ${systemd_system_unitdir}/org.freedeskto
>>> p.machine1.busname \
>>> ${systemd_system_unitdir}/systemd-
>>> importd.service \
>>> ${systemd_system_unitdir}/systemd-
>>> machined.service \
>>> + ${systemd_system_unitdir}/systemd-
>>> portabled.service \
>>> ${systemd_system_unitdir}/dbus-
>>> org.freedesktop.machine1.service \
>>> + ${systemd_system_unitdir}/dbus-
>>> org.freedesktop.portable1.service \
>>> ${systemd_system_unitdir}/var-lib-
>>> machines.mount \
>>> ${rootlibexecdir}/systemd/systemd-import
>>> \
>>> ${rootlibexecdir}/systemd/systemd-
>>> importd \
>>> ${rootlibexecdir}/systemd/systemd-
>>> machined \
>>> + ${rootlibexecdir}/systemd/systemd-
>>> portabled \
>>> ${rootlibexecdir}/systemd/systemd-pull \
>>> + ${exec_prefix}/lib/tmpfiles.d/portables.c
>>> onf \
>>> ${exec_prefix}/lib/tmpfiles.d/systemd-
>>> nspawn.conf \
>>> ${systemd_system_unitdir}/systemd-
>>> nspawn@.service \
>>> ${libdir}/libnss_mymachines.so.2 \
>>> ${datadir}/dbus-1/system-
>>> services/org.freedesktop.import1.service \
>>> ${datadir}/dbus-1/system-
>>> services/org.freedesktop.machine1.service \
>>> + ${datadir}/dbus-1/system-
>>> services/org.freedesktop.portable1.service \
>>> ${datadir}/dbus-
>>> 1/system.d/org.freedesktop.import1.conf \
>>> ${datadir}/dbus-
>>> 1/system.d/org.freedesktop.machine1.conf \
>>> + ${datadir}/dbus-
>>> 1/system.d/org.freedesktop.portable1.conf \
>>> ${datadir}/polkit-
>>> 1/actions/org.freedesktop.import1.policy \
>>> ${datadir}/polkit-
>>> 1/actions/org.freedesktop.machine1.policy \
>>> + ${datadir}/polkit-
>>> 1/actions/org.freedesktop.portable1.policy \
>>> "
>>>
>>> RRECOMMENDS_${PN}-container += "\
>>>
>>
>>
--
Kind regards,
Martin Hundebøll
Embedded Linux Consultant
+45 61 65 54 61
martin@geanix.com
Geanix ApS
https://geanix.com
DK39600706
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] systemd: enable portabled by default
2019-05-09 21:40 [PATCH] systemd: enable portabled by default and install utilities in systemd-container luca.boccassi
2019-05-10 5:23 ` Martin Hundebøll
@ 2019-05-10 12:09 ` luca.boccassi
2019-05-10 16:45 ` Khem Raj
2019-05-21 12:34 ` [PATCH v3] python*-setuptools: add separate packages for pkg_resources module luca.boccassi
2 siblings, 1 reply; 11+ messages in thread
From: luca.boccassi @ 2019-05-10 12:09 UTC (permalink / raw)
To: openembedded-core
From: Luca Boccassi <luca.boccassi@microsoft.com>
portable services have been declared production ready with v241, so enable
by default and install the files in the main package.
Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
v2: Just enable by default, and let the files be installed in the main package
as requested by reviewers.
meta/recipes-core/systemd/systemd_242.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-core/systemd/systemd_242.bb b/meta/recipes-core/systemd/systemd_242.bb
index 73e03c7a77..f15d125bf8 100644
--- a/meta/recipes-core/systemd/systemd_242.bb
+++ b/meta/recipes-core/systemd/systemd_242.bb
@@ -81,6 +81,7 @@ PACKAGECONFIG ??= " \
nss \
nss-mymachines \
nss-resolve \
+ portabled \
quotacheck \
randomseed \
resolved \
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2] systemd: enable portabled by default
2019-05-10 12:09 ` [PATCH v2] systemd: enable portabled by default luca.boccassi
@ 2019-05-10 16:45 ` Khem Raj
2019-05-13 10:10 ` Luca Boccassi
0 siblings, 1 reply; 11+ messages in thread
From: Khem Raj @ 2019-05-10 16:45 UTC (permalink / raw)
To: luca.boccassi; +Cc: Patches and discussions about the oe-core layer
On Fri, May 10, 2019 at 5:10 AM <luca.boccassi@gmail.com> wrote:
>
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> portable services have been declared production ready with v241, so enable
> by default and install the files in the main package.
>
what is the rationale to enable it by default ?
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> v2: Just enable by default, and let the files be installed in the main package
> as requested by reviewers.
>
> meta/recipes-core/systemd/systemd_242.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/systemd/systemd_242.bb b/meta/recipes-core/systemd/systemd_242.bb
> index 73e03c7a77..f15d125bf8 100644
> --- a/meta/recipes-core/systemd/systemd_242.bb
> +++ b/meta/recipes-core/systemd/systemd_242.bb
> @@ -81,6 +81,7 @@ PACKAGECONFIG ??= " \
> nss \
> nss-mymachines \
> nss-resolve \
> + portabled \
> quotacheck \
> randomseed \
> resolved \
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] systemd: enable portabled by default
2019-05-10 16:45 ` Khem Raj
@ 2019-05-13 10:10 ` Luca Boccassi
2019-05-13 15:24 ` Khem Raj
0 siblings, 1 reply; 11+ messages in thread
From: Luca Boccassi @ 2019-05-13 10:10 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
On Fri, 2019-05-10 at 09:45 -0700, Khem Raj wrote:
> On Fri, May 10, 2019 at 5:10 AM <
> luca.boccassi@gmail.com
> > wrote:
> > From: Luca Boccassi <
> > luca.boccassi@microsoft.com
> > >
> >
> > portable services have been declared production ready with v241, so
> > enable
> > by default and install the files in the main package.
> >
>
> what is the rationale to enable it by default ?
Hi,
commit ada8a5d9175b disabled it by default because it was experimental:
"Add a new PACKAGECONFIG item 'portabled'. Default to disable it
because it's still experimental, according to the announcement letter."
Now it's been declared as stable by upstream, and also given machined
and nspawn are enabled by default I don't see a reason why this
shouldn't be as well, as they all provide the same "kind" of
feature/functionality, albeit on a different level.
> > Signed-off-by: Luca Boccassi <
> > luca.boccassi@microsoft.com
> > >
> > ---
> > v2: Just enable by default, and let the files be installed in the
> > main package
> > as requested by reviewers.
> >
> > meta/recipes-core/systemd/systemd_242.bb | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/recipes-core/systemd/systemd_242.bb
> > b/meta/recipes-core/systemd/systemd_242.bb
> > index 73e03c7a77..f15d125bf8 100644
> > --- a/meta/recipes-core/systemd/systemd_242.bb
> > +++ b/meta/recipes-core/systemd/systemd_242.bb
> > @@ -81,6 +81,7 @@ PACKAGECONFIG ??= " \
> > nss \
> > nss-mymachines \
> > nss-resolve \
> > + portabled \
> > quotacheck \
> > randomseed \
> > resolved \
> > --
> > 2.20.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> >
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] systemd: enable portabled by default
2019-05-13 10:10 ` Luca Boccassi
@ 2019-05-13 15:24 ` Khem Raj
2019-05-14 22:08 ` Luca Boccassi
0 siblings, 1 reply; 11+ messages in thread
From: Khem Raj @ 2019-05-13 15:24 UTC (permalink / raw)
To: Luca Boccassi; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 2282 bytes --]
On Mon, May 13, 2019 at 3:10 AM Luca Boccassi <luca.boccassi@gmail.com>
wrote:
> On Fri, 2019-05-10 at 09:45 -0700, Khem Raj wrote:
> > On Fri, May 10, 2019 at 5:10 AM <
> > luca.boccassi@gmail.com
> > > wrote:
> > > From: Luca Boccassi <
> > > luca.boccassi@microsoft.com
> > > >
> > >
> > > portable services have been declared production ready with v241, so
> > > enable
> > > by default and install the files in the main package.
> > >
> >
> > what is the rationale to enable it by default ?
>
> Hi,
>
> commit ada8a5d9175b disabled it by default because it was experimental:
> "Add a new PACKAGECONFIG item 'portabled'. Default to disable it
> because it's still experimental, according to the announcement letter."
>
> Now it's been declared as stable by upstream, and also given machined
> and nspawn are enabled by default I don't see a reason why this
> shouldn't be as well, as they all provide the same "kind" of
> feature/functionality, albeit on a different level.
>
Ok being stable is a good thing I agree but I still fail to understand why
make it default I am for disabling nspawn and machined as well
>
> > > Signed-off-by: Luca Boccassi <
> > > luca.boccassi@microsoft.com
> > > >
> > > ---
> > > v2: Just enable by default, and let the files be installed in the
> > > main package
> > > as requested by reviewers.
> > >
> > > meta/recipes-core/systemd/systemd_242.bb | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/meta/recipes-core/systemd/systemd_242.bb
> > > b/meta/recipes-core/systemd/systemd_242.bb
> > > index 73e03c7a77..f15d125bf8 100644
> > > --- a/meta/recipes-core/systemd/systemd_242.bb
> > > +++ b/meta/recipes-core/systemd/systemd_242.bb
> > > @@ -81,6 +81,7 @@ PACKAGECONFIG ??= " \
> > > nss \
> > > nss-mymachines \
> > > nss-resolve \
> > > + portabled \
> > > quotacheck \
> > > randomseed \
> > > resolved \
> > > --
> > > 2.20.1
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-core mailing list
> > > Openembedded-core@lists.openembedded.org
> > >
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> > >
> --
> Kind regards,
> Luca Boccassi
>
>
[-- Attachment #2: Type: text/html, Size: 3929 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] systemd: enable portabled by default
2019-05-13 15:24 ` Khem Raj
@ 2019-05-14 22:08 ` Luca Boccassi
0 siblings, 0 replies; 11+ messages in thread
From: Luca Boccassi @ 2019-05-14 22:08 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
On Mon, 2019-05-13 at 08:24 -0700, Khem Raj wrote:
>
>
> On Mon, May 13, 2019 at 3:10 AM Luca Boccassi <
> luca.boccassi@gmail.com> wrote:
> > On Fri, 2019-05-10 at 09:45 -0700, Khem Raj wrote:
> > > On Fri, May 10, 2019 at 5:10 AM <
> > > luca.boccassi@gmail.com
> > > > wrote:
> > > > From: Luca Boccassi <
> > > > luca.boccassi@microsoft.com
> > > > >
> > > >
> > > > portable services have been declared production ready with
> > v241, so
> > > > enable
> > > > by default and install the files in the main package.
> > > >
> > >
> > > what is the rationale to enable it by default ?
> >
> > Hi,
> >
> > commit ada8a5d9175b disabled it by default because it was
> > experimental:
> > "Add a new PACKAGECONFIG item 'portabled'. Default to disable it
> > because it's still experimental, according to the announcement
> > letter."
> >
> > Now it's been declared as stable by upstream, and also given
> > machined
> > and nspawn are enabled by default I don't see a reason why this
> > shouldn't be as well, as they all provide the same "kind" of
> > feature/functionality, albeit on a different level.
> >
>
> Ok being stable is a good thing I agree but I still fail to
> understand why make it default I am for disabling nspawn and machined
> as well
Simply that as long as nspawn and machined are enabled by default,
there's no reason to do something different for portable services, in
my opinion. At the moment they are enabled, hence this patch.
> > > > Signed-off-by: Luca Boccassi <
> > > > luca.boccassi@microsoft.com
> > > > >
> > > > ---
> > > > v2: Just enable by default, and let the files be installed in
> > the
> > > > main package
> > > > as requested by reviewers.
> > > >
> > > > meta/recipes-core/systemd/systemd_242.bb | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/meta/recipes-core/systemd/systemd_242.bb
> > > > b/meta/recipes-core/systemd/systemd_242.bb
> > > > index 73e03c7a77..f15d125bf8 100644
> > > > --- a/meta/recipes-core/systemd/systemd_242.bb
> > > > +++ b/meta/recipes-core/systemd/systemd_242.bb
> > > > @@ -81,6 +81,7 @@ PACKAGECONFIG ??= " \
> > > > nss \
> > > > nss-mymachines \
> > > > nss-resolve \
> > > > + portabled \
> > > > quotacheck \
> > > > randomseed \
> > > > resolved \
> > > > --
> > > > 2.20.1
> > > >
> > > > --
> > > > _______________________________________________
> > > > Openembedded-core mailing list
> > > > Openembedded-core@lists.openembedded.org
> > > >
> > > >
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> > > >
>
>
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3] python*-setuptools: add separate packages for pkg_resources module
2019-05-09 21:40 [PATCH] systemd: enable portabled by default and install utilities in systemd-container luca.boccassi
2019-05-10 5:23 ` Martin Hundebøll
2019-05-10 12:09 ` [PATCH v2] systemd: enable portabled by default luca.boccassi
@ 2019-05-21 12:34 ` luca.boccassi
2019-05-21 12:35 ` Luca Boccassi
2 siblings, 1 reply; 11+ messages in thread
From: luca.boccassi @ 2019-05-21 12:34 UTC (permalink / raw)
To: openembedded-core
From: Luca Boccassi <luca.boccassi@microsoft.com>
The pkg_resources Python module is useful by itself, for example for
automatic loading of resources shipped in a Python package.
Add separate packages for it, so that users can depend on them
individually and avoid pulling in the entire setuptools, which
include scripts to download other packages, which might not be
desired on minimal images.
Other distributions like Debian and Ubuntu already split setuptools
and pkg-resources in this way.
The setuptools packages now depend on the new pkg-resources packages,
to avoid regressions for other packages that depend on them
already.
Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
v2: restrict new RDEPENDS to class-target. As advised by Alexander, bitbake
cannot resolve native rdeps that mention package names rather than
recipe names.
v3: manually add RPROVIDES to the native class instead of restricting the
RDEPENDS to the target class as a better workaround. Also document why
the package is being split.
meta/recipes-devtools/python/python-setuptools.inc | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/meta/recipes-devtools/python/python-setuptools.inc b/meta/recipes-devtools/python/python-setuptools.inc
index 357aa07086..f49e078697 100644
--- a/meta/recipes-devtools/python/python-setuptools.inc
+++ b/meta/recipes-devtools/python/python-setuptools.inc
@@ -37,3 +37,14 @@ do_install_prepend() {
}
BBCLASSEXTEND = "native nativesdk"
+
+# The pkg-resources module can be used by itself, without the package downloader
+# and easy_install. Ship it in a separate package so that it can be used by
+# minimal distributions.
+PACKAGES =+ "${PYTHON_PN}-pkg-resources "
+FILES_${PYTHON_PN}-pkg-resources = "${PYTHON_SITEPACKAGES_DIR}/pkg_resources/*"
+# Due to the way OE-Core implemented native recipes, the native class cannot
+# have a dependency on something that is not a recipe name. Work around that by
+# manually setting RPROVIDES.
+RDEPENDS_${PN}_append = " ${PYTHON_PN}-pkg-resources"
+RPROVIDES_append_class-native = " ${PYTHON_PN}-pkg-resources-native"
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v3] python*-setuptools: add separate packages for pkg_resources module
2019-05-21 12:34 ` [PATCH v3] python*-setuptools: add separate packages for pkg_resources module luca.boccassi
@ 2019-05-21 12:35 ` Luca Boccassi
0 siblings, 0 replies; 11+ messages in thread
From: Luca Boccassi @ 2019-05-21 12:35 UTC (permalink / raw)
To: openembedded-core
On Tue, 2019-05-21 at 13:34 +0100, luca.boccassi@gmail.com wrote:
> From: Luca Boccassi <
> luca.boccassi@microsoft.com
> >
>
> The pkg_resources Python module is useful by itself, for example for
> automatic loading of resources shipped in a Python package.
> Add separate packages for it, so that users can depend on them
> individually and avoid pulling in the entire setuptools, which
> include scripts to download other packages, which might not be
> desired on minimal images.
>
> Other distributions like Debian and Ubuntu already split setuptools
> and pkg-resources in this way.
>
> The setuptools packages now depend on the new pkg-resources packages,
> to avoid regressions for other packages that depend on them
> already.
>
> Signed-off-by: Luca Boccassi <
> luca.boccassi@microsoft.com
> >
> ---
>
> v2: restrict new RDEPENDS to class-target. As advised by Alexander,
> bitbake
> cannot resolve native rdeps that mention package names rather
> than
> recipe names.
> v3: manually add RPROVIDES to the native class instead of restricting
> the
> RDEPENDS to the target class as a better workaround. Also
> document why
> the package is being split.
>
> meta/recipes-devtools/python/python-setuptools.inc | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/meta/recipes-devtools/python/python-setuptools.inc
> b/meta/recipes-devtools/python/python-setuptools.inc
> index 357aa07086..f49e078697 100644
> --- a/meta/recipes-devtools/python/python-setuptools.inc
> +++ b/meta/recipes-devtools/python/python-setuptools.inc
> @@ -37,3 +37,14 @@ do_install_prepend() {
> }
>
> BBCLASSEXTEND = "native nativesdk"
> +
> +# The pkg-resources module can be used by itself, without the
> package downloader
> +# and easy_install. Ship it in a separate package so that it can be
> used by
> +# minimal distributions.
> +PACKAGES =+ "${PYTHON_PN}-pkg-resources "
> +FILES_${PYTHON_PN}-pkg-resources =
> "${PYTHON_SITEPACKAGES_DIR}/pkg_resources/*"
> +# Due to the way OE-Core implemented native recipes, the native
> class cannot
> +# have a dependency on something that is not a recipe name. Work
> around that by
> +# manually setting RPROVIDES.
> +RDEPENDS_${PN}_append = " ${PYTHON_PN}-pkg-resources"
> +RPROVIDES_append_class-native = " ${PYTHON_PN}-pkg-resources-native"
>
Sorry, wrong in-reply-to, resending.
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-05-21 12:35 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-09 21:40 [PATCH] systemd: enable portabled by default and install utilities in systemd-container luca.boccassi
2019-05-10 5:23 ` Martin Hundebøll
2019-05-10 10:45 ` Luca Boccassi
2019-05-10 10:46 ` Martin Hundebøll
2019-05-10 12:09 ` [PATCH v2] systemd: enable portabled by default luca.boccassi
2019-05-10 16:45 ` Khem Raj
2019-05-13 10:10 ` Luca Boccassi
2019-05-13 15:24 ` Khem Raj
2019-05-14 22:08 ` Luca Boccassi
2019-05-21 12:34 ` [PATCH v3] python*-setuptools: add separate packages for pkg_resources module luca.boccassi
2019-05-21 12:35 ` Luca Boccassi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.