* [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking
@ 2019-05-11 23:17 ` Peter Geis
0 siblings, 0 replies; 14+ messages in thread
From: Peter Geis @ 2019-05-11 23:17 UTC (permalink / raw)
To: Serge Semin
Cc: Andrew Lunn, Florian Fainelli, Heiner Kallweit, David S. Miller,
Serge Semin, netdev, linux-rockchip
Good Evening,
Commit f81dadbcf7fd067baf184b63c179fc392bdb226e "net: phy: realtek: Add
rtl8211e rx/tx delays config" breaks networking completely on the
rk3328-roc-cc.
Reverting the offending commit solves the problem.
The following error occurs:
[ 49.442425] Unable to handle kernel execution of user memory at
virtual address 0000000000000000
[ 49.443237] Mem abort info:
[ 49.443512] ESR = 0x86000005
[ 49.443798] Exception class = IABT (current EL), IL = 32 bits
[ 49.444331] SET = 0, FnV = 0
[ 49.444613] EA = 0, S1PTW = 0
[ 49.444914] user pgtable: 64k pages, 48-bit VAs, pgdp = 000000008f8d6f90
[ 49.445516] [0000000000000000] pgd=0000000000000000, pud=0000000000000000
[ 49.446136] Internal error: Oops: 86000005 [#1] PREEMPT SMP
[ 49.446641] Modules linked in: snd_soc_hdmi_codec dw_hdmi_i2s_audio
aes_ce_blk crypto_simd aes_ce_cipher crct10dif_ce ghash_ce aes_arm64
sha2_ce rockchipdrm sha256_arm64 sha1_ce dw_hdmi lima drm_kms_helper
gpu_sched pwm_fan snd_soc_simple_card snd_soc_simple_card_utils drm
snd_soc_rockchip_i2s drm_panel_orientation_quirks snd_soc_rockchip_pcm
squashfs sch_fq_codel ip_tables x_tables ipv6 crc_ccitt btrfs xor
xor_neon zstd_compress raid6_pq libcrc32c zstd_decompress rtc_rk808 realtek
[ 49.450477] Process NetworkManager (pid: 1814, stack limit =
0x00000000cc8e3ffb)
[ 49.451150] CPU: 2 PID: 1814 Comm: NetworkManager Not tainted
5.1.0-next-20190510test-00009-g3ed182aaa670 #51
[ 49.452036] Hardware name: Firefly roc-rk3328-cc (DT)
[ 49.452496] pstate: 80400005 (Nzcv daif +PAN -UAO)
[ 49.452938] pc : 0x0
[ 49.453158] lr : phy_select_page+0x34/0x78
[ 49.453532] sp : ffff0000139cf130
[ 49.453841] x29: ffff0000139cf130 x28: ffff80000c9908c0
[ 49.454326] x27: ffff800000ba1e10 x26: ffff0000139cf9a0
[ 49.454806] x25: ffff80000034a000 x24: 0000000000000000
[ 49.455285] x23: 0000000000000000 x22: 0000000000000008
[ 49.455762] x21: 0000000000000007 x20: ffff800000344800
[ 49.456245] x19: ffff800000344800 x18: 0000000000000030
[ 49.456726] x17: 0000000000000000 x16: 0000000000000000
[ 49.457207] x15: ffffffffffffffff x14: ffff000010f03688
[ 49.457688] x13: 000000cce415c000 x12: 0000000000000001
[ 49.458167] x11: 0000000000000000 x10: 00000000000004e5
[ 49.458647] x9 : 000000000b94d076 x8 : 00000000000000cc
[ 49.459130] x7 : 0000000000ddfd31 x6 : ffff8000feabcf70
[ 49.459610] x5 : ffff8000007e9f00 x4 : ffff000010a1cbd8
[ 49.460090] x3 : ffff80000034a070 x2 : ffff8000007e9f00
[ 49.460569] x1 : 0000000000000000 x0 : ffff800000344800
[ 49.461050] Call trace:
[ 49.461287] 0x0
[ 49.461468] rtl8211e_config_init+0x40/0xa0 [realtek]
[ 49.461927] phy_init_hw+0x54/0x70
[ 49.462243] phy_attach_direct+0xd4/0x250
[ 49.462612] phy_connect_direct+0x20/0x70
[ 49.462978] phy_connect+0x54/0xa0
[ 49.463295] stmmac_init_phy+0x17c/0x200
[ 49.463655] stmmac_open+0x124/0xac0
[ 49.463983] __dev_open+0xd8/0x158
[ 49.464299] __dev_change_flags+0x164/0x1c8
[ 49.464680] dev_change_flags+0x20/0x60
[ 49.465047] do_setlink+0x288/0xba8
[ 49.465366] __rtnl_newlink+0x5cc/0x6e8
[ 49.465720] rtnl_newlink+0x48/0x70
[ 49.466038] rtnetlink_rcv_msg+0x120/0x368
[ 49.466426] netlink_rcv_skb+0x58/0x118
[ 49.466784] rtnetlink_rcv+0x14/0x20
[ 49.467115] netlink_unicast+0x180/0x1f8
[ 49.467479] netlink_sendmsg+0x190/0x330
[ 49.467878] sock_sendmsg+0x3c/0x58
[ 49.468199] ___sys_sendmsg+0x268/0x2a0
[ 49.468554] __sys_sendmsg+0x68/0xb8
[ 49.468884] __arm64_sys_sendmsg+0x20/0x28
[ 49.469266] el0_svc_common.constprop.0+0x7c/0xe8
[ 49.469705] el0_svc_handler+0x28/0x78
[ 49.470052] el0_svc+0x8/0xc
[ 49.470334] Code: bad PC value
[ 49.470619] ---[ end trace f330c41329b3e289 ]---
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking
@ 2019-05-11 23:17 ` Peter Geis
0 siblings, 0 replies; 14+ messages in thread
From: Peter Geis @ 2019-05-11 23:17 UTC (permalink / raw)
To: Serge Semin
Cc: Andrew Lunn, Florian Fainelli, Serge Semin,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, David S. Miller,
Heiner Kallweit
Good Evening,
Commit f81dadbcf7fd067baf184b63c179fc392bdb226e "net: phy: realtek: Add
rtl8211e rx/tx delays config" breaks networking completely on the
rk3328-roc-cc.
Reverting the offending commit solves the problem.
The following error occurs:
[ 49.442425] Unable to handle kernel execution of user memory at
virtual address 0000000000000000
[ 49.443237] Mem abort info:
[ 49.443512] ESR = 0x86000005
[ 49.443798] Exception class = IABT (current EL), IL = 32 bits
[ 49.444331] SET = 0, FnV = 0
[ 49.444613] EA = 0, S1PTW = 0
[ 49.444914] user pgtable: 64k pages, 48-bit VAs, pgdp = 000000008f8d6f90
[ 49.445516] [0000000000000000] pgd=0000000000000000, pud=0000000000000000
[ 49.446136] Internal error: Oops: 86000005 [#1] PREEMPT SMP
[ 49.446641] Modules linked in: snd_soc_hdmi_codec dw_hdmi_i2s_audio
aes_ce_blk crypto_simd aes_ce_cipher crct10dif_ce ghash_ce aes_arm64
sha2_ce rockchipdrm sha256_arm64 sha1_ce dw_hdmi lima drm_kms_helper
gpu_sched pwm_fan snd_soc_simple_card snd_soc_simple_card_utils drm
snd_soc_rockchip_i2s drm_panel_orientation_quirks snd_soc_rockchip_pcm
squashfs sch_fq_codel ip_tables x_tables ipv6 crc_ccitt btrfs xor
xor_neon zstd_compress raid6_pq libcrc32c zstd_decompress rtc_rk808 realtek
[ 49.450477] Process NetworkManager (pid: 1814, stack limit =
0x00000000cc8e3ffb)
[ 49.451150] CPU: 2 PID: 1814 Comm: NetworkManager Not tainted
5.1.0-next-20190510test-00009-g3ed182aaa670 #51
[ 49.452036] Hardware name: Firefly roc-rk3328-cc (DT)
[ 49.452496] pstate: 80400005 (Nzcv daif +PAN -UAO)
[ 49.452938] pc : 0x0
[ 49.453158] lr : phy_select_page+0x34/0x78
[ 49.453532] sp : ffff0000139cf130
[ 49.453841] x29: ffff0000139cf130 x28: ffff80000c9908c0
[ 49.454326] x27: ffff800000ba1e10 x26: ffff0000139cf9a0
[ 49.454806] x25: ffff80000034a000 x24: 0000000000000000
[ 49.455285] x23: 0000000000000000 x22: 0000000000000008
[ 49.455762] x21: 0000000000000007 x20: ffff800000344800
[ 49.456245] x19: ffff800000344800 x18: 0000000000000030
[ 49.456726] x17: 0000000000000000 x16: 0000000000000000
[ 49.457207] x15: ffffffffffffffff x14: ffff000010f03688
[ 49.457688] x13: 000000cce415c000 x12: 0000000000000001
[ 49.458167] x11: 0000000000000000 x10: 00000000000004e5
[ 49.458647] x9 : 000000000b94d076 x8 : 00000000000000cc
[ 49.459130] x7 : 0000000000ddfd31 x6 : ffff8000feabcf70
[ 49.459610] x5 : ffff8000007e9f00 x4 : ffff000010a1cbd8
[ 49.460090] x3 : ffff80000034a070 x2 : ffff8000007e9f00
[ 49.460569] x1 : 0000000000000000 x0 : ffff800000344800
[ 49.461050] Call trace:
[ 49.461287] 0x0
[ 49.461468] rtl8211e_config_init+0x40/0xa0 [realtek]
[ 49.461927] phy_init_hw+0x54/0x70
[ 49.462243] phy_attach_direct+0xd4/0x250
[ 49.462612] phy_connect_direct+0x20/0x70
[ 49.462978] phy_connect+0x54/0xa0
[ 49.463295] stmmac_init_phy+0x17c/0x200
[ 49.463655] stmmac_open+0x124/0xac0
[ 49.463983] __dev_open+0xd8/0x158
[ 49.464299] __dev_change_flags+0x164/0x1c8
[ 49.464680] dev_change_flags+0x20/0x60
[ 49.465047] do_setlink+0x288/0xba8
[ 49.465366] __rtnl_newlink+0x5cc/0x6e8
[ 49.465720] rtnl_newlink+0x48/0x70
[ 49.466038] rtnetlink_rcv_msg+0x120/0x368
[ 49.466426] netlink_rcv_skb+0x58/0x118
[ 49.466784] rtnetlink_rcv+0x14/0x20
[ 49.467115] netlink_unicast+0x180/0x1f8
[ 49.467479] netlink_sendmsg+0x190/0x330
[ 49.467878] sock_sendmsg+0x3c/0x58
[ 49.468199] ___sys_sendmsg+0x268/0x2a0
[ 49.468554] __sys_sendmsg+0x68/0xb8
[ 49.468884] __arm64_sys_sendmsg+0x20/0x28
[ 49.469266] el0_svc_common.constprop.0+0x7c/0xe8
[ 49.469705] el0_svc_handler+0x28/0x78
[ 49.470052] el0_svc+0x8/0xc
[ 49.470334] Code: bad PC value
[ 49.470619] ---[ end trace f330c41329b3e289 ]---
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking
@ 2019-05-12 2:37 ` Andrew Lunn
0 siblings, 0 replies; 14+ messages in thread
From: Andrew Lunn @ 2019-05-12 2:37 UTC (permalink / raw)
To: Peter Geis
Cc: Serge Semin, Florian Fainelli, Heiner Kallweit, David S. Miller,
Serge Semin, netdev, linux-rockchip
On Sat, May 11, 2019 at 07:17:08PM -0400, Peter Geis wrote:
> Good Evening,
>
> Commit f81dadbcf7fd067baf184b63c179fc392bdb226e "net: phy: realtek: Add
> rtl8211e rx/tx delays config" breaks networking completely on the
> rk3328-roc-cc.
> Reverting the offending commit solves the problem.
Hi Peter
The fix should be in net, and will soon make its way upwards.
Andrew
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking
@ 2019-05-12 2:37 ` Andrew Lunn
0 siblings, 0 replies; 14+ messages in thread
From: Andrew Lunn @ 2019-05-12 2:37 UTC (permalink / raw)
To: Peter Geis
Cc: Florian Fainelli, Serge Semin, netdev-u79uwXL29TY76Z2rM5mHXA,
Serge Semin, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
David S. Miller, Heiner Kallweit
On Sat, May 11, 2019 at 07:17:08PM -0400, Peter Geis wrote:
> Good Evening,
>
> Commit f81dadbcf7fd067baf184b63c179fc392bdb226e "net: phy: realtek: Add
> rtl8211e rx/tx delays config" breaks networking completely on the
> rk3328-roc-cc.
> Reverting the offending commit solves the problem.
Hi Peter
The fix should be in net, and will soon make its way upwards.
Andrew
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking
@ 2019-05-12 2:50 ` Peter Geis
0 siblings, 0 replies; 14+ messages in thread
From: Peter Geis @ 2019-05-12 2:50 UTC (permalink / raw)
To: Andrew Lunn
Cc: Serge Semin, Florian Fainelli, Heiner Kallweit, David S. Miller,
Serge Semin, netdev, linux-rockchip
On 5/11/2019 10:37 PM, Andrew Lunn wrote:
> On Sat, May 11, 2019 at 07:17:08PM -0400, Peter Geis wrote:
>> Good Evening,
>>
>> Commit f81dadbcf7fd067baf184b63c179fc392bdb226e "net: phy: realtek: Add
>> rtl8211e rx/tx delays config" breaks networking completely on the
>> rk3328-roc-cc.
>> Reverting the offending commit solves the problem.
>
> Hi Peter
>
> The fix should be in net, and will soon make its way upwards.
>
> Andrew
>
Good Evening,
Thanks, is there a link to the patch so I may test it?
Peter
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking
@ 2019-05-12 2:50 ` Peter Geis
0 siblings, 0 replies; 14+ messages in thread
From: Peter Geis @ 2019-05-12 2:50 UTC (permalink / raw)
To: Andrew Lunn
Cc: Florian Fainelli, Serge Semin, netdev-u79uwXL29TY76Z2rM5mHXA,
Serge Semin, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
David S. Miller, Heiner Kallweit
On 5/11/2019 10:37 PM, Andrew Lunn wrote:
> On Sat, May 11, 2019 at 07:17:08PM -0400, Peter Geis wrote:
>> Good Evening,
>>
>> Commit f81dadbcf7fd067baf184b63c179fc392bdb226e "net: phy: realtek: Add
>> rtl8211e rx/tx delays config" breaks networking completely on the
>> rk3328-roc-cc.
>> Reverting the offending commit solves the problem.
>
> Hi Peter
>
> The fix should be in net, and will soon make its way upwards.
>
> Andrew
>
Good Evening,
Thanks, is there a link to the patch so I may test it?
Peter
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking
2019-05-12 2:50 ` Peter Geis
@ 2019-05-12 7:34 ` Heiner Kallweit
-1 siblings, 0 replies; 14+ messages in thread
From: Heiner Kallweit @ 2019-05-12 7:34 UTC (permalink / raw)
To: Peter Geis, Andrew Lunn
Cc: Serge Semin, Florian Fainelli, David S. Miller, Serge Semin,
netdev, linux-rockchip
On 12.05.2019 04:50, Peter Geis wrote:
> On 5/11/2019 10:37 PM, Andrew Lunn wrote:
>> On Sat, May 11, 2019 at 07:17:08PM -0400, Peter Geis wrote:
>>> Good Evening,
>>>
>>> Commit f81dadbcf7fd067baf184b63c179fc392bdb226e "net: phy: realtek: Add
>>> rtl8211e rx/tx delays config" breaks networking completely on the
>>> rk3328-roc-cc.
>>> Reverting the offending commit solves the problem.
>>
>> Hi Peter
>>
>> The fix should be in net, and will soon make its way upwards.
>>
>> Andrew
>>
>
>
> Good Evening,
>
> Thanks, is there a link to the patch so I may test it?
>
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=daf3ddbe11a2ff74c95bc814df8e5fe3201b4cb5
> Peter
>
Heiner
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking
@ 2019-05-12 7:34 ` Heiner Kallweit
0 siblings, 0 replies; 14+ messages in thread
From: Heiner Kallweit @ 2019-05-12 7:34 UTC (permalink / raw)
To: Peter Geis, Andrew Lunn
Cc: Serge Semin, Florian Fainelli, David S. Miller, Serge Semin,
netdev, linux-rockchip
On 12.05.2019 04:50, Peter Geis wrote:
> On 5/11/2019 10:37 PM, Andrew Lunn wrote:
>> On Sat, May 11, 2019 at 07:17:08PM -0400, Peter Geis wrote:
>>> Good Evening,
>>>
>>> Commit f81dadbcf7fd067baf184b63c179fc392bdb226e "net: phy: realtek: Add
>>> rtl8211e rx/tx delays config" breaks networking completely on the
>>> rk3328-roc-cc.
>>> Reverting the offending commit solves the problem.
>>
>> Hi Peter
>>
>> The fix should be in net, and will soon make its way upwards.
>>
>> Andrew
>>
>
>
> Good Evening,
>
> Thanks, is there a link to the patch so I may test it?
>
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=daf3ddbe11a2ff74c95bc814df8e5fe3201b4cb5
> Peter
>
Heiner
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking
2019-05-12 7:34 ` Heiner Kallweit
@ 2019-05-14 11:53 ` Peter Geis
-1 siblings, 0 replies; 14+ messages in thread
From: Peter Geis @ 2019-05-14 11:53 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Andrew Lunn, Serge Semin, Florian Fainelli, David S. Miller,
Serge Semin, netdev, linux-rockchip
On Sun, May 12, 2019 at 3:34 AM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> On 12.05.2019 04:50, Peter Geis wrote:
> > On 5/11/2019 10:37 PM, Andrew Lunn wrote:
> >> On Sat, May 11, 2019 at 07:17:08PM -0400, Peter Geis wrote:
> >>> Good Evening,
> >>>
> >>> Commit f81dadbcf7fd067baf184b63c179fc392bdb226e "net: phy: realtek: Add
> >>> rtl8211e rx/tx delays config" breaks networking completely on the
> >>> rk3328-roc-cc.
> >>> Reverting the offending commit solves the problem.
> >>
> >> Hi Peter
> >>
> >> The fix should be in net, and will soon make its way upwards.
> >>
> >> Andrew
> >>
> >
> >
> > Good Evening,
> >
> > Thanks, is there a link to the patch so I may test it?
> >
> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=daf3ddbe11a2ff74c95bc814df8e5fe3201b4cb5
>
> > Peter
> >
> Heiner
This patch does correct the error message on boot, however networking
is still completely broken.
The current error is as follows:
[ 121.829375] kworker/3:1 D 0 67 2 0x00000028
[ 121.829398] Workqueue: events linkwatch_event
[ 121.829403] Call trace:
[ 121.829412] __switch_to+0xb8/0x1a8
[ 121.829420] __schedule+0x220/0x560
[ 121.829423] schedule+0x38/0xd8
[ 121.829429] schedule_preempt_disabled+0x20/0x38
[ 121.829435] __mutex_lock.isra.1+0x1c4/0x500
[ 121.829438] __mutex_lock_slowpath+0x10/0x18
[ 121.829443] mutex_lock+0x2c/0x38
[ 121.829449] rtnl_lock+0x14/0x20
[ 121.829453] linkwatch_event+0xc/0x38
[ 121.829461] process_one_work+0x1e0/0x320
[ 121.829466] worker_thread+0x40/0x428
[ 121.829473] kthread+0x120/0x128
[ 121.829476] ret_from_fork+0x10/0x18
[ 121.829533] INFO: task NetworkManager:1833 blocked for more than 61 seconds.
[ 121.830160] Not tainted
5.1.0-next-20190510test-00009-g3ed182aaa670-dirty #55
[ 121.830831] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs"
disables this message.
[ 121.831589] NetworkManager D 0 1833 1 0x00000028
[ 121.831601] Call trace:
[ 121.831614] __switch_to+0xb8/0x1a8
[ 121.831623] __schedule+0x220/0x560
[ 121.831631] schedule+0x38/0xd8
[ 121.831639] schedule_preempt_disabled+0x20/0x38
[ 121.831647] __mutex_lock.isra.1+0x1c4/0x500
[ 121.831666] __mutex_lock_slowpath+0x10/0x18
[ 121.831671] mutex_lock+0x2c/0x38
[ 121.831687] mdiobus_write+0x40/0x80
[ 121.831698] rtl8211e_config_init+0x60/0xa0 [realtek]
[ 121.831706] phy_init_hw+0x54/0x70
[ 121.831714] phy_attach_direct+0xd4/0x250
[ 121.831720] phy_connect_direct+0x20/0x70
[ 121.831728] phy_connect+0x54/0xa0
[ 121.831741] stmmac_init_phy+0x17c/0x200
[ 121.831748] stmmac_open+0x124/0xac0
[ 121.831759] __dev_open+0xd8/0x158
[ 121.831762] __dev_change_flags+0x164/0x1c8
[ 121.831766] dev_change_flags+0x20/0x60
[ 121.831774] do_setlink+0x288/0xba8
[ 121.831778] __rtnl_newlink+0x5cc/0x6e8
[ 121.831783] rtnl_newlink+0x48/0x70
[ 121.831786] rtnetlink_rcv_msg+0x120/0x368
[ 121.831807] netlink_rcv_skb+0x58/0x118
[ 121.831811] rtnetlink_rcv+0x14/0x20
[ 121.831816] netlink_unicast+0x180/0x1f8
[ 121.831822] netlink_sendmsg+0x190/0x330
[ 121.831837] sock_sendmsg+0x3c/0x58
[ 121.831844] ___sys_sendmsg+0x268/0x2a0
[ 121.831849] __sys_sendmsg+0x68/0xb8
[ 121.831855] __arm64_sys_sendmsg+0x20/0x28
[ 121.831864] el0_svc_common.constprop.0+0x7c/0xe8
[ 121.831870] el0_svc_handler+0x28/0x78
[ 121.831875] el0_svc+0x8/0xc
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking
@ 2019-05-14 11:53 ` Peter Geis
0 siblings, 0 replies; 14+ messages in thread
From: Peter Geis @ 2019-05-14 11:53 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Andrew Lunn, Serge Semin, Florian Fainelli, David S. Miller,
Serge Semin, netdev, linux-rockchip
On Sun, May 12, 2019 at 3:34 AM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> On 12.05.2019 04:50, Peter Geis wrote:
> > On 5/11/2019 10:37 PM, Andrew Lunn wrote:
> >> On Sat, May 11, 2019 at 07:17:08PM -0400, Peter Geis wrote:
> >>> Good Evening,
> >>>
> >>> Commit f81dadbcf7fd067baf184b63c179fc392bdb226e "net: phy: realtek: Add
> >>> rtl8211e rx/tx delays config" breaks networking completely on the
> >>> rk3328-roc-cc.
> >>> Reverting the offending commit solves the problem.
> >>
> >> Hi Peter
> >>
> >> The fix should be in net, and will soon make its way upwards.
> >>
> >> Andrew
> >>
> >
> >
> > Good Evening,
> >
> > Thanks, is there a link to the patch so I may test it?
> >
> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=daf3ddbe11a2ff74c95bc814df8e5fe3201b4cb5
>
> > Peter
> >
> Heiner
This patch does correct the error message on boot, however networking
is still completely broken.
The current error is as follows:
[ 121.829375] kworker/3:1 D 0 67 2 0x00000028
[ 121.829398] Workqueue: events linkwatch_event
[ 121.829403] Call trace:
[ 121.829412] __switch_to+0xb8/0x1a8
[ 121.829420] __schedule+0x220/0x560
[ 121.829423] schedule+0x38/0xd8
[ 121.829429] schedule_preempt_disabled+0x20/0x38
[ 121.829435] __mutex_lock.isra.1+0x1c4/0x500
[ 121.829438] __mutex_lock_slowpath+0x10/0x18
[ 121.829443] mutex_lock+0x2c/0x38
[ 121.829449] rtnl_lock+0x14/0x20
[ 121.829453] linkwatch_event+0xc/0x38
[ 121.829461] process_one_work+0x1e0/0x320
[ 121.829466] worker_thread+0x40/0x428
[ 121.829473] kthread+0x120/0x128
[ 121.829476] ret_from_fork+0x10/0x18
[ 121.829533] INFO: task NetworkManager:1833 blocked for more than 61 seconds.
[ 121.830160] Not tainted
5.1.0-next-20190510test-00009-g3ed182aaa670-dirty #55
[ 121.830831] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs"
disables this message.
[ 121.831589] NetworkManager D 0 1833 1 0x00000028
[ 121.831601] Call trace:
[ 121.831614] __switch_to+0xb8/0x1a8
[ 121.831623] __schedule+0x220/0x560
[ 121.831631] schedule+0x38/0xd8
[ 121.831639] schedule_preempt_disabled+0x20/0x38
[ 121.831647] __mutex_lock.isra.1+0x1c4/0x500
[ 121.831666] __mutex_lock_slowpath+0x10/0x18
[ 121.831671] mutex_lock+0x2c/0x38
[ 121.831687] mdiobus_write+0x40/0x80
[ 121.831698] rtl8211e_config_init+0x60/0xa0 [realtek]
[ 121.831706] phy_init_hw+0x54/0x70
[ 121.831714] phy_attach_direct+0xd4/0x250
[ 121.831720] phy_connect_direct+0x20/0x70
[ 121.831728] phy_connect+0x54/0xa0
[ 121.831741] stmmac_init_phy+0x17c/0x200
[ 121.831748] stmmac_open+0x124/0xac0
[ 121.831759] __dev_open+0xd8/0x158
[ 121.831762] __dev_change_flags+0x164/0x1c8
[ 121.831766] dev_change_flags+0x20/0x60
[ 121.831774] do_setlink+0x288/0xba8
[ 121.831778] __rtnl_newlink+0x5cc/0x6e8
[ 121.831783] rtnl_newlink+0x48/0x70
[ 121.831786] rtnetlink_rcv_msg+0x120/0x368
[ 121.831807] netlink_rcv_skb+0x58/0x118
[ 121.831811] rtnetlink_rcv+0x14/0x20
[ 121.831816] netlink_unicast+0x180/0x1f8
[ 121.831822] netlink_sendmsg+0x190/0x330
[ 121.831837] sock_sendmsg+0x3c/0x58
[ 121.831844] ___sys_sendmsg+0x268/0x2a0
[ 121.831849] __sys_sendmsg+0x68/0xb8
[ 121.831855] __arm64_sys_sendmsg+0x20/0x28
[ 121.831864] el0_svc_common.constprop.0+0x7c/0xe8
[ 121.831870] el0_svc_handler+0x28/0x78
[ 121.831875] el0_svc+0x8/0xc
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking
2019-05-14 11:53 ` Peter Geis
@ 2019-05-14 16:19 ` Serge Semin
-1 siblings, 0 replies; 14+ messages in thread
From: Serge Semin @ 2019-05-14 16:19 UTC (permalink / raw)
To: Peter Geis
Cc: Heiner Kallweit, Andrew Lunn, Florian Fainelli, David S. Miller,
Serge Semin, netdev, linux-rockchip
Hello Peter
On Tue, May 14, 2019 at 07:53:21AM -0400, Peter Geis wrote:
> On Sun, May 12, 2019 at 3:34 AM Heiner Kallweit <hkallweit1@gmail.com> wrote:
> >
> > On 12.05.2019 04:50, Peter Geis wrote:
> > > On 5/11/2019 10:37 PM, Andrew Lunn wrote:
> > >> On Sat, May 11, 2019 at 07:17:08PM -0400, Peter Geis wrote:
> > >>> Good Evening,
> > >>>
> > >>> Commit f81dadbcf7fd067baf184b63c179fc392bdb226e "net: phy: realtek: Add
> > >>> rtl8211e rx/tx delays config" breaks networking completely on the
> > >>> rk3328-roc-cc.
> > >>> Reverting the offending commit solves the problem.
> > >>
> > >> Hi Peter
> > >>
> > >> The fix should be in net, and will soon make its way upwards.
> > >>
> > >> Andrew
> > >>
> > >
> > >
> > > Good Evening,
> > >
> > > Thanks, is there a link to the patch so I may test it?
> > >
> > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=daf3ddbe11a2ff74c95bc814df8e5fe3201b4cb5
> >
> > > Peter
> > >
> > Heiner
>
> This patch does correct the error message on boot, however networking
> is still completely broken.
> The current error is as follows:
>
> [ 121.829375] kworker/3:1 D 0 67 2 0x00000028
> [ 121.829398] Workqueue: events linkwatch_event
> [ 121.829403] Call trace:
> [ 121.829412] __switch_to+0xb8/0x1a8
> [ 121.829420] __schedule+0x220/0x560
> [ 121.829423] schedule+0x38/0xd8
> [ 121.829429] schedule_preempt_disabled+0x20/0x38
> [ 121.829435] __mutex_lock.isra.1+0x1c4/0x500
> [ 121.829438] __mutex_lock_slowpath+0x10/0x18
> [ 121.829443] mutex_lock+0x2c/0x38
> [ 121.829449] rtnl_lock+0x14/0x20
> [ 121.829453] linkwatch_event+0xc/0x38
> [ 121.829461] process_one_work+0x1e0/0x320
> [ 121.829466] worker_thread+0x40/0x428
> [ 121.829473] kthread+0x120/0x128
> [ 121.829476] ret_from_fork+0x10/0x18
> [ 121.829533] INFO: task NetworkManager:1833 blocked for more than 61 seconds.
> [ 121.830160] Not tainted
> 5.1.0-next-20190510test-00009-g3ed182aaa670-dirty #55
> [ 121.830831] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs"
> disables this message.
> [ 121.831589] NetworkManager D 0 1833 1 0x00000028
> [ 121.831601] Call trace:
> [ 121.831614] __switch_to+0xb8/0x1a8
> [ 121.831623] __schedule+0x220/0x560
> [ 121.831631] schedule+0x38/0xd8
> [ 121.831639] schedule_preempt_disabled+0x20/0x38
> [ 121.831647] __mutex_lock.isra.1+0x1c4/0x500
> [ 121.831666] __mutex_lock_slowpath+0x10/0x18
> [ 121.831671] mutex_lock+0x2c/0x38
> [ 121.831687] mdiobus_write+0x40/0x80
> [ 121.831698] rtl8211e_config_init+0x60/0xa0 [realtek]
> [ 121.831706] phy_init_hw+0x54/0x70
> [ 121.831714] phy_attach_direct+0xd4/0x250
> [ 121.831720] phy_connect_direct+0x20/0x70
> [ 121.831728] phy_connect+0x54/0xa0
> [ 121.831741] stmmac_init_phy+0x17c/0x200
> [ 121.831748] stmmac_open+0x124/0xac0
> [ 121.831759] __dev_open+0xd8/0x158
> [ 121.831762] __dev_change_flags+0x164/0x1c8
> [ 121.831766] dev_change_flags+0x20/0x60
> [ 121.831774] do_setlink+0x288/0xba8
> [ 121.831778] __rtnl_newlink+0x5cc/0x6e8
> [ 121.831783] rtnl_newlink+0x48/0x70
> [ 121.831786] rtnetlink_rcv_msg+0x120/0x368
> [ 121.831807] netlink_rcv_skb+0x58/0x118
> [ 121.831811] rtnetlink_rcv+0x14/0x20
> [ 121.831816] netlink_unicast+0x180/0x1f8
> [ 121.831822] netlink_sendmsg+0x190/0x330
> [ 121.831837] sock_sendmsg+0x3c/0x58
> [ 121.831844] ___sys_sendmsg+0x268/0x2a0
> [ 121.831849] __sys_sendmsg+0x68/0xb8
> [ 121.831855] __arm64_sys_sendmsg+0x20/0x28
> [ 121.831864] el0_svc_common.constprop.0+0x7c/0xe8
> [ 121.831870] el0_svc_handler+0x28/0x78
> [ 121.831875] el0_svc+0x8/0xc
Thanks for sending the report. The fix has already been found and applied
to the net-next:
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=dffe7d2e04670ff98e4dacf258df30446e2e80d4
-Sergey
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking
@ 2019-05-14 16:19 ` Serge Semin
0 siblings, 0 replies; 14+ messages in thread
From: Serge Semin @ 2019-05-14 16:19 UTC (permalink / raw)
To: Peter Geis
Cc: Heiner Kallweit, Andrew Lunn, Florian Fainelli, David S. Miller,
Serge Semin, netdev, linux-rockchip
Hello Peter
On Tue, May 14, 2019 at 07:53:21AM -0400, Peter Geis wrote:
> On Sun, May 12, 2019 at 3:34 AM Heiner Kallweit <hkallweit1@gmail.com> wrote:
> >
> > On 12.05.2019 04:50, Peter Geis wrote:
> > > On 5/11/2019 10:37 PM, Andrew Lunn wrote:
> > >> On Sat, May 11, 2019 at 07:17:08PM -0400, Peter Geis wrote:
> > >>> Good Evening,
> > >>>
> > >>> Commit f81dadbcf7fd067baf184b63c179fc392bdb226e "net: phy: realtek: Add
> > >>> rtl8211e rx/tx delays config" breaks networking completely on the
> > >>> rk3328-roc-cc.
> > >>> Reverting the offending commit solves the problem.
> > >>
> > >> Hi Peter
> > >>
> > >> The fix should be in net, and will soon make its way upwards.
> > >>
> > >> Andrew
> > >>
> > >
> > >
> > > Good Evening,
> > >
> > > Thanks, is there a link to the patch so I may test it?
> > >
> > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=daf3ddbe11a2ff74c95bc814df8e5fe3201b4cb5
> >
> > > Peter
> > >
> > Heiner
>
> This patch does correct the error message on boot, however networking
> is still completely broken.
> The current error is as follows:
>
> [ 121.829375] kworker/3:1 D 0 67 2 0x00000028
> [ 121.829398] Workqueue: events linkwatch_event
> [ 121.829403] Call trace:
> [ 121.829412] __switch_to+0xb8/0x1a8
> [ 121.829420] __schedule+0x220/0x560
> [ 121.829423] schedule+0x38/0xd8
> [ 121.829429] schedule_preempt_disabled+0x20/0x38
> [ 121.829435] __mutex_lock.isra.1+0x1c4/0x500
> [ 121.829438] __mutex_lock_slowpath+0x10/0x18
> [ 121.829443] mutex_lock+0x2c/0x38
> [ 121.829449] rtnl_lock+0x14/0x20
> [ 121.829453] linkwatch_event+0xc/0x38
> [ 121.829461] process_one_work+0x1e0/0x320
> [ 121.829466] worker_thread+0x40/0x428
> [ 121.829473] kthread+0x120/0x128
> [ 121.829476] ret_from_fork+0x10/0x18
> [ 121.829533] INFO: task NetworkManager:1833 blocked for more than 61 seconds.
> [ 121.830160] Not tainted
> 5.1.0-next-20190510test-00009-g3ed182aaa670-dirty #55
> [ 121.830831] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs"
> disables this message.
> [ 121.831589] NetworkManager D 0 1833 1 0x00000028
> [ 121.831601] Call trace:
> [ 121.831614] __switch_to+0xb8/0x1a8
> [ 121.831623] __schedule+0x220/0x560
> [ 121.831631] schedule+0x38/0xd8
> [ 121.831639] schedule_preempt_disabled+0x20/0x38
> [ 121.831647] __mutex_lock.isra.1+0x1c4/0x500
> [ 121.831666] __mutex_lock_slowpath+0x10/0x18
> [ 121.831671] mutex_lock+0x2c/0x38
> [ 121.831687] mdiobus_write+0x40/0x80
> [ 121.831698] rtl8211e_config_init+0x60/0xa0 [realtek]
> [ 121.831706] phy_init_hw+0x54/0x70
> [ 121.831714] phy_attach_direct+0xd4/0x250
> [ 121.831720] phy_connect_direct+0x20/0x70
> [ 121.831728] phy_connect+0x54/0xa0
> [ 121.831741] stmmac_init_phy+0x17c/0x200
> [ 121.831748] stmmac_open+0x124/0xac0
> [ 121.831759] __dev_open+0xd8/0x158
> [ 121.831762] __dev_change_flags+0x164/0x1c8
> [ 121.831766] dev_change_flags+0x20/0x60
> [ 121.831774] do_setlink+0x288/0xba8
> [ 121.831778] __rtnl_newlink+0x5cc/0x6e8
> [ 121.831783] rtnl_newlink+0x48/0x70
> [ 121.831786] rtnetlink_rcv_msg+0x120/0x368
> [ 121.831807] netlink_rcv_skb+0x58/0x118
> [ 121.831811] rtnetlink_rcv+0x14/0x20
> [ 121.831816] netlink_unicast+0x180/0x1f8
> [ 121.831822] netlink_sendmsg+0x190/0x330
> [ 121.831837] sock_sendmsg+0x3c/0x58
> [ 121.831844] ___sys_sendmsg+0x268/0x2a0
> [ 121.831849] __sys_sendmsg+0x68/0xb8
> [ 121.831855] __arm64_sys_sendmsg+0x20/0x28
> [ 121.831864] el0_svc_common.constprop.0+0x7c/0xe8
> [ 121.831870] el0_svc_handler+0x28/0x78
> [ 121.831875] el0_svc+0x8/0xc
Thanks for sending the report. The fix has already been found and applied
to the net-next:
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=dffe7d2e04670ff98e4dacf258df30446e2e80d4
-Sergey
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking
2019-05-14 16:19 ` Serge Semin
@ 2019-05-18 12:06 ` Peter Geis
-1 siblings, 0 replies; 14+ messages in thread
From: Peter Geis @ 2019-05-18 12:06 UTC (permalink / raw)
To: Serge Semin
Cc: Heiner Kallweit, Andrew Lunn, Florian Fainelli, David S. Miller,
Serge Semin, netdev, linux-rockchip
On Tue, May 14, 2019 at 12:20 PM Serge Semin <fancer.lancer@gmail.com> wrote:
>
> Hello Peter
>
> On Tue, May 14, 2019 at 07:53:21AM -0400, Peter Geis wrote:
> > On Sun, May 12, 2019 at 3:34 AM Heiner Kallweit <hkallweit1@gmail.com> wrote:
> > >
> > > On 12.05.2019 04:50, Peter Geis wrote:
> > > > On 5/11/2019 10:37 PM, Andrew Lunn wrote:
> > > >> On Sat, May 11, 2019 at 07:17:08PM -0400, Peter Geis wrote:
> > > >>> Good Evening,
> > > >>>
> > > >>> Commit f81dadbcf7fd067baf184b63c179fc392bdb226e "net: phy: realtek: Add
> > > >>> rtl8211e rx/tx delays config" breaks networking completely on the
> > > >>> rk3328-roc-cc.
> > > >>> Reverting the offending commit solves the problem.
> > > >>
> > > >> Hi Peter
> > > >>
> > > >> The fix should be in net, and will soon make its way upwards.
> > > >>
> > > >> Andrew
> > > >>
> > > >
> > > >
> > > > Good Evening,
> > > >
> > > > Thanks, is there a link to the patch so I may test it?
> > > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=daf3ddbe11a2ff74c95bc814df8e5fe3201b4cb5
> > >
> > > > Peter
> > > >
> > > Heiner
> >
> > This patch does correct the error message on boot, however networking
> > is still completely broken.
> > The current error is as follows:
> >
> > [ 121.829375] kworker/3:1 D 0 67 2 0x00000028
> > [ 121.829398] Workqueue: events linkwatch_event
> > [ 121.829403] Call trace:
> > [ 121.829412] __switch_to+0xb8/0x1a8
> > [ 121.829420] __schedule+0x220/0x560
> > [ 121.829423] schedule+0x38/0xd8
> > [ 121.829429] schedule_preempt_disabled+0x20/0x38
> > [ 121.829435] __mutex_lock.isra.1+0x1c4/0x500
> > [ 121.829438] __mutex_lock_slowpath+0x10/0x18
> > [ 121.829443] mutex_lock+0x2c/0x38
> > [ 121.829449] rtnl_lock+0x14/0x20
> > [ 121.829453] linkwatch_event+0xc/0x38
> > [ 121.829461] process_one_work+0x1e0/0x320
> > [ 121.829466] worker_thread+0x40/0x428
> > [ 121.829473] kthread+0x120/0x128
> > [ 121.829476] ret_from_fork+0x10/0x18
> > [ 121.829533] INFO: task NetworkManager:1833 blocked for more than 61 seconds.
> > [ 121.830160] Not tainted
> > 5.1.0-next-20190510test-00009-g3ed182aaa670-dirty #55
> > [ 121.830831] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs"
> > disables this message.
> > [ 121.831589] NetworkManager D 0 1833 1 0x00000028
> > [ 121.831601] Call trace:
> > [ 121.831614] __switch_to+0xb8/0x1a8
> > [ 121.831623] __schedule+0x220/0x560
> > [ 121.831631] schedule+0x38/0xd8
> > [ 121.831639] schedule_preempt_disabled+0x20/0x38
> > [ 121.831647] __mutex_lock.isra.1+0x1c4/0x500
> > [ 121.831666] __mutex_lock_slowpath+0x10/0x18
> > [ 121.831671] mutex_lock+0x2c/0x38
> > [ 121.831687] mdiobus_write+0x40/0x80
> > [ 121.831698] rtl8211e_config_init+0x60/0xa0 [realtek]
> > [ 121.831706] phy_init_hw+0x54/0x70
> > [ 121.831714] phy_attach_direct+0xd4/0x250
> > [ 121.831720] phy_connect_direct+0x20/0x70
> > [ 121.831728] phy_connect+0x54/0xa0
> > [ 121.831741] stmmac_init_phy+0x17c/0x200
> > [ 121.831748] stmmac_open+0x124/0xac0
> > [ 121.831759] __dev_open+0xd8/0x158
> > [ 121.831762] __dev_change_flags+0x164/0x1c8
> > [ 121.831766] dev_change_flags+0x20/0x60
> > [ 121.831774] do_setlink+0x288/0xba8
> > [ 121.831778] __rtnl_newlink+0x5cc/0x6e8
> > [ 121.831783] rtnl_newlink+0x48/0x70
> > [ 121.831786] rtnetlink_rcv_msg+0x120/0x368
> > [ 121.831807] netlink_rcv_skb+0x58/0x118
> > [ 121.831811] rtnetlink_rcv+0x14/0x20
> > [ 121.831816] netlink_unicast+0x180/0x1f8
> > [ 121.831822] netlink_sendmsg+0x190/0x330
> > [ 121.831837] sock_sendmsg+0x3c/0x58
> > [ 121.831844] ___sys_sendmsg+0x268/0x2a0
> > [ 121.831849] __sys_sendmsg+0x68/0xb8
> > [ 121.831855] __arm64_sys_sendmsg+0x20/0x28
> > [ 121.831864] el0_svc_common.constprop.0+0x7c/0xe8
> > [ 121.831870] el0_svc_handler+0x28/0x78
> > [ 121.831875] el0_svc+0x8/0xc
>
> Thanks for sending the report. The fix has already been found and applied
> to the net-next:
> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=dffe7d2e04670ff98e4dacf258df30446e2e80d4
>
> -Sergey
Thanks, this fixes networking, but there are now complaints about
leaking references.
[ 59.504597] ------------[ cut here ]------------
[ 59.504613] remove_proc_entry: removing non-empty directory
'net/rpc', leaking at least 'use-gss-proxy'
[ 59.504677] WARNING: CPU: 3 PID: 7 at fs/proc/generic.c:683
remove_proc_entry+0x178/0x188
[ 59.504682] Modules linked in: fuse bridge stp llc
snd_soc_hdmi_codec dw_hdmi_i2s_audio aes_ce_blk crypto_simd
aes_ce_cipher crct10dif_ce ghash_ce aes_arm64 sha2_ce sha256_arm64
sha1_ce rockchipdrm pwm_fan dw_hdmi lima snd_soc_simple_card
snd_soc_simple_card_utils drm_kms_helper gpu_sched drm
snd_soc_rockchip_i2s drm_panel_orientation_quirks snd_soc_rockchip_pcm
squashfs sch_fq_codel ip_tables x_tables ipv6 crc_ccitt btrfs xor
xor_neon zstd_compress raid6_pq libcrc32c zstd_decompress rtc_rk808
realtek
[ 59.504768] CPU: 3 PID: 7 Comm: kworker/u8:0 Not tainted
5.1.0-next-20190514test-13354-gfd862c6fd105 #57
[ 59.504770] Hardware name: Firefly roc-rk3328-cc (DT)
[ 59.504790] Workqueue: netns cleanup_net
[ 59.504794] pstate: 40400005 (nZcv daif +PAN -UAO)
[ 59.504801] pc : remove_proc_entry+0x178/0x188
[ 59.504805] lr : remove_proc_entry+0x178/0x188
[ 59.504807] sp : ffff00001120fc80
[ 59.504809] x29: ffff00001120fc80 x28: 0000000000000000
[ 59.504814] x27: ffff800003284b38 x26: ffff000010c2ba00
[ 59.504818] x25: 0000000000000000 x24: ffff80000ababc50
[ 59.504822] x23: ffff8000036e5640 x22: ffff8000036e56eb
[ 59.504825] x21: ffff8000036e8feb x20: ffff000010f03688
[ 59.504829] x19: ffff8000036e8f40 x18: ffff000010f17000
[ 59.504833] x17: 0000000000000001 x16: 0000000000000007
[ 59.504836] x15: 00000000fffffff0 x14: 696b61656c202c27
[ 59.504840] x13: 6370722f74656e27 x12: 2079726f74636572
[ 59.504845] x11: 6964207974706d65 x10: 2d6e6f6e20676e69
[ 59.504849] x9 : 0000000000000000 x8 : 0000000000000004
[ 59.504853] x7 : 00000000000001c0 x6 : ffff000010ff5000
[ 59.504856] x5 : 0000000000000001 x4 : ffff8000fead22a8
[ 59.504860] x3 : ffff8000fead22a8 x2 : 0000000000000007
[ 59.504864] x1 : e5b404e852ff9000 x0 : 0000000000000000
[ 59.504868] Call trace:
[ 59.504874] remove_proc_entry+0x178/0x188
[ 59.504884] rpc_proc_exit+0x18/0x20
[ 59.504906] sunrpc_exit_net+0x48/0x70
[ 59.504915] ops_exit_list.isra.0+0x44/0x78
[ 59.504918] cleanup_net+0x1a8/0x2c0
[ 59.504934] process_one_work+0x1e0/0x320
[ 59.504939] worker_thread+0x40/0x428
[ 59.504948] kthread+0x120/0x128
[ 59.504955] ret_from_fork+0x10/0x18
[ 59.504962] ---[ end trace 66885a1575002df1 ]---
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking
@ 2019-05-18 12:06 ` Peter Geis
0 siblings, 0 replies; 14+ messages in thread
From: Peter Geis @ 2019-05-18 12:06 UTC (permalink / raw)
To: Serge Semin
Cc: Andrew Lunn, Florian Fainelli, Serge Semin,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, David S. Miller,
Heiner Kallweit
On Tue, May 14, 2019 at 12:20 PM Serge Semin <fancer.lancer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> Hello Peter
>
> On Tue, May 14, 2019 at 07:53:21AM -0400, Peter Geis wrote:
> > On Sun, May 12, 2019 at 3:34 AM Heiner Kallweit <hkallweit1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > >
> > > On 12.05.2019 04:50, Peter Geis wrote:
> > > > On 5/11/2019 10:37 PM, Andrew Lunn wrote:
> > > >> On Sat, May 11, 2019 at 07:17:08PM -0400, Peter Geis wrote:
> > > >>> Good Evening,
> > > >>>
> > > >>> Commit f81dadbcf7fd067baf184b63c179fc392bdb226e "net: phy: realtek: Add
> > > >>> rtl8211e rx/tx delays config" breaks networking completely on the
> > > >>> rk3328-roc-cc.
> > > >>> Reverting the offending commit solves the problem.
> > > >>
> > > >> Hi Peter
> > > >>
> > > >> The fix should be in net, and will soon make its way upwards.
> > > >>
> > > >> Andrew
> > > >>
> > > >
> > > >
> > > > Good Evening,
> > > >
> > > > Thanks, is there a link to the patch so I may test it?
> > > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=daf3ddbe11a2ff74c95bc814df8e5fe3201b4cb5
> > >
> > > > Peter
> > > >
> > > Heiner
> >
> > This patch does correct the error message on boot, however networking
> > is still completely broken.
> > The current error is as follows:
> >
> > [ 121.829375] kworker/3:1 D 0 67 2 0x00000028
> > [ 121.829398] Workqueue: events linkwatch_event
> > [ 121.829403] Call trace:
> > [ 121.829412] __switch_to+0xb8/0x1a8
> > [ 121.829420] __schedule+0x220/0x560
> > [ 121.829423] schedule+0x38/0xd8
> > [ 121.829429] schedule_preempt_disabled+0x20/0x38
> > [ 121.829435] __mutex_lock.isra.1+0x1c4/0x500
> > [ 121.829438] __mutex_lock_slowpath+0x10/0x18
> > [ 121.829443] mutex_lock+0x2c/0x38
> > [ 121.829449] rtnl_lock+0x14/0x20
> > [ 121.829453] linkwatch_event+0xc/0x38
> > [ 121.829461] process_one_work+0x1e0/0x320
> > [ 121.829466] worker_thread+0x40/0x428
> > [ 121.829473] kthread+0x120/0x128
> > [ 121.829476] ret_from_fork+0x10/0x18
> > [ 121.829533] INFO: task NetworkManager:1833 blocked for more than 61 seconds.
> > [ 121.830160] Not tainted
> > 5.1.0-next-20190510test-00009-g3ed182aaa670-dirty #55
> > [ 121.830831] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs"
> > disables this message.
> > [ 121.831589] NetworkManager D 0 1833 1 0x00000028
> > [ 121.831601] Call trace:
> > [ 121.831614] __switch_to+0xb8/0x1a8
> > [ 121.831623] __schedule+0x220/0x560
> > [ 121.831631] schedule+0x38/0xd8
> > [ 121.831639] schedule_preempt_disabled+0x20/0x38
> > [ 121.831647] __mutex_lock.isra.1+0x1c4/0x500
> > [ 121.831666] __mutex_lock_slowpath+0x10/0x18
> > [ 121.831671] mutex_lock+0x2c/0x38
> > [ 121.831687] mdiobus_write+0x40/0x80
> > [ 121.831698] rtl8211e_config_init+0x60/0xa0 [realtek]
> > [ 121.831706] phy_init_hw+0x54/0x70
> > [ 121.831714] phy_attach_direct+0xd4/0x250
> > [ 121.831720] phy_connect_direct+0x20/0x70
> > [ 121.831728] phy_connect+0x54/0xa0
> > [ 121.831741] stmmac_init_phy+0x17c/0x200
> > [ 121.831748] stmmac_open+0x124/0xac0
> > [ 121.831759] __dev_open+0xd8/0x158
> > [ 121.831762] __dev_change_flags+0x164/0x1c8
> > [ 121.831766] dev_change_flags+0x20/0x60
> > [ 121.831774] do_setlink+0x288/0xba8
> > [ 121.831778] __rtnl_newlink+0x5cc/0x6e8
> > [ 121.831783] rtnl_newlink+0x48/0x70
> > [ 121.831786] rtnetlink_rcv_msg+0x120/0x368
> > [ 121.831807] netlink_rcv_skb+0x58/0x118
> > [ 121.831811] rtnetlink_rcv+0x14/0x20
> > [ 121.831816] netlink_unicast+0x180/0x1f8
> > [ 121.831822] netlink_sendmsg+0x190/0x330
> > [ 121.831837] sock_sendmsg+0x3c/0x58
> > [ 121.831844] ___sys_sendmsg+0x268/0x2a0
> > [ 121.831849] __sys_sendmsg+0x68/0xb8
> > [ 121.831855] __arm64_sys_sendmsg+0x20/0x28
> > [ 121.831864] el0_svc_common.constprop.0+0x7c/0xe8
> > [ 121.831870] el0_svc_handler+0x28/0x78
> > [ 121.831875] el0_svc+0x8/0xc
>
> Thanks for sending the report. The fix has already been found and applied
> to the net-next:
> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=dffe7d2e04670ff98e4dacf258df30446e2e80d4
>
> -Sergey
Thanks, this fixes networking, but there are now complaints about
leaking references.
[ 59.504597] ------------[ cut here ]------------
[ 59.504613] remove_proc_entry: removing non-empty directory
'net/rpc', leaking at least 'use-gss-proxy'
[ 59.504677] WARNING: CPU: 3 PID: 7 at fs/proc/generic.c:683
remove_proc_entry+0x178/0x188
[ 59.504682] Modules linked in: fuse bridge stp llc
snd_soc_hdmi_codec dw_hdmi_i2s_audio aes_ce_blk crypto_simd
aes_ce_cipher crct10dif_ce ghash_ce aes_arm64 sha2_ce sha256_arm64
sha1_ce rockchipdrm pwm_fan dw_hdmi lima snd_soc_simple_card
snd_soc_simple_card_utils drm_kms_helper gpu_sched drm
snd_soc_rockchip_i2s drm_panel_orientation_quirks snd_soc_rockchip_pcm
squashfs sch_fq_codel ip_tables x_tables ipv6 crc_ccitt btrfs xor
xor_neon zstd_compress raid6_pq libcrc32c zstd_decompress rtc_rk808
realtek
[ 59.504768] CPU: 3 PID: 7 Comm: kworker/u8:0 Not tainted
5.1.0-next-20190514test-13354-gfd862c6fd105 #57
[ 59.504770] Hardware name: Firefly roc-rk3328-cc (DT)
[ 59.504790] Workqueue: netns cleanup_net
[ 59.504794] pstate: 40400005 (nZcv daif +PAN -UAO)
[ 59.504801] pc : remove_proc_entry+0x178/0x188
[ 59.504805] lr : remove_proc_entry+0x178/0x188
[ 59.504807] sp : ffff00001120fc80
[ 59.504809] x29: ffff00001120fc80 x28: 0000000000000000
[ 59.504814] x27: ffff800003284b38 x26: ffff000010c2ba00
[ 59.504818] x25: 0000000000000000 x24: ffff80000ababc50
[ 59.504822] x23: ffff8000036e5640 x22: ffff8000036e56eb
[ 59.504825] x21: ffff8000036e8feb x20: ffff000010f03688
[ 59.504829] x19: ffff8000036e8f40 x18: ffff000010f17000
[ 59.504833] x17: 0000000000000001 x16: 0000000000000007
[ 59.504836] x15: 00000000fffffff0 x14: 696b61656c202c27
[ 59.504840] x13: 6370722f74656e27 x12: 2079726f74636572
[ 59.504845] x11: 6964207974706d65 x10: 2d6e6f6e20676e69
[ 59.504849] x9 : 0000000000000000 x8 : 0000000000000004
[ 59.504853] x7 : 00000000000001c0 x6 : ffff000010ff5000
[ 59.504856] x5 : 0000000000000001 x4 : ffff8000fead22a8
[ 59.504860] x3 : ffff8000fead22a8 x2 : 0000000000000007
[ 59.504864] x1 : e5b404e852ff9000 x0 : 0000000000000000
[ 59.504868] Call trace:
[ 59.504874] remove_proc_entry+0x178/0x188
[ 59.504884] rpc_proc_exit+0x18/0x20
[ 59.504906] sunrpc_exit_net+0x48/0x70
[ 59.504915] ops_exit_list.isra.0+0x44/0x78
[ 59.504918] cleanup_net+0x1a8/0x2c0
[ 59.504934] process_one_work+0x1e0/0x320
[ 59.504939] worker_thread+0x40/0x428
[ 59.504948] kthread+0x120/0x128
[ 59.504955] ret_from_fork+0x10/0x18
[ 59.504962] ---[ end trace 66885a1575002df1 ]---
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-05-18 12:06 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-11 23:17 [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking Peter Geis
2019-05-11 23:17 ` Peter Geis
2019-05-12 2:37 ` Andrew Lunn
2019-05-12 2:37 ` Andrew Lunn
2019-05-12 2:50 ` Peter Geis
2019-05-12 2:50 ` Peter Geis
2019-05-12 7:34 ` Heiner Kallweit
2019-05-12 7:34 ` Heiner Kallweit
2019-05-14 11:53 ` Peter Geis
2019-05-14 11:53 ` Peter Geis
2019-05-14 16:19 ` Serge Semin
2019-05-14 16:19 ` Serge Semin
2019-05-18 12:06 ` Peter Geis
2019-05-18 12:06 ` Peter Geis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.