* [PATCH v3] drivers: staging : wlan-ng : collect return status without variable
@ 2019-05-12 10:53 Hariprasad Kelam
2019-05-13 8:24 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Hariprasad Kelam @ 2019-05-12 10:53 UTC (permalink / raw)
To: dan.carpenter, Greg Kroah-Hartman, Tim Collier, Chris Opperman,
Hariprasad Kelam, devel, linux-kernel
As caller rdev_set_default_key not particular about -EFAULT.
We can preserve the return value of prism2_domibset_uint32.
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
----
Changes in v2:
- remove masking of original return value with EFAULT
Changes in v3:
- merge patch v1 and v2 sothat it can be applied on linux-next
---
drivers/staging/wlan-ng/cfg80211.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index 8a862f7..eee1998 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -231,17 +231,9 @@ static int prism2_set_default_key(struct wiphy *wiphy, struct net_device *dev,
{
struct wlandevice *wlandev = dev->ml_priv;
- int err = 0;
- int result = 0;
-
- result = prism2_domibset_uint32(wlandev,
- DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID,
- key_index);
-
- if (result)
- err = -EFAULT;
-
- return err;
+ return prism2_domibset_uint32(wlandev,
+ DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID,
+ key_index);
}
static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] drivers: staging : wlan-ng : collect return status without variable
2019-05-12 10:53 [PATCH v3] drivers: staging : wlan-ng : collect return status without variable Hariprasad Kelam
@ 2019-05-13 8:24 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2019-05-13 8:24 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: Greg Kroah-Hartman, Tim Collier, Chris Opperman, devel, linux-kernel
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-13 8:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-12 10:53 [PATCH v3] drivers: staging : wlan-ng : collect return status without variable Hariprasad Kelam
2019-05-13 8:24 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.