* [PATCH] drm/hdcp: drm_hdcp_request_srm() as static
@ 2019-05-13 13:35 Ramalingam C
2019-05-13 14:51 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Ramalingam C @ 2019-05-13 13:35 UTC (permalink / raw)
To: intel-gfx, dri-devel, daniel.vetter
Below Sparsh warnings are fixed.
Commit: drm: revocation check at drm subsystem
+drivers/gpu/drm/drm_hdcp.c:235:6: warning: symbol
'drm_hdcp_request_srm' was not declared. Should it be static?
+drivers/gpu/drm/drm_hdcp.c:27:3: warning: symbol 'srm_data' was not
declared. Should it be static?
+drivers/gpu/drm/drm_hdcp.c:317:5: warning: symbol 'drm_setup_hdcp_srm'
was not declared. Should it be static?
+drivers/gpu/drm/drm_hdcp.c:327:6: warning: symbol
'drm_teardown_hdcp_srm' was not declared. Should it be static?
cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
---
drivers/gpu/drm/drm_hdcp.c | 6 ++++--
drivers/gpu/drm/drm_internal.h | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_hdcp.c b/drivers/gpu/drm/drm_hdcp.c
index 0da7b3718bad..cd837bd409f7 100644
--- a/drivers/gpu/drm/drm_hdcp.c
+++ b/drivers/gpu/drm/drm_hdcp.c
@@ -21,7 +21,9 @@
#include <drm/drm_mode_object.h>
#include <drm/drm_connector.h>
-struct hdcp_srm {
+#include "drm_internal.h"
+
+static struct hdcp_srm {
u32 revoked_ksv_cnt;
u8 *revoked_ksv_list;
@@ -235,7 +237,7 @@ static void drm_hdcp_srm_update(const u8 *buf, size_t count)
drm_hdcp_parse_hdcp2_srm(buf, count);
}
-void drm_hdcp_request_srm(struct drm_device *drm_dev)
+static void drm_hdcp_request_srm(struct drm_device *drm_dev)
{
char fw_name[36] = "display_hdcp_srm.bin";
const struct firmware *fw;
diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h
index 476a422414f6..65abf3a69b40 100644
--- a/drivers/gpu/drm/drm_internal.h
+++ b/drivers/gpu/drm/drm_internal.h
@@ -106,6 +106,7 @@ void drm_sysfs_connector_remove(struct drm_connector *connector);
void drm_sysfs_lease_event(struct drm_device *dev);
/* drm_gem.c */
+struct drm_gem_object;
int drm_gem_init(struct drm_device *dev);
void drm_gem_destroy(struct drm_device *dev);
int drm_gem_handle_create_tail(struct drm_file *file_priv,
--
2.19.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✗ Fi.CI.SPARSE: warning for drm/hdcp: drm_hdcp_request_srm() as static
2019-05-13 13:35 [PATCH] drm/hdcp: drm_hdcp_request_srm() as static Ramalingam C
@ 2019-05-13 14:51 ` Patchwork
2019-05-13 15:41 ` ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-05-13 14:51 UTC (permalink / raw)
To: Ramalingam C; +Cc: intel-gfx
== Series Details ==
Series: drm/hdcp: drm_hdcp_request_srm() as static
URL : https://patchwork.freedesktop.org/series/60580/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/hdcp: drm_hdcp_request_srm() as static
-O:drivers/gpu/drm/drm_hdcp.c:238:6: warning: symbol 'drm_hdcp_request_srm' was not declared. Should it be static?
-drivers/gpu/drm/drm_hdcp.c:32:3: warning: symbol 'srm_data' was not declared. Should it be static?
-drivers/gpu/drm/drm_hdcp.c:322:5: warning: symbol 'drm_setup_hdcp_srm' was not declared. Should it be static?
-drivers/gpu/drm/drm_hdcp.c:332:6: warning: symbol 'drm_teardown_hdcp_srm' was not declared. Should it be static?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/hdcp: drm_hdcp_request_srm() as static
2019-05-13 13:35 [PATCH] drm/hdcp: drm_hdcp_request_srm() as static Ramalingam C
2019-05-13 14:51 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
@ 2019-05-13 15:41 ` Patchwork
2019-05-13 19:26 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-13 20:06 ` [PATCH] " Daniel Vetter
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-05-13 15:41 UTC (permalink / raw)
To: Ramalingam C; +Cc: intel-gfx
== Series Details ==
Series: drm/hdcp: drm_hdcp_request_srm() as static
URL : https://patchwork.freedesktop.org/series/60580/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6076 -> Patchwork_13007
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/
Known issues
------------
Here are the changes found in Patchwork_13007 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [PASS][1] -> [DMESG-FAIL][2] ([fdo#110235])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
- fi-skl-gvtdvm: [PASS][3] -> [DMESG-FAIL][4] ([fdo#110235])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
#### Possible fixes ####
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: [INCOMPLETE][5] ([fdo#108602] / [fdo#108744]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
* igt@kms_chamelium@dp-crc-fast:
- {fi-cml-u2}: [FAIL][7] ([fdo#110627]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
[fdo#110627]: https://bugs.freedesktop.org/show_bug.cgi?id=110627
Participating hosts (52 -> 46)
------------------------------
Additional (1): fi-pnv-d510
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_6076 -> Patchwork_13007
CI_DRM_6076: 71dc43d6470737153d1859ea941436fc39f8fbc2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4983: 7455cff58bfaba946b70e62e354851feb5f55f3a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13007: 8fb6403c45343446857827ef756ae9e2e34a420b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
8fb6403c4534 drm/hdcp: drm_hdcp_request_srm() as static
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.IGT: success for drm/hdcp: drm_hdcp_request_srm() as static
2019-05-13 13:35 [PATCH] drm/hdcp: drm_hdcp_request_srm() as static Ramalingam C
2019-05-13 14:51 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-05-13 15:41 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-05-13 19:26 ` Patchwork
2019-05-13 20:06 ` [PATCH] " Daniel Vetter
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-05-13 19:26 UTC (permalink / raw)
To: Ramalingam C; +Cc: intel-gfx
== Series Details ==
Series: drm/hdcp: drm_hdcp_request_srm() as static
URL : https://patchwork.freedesktop.org/series/60580/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6076_full -> Patchwork_13007_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_13007_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] ([fdo#108566]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-apl5/igt@i915_suspend@debugfs-reader.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-apl6/igt@i915_suspend@debugfs-reader.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109349])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-iclb7/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-iclb: [PASS][5] -> [FAIL][6] ([fdo#103167]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-snb: [PASS][7] -> [DMESG-WARN][8] ([fdo#102365])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-snb5/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-snb5/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109441])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-iclb7/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][11] -> [FAIL][12] ([fdo#99912])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-apl6/igt@kms_setmode@basic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-apl7/igt@kms_setmode@basic.html
#### Possible fixes ####
* igt@gem_ctx_isolation@vcs0-s3:
- shard-skl: [INCOMPLETE][13] ([fdo#104108] / [fdo#107773]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-skl7/igt@gem_ctx_isolation@vcs0-s3.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-skl4/igt@gem_ctx_isolation@vcs0-s3.html
* igt@i915_pm_rpm@system-suspend-devices:
- shard-skl: [INCOMPLETE][15] ([fdo#107807]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-skl9/igt@i915_pm_rpm@system-suspend-devices.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-skl8/igt@i915_pm_rpm@system-suspend-devices.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [FAIL][17] ([fdo#104873]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-glk8/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-glk1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-glk: [FAIL][19] ([fdo#103060]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-glk6/igt@kms_flip@2x-modeset-vs-vblank-race-interruptible.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-glk5/igt@kms_flip@2x-modeset-vs-vblank-race-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [FAIL][21] ([fdo#105363]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-fences:
- shard-kbl: [DMESG-WARN][23] ([fdo#103558] / [fdo#105602]) -> [PASS][24] +18 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-kbl7/igt@kms_flip@flip-vs-fences.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-kbl3/igt@kms_flip@flip-vs-fences.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: [FAIL][25] ([fdo#103167]) -> [PASS][26] +8 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-apl: [DMESG-WARN][27] ([fdo#108566]) -> [PASS][28] +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-apl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][29] ([fdo#108145]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [FAIL][31] ([fdo#103166]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [SKIP][33] ([fdo#109441]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-iclb1/igt@kms_psr@psr2_primary_blt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-iclb2/igt@kms_psr@psr2_primary_blt.html
* igt@perf_pmu@rc6:
- shard-kbl: [SKIP][35] ([fdo#109271]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-kbl2/igt@perf_pmu@rc6.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-kbl3/igt@perf_pmu@rc6.html
#### Warnings ####
* igt@kms_busy@basic-flip-f:
- shard-apl: [INCOMPLETE][37] ([fdo#103927]) -> [SKIP][38] ([fdo#109271] / [fdo#109278])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-apl4/igt@kms_busy@basic-flip-f.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-apl4/igt@kms_busy@basic-flip-f.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-gtt:
- shard-kbl: [SKIP][39] ([fdo#105602] / [fdo#109271]) -> [SKIP][40] ([fdo#109271]) +8 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-kbl7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-kbl3/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d:
- shard-kbl: [SKIP][41] ([fdo#105602] / [fdo#109271] / [fdo#109278]) -> [SKIP][42] ([fdo#109271] / [fdo#109278])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6076/shard-kbl4/igt@kms_pipe_crc_basic@read-crc-pipe-d.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/shard-kbl1/igt@kms_pipe_crc_basic@read-crc-pipe-d.html
[fdo#102365]: https://bugs.freedesktop.org/show_bug.cgi?id=102365
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_6076 -> Patchwork_13007
CI_DRM_6076: 71dc43d6470737153d1859ea941436fc39f8fbc2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4983: 7455cff58bfaba946b70e62e354851feb5f55f3a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13007: 8fb6403c45343446857827ef756ae9e2e34a420b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13007/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/hdcp: drm_hdcp_request_srm() as static
2019-05-13 13:35 [PATCH] drm/hdcp: drm_hdcp_request_srm() as static Ramalingam C
` (2 preceding siblings ...)
2019-05-13 19:26 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-05-13 20:06 ` Daniel Vetter
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2019-05-13 20:06 UTC (permalink / raw)
To: Ramalingam C; +Cc: daniel.vetter, intel-gfx, dri-devel
On Mon, May 13, 2019 at 07:05:04PM +0530, Ramalingam C wrote:
> Below Sparsh warnings are fixed.
>
> Commit: drm: revocation check at drm subsystem
> +drivers/gpu/drm/drm_hdcp.c:235:6: warning: symbol
> 'drm_hdcp_request_srm' was not declared. Should it be static?
> +drivers/gpu/drm/drm_hdcp.c:27:3: warning: symbol 'srm_data' was not
> declared. Should it be static?
> +drivers/gpu/drm/drm_hdcp.c:317:5: warning: symbol 'drm_setup_hdcp_srm'
> was not declared. Should it be static?
> +drivers/gpu/drm/drm_hdcp.c:327:6: warning: symbol
> 'drm_teardown_hdcp_srm' was not declared. Should it be static?
>
> cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
Merged with Dave's irc ack into drm-intel-next-queued, thanks for your
quick fix.
-Daniel
> ---
> drivers/gpu/drm/drm_hdcp.c | 6 ++++--
> drivers/gpu/drm/drm_internal.h | 1 +
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_hdcp.c b/drivers/gpu/drm/drm_hdcp.c
> index 0da7b3718bad..cd837bd409f7 100644
> --- a/drivers/gpu/drm/drm_hdcp.c
> +++ b/drivers/gpu/drm/drm_hdcp.c
> @@ -21,7 +21,9 @@
> #include <drm/drm_mode_object.h>
> #include <drm/drm_connector.h>
>
> -struct hdcp_srm {
> +#include "drm_internal.h"
> +
> +static struct hdcp_srm {
> u32 revoked_ksv_cnt;
> u8 *revoked_ksv_list;
>
> @@ -235,7 +237,7 @@ static void drm_hdcp_srm_update(const u8 *buf, size_t count)
> drm_hdcp_parse_hdcp2_srm(buf, count);
> }
>
> -void drm_hdcp_request_srm(struct drm_device *drm_dev)
> +static void drm_hdcp_request_srm(struct drm_device *drm_dev)
> {
> char fw_name[36] = "display_hdcp_srm.bin";
> const struct firmware *fw;
> diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h
> index 476a422414f6..65abf3a69b40 100644
> --- a/drivers/gpu/drm/drm_internal.h
> +++ b/drivers/gpu/drm/drm_internal.h
> @@ -106,6 +106,7 @@ void drm_sysfs_connector_remove(struct drm_connector *connector);
> void drm_sysfs_lease_event(struct drm_device *dev);
>
> /* drm_gem.c */
> +struct drm_gem_object;
> int drm_gem_init(struct drm_device *dev);
> void drm_gem_destroy(struct drm_device *dev);
> int drm_gem_handle_create_tail(struct drm_file *file_priv,
> --
> 2.19.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-13 20:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13 13:35 [PATCH] drm/hdcp: drm_hdcp_request_srm() as static Ramalingam C
2019-05-13 14:51 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-05-13 15:41 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-13 19:26 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-13 20:06 ` [PATCH] " Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.