From: keescook at chromium.org (Kees Cook)
Subject: next-20190510 kselftest results
Date: Tue, 14 May 2019 08:46:14 -0700 [thread overview]
Message-ID: <201905140843.B972AA13B6@keescook> (raw)
In-Reply-To: <CADYN=9+nwM4Kw-PWHHDpQ5hpf=N5N8Ewy=h7Y2RTyO5Kwak88A@mail.gmail.com>
On Tue, May 14, 2019 at 05:28:45PM +0200, Anders Roxell wrote:
> On Sat, 11 May 2019 at 16:51, Kees Cook <keescook at chromium.org> wrote:
> > > Test Suites
> > > -----------
> > > * boot-lkft-kselftests-master-519
> >
> > What counts as a "pass" for this? I looked at the x86_64 log, and there are lots of kselftest failures, but the dashboard counts it as a "pass"?
>
> The boot is passed when the auto-login-action in suite 'lava' is passed [1].
>
> There's is two issues:
> 1. We had a way that changed the run_kselftest.sh file in order to
> skip tests that hanged (that results in no test output from the run)
> various boards. Since the new change to kselftest, the patch to
> run_kselftest.sh got added that breaks our way to skip the tests and
> kernel hangs.
There's a fix in -next that adds an "alarm" check now so no tests should ever hang for more than 30 seconds now:
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?id=a745f7af3cbd04b9c9c9e803429e1c20775b538d
> 2. The way we parse the output doesn't match the new output format.
>
> We will turn off the "next-* kselftest restults" until we have
> resolved this issue.
I'd prefer to keep the tests running -- they're still valuable logs to
have. I was just curious about the specific reporting. As long as the
issue is known, that's fine. No need to disable it entirely. :)
-Kees
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: keescook@chromium.org (Kees Cook)
Subject: next-20190510 kselftest results
Date: Tue, 14 May 2019 08:46:14 -0700 [thread overview]
Message-ID: <201905140843.B972AA13B6@keescook> (raw)
Message-ID: <20190514154614.jI9nHeUPcwSeNZWSVddWvJZXX0Nic-9_3UZ_CvulKSE@z> (raw)
In-Reply-To: <CADYN=9+nwM4Kw-PWHHDpQ5hpf=N5N8Ewy=h7Y2RTyO5Kwak88A@mail.gmail.com>
On Tue, May 14, 2019@05:28:45PM +0200, Anders Roxell wrote:
> On Sat, 11 May 2019@16:51, Kees Cook <keescook@chromium.org> wrote:
> > > Test Suites
> > > -----------
> > > * boot-lkft-kselftests-master-519
> >
> > What counts as a "pass" for this? I looked at the x86_64 log, and there are lots of kselftest failures, but the dashboard counts it as a "pass"?
>
> The boot is passed when the auto-login-action in suite 'lava' is passed [1].
>
> There's is two issues:
> 1. We had a way that changed the run_kselftest.sh file in order to
> skip tests that hanged (that results in no test output from the run)
> various boards. Since the new change to kselftest, the patch to
> run_kselftest.sh got added that breaks our way to skip the tests and
> kernel hangs.
There's a fix in -next that adds an "alarm" check now so no tests should ever hang for more than 30 seconds now:
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?id=a745f7af3cbd04b9c9c9e803429e1c20775b538d
> 2. The way we parse the output doesn't match the new output format.
>
> We will turn off the "next-* kselftest restults" until we have
> resolved this issue.
I'd prefer to keep the tests running -- they're still valuable logs to
have. I was just curious about the specific reporting. As long as the
issue is known, that's fine. No need to disable it entirely. :)
-Kees
--
Kees Cook
next prev parent reply other threads:[~2019-05-14 15:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-11 10:14 next-20190510 kselftest results ci_notify
2019-05-11 10:14 ` ci_notify
2019-05-11 14:51 ` keescook
2019-05-11 14:51 ` Kees Cook
2019-05-14 15:28 ` anders.roxell
2019-05-14 15:28 ` Anders Roxell
2019-05-14 15:46 ` keescook [this message]
2019-05-14 15:46 ` Kees Cook
2019-05-14 21:49 ` anders.roxell
2019-05-14 21:49 ` Anders Roxell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201905140843.B972AA13B6@keescook \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.