All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH] syscall/ioctl: fix compiler error
@ 2019-05-13  1:46 Jinhui huang
  2019-05-14 13:02 ` Petr Vorel
  0 siblings, 1 reply; 5+ messages in thread
From: Jinhui huang @ 2019-05-13  1:46 UTC (permalink / raw)
  To: ltp

"CLONE_NEWPID" and "CLONE_NEWUSER" are not defined on some old distros,
so include "lapi/namespaces_constants.h" to fix it.

Signed-off-by: Jinhui huang <huangjh.jy@cn.fujitsu.com>
---
 testcases/kernel/syscalls/ioctl/ioctl_ns01.c | 1 +
 testcases/kernel/syscalls/ioctl/ioctl_ns05.c | 1 +
 testcases/kernel/syscalls/ioctl/ioctl_ns06.c | 1 +
 3 files changed, 3 insertions(+)

diff --git a/testcases/kernel/syscalls/ioctl/ioctl_ns01.c b/testcases/kernel/syscalls/ioctl/ioctl_ns01.c
index 59b215f..f2c77a0 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl_ns01.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl_ns01.c
@@ -19,6 +19,7 @@
 #include <sched.h>
 #include "tst_test.h"
 #include "lapi/ioctl_ns.h"
+#include "lapi/namespaces_constants.h"
 
 #define STACK_SIZE (1024 * 1024)
 
diff --git a/testcases/kernel/syscalls/ioctl/ioctl_ns05.c b/testcases/kernel/syscalls/ioctl/ioctl_ns05.c
index add6980..bdef4d6 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl_ns05.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl_ns05.c
@@ -18,6 +18,7 @@
 #include <sched.h>
 #include "tst_test.h"
 #include "lapi/ioctl_ns.h"
+#include "lapi/namespaces_constants.h"
 
 #define STACK_SIZE (1024 * 1024)
 
diff --git a/testcases/kernel/syscalls/ioctl/ioctl_ns06.c b/testcases/kernel/syscalls/ioctl/ioctl_ns06.c
index f077a3b..eabb7e4 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl_ns06.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl_ns06.c
@@ -19,6 +19,7 @@
 #include <sched.h>
 #include "tst_test.h"
 #include "lapi/ioctl_ns.h"
+#include "lapi/namespaces_constants.h"
 
 #define STACK_SIZE (1024 * 1024)
 
-- 
1.8.3.1




^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [LTP] [PATCH] syscall/ioctl: fix compiler error
  2019-05-13  1:46 [LTP] [PATCH] syscall/ioctl: fix compiler error Jinhui huang
@ 2019-05-14 13:02 ` Petr Vorel
  2019-05-14 14:11   ` Cyril Hrubis
  2019-05-15  5:21   ` jinhui huang
  0 siblings, 2 replies; 5+ messages in thread
From: Petr Vorel @ 2019-05-14 13:02 UTC (permalink / raw)
  To: ltp

Hi Jinhui,

> "CLONE_NEWPID" and "CLONE_NEWUSER" are not defined on some old distros,
> so include "lapi/namespaces_constants.h" to fix it.

Can you be more specific, which distros?
CLONE_* has been added into glibc in 2008 (released in glibc 2.8).

> Signed-off-by: Jinhui huang <huangjh.jy@cn.fujitsu.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>

@Cyril: this could go before release as well.

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [LTP] [PATCH] syscall/ioctl: fix compiler error
  2019-05-14 13:02 ` Petr Vorel
@ 2019-05-14 14:11   ` Cyril Hrubis
  2019-05-15  5:21   ` jinhui huang
  1 sibling, 0 replies; 5+ messages in thread
From: Cyril Hrubis @ 2019-05-14 14:11 UTC (permalink / raw)
  To: ltp

Hi!
> > "CLONE_NEWPID" and "CLONE_NEWUSER" are not defined on some old distros,
> > so include "lapi/namespaces_constants.h" to fix it.
> 
> Can you be more specific, which distros?
> CLONE_* has been added into glibc in 2008 (released in glibc 2.8).
> 
> > Signed-off-by: Jinhui huang <huangjh.jy@cn.fujitsu.com>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> @Cyril: this could go before release as well.

Let's wait a bit I would be happier if we had more info about the
distros this patch is fixing. But other than that this is pretty much
obvious fix.

-- 
Cyril Hrubis
chrubis@suse.cz

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [LTP] [PATCH] syscall/ioctl: fix compiler error
  2019-05-14 13:02 ` Petr Vorel
  2019-05-14 14:11   ` Cyril Hrubis
@ 2019-05-15  5:21   ` jinhui huang
  2019-05-15  6:03     ` Petr Vorel
  1 sibling, 1 reply; 5+ messages in thread
From: jinhui huang @ 2019-05-15  5:21 UTC (permalink / raw)
  To: ltp

On 2019/05/14 21:02, Petr Vorel wrote:

Hi,
> Hi Jinhui,
>
>> "CLONE_NEWPID" and "CLONE_NEWUSER" are not defined on some old distros,
>> so include "lapi/namespaces_constants.h" to fix it.
> Can you be more specific, which distros?
> CLONE_* has been added into glibc in 2008 (released in glibc 2.8).
>
The kernel version is 2.6.18-398.el5 and the glibc version is 
glibc-2.5-123.
>> Signed-off-by: Jinhui huang<huangjh.jy@cn.fujitsu.com>
> Reviewed-by: Petr Vorel<pvorel@suse.cz>
>
> @Cyril: this could go before release as well.
>
> Kind regards,
> Petr
Kind regards,
Jinhui



^ permalink raw reply	[flat|nested] 5+ messages in thread
* [LTP] [PATCH] syscall/ioctl: fix compiler error
  2019-05-15  5:21   ` jinhui huang
@ 2019-05-15  6:03     ` Petr Vorel
  0 siblings, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2019-05-15  6:03 UTC (permalink / raw)
  To: ltp

Hi Jinhui,

> > > "CLONE_NEWPID" and "CLONE_NEWUSER" are not defined on some old distros,
> > > so include "lapi/namespaces_constants.h" to fix it.
> > Can you be more specific, which distros?
> > CLONE_* has been added into glibc in 2008 (released in glibc 2.8).

> The kernel version is 2.6.18-398.el5 and the glibc version is glibc-2.5-123.
Thanks for info, merged!

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-15  6:03 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13  1:46 [LTP] [PATCH] syscall/ioctl: fix compiler error Jinhui huang
2019-05-14 13:02 ` Petr Vorel
2019-05-14 14:11   ` Cyril Hrubis
2019-05-15  5:21   ` jinhui huang
2019-05-15  6:03     ` Petr Vorel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.