* [PATCH] lib: Correct comment of prandom_seed
@ 2019-05-17 10:44 Philippe Mazenauer
2019-05-17 10:50 ` Lee Jones
2019-05-17 18:40 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mazenauer @ 2019-05-17 10:44 UTC (permalink / raw)
Cc: lee.jones, Philippe Mazenauer, David S. Miller,
open list:NETWORKING [GENERAL],
open list
Variable 'entropy' was wrongly documented as 'seed', changed comment to
reflect actual variable name.
../lib/random32.c:179: warning: Function parameter or member 'entropy' not described in 'prandom_seed'
../lib/random32.c:179: warning: Excess function parameter 'seed' description in 'prandom_seed'
Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
---
lib/random32.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/random32.c b/lib/random32.c
index 4aaa76404d56..763b920a6206 100644
--- a/lib/random32.c
+++ b/lib/random32.c
@@ -171,9 +171,9 @@ static void prandom_seed_early(struct rnd_state *state, u32 seed,
/**
* prandom_seed - add entropy to pseudo random number generator
- * @seed: seed value
+ * @entropy: entropy value
*
- * Add some additional seeding to the prandom pool.
+ * Add some additional entropy to the prandom pool.
*/
void prandom_seed(u32 entropy)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] lib: Correct comment of prandom_seed
2019-05-17 10:44 [PATCH] lib: Correct comment of prandom_seed Philippe Mazenauer
@ 2019-05-17 10:50 ` Lee Jones
2019-05-17 18:40 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2019-05-17 10:50 UTC (permalink / raw)
To: Philippe Mazenauer
Cc: David S. Miller, open list:NETWORKING [GENERAL], open list
On Fri, 17 May 2019, Philippe Mazenauer wrote:
> Variable 'entropy' was wrongly documented as 'seed', changed comment to
> reflect actual variable name.
>
> ../lib/random32.c:179: warning: Function parameter or member 'entropy' not described in 'prandom_seed'
> ../lib/random32.c:179: warning: Excess function parameter 'seed' description in 'prandom_seed'
>
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
> ---
> lib/random32.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Looks reasonable:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lib: Correct comment of prandom_seed
2019-05-17 10:44 [PATCH] lib: Correct comment of prandom_seed Philippe Mazenauer
2019-05-17 10:50 ` Lee Jones
@ 2019-05-17 18:40 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-05-17 18:40 UTC (permalink / raw)
To: philippe.mazenauer; +Cc: lee.jones, netdev, linux-kernel
From: Philippe Mazenauer <philippe.mazenauer@outlook.de>
Date: Fri, 17 May 2019 10:44:44 +0000
> Variable 'entropy' was wrongly documented as 'seed', changed comment to
> reflect actual variable name.
>
> ../lib/random32.c:179: warning: Function parameter or member 'entropy' not described in 'prandom_seed'
> ../lib/random32.c:179: warning: Excess function parameter 'seed' description in 'prandom_seed'
>
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-17 18:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-17 10:44 [PATCH] lib: Correct comment of prandom_seed Philippe Mazenauer
2019-05-17 10:50 ` Lee Jones
2019-05-17 18:40 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.