* [U-Boot] [PATCH 1/1] toradex apalis/colibri: extend CONFIG_SYS_MALLOC_F_LEN
@ 2019-05-17 14:48 Igor Opaniuk
2019-05-17 14:52 ` Bin Meng
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Igor Opaniuk @ 2019-05-17 14:48 UTC (permalink / raw)
To: u-boot
Extend size of the malloc() pool for use before relocation, from 0x400
(default one) to 0x2000 (CONFIG_SYS_MALLOC_F_LEN=0x2000),
as adding of DM_FLAG_PRE_RELOC flag to simple-bus driver introduced a
regression on multiple boards, because of more intensive usage of malloc()
pool and therefore a broken boot as the size of pool isn't sufficient.
Fixes: 3a7c45f6a7 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus")
Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
---
configs/apalis-tk1_defconfig | 1 +
configs/apalis_imx6_defconfig | 1 +
configs/apalis_t30_defconfig | 1 +
configs/colibri-imx6ull_defconfig | 1 +
configs/colibri_imx6_defconfig | 1 +
configs/colibri_imx7_defconfig | 1 +
configs/colibri_imx7_emmc_defconfig | 1 +
configs/colibri_pxa270_defconfig | 1 +
configs/colibri_t20_defconfig | 1 +
configs/colibri_t30_defconfig | 1 +
configs/colibri_vf_defconfig | 2 +-
11 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/configs/apalis-tk1_defconfig b/configs/apalis-tk1_defconfig
index be9d55e7d4..946858e48e 100644
--- a/configs/apalis-tk1_defconfig
+++ b/configs/apalis-tk1_defconfig
@@ -1,6 +1,7 @@
CONFIG_ARM=y
CONFIG_TEGRA=y
CONFIG_SYS_TEXT_BASE=0x80110000
+CONFIG_SYS_MALLOC_F_LEN=0x2000
CONFIG_NR_DRAM_BANKS=2
CONFIG_TEGRA124=y
CONFIG_TARGET_APALIS_TK1=y
diff --git a/configs/apalis_imx6_defconfig b/configs/apalis_imx6_defconfig
index 3292d644aa..bcf7444311 100644
--- a/configs/apalis_imx6_defconfig
+++ b/configs/apalis_imx6_defconfig
@@ -1,6 +1,7 @@
CONFIG_ARM=y
CONFIG_ARCH_MX6=y
CONFIG_SYS_TEXT_BASE=0x17800000
+CONFIG_SYS_MALLOC_F_LEN=0x2000
CONFIG_SPL_GPIO_SUPPORT=y
CONFIG_SPL_LIBCOMMON_SUPPORT=y
CONFIG_SPL_LIBGENERIC_SUPPORT=y
diff --git a/configs/apalis_t30_defconfig b/configs/apalis_t30_defconfig
index 31a763536d..d231ccdb49 100644
--- a/configs/apalis_t30_defconfig
+++ b/configs/apalis_t30_defconfig
@@ -1,6 +1,7 @@
CONFIG_ARM=y
CONFIG_TEGRA=y
CONFIG_SYS_TEXT_BASE=0x80110000
+CONFIG_SYS_MALLOC_F_LEN=0x2000
CONFIG_NR_DRAM_BANKS=2
CONFIG_TEGRA30=y
CONFIG_TARGET_APALIS_T30=y
diff --git a/configs/colibri-imx6ull_defconfig b/configs/colibri-imx6ull_defconfig
index 3dbb4d95b6..133df9e723 100644
--- a/configs/colibri-imx6ull_defconfig
+++ b/configs/colibri-imx6ull_defconfig
@@ -2,6 +2,7 @@ CONFIG_ARM=y
CONFIG_SYS_THUMB_BUILD=y
CONFIG_ARCH_MX6=y
CONFIG_SYS_TEXT_BASE=0x87800000
+CONFIG_SYS_MALLOC_F_LEN=0x2000
CONFIG_TARGET_COLIBRI_IMX6ULL=y
CONFIG_NR_DRAM_BANKS=1
CONFIG_DISTRO_DEFAULTS=y
diff --git a/configs/colibri_imx6_defconfig b/configs/colibri_imx6_defconfig
index ba17ec0030..b2f7739725 100644
--- a/configs/colibri_imx6_defconfig
+++ b/configs/colibri_imx6_defconfig
@@ -1,6 +1,7 @@
CONFIG_ARM=y
CONFIG_ARCH_MX6=y
CONFIG_SYS_TEXT_BASE=0x17800000
+CONFIG_SYS_MALLOC_F_LEN=0x2000
CONFIG_SPL_GPIO_SUPPORT=y
CONFIG_SPL_LIBCOMMON_SUPPORT=y
CONFIG_SPL_LIBGENERIC_SUPPORT=y
diff --git a/configs/colibri_imx7_defconfig b/configs/colibri_imx7_defconfig
index 58620ea68f..40f3b99f61 100644
--- a/configs/colibri_imx7_defconfig
+++ b/configs/colibri_imx7_defconfig
@@ -2,6 +2,7 @@ CONFIG_ARM=y
CONFIG_SYS_THUMB_BUILD=y
CONFIG_ARCH_MX7=y
CONFIG_SYS_TEXT_BASE=0x87800000
+CONFIG_SYS_MALLOC_F_LEN=0x2000
CONFIG_SECURE_BOOT=y
CONFIG_TARGET_COLIBRI_IMX7=y
CONFIG_NR_DRAM_BANKS=1
diff --git a/configs/colibri_imx7_emmc_defconfig b/configs/colibri_imx7_emmc_defconfig
index 0617b120a0..f35cabaed6 100644
--- a/configs/colibri_imx7_emmc_defconfig
+++ b/configs/colibri_imx7_emmc_defconfig
@@ -2,6 +2,7 @@ CONFIG_ARM=y
CONFIG_SYS_THUMB_BUILD=y
CONFIG_ARCH_MX7=y
CONFIG_SYS_TEXT_BASE=0x87800000
+CONFIG_SYS_MALLOC_F_LEN=0x2000
CONFIG_SECURE_BOOT=y
CONFIG_TARGET_COLIBRI_IMX7=y
CONFIG_TARGET_COLIBRI_IMX7_EMMC=y
diff --git a/configs/colibri_pxa270_defconfig b/configs/colibri_pxa270_defconfig
index 6cd948e159..b2beb32320 100644
--- a/configs/colibri_pxa270_defconfig
+++ b/configs/colibri_pxa270_defconfig
@@ -1,6 +1,7 @@
CONFIG_ARM=y
CONFIG_TARGET_COLIBRI_PXA270=y
CONFIG_SYS_TEXT_BASE=0x0
+CONFIG_SYS_MALLOC_F_LEN=0x2000
CONFIG_NR_DRAM_BANKS=1
CONFIG_ENV_VARS_UBOOT_CONFIG=y
CONFIG_USE_BOOTARGS=y
diff --git a/configs/colibri_t20_defconfig b/configs/colibri_t20_defconfig
index 15fb9555f3..6b8a690ec3 100644
--- a/configs/colibri_t20_defconfig
+++ b/configs/colibri_t20_defconfig
@@ -1,6 +1,7 @@
CONFIG_ARM=y
CONFIG_TEGRA=y
CONFIG_SYS_TEXT_BASE=0x00110000
+CONFIG_SYS_MALLOC_F_LEN=0x2000
CONFIG_NR_DRAM_BANKS=2
CONFIG_TEGRA20=y
CONFIG_TARGET_COLIBRI_T20=y
diff --git a/configs/colibri_t30_defconfig b/configs/colibri_t30_defconfig
index 2d12fc10c4..99be27823d 100644
--- a/configs/colibri_t30_defconfig
+++ b/configs/colibri_t30_defconfig
@@ -1,6 +1,7 @@
CONFIG_ARM=y
CONFIG_TEGRA=y
CONFIG_SYS_TEXT_BASE=0x80110000
+CONFIG_SYS_MALLOC_F_LEN=0x2000
CONFIG_NR_DRAM_BANKS=2
CONFIG_TEGRA30=y
CONFIG_TARGET_COLIBRI_T30=y
diff --git a/configs/colibri_vf_defconfig b/configs/colibri_vf_defconfig
index d214a79d23..3a267bdbc6 100644
--- a/configs/colibri_vf_defconfig
+++ b/configs/colibri_vf_defconfig
@@ -2,7 +2,7 @@ CONFIG_ARM=y
CONFIG_SYS_THUMB_BUILD=y
CONFIG_ARCH_VF610=y
CONFIG_SYS_TEXT_BASE=0x3f401000
-CONFIG_SYS_MALLOC_F_LEN=0x800
+CONFIG_SYS_MALLOC_F_LEN=0x2000
CONFIG_NR_DRAM_BANKS=1
CONFIG_TARGET_COLIBRI_VF=y
CONFIG_ENV_VARS_UBOOT_CONFIG=y
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] toradex apalis/colibri: extend CONFIG_SYS_MALLOC_F_LEN
2019-05-17 14:48 [U-Boot] [PATCH 1/1] toradex apalis/colibri: extend CONFIG_SYS_MALLOC_F_LEN Igor Opaniuk
@ 2019-05-17 14:52 ` Bin Meng
2019-05-17 14:52 ` Fabio Estevam
2019-06-10 9:40 ` [U-Boot] [PATCH 1/1] toradex apalis/colibri: extend sbabic at denx.de
2 siblings, 0 replies; 6+ messages in thread
From: Bin Meng @ 2019-05-17 14:52 UTC (permalink / raw)
To: u-boot
On Fri, May 17, 2019 at 10:49 PM Igor Opaniuk <igor.opaniuk@toradex.com> wrote:
>
> Extend size of the malloc() pool for use before relocation, from 0x400
> (default one) to 0x2000 (CONFIG_SYS_MALLOC_F_LEN=0x2000),
> as adding of DM_FLAG_PRE_RELOC flag to simple-bus driver introduced a
> regression on multiple boards, because of more intensive usage of malloc()
> pool and therefore a broken boot as the size of pool isn't sufficient.
>
> Fixes: 3a7c45f6a7 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus")
> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> ---
> configs/apalis-tk1_defconfig | 1 +
> configs/apalis_imx6_defconfig | 1 +
> configs/apalis_t30_defconfig | 1 +
> configs/colibri-imx6ull_defconfig | 1 +
> configs/colibri_imx6_defconfig | 1 +
> configs/colibri_imx7_defconfig | 1 +
> configs/colibri_imx7_emmc_defconfig | 1 +
> configs/colibri_pxa270_defconfig | 1 +
> configs/colibri_t20_defconfig | 1 +
> configs/colibri_t30_defconfig | 1 +
> configs/colibri_vf_defconfig | 2 +-
> 11 files changed, 11 insertions(+), 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] toradex apalis/colibri: extend CONFIG_SYS_MALLOC_F_LEN
2019-05-17 14:48 [U-Boot] [PATCH 1/1] toradex apalis/colibri: extend CONFIG_SYS_MALLOC_F_LEN Igor Opaniuk
2019-05-17 14:52 ` Bin Meng
@ 2019-05-17 14:52 ` Fabio Estevam
2019-05-17 14:58 ` Marcel Ziswiler
2019-05-17 15:00 ` Marcel Ziswiler
2019-06-10 9:40 ` [U-Boot] [PATCH 1/1] toradex apalis/colibri: extend sbabic at denx.de
2 siblings, 2 replies; 6+ messages in thread
From: Fabio Estevam @ 2019-05-17 14:52 UTC (permalink / raw)
To: u-boot
Hi Igor,
On Fri, May 17, 2019 at 11:49 AM Igor Opaniuk <igor.opaniuk@toradex.com> wrote:
>
> Extend size of the malloc() pool for use before relocation, from 0x400
> (default one) to 0x2000 (CONFIG_SYS_MALLOC_F_LEN=0x2000),
> as adding of DM_FLAG_PRE_RELOC flag to simple-bus driver introduced a
> regression on multiple boards, because of more intensive usage of malloc()
> pool and therefore a broken boot as the size of pool isn't sufficient.
>
> Fixes: 3a7c45f6a7 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus")
> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
I have already sent a fix for this issue:
https://lists.denx.de/pipermail/u-boot/2019-May/367839.html
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] toradex apalis/colibri: extend CONFIG_SYS_MALLOC_F_LEN
2019-05-17 14:52 ` Fabio Estevam
@ 2019-05-17 14:58 ` Marcel Ziswiler
2019-05-17 15:00 ` Marcel Ziswiler
1 sibling, 0 replies; 6+ messages in thread
From: Marcel Ziswiler @ 2019-05-17 14:58 UTC (permalink / raw)
To: u-boot
On Fri, 2019-05-17 at 11:52 -0300, Fabio Estevam wrote:
> Hi Igor,
>
> On Fri, May 17, 2019 at 11:49 AM Igor Opaniuk <
> igor.opaniuk at toradex.com> wrote:
> > Extend size of the malloc() pool for use before relocation, from
> > 0x400
> > (default one) to 0x2000 (CONFIG_SYS_MALLOC_F_LEN=0x2000),
> > as adding of DM_FLAG_PRE_RELOC flag to simple-bus driver introduced
> > a
> > regression on multiple boards, because of more intensive usage of
> > malloc()
> > pool and therefore a broken boot as the size of pool isn't
> > sufficient.
> >
> > Fixes: 3a7c45f6a7 ("simple-bus: add DM_FLAG_PRE_RELOC flag to
> > simple-bus")
> > Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
>
> I have already sent a fix for this issue:
> https://lists.denx.de/pipermail/u-boot/2019-May/367839.html
Ah, cool. But I believe on i.MX 8QM not even 0x2000 is/was enough but I
rather had/have to increase it to 0x4000 (which BTW: Peng had already
increased it to on i.MX 8QXP (;-p).
commit e5b8f7e665aa ("imx8qxp: mek: enable dm-spl for pm")
> Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] toradex apalis/colibri: extend CONFIG_SYS_MALLOC_F_LEN
2019-05-17 14:52 ` Fabio Estevam
2019-05-17 14:58 ` Marcel Ziswiler
@ 2019-05-17 15:00 ` Marcel Ziswiler
1 sibling, 0 replies; 6+ messages in thread
From: Marcel Ziswiler @ 2019-05-17 15:00 UTC (permalink / raw)
To: u-boot
On Fri, 2019-05-17 at 11:52 -0300, Fabio Estevam wrote:
> Hi Igor,
>
> On Fri, May 17, 2019 at 11:49 AM Igor Opaniuk <
> igor.opaniuk at toradex.com> wrote:
> > Extend size of the malloc() pool for use before relocation, from
> > 0x400
> > (default one) to 0x2000 (CONFIG_SYS_MALLOC_F_LEN=0x2000),
> > as adding of DM_FLAG_PRE_RELOC flag to simple-bus driver introduced
> > a
> > regression on multiple boards, because of more intensive usage of
> > malloc()
> > pool and therefore a broken boot as the size of pool isn't
> > sufficient.
> >
> > Fixes: 3a7c45f6a7 ("simple-bus: add DM_FLAG_PRE_RELOC flag to
> > simple-bus")
> > Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
>
> I have already sent a fix for this issue:
> https://lists.denx.de/pipermail/u-boot/2019-May/367839.html
And then BTW this also does not fix it should one already manually have
set a different but too small value ins his board configuration!
> Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] toradex apalis/colibri: extend
2019-05-17 14:48 [U-Boot] [PATCH 1/1] toradex apalis/colibri: extend CONFIG_SYS_MALLOC_F_LEN Igor Opaniuk
2019-05-17 14:52 ` Bin Meng
2019-05-17 14:52 ` Fabio Estevam
@ 2019-06-10 9:40 ` sbabic at denx.de
2 siblings, 0 replies; 6+ messages in thread
From: sbabic at denx.de @ 2019-06-10 9:40 UTC (permalink / raw)
To: u-boot
> Extend size of the malloc() pool for use before relocation, from 0x400
> (default one) to 0x2000 (CONFIG_SYS_MALLOC_F_LEN=0x2000),
> as adding of DM_FLAG_PRE_RELOC flag to simple-bus driver introduced a
> regression on multiple boards, because of more intensive usage of malloc()
> pool and therefore a broken boot as the size of pool isn't sufficient.
> Fixes: 3a7c45f6a7 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus")
> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-10 9:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-17 14:48 [U-Boot] [PATCH 1/1] toradex apalis/colibri: extend CONFIG_SYS_MALLOC_F_LEN Igor Opaniuk
2019-05-17 14:52 ` Bin Meng
2019-05-17 14:52 ` Fabio Estevam
2019-05-17 14:58 ` Marcel Ziswiler
2019-05-17 15:00 ` Marcel Ziswiler
2019-06-10 9:40 ` [U-Boot] [PATCH 1/1] toradex apalis/colibri: extend sbabic at denx.de
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.