* [U-Boot] [PATCH] cmd: define CMD_DATA_SIZE when CONFIG_CMD_SETEXPR is selected
@ 2019-05-20 8:22 Bartosz Golaszewski
2019-06-15 17:00 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Golaszewski @ 2019-05-20 8:22 UTC (permalink / raw)
To: u-boot
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
The setexpr shell command calls cmd_get_data_size() which is only built
when CMD_DATA_SIZE is defined. We need to define CMD_DATA_SIZE if
CONFIG_CMD_SETEXPR is selected or the build will fail if no other
command selecting this option is enabled.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
include/command.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/command.h b/include/command.h
index be74f6ac92..2bfee89df3 100644
--- a/include/command.h
+++ b/include/command.h
@@ -109,7 +109,8 @@ int cmd_process_error(cmd_tbl_t *cmdtp, int err);
#if defined(CONFIG_CMD_MEMORY) || \
defined(CONFIG_CMD_I2C) || \
defined(CONFIG_CMD_ITEST) || \
- defined(CONFIG_CMD_PCI)
+ defined(CONFIG_CMD_PCI) || \
+ defined(CONFIG_CMD_SETEXPR)
#define CMD_DATA_SIZE
extern int cmd_get_data_size(char* arg, int default_size);
#endif
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] cmd: define CMD_DATA_SIZE when CONFIG_CMD_SETEXPR is selected
2019-05-20 8:22 [U-Boot] [PATCH] cmd: define CMD_DATA_SIZE when CONFIG_CMD_SETEXPR is selected Bartosz Golaszewski
@ 2019-06-15 17:00 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2019-06-15 17:00 UTC (permalink / raw)
To: u-boot
On Mon, May 20, 2019 at 10:22:14AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> The setexpr shell command calls cmd_get_data_size() which is only built
> when CMD_DATA_SIZE is defined. We need to define CMD_DATA_SIZE if
> CONFIG_CMD_SETEXPR is selected or the build will fail if no other
> command selecting this option is enabled.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190615/1f17cfb1/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-15 17:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-20 8:22 [U-Boot] [PATCH] cmd: define CMD_DATA_SIZE when CONFIG_CMD_SETEXPR is selected Bartosz Golaszewski
2019-06-15 17:00 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.