* [PATCH] KVM: selftests: Remove duplicated TEST_ASSERT in hyperv_cpuid.c
@ 2019-05-20 10:55 ` thuth
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2019-05-20 10:55 UTC (permalink / raw)
To: Paolo Bonzini, Radim Krčmář, Vitaly Kuznetsov
Cc: Shuah Khan, linux-kselftest, kvm, linux-kernel
The check for entry->index == 0 is done twice. One time should
be sufficient.
Suggested-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
Vitaly already noticed this in his review to the "Fix a condition
in test_hv_cpuid()" patch a couple of days ago, but so far I haven't
seen any patch yet on the list that fixes this ... if I missed it
instead, please simply ignore this patch.
tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
index 9a21e912097c..8bdf1e7da6cc 100644
--- a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
+++ b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
@@ -52,9 +52,6 @@ static void test_hv_cpuid(struct kvm_cpuid2 *hv_cpuid_entries,
TEST_ASSERT(entry->index == 0,
".index field should be zero");
- TEST_ASSERT(entry->index == 0,
- ".index field should be zero");
-
TEST_ASSERT(entry->flags == 0,
".flags field should be zero");
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] KVM: selftests: Remove duplicated TEST_ASSERT in hyperv_cpuid.c
@ 2019-05-20 10:55 ` thuth
0 siblings, 0 replies; 6+ messages in thread
From: thuth @ 2019-05-20 10:55 UTC (permalink / raw)
The check for entry->index == 0 is done twice. One time should
be sufficient.
Suggested-by: Vitaly Kuznetsov <vkuznets at redhat.com>
Signed-off-by: Thomas Huth <thuth at redhat.com>
---
Vitaly already noticed this in his review to the "Fix a condition
in test_hv_cpuid()" patch a couple of days ago, but so far I haven't
seen any patch yet on the list that fixes this ... if I missed it
instead, please simply ignore this patch.
tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
index 9a21e912097c..8bdf1e7da6cc 100644
--- a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
+++ b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
@@ -52,9 +52,6 @@ static void test_hv_cpuid(struct kvm_cpuid2 *hv_cpuid_entries,
TEST_ASSERT(entry->index == 0,
".index field should be zero");
- TEST_ASSERT(entry->index == 0,
- ".index field should be zero");
-
TEST_ASSERT(entry->flags == 0,
".flags field should be zero");
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] KVM: selftests: Remove duplicated TEST_ASSERT in hyperv_cpuid.c
@ 2019-05-20 10:55 ` thuth
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2019-05-20 10:55 UTC (permalink / raw)
The check for entry->index == 0 is done twice. One time should
be sufficient.
Suggested-by: Vitaly Kuznetsov <vkuznets at redhat.com>
Signed-off-by: Thomas Huth <thuth at redhat.com>
---
Vitaly already noticed this in his review to the "Fix a condition
in test_hv_cpuid()" patch a couple of days ago, but so far I haven't
seen any patch yet on the list that fixes this ... if I missed it
instead, please simply ignore this patch.
tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
index 9a21e912097c..8bdf1e7da6cc 100644
--- a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
+++ b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
@@ -52,9 +52,6 @@ static void test_hv_cpuid(struct kvm_cpuid2 *hv_cpuid_entries,
TEST_ASSERT(entry->index == 0,
".index field should be zero");
- TEST_ASSERT(entry->index == 0,
- ".index field should be zero");
-
TEST_ASSERT(entry->flags == 0,
".flags field should be zero");
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] KVM: selftests: Remove duplicated TEST_ASSERT in hyperv_cpuid.c
2019-05-20 10:55 ` thuth
(?)
@ 2019-05-20 11:16 ` pbonzini
-1 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2019-05-20 11:16 UTC (permalink / raw)
To: Thomas Huth, Radim Krčmář, Vitaly Kuznetsov
Cc: Shuah Khan, linux-kselftest, kvm, linux-kernel
On 20/05/19 12:55, Thomas Huth wrote:
> The check for entry->index == 0 is done twice. One time should
> be sufficient.
>
> Suggested-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> Vitaly already noticed this in his review to the "Fix a condition
> in test_hv_cpuid()" patch a couple of days ago, but so far I haven't
> seen any patch yet on the list that fixes this ... if I missed it
> instead, please simply ignore this patch.
>
> tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
> index 9a21e912097c..8bdf1e7da6cc 100644
> --- a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
> +++ b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
> @@ -52,9 +52,6 @@ static void test_hv_cpuid(struct kvm_cpuid2 *hv_cpuid_entries,
> TEST_ASSERT(entry->index == 0,
> ".index field should be zero");
>
> - TEST_ASSERT(entry->index == 0,
> - ".index field should be zero");
> -
> TEST_ASSERT(entry->flags == 0,
> ".flags field should be zero");
>
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] KVM: selftests: Remove duplicated TEST_ASSERT in hyperv_cpuid.c
@ 2019-05-20 11:16 ` pbonzini
0 siblings, 0 replies; 6+ messages in thread
From: pbonzini @ 2019-05-20 11:16 UTC (permalink / raw)
On 20/05/19 12:55, Thomas Huth wrote:
> The check for entry->index == 0 is done twice. One time should
> be sufficient.
>
> Suggested-by: Vitaly Kuznetsov <vkuznets at redhat.com>
> Signed-off-by: Thomas Huth <thuth at redhat.com>
> ---
> Vitaly already noticed this in his review to the "Fix a condition
> in test_hv_cpuid()" patch a couple of days ago, but so far I haven't
> seen any patch yet on the list that fixes this ... if I missed it
> instead, please simply ignore this patch.
>
> tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
> index 9a21e912097c..8bdf1e7da6cc 100644
> --- a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
> +++ b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
> @@ -52,9 +52,6 @@ static void test_hv_cpuid(struct kvm_cpuid2 *hv_cpuid_entries,
> TEST_ASSERT(entry->index == 0,
> ".index field should be zero");
>
> - TEST_ASSERT(entry->index == 0,
> - ".index field should be zero");
> -
> TEST_ASSERT(entry->flags == 0,
> ".flags field should be zero");
>
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] KVM: selftests: Remove duplicated TEST_ASSERT in hyperv_cpuid.c
@ 2019-05-20 11:16 ` pbonzini
0 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2019-05-20 11:16 UTC (permalink / raw)
On 20/05/19 12:55, Thomas Huth wrote:
> The check for entry->index == 0 is done twice. One time should
> be sufficient.
>
> Suggested-by: Vitaly Kuznetsov <vkuznets at redhat.com>
> Signed-off-by: Thomas Huth <thuth at redhat.com>
> ---
> Vitaly already noticed this in his review to the "Fix a condition
> in test_hv_cpuid()" patch a couple of days ago, but so far I haven't
> seen any patch yet on the list that fixes this ... if I missed it
> instead, please simply ignore this patch.
>
> tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
> index 9a21e912097c..8bdf1e7da6cc 100644
> --- a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
> +++ b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c
> @@ -52,9 +52,6 @@ static void test_hv_cpuid(struct kvm_cpuid2 *hv_cpuid_entries,
> TEST_ASSERT(entry->index == 0,
> ".index field should be zero");
>
> - TEST_ASSERT(entry->index == 0,
> - ".index field should be zero");
> -
> TEST_ASSERT(entry->flags == 0,
> ".flags field should be zero");
>
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-20 11:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-20 10:55 [PATCH] KVM: selftests: Remove duplicated TEST_ASSERT in hyperv_cpuid.c Thomas Huth
2019-05-20 10:55 ` Thomas Huth
2019-05-20 10:55 ` thuth
2019-05-20 11:16 ` Paolo Bonzini
2019-05-20 11:16 ` Paolo Bonzini
2019-05-20 11:16 ` pbonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.