* [U-Boot] [PATCH 1/2] arm: dts: rock960: Enable booting from eMMC when using SPL
@ 2019-05-20 15:46 Manivannan Sadhasivam
2019-05-20 15:46 ` [U-Boot] [PATCH 2/2] arm: dts: ficus: " Manivannan Sadhasivam
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Manivannan Sadhasivam @ 2019-05-20 15:46 UTC (permalink / raw)
To: u-boot
This commits enables booting from eMMC when using SPL on 96Boards
Rock960 board by adding SDHCI to boot order. Since the SDHCI driver
already has the reloc flag, this works straightaway.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm/dts/rk3399-rock960-u-boot.dtsi | 1 +
arch/arm/dts/rk3399-rock960.dts | 2 ++
2 files changed, 3 insertions(+)
diff --git a/arch/arm/dts/rk3399-rock960-u-boot.dtsi b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
index 5256f6d3f2..7fb5072a9b 100644
--- a/arch/arm/dts/rk3399-rock960-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
@@ -3,4 +3,5 @@
* Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com>
*/
+#include "rk3399-u-boot.dtsi"
#include "rk3399-sdram-lpddr3-2GB-1600.dtsi"
diff --git a/arch/arm/dts/rk3399-rock960.dts b/arch/arm/dts/rk3399-rock960.dts
index 7e06bc97e5..c8b9075c73 100644
--- a/arch/arm/dts/rk3399-rock960.dts
+++ b/arch/arm/dts/rk3399-rock960.dts
@@ -12,6 +12,8 @@
chosen {
stdout-path = "serial2:1500000n8";
+ u-boot,spl-boot-order = \
+ &sdhci, &sdmmc;
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 2/2] arm: dts: ficus: Enable booting from eMMC when using SPL
2019-05-20 15:46 [U-Boot] [PATCH 1/2] arm: dts: rock960: Enable booting from eMMC when using SPL Manivannan Sadhasivam
@ 2019-05-20 15:46 ` Manivannan Sadhasivam
2019-05-27 6:49 ` Kever Yang
2019-07-24 8:03 ` Peter Robinson
2019-05-27 6:49 ` [U-Boot] [PATCH 1/2] arm: dts: rock960: " Kever Yang
2019-07-24 7:59 ` Peter Robinson
2 siblings, 2 replies; 10+ messages in thread
From: Manivannan Sadhasivam @ 2019-05-20 15:46 UTC (permalink / raw)
To: u-boot
This commits enables booting from eMMC when using SPL on 96Boards
Ficus board by adding SDHCI to boot order. Since the SDHCI driver
already has the reloc flag, this works straightaway.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm/dts/rk3399-ficus-u-boot.dtsi | 1 +
arch/arm/dts/rk3399-ficus.dts | 2 ++
2 files changed, 3 insertions(+)
diff --git a/arch/arm/dts/rk3399-ficus-u-boot.dtsi b/arch/arm/dts/rk3399-ficus-u-boot.dtsi
index eab86bdb30..67b63a8352 100644
--- a/arch/arm/dts/rk3399-ficus-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-ficus-u-boot.dtsi
@@ -3,4 +3,5 @@
* Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com>
*/
+#include "rk3399-u-boot.dtsi"
#include "rk3399-sdram-ddr3-1600.dtsi"
diff --git a/arch/arm/dts/rk3399-ficus.dts b/arch/arm/dts/rk3399-ficus.dts
index 4b2dd82b67..0f219f4a9c 100644
--- a/arch/arm/dts/rk3399-ficus.dts
+++ b/arch/arm/dts/rk3399-ficus.dts
@@ -15,6 +15,8 @@
chosen {
stdout-path = "serial2:1500000n8";
+ u-boot,spl-boot-order = \
+ &sdhci, &sdmmc;
};
clkin_gmac: external-gmac-clock {
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/2] arm: dts: rock960: Enable booting from eMMC when using SPL
2019-05-20 15:46 [U-Boot] [PATCH 1/2] arm: dts: rock960: Enable booting from eMMC when using SPL Manivannan Sadhasivam
2019-05-20 15:46 ` [U-Boot] [PATCH 2/2] arm: dts: ficus: " Manivannan Sadhasivam
@ 2019-05-27 6:49 ` Kever Yang
2019-07-23 15:06 ` Manivannan Sadhasivam
2019-07-24 7:59 ` Peter Robinson
2 siblings, 1 reply; 10+ messages in thread
From: Kever Yang @ 2019-05-27 6:49 UTC (permalink / raw)
To: u-boot
On 05/20/2019 11:46 PM, Manivannan Sadhasivam wrote:
> This commits enables booting from eMMC when using SPL on 96Boards
> Rock960 board by adding SDHCI to boot order. Since the SDHCI driver
> already has the reloc flag, this works straightaway.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> arch/arm/dts/rk3399-rock960-u-boot.dtsi | 1 +
> arch/arm/dts/rk3399-rock960.dts | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-rock960-u-boot.dtsi b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
> index 5256f6d3f2..7fb5072a9b 100644
> --- a/arch/arm/dts/rk3399-rock960-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
> @@ -3,4 +3,5 @@
> * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com>
> */
>
> +#include "rk3399-u-boot.dtsi"
> #include "rk3399-sdram-lpddr3-2GB-1600.dtsi"
> diff --git a/arch/arm/dts/rk3399-rock960.dts b/arch/arm/dts/rk3399-rock960.dts
> index 7e06bc97e5..c8b9075c73 100644
> --- a/arch/arm/dts/rk3399-rock960.dts
> +++ b/arch/arm/dts/rk3399-rock960.dts
> @@ -12,6 +12,8 @@
>
> chosen {
> stdout-path = "serial2:1500000n8";
> + u-boot,spl-boot-order = \
> + &sdhci, &sdmmc;
> };
> };
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 2/2] arm: dts: ficus: Enable booting from eMMC when using SPL
2019-05-20 15:46 ` [U-Boot] [PATCH 2/2] arm: dts: ficus: " Manivannan Sadhasivam
@ 2019-05-27 6:49 ` Kever Yang
2019-07-23 15:07 ` Manivannan Sadhasivam
2019-07-24 8:03 ` Peter Robinson
1 sibling, 1 reply; 10+ messages in thread
From: Kever Yang @ 2019-05-27 6:49 UTC (permalink / raw)
To: u-boot
On 05/20/2019 11:46 PM, Manivannan Sadhasivam wrote:
> This commits enables booting from eMMC when using SPL on 96Boards
> Ficus board by adding SDHCI to boot order. Since the SDHCI driver
> already has the reloc flag, this works straightaway.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> arch/arm/dts/rk3399-ficus-u-boot.dtsi | 1 +
> arch/arm/dts/rk3399-ficus.dts | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-ficus-u-boot.dtsi b/arch/arm/dts/rk3399-ficus-u-boot.dtsi
> index eab86bdb30..67b63a8352 100644
> --- a/arch/arm/dts/rk3399-ficus-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-ficus-u-boot.dtsi
> @@ -3,4 +3,5 @@
> * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com>
> */
>
> +#include "rk3399-u-boot.dtsi"
> #include "rk3399-sdram-ddr3-1600.dtsi"
> diff --git a/arch/arm/dts/rk3399-ficus.dts b/arch/arm/dts/rk3399-ficus.dts
> index 4b2dd82b67..0f219f4a9c 100644
> --- a/arch/arm/dts/rk3399-ficus.dts
> +++ b/arch/arm/dts/rk3399-ficus.dts
> @@ -15,6 +15,8 @@
>
> chosen {
> stdout-path = "serial2:1500000n8";
> + u-boot,spl-boot-order = \
> + &sdhci, &sdmmc;
> };
>
> clkin_gmac: external-gmac-clock {
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/2] arm: dts: rock960: Enable booting from eMMC when using SPL
2019-05-27 6:49 ` [U-Boot] [PATCH 1/2] arm: dts: rock960: " Kever Yang
@ 2019-07-23 15:06 ` Manivannan Sadhasivam
0 siblings, 0 replies; 10+ messages in thread
From: Manivannan Sadhasivam @ 2019-07-23 15:06 UTC (permalink / raw)
To: u-boot
On Mon, May 27, 2019 at 02:49:39PM +0800, Kever Yang wrote:
>
>
> On 05/20/2019 11:46 PM, Manivannan Sadhasivam wrote:
> > This commits enables booting from eMMC when using SPL on 96Boards
> > Rock960 board by adding SDHCI to boot order. Since the SDHCI driver
> > already has the reloc flag, this works straightaway.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
>
Ping!
> Thanks,
> - Kever
> > ---
> > arch/arm/dts/rk3399-rock960-u-boot.dtsi | 1 +
> > arch/arm/dts/rk3399-rock960.dts | 2 ++
> > 2 files changed, 3 insertions(+)
> >
> > diff --git a/arch/arm/dts/rk3399-rock960-u-boot.dtsi b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
> > index 5256f6d3f2..7fb5072a9b 100644
> > --- a/arch/arm/dts/rk3399-rock960-u-boot.dtsi
> > +++ b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
> > @@ -3,4 +3,5 @@
> > * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com>
> > */
> >
> > +#include "rk3399-u-boot.dtsi"
> > #include "rk3399-sdram-lpddr3-2GB-1600.dtsi"
> > diff --git a/arch/arm/dts/rk3399-rock960.dts b/arch/arm/dts/rk3399-rock960.dts
> > index 7e06bc97e5..c8b9075c73 100644
> > --- a/arch/arm/dts/rk3399-rock960.dts
> > +++ b/arch/arm/dts/rk3399-rock960.dts
> > @@ -12,6 +12,8 @@
> >
> > chosen {
> > stdout-path = "serial2:1500000n8";
> > + u-boot,spl-boot-order = \
> > + &sdhci, &sdmmc;
> > };
> > };
> >
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 2/2] arm: dts: ficus: Enable booting from eMMC when using SPL
2019-05-27 6:49 ` Kever Yang
@ 2019-07-23 15:07 ` Manivannan Sadhasivam
0 siblings, 0 replies; 10+ messages in thread
From: Manivannan Sadhasivam @ 2019-07-23 15:07 UTC (permalink / raw)
To: u-boot
On Mon, May 27, 2019 at 02:49:49PM +0800, Kever Yang wrote:
>
>
> On 05/20/2019 11:46 PM, Manivannan Sadhasivam wrote:
> > This commits enables booting from eMMC when using SPL on 96Boards
> > Ficus board by adding SDHCI to boot order. Since the SDHCI driver
> > already has the reloc flag, this works straightaway.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
>
Ping!
> Thanks,
> - Kever
> > ---
> > arch/arm/dts/rk3399-ficus-u-boot.dtsi | 1 +
> > arch/arm/dts/rk3399-ficus.dts | 2 ++
> > 2 files changed, 3 insertions(+)
> >
> > diff --git a/arch/arm/dts/rk3399-ficus-u-boot.dtsi b/arch/arm/dts/rk3399-ficus-u-boot.dtsi
> > index eab86bdb30..67b63a8352 100644
> > --- a/arch/arm/dts/rk3399-ficus-u-boot.dtsi
> > +++ b/arch/arm/dts/rk3399-ficus-u-boot.dtsi
> > @@ -3,4 +3,5 @@
> > * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com>
> > */
> >
> > +#include "rk3399-u-boot.dtsi"
> > #include "rk3399-sdram-ddr3-1600.dtsi"
> > diff --git a/arch/arm/dts/rk3399-ficus.dts b/arch/arm/dts/rk3399-ficus.dts
> > index 4b2dd82b67..0f219f4a9c 100644
> > --- a/arch/arm/dts/rk3399-ficus.dts
> > +++ b/arch/arm/dts/rk3399-ficus.dts
> > @@ -15,6 +15,8 @@
> >
> > chosen {
> > stdout-path = "serial2:1500000n8";
> > + u-boot,spl-boot-order = \
> > + &sdhci, &sdmmc;
> > };
> >
> > clkin_gmac: external-gmac-clock {
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/2] arm: dts: rock960: Enable booting from eMMC when using SPL
2019-05-20 15:46 [U-Boot] [PATCH 1/2] arm: dts: rock960: Enable booting from eMMC when using SPL Manivannan Sadhasivam
2019-05-20 15:46 ` [U-Boot] [PATCH 2/2] arm: dts: ficus: " Manivannan Sadhasivam
2019-05-27 6:49 ` [U-Boot] [PATCH 1/2] arm: dts: rock960: " Kever Yang
@ 2019-07-24 7:59 ` Peter Robinson
2019-07-24 9:11 ` Kever Yang
2019-07-24 9:13 ` Manivannan Sadhasivam
2 siblings, 2 replies; 10+ messages in thread
From: Peter Robinson @ 2019-07-24 7:59 UTC (permalink / raw)
To: u-boot
On Mon, May 20, 2019 at 4:47 PM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
>
> This commits enables booting from eMMC when using SPL on 96Boards
> Rock960 board by adding SDHCI to boot order. Since the SDHCI driver
> already has the reloc flag, this works straightaway.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> arch/arm/dts/rk3399-rock960-u-boot.dtsi | 1 +
> arch/arm/dts/rk3399-rock960.dts | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-rock960-u-boot.dtsi b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
> index 5256f6d3f2..7fb5072a9b 100644
> --- a/arch/arm/dts/rk3399-rock960-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
> @@ -3,4 +3,5 @@
> * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com>
> */
>
> +#include "rk3399-u-boot.dtsi"
> #include "rk3399-sdram-lpddr3-2GB-1600.dtsi"
> diff --git a/arch/arm/dts/rk3399-rock960.dts b/arch/arm/dts/rk3399-rock960.dts
> index 7e06bc97e5..c8b9075c73 100644
> --- a/arch/arm/dts/rk3399-rock960.dts
> +++ b/arch/arm/dts/rk3399-rock960.dts
> @@ -12,6 +12,8 @@
>
> chosen {
> stdout-path = "serial2:1500000n8";
> + u-boot,spl-boot-order = \
> + &sdhci, &sdmmc;
Shouldn't this bit be in the rk3399-rock960-u-boot.dtsi not
rk3399-rock960.dts because it's U-Boot specific?
> };
> };
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 2/2] arm: dts: ficus: Enable booting from eMMC when using SPL
2019-05-20 15:46 ` [U-Boot] [PATCH 2/2] arm: dts: ficus: " Manivannan Sadhasivam
2019-05-27 6:49 ` Kever Yang
@ 2019-07-24 8:03 ` Peter Robinson
1 sibling, 0 replies; 10+ messages in thread
From: Peter Robinson @ 2019-07-24 8:03 UTC (permalink / raw)
To: u-boot
On Mon, May 20, 2019 at 4:47 PM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
>
> This commits enables booting from eMMC when using SPL on 96Boards
> Ficus board by adding SDHCI to boot order. Since the SDHCI driver
> already has the reloc flag, this works straightaway.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> arch/arm/dts/rk3399-ficus-u-boot.dtsi | 1 +
> arch/arm/dts/rk3399-ficus.dts | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-ficus-u-boot.dtsi b/arch/arm/dts/rk3399-ficus-u-boot.dtsi
> index eab86bdb30..67b63a8352 100644
> --- a/arch/arm/dts/rk3399-ficus-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-ficus-u-boot.dtsi
> @@ -3,4 +3,5 @@
> * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com>
> */
>
> +#include "rk3399-u-boot.dtsi"
> #include "rk3399-sdram-ddr3-1600.dtsi"
> diff --git a/arch/arm/dts/rk3399-ficus.dts b/arch/arm/dts/rk3399-ficus.dts
> index 4b2dd82b67..0f219f4a9c 100644
> --- a/arch/arm/dts/rk3399-ficus.dts
> +++ b/arch/arm/dts/rk3399-ficus.dts
> @@ -15,6 +15,8 @@
>
> chosen {
> stdout-path = "serial2:1500000n8";
> + u-boot,spl-boot-order = \
> + &sdhci, &sdmmc;
Shouldn't this be in the rk3399-ficus-u-boot.dtsi above? It would get
lost with a resync of dts files from linux.
> };
>
> clkin_gmac: external-gmac-clock {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/2] arm: dts: rock960: Enable booting from eMMC when using SPL
2019-07-24 7:59 ` Peter Robinson
@ 2019-07-24 9:11 ` Kever Yang
2019-07-24 9:13 ` Manivannan Sadhasivam
1 sibling, 0 replies; 10+ messages in thread
From: Kever Yang @ 2019-07-24 9:11 UTC (permalink / raw)
To: u-boot
Hi Manivannan,
On 2019/7/24 下午3:59, Peter Robinson wrote:
> On Mon, May 20, 2019 at 4:47 PM Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org> wrote:
>> This commits enables booting from eMMC when using SPL on 96Boards
>> Rock960 board by adding SDHCI to boot order. Since the SDHCI driver
>> already has the reloc flag, this works straightaway.
>>
>> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>> ---
>> arch/arm/dts/rk3399-rock960-u-boot.dtsi | 1 +
>> arch/arm/dts/rk3399-rock960.dts | 2 ++
>> 2 files changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/dts/rk3399-rock960-u-boot.dtsi b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
>> index 5256f6d3f2..7fb5072a9b 100644
>> --- a/arch/arm/dts/rk3399-rock960-u-boot.dtsi
>> +++ b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
>> @@ -3,4 +3,5 @@
>> * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com>
>> */
>>
>> +#include "rk3399-u-boot.dtsi"
>> #include "rk3399-sdram-lpddr3-2GB-1600.dtsi"
>> diff --git a/arch/arm/dts/rk3399-rock960.dts b/arch/arm/dts/rk3399-rock960.dts
>> index 7e06bc97e5..c8b9075c73 100644
>> --- a/arch/arm/dts/rk3399-rock960.dts
>> +++ b/arch/arm/dts/rk3399-rock960.dts
>> @@ -12,6 +12,8 @@
>>
>> chosen {
>> stdout-path = "serial2:1500000n8";
>> + u-boot,spl-boot-order = \
>> + &sdhci, &sdmmc;
> Shouldn't this bit be in the rk3399-rock960-u-boot.dtsi not
> rk3399-rock960.dts because it's U-Boot specific?
Peter is correct, all the update to dts by U-Boot should go to
-u-boot.dtsi now,
could you update and send the patch again?
Thanks,
- Kever
>
>> };
>> };
>>
>> --
>> 2.17.1
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/2] arm: dts: rock960: Enable booting from eMMC when using SPL
2019-07-24 7:59 ` Peter Robinson
2019-07-24 9:11 ` Kever Yang
@ 2019-07-24 9:13 ` Manivannan Sadhasivam
1 sibling, 0 replies; 10+ messages in thread
From: Manivannan Sadhasivam @ 2019-07-24 9:13 UTC (permalink / raw)
To: u-boot
Hi Peter,
On 24 July 2019 1:29:27 PM IST, Peter Robinson <pbrobinson@gmail.com> wrote:
>On Mon, May 20, 2019 at 4:47 PM Manivannan Sadhasivam
><manivannan.sadhasivam@linaro.org> wrote:
>>
>> This commits enables booting from eMMC when using SPL on 96Boards
>> Rock960 board by adding SDHCI to boot order. Since the SDHCI driver
>> already has the reloc flag, this works straightaway.
>>
>> Signed-off-by: Manivannan Sadhasivam
><manivannan.sadhasivam@linaro.org>
>> ---
>> arch/arm/dts/rk3399-rock960-u-boot.dtsi | 1 +
>> arch/arm/dts/rk3399-rock960.dts | 2 ++
>> 2 files changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/dts/rk3399-rock960-u-boot.dtsi
>b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
>> index 5256f6d3f2..7fb5072a9b 100644
>> --- a/arch/arm/dts/rk3399-rock960-u-boot.dtsi
>> +++ b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
>> @@ -3,4 +3,5 @@
>> * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com>
>> */
>>
>> +#include "rk3399-u-boot.dtsi"
>> #include "rk3399-sdram-lpddr3-2GB-1600.dtsi"
>> diff --git a/arch/arm/dts/rk3399-rock960.dts
>b/arch/arm/dts/rk3399-rock960.dts
>> index 7e06bc97e5..c8b9075c73 100644
>> --- a/arch/arm/dts/rk3399-rock960.dts
>> +++ b/arch/arm/dts/rk3399-rock960.dts
>> @@ -12,6 +12,8 @@
>>
>> chosen {
>> stdout-path = "serial2:1500000n8";
>> + u-boot,spl-boot-order = \
>> + &sdhci, &sdmmc;
>
>Shouldn't this bit be in the rk3399-rock960-u-boot.dtsi not
>rk3399-rock960.dts because it's U-Boot specific?
>
Good catch! Will fix this and send next revision.
Thanks,
Mani
>> };
>> };
>>
>> --
>> 2.17.1
>>
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-07-24 9:13 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-20 15:46 [U-Boot] [PATCH 1/2] arm: dts: rock960: Enable booting from eMMC when using SPL Manivannan Sadhasivam
2019-05-20 15:46 ` [U-Boot] [PATCH 2/2] arm: dts: ficus: " Manivannan Sadhasivam
2019-05-27 6:49 ` Kever Yang
2019-07-23 15:07 ` Manivannan Sadhasivam
2019-07-24 8:03 ` Peter Robinson
2019-05-27 6:49 ` [U-Boot] [PATCH 1/2] arm: dts: rock960: " Kever Yang
2019-07-23 15:06 ` Manivannan Sadhasivam
2019-07-24 7:59 ` Peter Robinson
2019-07-24 9:11 ` Kever Yang
2019-07-24 9:13 ` Manivannan Sadhasivam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.