* [Qemu-devel] [PATCH] docs: smbios: remove family=x from type2 entry description
@ 2019-05-21 13:14 Igor Mammedov
2019-05-21 13:33 ` Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Igor Mammedov @ 2019-05-21 13:14 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, thuth, berrange, mst, armbru, pbonzini
'family' option is not part of type 2 table and if user tries to use it
as such QEMU will error out with an unknow option error.
Drop it from docs lest it confuse users.
Fixes: b155eb1d04
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 5daa5a8..dcdb808 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2080,7 +2080,7 @@ Specify SMBIOS type 0 fields
@item -smbios type=1[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,uuid=@var{uuid}][,sku=@var{str}][,family=@var{str}]
Specify SMBIOS type 1 fields
-@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}][,family=@var{str}]
+@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}]
Specify SMBIOS type 2 fields
@item -smbios type=3[,manufacturer=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,sku=@var{str}]
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] docs: smbios: remove family=x from type2 entry description
2019-05-21 13:14 [Qemu-devel] [PATCH] docs: smbios: remove family=x from type2 entry description Igor Mammedov
@ 2019-05-21 13:33 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2019-05-21 13:33 UTC (permalink / raw)
To: Igor Mammedov; +Cc: kwolf, thuth, berrange, qemu-devel, armbru, pbonzini
On Tue, May 21, 2019 at 03:14:46PM +0200, Igor Mammedov wrote:
> 'family' option is not part of type 2 table and if user tries to use it
> as such QEMU will error out with an unknow option error.
> Drop it from docs lest it confuse users.
>
> Fixes: b155eb1d04
Add summary after the hash within ("...") please.
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 5daa5a8..dcdb808 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2080,7 +2080,7 @@ Specify SMBIOS type 0 fields
> @item -smbios type=1[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,uuid=@var{uuid}][,sku=@var{str}][,family=@var{str}]
> Specify SMBIOS type 1 fields
>
> -@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}][,family=@var{str}]
> +@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}]
> Specify SMBIOS type 2 fields
>
> @item -smbios type=3[,manufacturer=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,sku=@var{str}]
> --
> 2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-21 13:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-21 13:14 [Qemu-devel] [PATCH] docs: smbios: remove family=x from type2 entry description Igor Mammedov
2019-05-21 13:33 ` Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.