All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Karsten Keil <isdn@linux-pingi.de>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] mISDN: Fix indenting in dsp_cmx.c
Date: Tue, 21 May 2019 13:27:42 +0300	[thread overview]
Message-ID: <20190521102742.GJ19380@kadam> (raw)
In-Reply-To: <60901822e34c6c715668dbcf7adbded312d19ea4.camel@perches.com>

On Tue, May 21, 2019 at 02:57:10AM -0700, Joe Perches wrote:
> On Tue, 2019-05-21 at 12:42 +0300, Dan Carpenter wrote:
> > We used a script to indent this code back in 2012, but I guess it got
> > confused by the ifdefs and added some extra tabs.  This patch removes
> > them.
> 
> Yup, thanks Dan.
> Emacs indent-region made a mess of it.
> 

The re-indent generally made things better and even in this case it
didn't really make it worse, just different.

regards,
dan carpenter


WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Karsten Keil <isdn@linux-pingi.de>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] mISDN: Fix indenting in dsp_cmx.c
Date: Tue, 21 May 2019 10:27:42 +0000	[thread overview]
Message-ID: <20190521102742.GJ19380@kadam> (raw)
In-Reply-To: <60901822e34c6c715668dbcf7adbded312d19ea4.camel@perches.com>

On Tue, May 21, 2019 at 02:57:10AM -0700, Joe Perches wrote:
> On Tue, 2019-05-21 at 12:42 +0300, Dan Carpenter wrote:
> > We used a script to indent this code back in 2012, but I guess it got
> > confused by the ifdefs and added some extra tabs.  This patch removes
> > them.
> 
> Yup, thanks Dan.
> Emacs indent-region made a mess of it.
> 

The re-indent generally made things better and even in this case it
didn't really make it worse, just different.

regards,
dan carpenter

  reply	other threads:[~2019-05-21 10:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21  9:42 [PATCH net] mISDN: Fix indenting in dsp_cmx.c Dan Carpenter
2019-05-21  9:42 ` Dan Carpenter
2019-05-21  9:57 ` Joe Perches
2019-05-21  9:57   ` Joe Perches
2019-05-21 10:27   ` Dan Carpenter [this message]
2019-05-21 10:27     ` Dan Carpenter
2019-05-22 19:14 ` David Miller
2019-05-22 19:14   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521102742.GJ19380@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=isdn@linux-pingi.de \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.