All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/fourcc: Fix the parameters name in the documentation
@ 2019-05-21 11:09 Maxime Ripard
  2019-05-21 12:41 ` Daniel Vetter
  0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2019-05-21 11:09 UTC (permalink / raw)
  To: Daniel Vetter, David Airlie, Maarten Lankhorst, Sean Paul, Maxime Ripard
  Cc: kbuild test robot, dri-devel

We introduced new functions in the commit bf39607c1614 ("drm/fourcc: Pass
the format_info pointer to drm_format_plane_width/height") based on
previous ones but with a slightly different prototype. However, the
documentation wasn't changed to reflect that change.

Fixes: bf39607c1614 ("drm/fourcc: Pass the format_info pointer to drm_format_plane_width/height")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 include/drm/drm_fourcc.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h
index 405466692bd2..306d1efeb5e0 100644
--- a/include/drm/drm_fourcc.h
+++ b/include/drm/drm_fourcc.h
@@ -262,7 +262,7 @@ drm_format_info_is_yuv_sampling_444(const struct drm_format_info *info)
 
 /**
  * drm_format_info_plane_width - width of the plane given the first plane
- * @format: pixel format info
+ * @info: pixel format info
  * @width: width of the first plane
  * @plane: plane index
  *
@@ -284,7 +284,7 @@ int drm_format_info_plane_width(const struct drm_format_info *info, int width,
 
 /**
  * drm_format_info_plane_height - height of the plane given the first plane
- * @format: pixel format info
+ * @info: pixel format info
  * @height: height of the first plane
  * @plane: plane index
  *
-- 
2.21.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/fourcc: Fix the parameters name in the documentation
  2019-05-21 11:09 [PATCH] drm/fourcc: Fix the parameters name in the documentation Maxime Ripard
@ 2019-05-21 12:41 ` Daniel Vetter
  2019-05-21 14:58   ` Maxime Ripard
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2019-05-21 12:41 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: kbuild test robot, David Airlie, dri-devel, Sean Paul, Daniel Vetter

On Tue, May 21, 2019 at 01:09:06PM +0200, Maxime Ripard wrote:
> We introduced new functions in the commit bf39607c1614 ("drm/fourcc: Pass
> the format_info pointer to drm_format_plane_width/height") based on
> previous ones but with a slightly different prototype. However, the
> documentation wasn't changed to reflect that change.
> 
> Fixes: bf39607c1614 ("drm/fourcc: Pass the format_info pointer to drm_format_plane_width/height")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
>  include/drm/drm_fourcc.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h
> index 405466692bd2..306d1efeb5e0 100644
> --- a/include/drm/drm_fourcc.h
> +++ b/include/drm/drm_fourcc.h
> @@ -262,7 +262,7 @@ drm_format_info_is_yuv_sampling_444(const struct drm_format_info *info)
>  
>  /**
>   * drm_format_info_plane_width - width of the plane given the first plane
> - * @format: pixel format info
> + * @info: pixel format info
>   * @width: width of the first plane
>   * @plane: plane index
>   *
> @@ -284,7 +284,7 @@ int drm_format_info_plane_width(const struct drm_format_info *info, int width,
>  
>  /**
>   * drm_format_info_plane_height - height of the plane given the first plane
> - * @format: pixel format info
> + * @info: pixel format info
>   * @height: height of the first plane
>   * @plane: plane index
>   *
> -- 
> 2.21.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/fourcc: Fix the parameters name in the documentation
  2019-05-21 12:41 ` Daniel Vetter
@ 2019-05-21 14:58   ` Maxime Ripard
  0 siblings, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2019-05-21 14:58 UTC (permalink / raw)
  To: Daniel Vetter
  Cc: kbuild test robot, David Airlie, dri-devel, Sean Paul, Daniel Vetter


[-- Attachment #1.1: Type: text/plain, Size: 791 bytes --]

On Tue, May 21, 2019 at 02:41:30PM +0200, Daniel Vetter wrote:
> On Tue, May 21, 2019 at 01:09:06PM +0200, Maxime Ripard wrote:
> > We introduced new functions in the commit bf39607c1614 ("drm/fourcc: Pass
> > the format_info pointer to drm_format_plane_width/height") based on
> > previous ones but with a slightly different prototype. However, the
> > documentation wasn't changed to reflect that change.
> >
> > Fixes: bf39607c1614 ("drm/fourcc: Pass the format_info pointer to drm_format_plane_width/height")
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Applied, thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-21 14:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-21 11:09 [PATCH] drm/fourcc: Fix the parameters name in the documentation Maxime Ripard
2019-05-21 12:41 ` Daniel Vetter
2019-05-21 14:58   ` Maxime Ripard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.