[PATCH] glib-networking: add PACKAGECONFIG for openssl

[PATCH] glib-networking: add PACKAGECONFIG for openssl

[Martin Jansa]

* gnutls from meta-gplv2 isn't new enough for this version of glib-networking:
  meson.build:74:0: ERROR:  Invalid version of dependency, need 'gnutls' ['>= 3.4.6'] found '3.3.30'

* disabling gnutls PACKAGECONFIG isn't an option either:
  meson.build:131:2: ERROR:  Problem encountered: No TLS backends enabled. Please enable at least one TLS backend

* add an option to replace gnutls with openssl

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/recipes-core/glib-networking/glib-networking_2.60.1.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
index 09af229d69..e2b4cffb2b 100644
--- a/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
+++ b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
@@ -15,6 +15,7 @@ SRC_URI[archive.sha256sum] = "d71c6b2faa5ac29100314f08a1be020a2afd0291f025614c0a
 PACKAGECONFIG ??= "gnutls"
 
 PACKAGECONFIG[gnutls] = "-Dgnutls=enabled,-Dgnutls=disabled,gnutls"
+PACKAGECONFIG[openssl] = "-Dopenssl=enabled,-Dopenssl=disabled,openssl"
 PACKAGECONFIG[libproxy] = "-Dlibproxy=enabled,-Dlibproxy=disabled,libproxy"
 
 EXTRA_OEMESON = "-Dgnome_proxy=disabled"
-- 
2.17.1

Re: [PATCH] glib-networking: add PACKAGECONFIG for openssl

[akuster808]

should we change the default to openssl ?

- armin

On 5/10/19 2:55 PM, Martin Jansa wrote:
> * gnutls from meta-gplv2 isn't new enough for this version of glib-networking:
>   meson.build:74:0: ERROR:  Invalid version of dependency, need 'gnutls' ['>= 3.4.6'] found '3.3.30'
>
> * disabling gnutls PACKAGECONFIG isn't an option either:
>   meson.build:131:2: ERROR:  Problem encountered: No TLS backends enabled. Please enable at least one TLS backend
>
> * add an option to replace gnutls with openssl
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/recipes-core/glib-networking/glib-networking_2.60.1.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> index 09af229d69..e2b4cffb2b 100644
> --- a/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> +++ b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> @@ -15,6 +15,7 @@ SRC_URI[archive.sha256sum] = "d71c6b2faa5ac29100314f08a1be020a2afd0291f025614c0a
>  PACKAGECONFIG ??= "gnutls"
>  
>  PACKAGECONFIG[gnutls] = "-Dgnutls=enabled,-Dgnutls=disabled,gnutls"
> +PACKAGECONFIG[openssl] = "-Dopenssl=enabled,-Dopenssl=disabled,openssl"
>  PACKAGECONFIG[libproxy] = "-Dlibproxy=enabled,-Dlibproxy=disabled,libproxy"
>  
>  EXTRA_OEMESON = "-Dgnome_proxy=disabled"

Re: [PATCH] glib-networking: add PACKAGECONFIG for openssl

[Khem Raj]

On 5/10/19 3:13 PM, akuster808 wrote:
> should we change the default to openssl ?
> 

I dont think so. Since newer versions of gnuTLS works okay.

> - armin
> 
> On 5/10/19 2:55 PM, Martin Jansa wrote:
>> * gnutls from meta-gplv2 isn't new enough for this version of glib-networking:
>>    meson.build:74:0: ERROR:  Invalid version of dependency, need 'gnutls' ['>= 3.4.6'] found '3.3.30'
>>
>> * disabling gnutls PACKAGECONFIG isn't an option either:
>>    meson.build:131:2: ERROR:  Problem encountered: No TLS backends enabled. Please enable at least one TLS backend
>>
>> * add an option to replace gnutls with openssl
>>
>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>> ---
>>   meta/recipes-core/glib-networking/glib-networking_2.60.1.bb | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
>> index 09af229d69..e2b4cffb2b 100644
>> --- a/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
>> +++ b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
>> @@ -15,6 +15,7 @@ SRC_URI[archive.sha256sum] = "d71c6b2faa5ac29100314f08a1be020a2afd0291f025614c0a
>>   PACKAGECONFIG ??= "gnutls"
>>   
>>   PACKAGECONFIG[gnutls] = "-Dgnutls=enabled,-Dgnutls=disabled,gnutls"
>> +PACKAGECONFIG[openssl] = "-Dopenssl=enabled,-Dopenssl=disabled,openssl"
>>   PACKAGECONFIG[libproxy] = "-Dlibproxy=enabled,-Dlibproxy=disabled,libproxy"
>>   
>>   EXTRA_OEMESON = "-Dgnome_proxy=disabled"
> 

Re: [PATCH] glib-networking: add PACKAGECONFIG for openssl

[Andre McCurdy]

On Fri, May 10, 2019 at 3:16 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> On 5/10/19 3:13 PM, akuster808 wrote:
> > should we change the default to openssl ?
>
> I dont think so. Since newer versions of gnuTLS works okay.

Isn't one of the goals for OE 2.8 to replace dependencies on [L]GPLv3
components with non-[L]GPLv3 alternatives so that meta-gplv2 can be
deprecated? This would seem to fit that goal exactly.

It wasn't possible to build glib-networking with openssl until very
recently but now that it's supported upstream I think we should
switch.

  https://github.com/GNOME/glib-networking/blob/master/NEWS

> > - armin
> >
> > On 5/10/19 2:55 PM, Martin Jansa wrote:
> >> * gnutls from meta-gplv2 isn't new enough for this version of glib-networking:
> >>    meson.build:74:0: ERROR:  Invalid version of dependency, need 'gnutls' ['>= 3.4.6'] found '3.3.30'
> >>
> >> * disabling gnutls PACKAGECONFIG isn't an option either:
> >>    meson.build:131:2: ERROR:  Problem encountered: No TLS backends enabled. Please enable at least one TLS backend
> >>
> >> * add an option to replace gnutls with openssl
> >>
> >> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> >> ---
> >>   meta/recipes-core/glib-networking/glib-networking_2.60.1.bb | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> >> index 09af229d69..e2b4cffb2b 100644
> >> --- a/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> >> +++ b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> >> @@ -15,6 +15,7 @@ SRC_URI[archive.sha256sum] = "d71c6b2faa5ac29100314f08a1be020a2afd0291f025614c0a
> >>   PACKAGECONFIG ??= "gnutls"
> >>
> >>   PACKAGECONFIG[gnutls] = "-Dgnutls=enabled,-Dgnutls=disabled,gnutls"
> >> +PACKAGECONFIG[openssl] = "-Dopenssl=enabled,-Dopenssl=disabled,openssl"
> >>   PACKAGECONFIG[libproxy] = "-Dlibproxy=enabled,-Dlibproxy=disabled,libproxy"
> >>
> >>   EXTRA_OEMESON = "-Dgnome_proxy=disabled"
> >
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] glib-networking: add PACKAGECONFIG for openssl

[Khem Raj]

On 5/10/19 4:00 PM, Andre McCurdy wrote:
> On Fri, May 10, 2019 at 3:16 PM Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On 5/10/19 3:13 PM, akuster808 wrote:
>>> should we change the default to openssl ?
>>
>> I dont think so. Since newer versions of gnuTLS works okay.
> 
> Isn't one of the goals for OE 2.8 to replace dependencies on [L]GPLv3
> components with non-[L]GPLv3 alternatives so that meta-gplv2 can be
> deprecated? This would seem to fit that goal exactly.

Is that stated somewhere ? while I like the goal probably I missed the 
memo, my suggestion was just to give openssl backend some time to mature 
since its relatively new, and maybe give it some soak time

> 
> It wasn't possible to build glib-networking with openssl until very
> recently but now that it's supported upstream I think we should
> switch.
> 
>    https://github.com/GNOME/glib-networking/blob/master/NEWS
> 
>>> - armin
>>>
>>> On 5/10/19 2:55 PM, Martin Jansa wrote:
>>>> * gnutls from meta-gplv2 isn't new enough for this version of glib-networking:
>>>>     meson.build:74:0: ERROR:  Invalid version of dependency, need 'gnutls' ['>= 3.4.6'] found '3.3.30'
>>>>
>>>> * disabling gnutls PACKAGECONFIG isn't an option either:
>>>>     meson.build:131:2: ERROR:  Problem encountered: No TLS backends enabled. Please enable at least one TLS backend
>>>>
>>>> * add an option to replace gnutls with openssl
>>>>
>>>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>>>> ---
>>>>    meta/recipes-core/glib-networking/glib-networking_2.60.1.bb | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
>>>> index 09af229d69..e2b4cffb2b 100644
>>>> --- a/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
>>>> +++ b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
>>>> @@ -15,6 +15,7 @@ SRC_URI[archive.sha256sum] = "d71c6b2faa5ac29100314f08a1be020a2afd0291f025614c0a
>>>>    PACKAGECONFIG ??= "gnutls"
>>>>
>>>>    PACKAGECONFIG[gnutls] = "-Dgnutls=enabled,-Dgnutls=disabled,gnutls"
>>>> +PACKAGECONFIG[openssl] = "-Dopenssl=enabled,-Dopenssl=disabled,openssl"
>>>>    PACKAGECONFIG[libproxy] = "-Dlibproxy=enabled,-Dlibproxy=disabled,libproxy"
>>>>
>>>>    EXTRA_OEMESON = "-Dgnome_proxy=disabled"
>>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] glib-networking: add PACKAGECONFIG for openssl

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3270 bytes --]

On Fri, May 10, 2019 at 04:54:57PM -0700, Khem Raj wrote:
> 
> 
> On 5/10/19 4:00 PM, Andre McCurdy wrote:
> > On Fri, May 10, 2019 at 3:16 PM Khem Raj <raj.khem@gmail.com> wrote:
> >>
> >> On 5/10/19 3:13 PM, akuster808 wrote:
> >>> should we change the default to openssl ?
> >>
> >> I dont think so. Since newer versions of gnuTLS works okay.
> > 
> > Isn't one of the goals for OE 2.8 to replace dependencies on [L]GPLv3
> > components with non-[L]GPLv3 alternatives so that meta-gplv2 can be
> > deprecated? This would seem to fit that goal exactly.
> 
> Is that stated somewhere ? while I like the goal probably I missed the 
> memo, my suggestion was just to give openssl backend some time to mature 
> since its relatively new, and maybe give it some soak time
> 
> > 
> > It wasn't possible to build glib-networking with openssl until very
> > recently but now that it's supported upstream I think we should
> > switch.
> > 
> >    https://github.com/GNOME/glib-networking/blob/master/NEWS

I don't have strong opinion either way.

I didn't want to change the default, because my only motivation was the
license issue with the newer gnutls, with the PACKAGECONFIG available
it's easy to change the TLS backend and that's all I need.

Will send v2 if there is some consensus from glib-networking users that
it should be changed and someone provides me the reasoning for the
commit message.

Cheers,

> > 
> >>> - armin
> >>>
> >>> On 5/10/19 2:55 PM, Martin Jansa wrote:
> >>>> * gnutls from meta-gplv2 isn't new enough for this version of glib-networking:
> >>>>     meson.build:74:0: ERROR:  Invalid version of dependency, need 'gnutls' ['>= 3.4.6'] found '3.3.30'
> >>>>
> >>>> * disabling gnutls PACKAGECONFIG isn't an option either:
> >>>>     meson.build:131:2: ERROR:  Problem encountered: No TLS backends enabled. Please enable at least one TLS backend
> >>>>
> >>>> * add an option to replace gnutls with openssl
> >>>>
> >>>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> >>>> ---
> >>>>    meta/recipes-core/glib-networking/glib-networking_2.60.1.bb | 1 +
> >>>>    1 file changed, 1 insertion(+)
> >>>>
> >>>> diff --git a/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> >>>> index 09af229d69..e2b4cffb2b 100644
> >>>> --- a/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> >>>> +++ b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> >>>> @@ -15,6 +15,7 @@ SRC_URI[archive.sha256sum] = "d71c6b2faa5ac29100314f08a1be020a2afd0291f025614c0a
> >>>>    PACKAGECONFIG ??= "gnutls"
> >>>>
> >>>>    PACKAGECONFIG[gnutls] = "-Dgnutls=enabled,-Dgnutls=disabled,gnutls"
> >>>> +PACKAGECONFIG[openssl] = "-Dopenssl=enabled,-Dopenssl=disabled,openssl"
> >>>>    PACKAGECONFIG[libproxy] = "-Dlibproxy=enabled,-Dlibproxy=disabled,libproxy"
> >>>>
> >>>>    EXTRA_OEMESON = "-Dgnome_proxy=disabled"
> >>>
> >> --
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

Re: [PATCH] glib-networking: add PACKAGECONFIG for openssl

[Joshua Watt]

[-- Attachment #1: Type: text/plain, Size: 4008 bytes --]

On Fri, May 10, 2019, 8:04 PM Martin Jansa <martin.jansa@gmail.com> wrote:

> On Fri, May 10, 2019 at 04:54:57PM -0700, Khem Raj wrote:
> >
> >
> > On 5/10/19 4:00 PM, Andre McCurdy wrote:
> > > On Fri, May 10, 2019 at 3:16 PM Khem Raj <raj.khem@gmail.com> wrote:
> > >>
> > >> On 5/10/19 3:13 PM, akuster808 wrote:
> > >>> should we change the default to openssl ?
> > >>
> > >> I dont think so. Since newer versions of gnuTLS works okay.
> > >
> > > Isn't one of the goals for OE 2.8 to replace dependencies on [L]GPLv3
> > > components with non-[L]GPLv3 alternatives so that meta-gplv2 can be
> > > deprecated? This would seem to fit that goal exactly.
> >
> > Is that stated somewhere ? while I like the goal probably I missed the
> > memo, my suggestion was just to give openssl backend some time to mature
> > since its relatively new, and maybe give it some soak time
> >
> > >
> > > It wasn't possible to build glib-networking with openssl until very
> > > recently but now that it's supported upstream I think we should
> > > switch.
> > >
> > >    https://github.com/GNOME/glib-networking/blob/master/NEWS
>
> I don't have strong opinion either way.
>
> I didn't want to change the default, because my only motivation was the
> license issue with the newer gnutls, with the PACKAGECONFIG available
> it's easy to change the TLS backend and that's all I need.
>
> Will send v2 if there is some consensus from glib-networking users that
> it should be changed and someone provides me the reasoning for the
> commit message.
>

FWIW, moving away from GPLv3 and/or meta-gplv2 has been discussed in the
2.8 planning meetings:
https://docs.google.com/document/d/1CNEKA4d0eT6-e0hnS2pwi7xdZ5_t6smpZO2HbaJGXbU/edit?usp=drivesdk

Not that it needs to be done right now. It is nice to at least have the
option.


> Cheers,
>
> > >
> > >>> - armin
> > >>>
> > >>> On 5/10/19 2:55 PM, Martin Jansa wrote:
> > >>>> * gnutls from meta-gplv2 isn't new enough for this version of
> glib-networking:
> > >>>>     meson.build:74:0: ERROR:  Invalid version of dependency, need
> 'gnutls' ['>= 3.4.6'] found '3.3.30'
> > >>>>
> > >>>> * disabling gnutls PACKAGECONFIG isn't an option either:
> > >>>>     meson.build:131:2: ERROR:  Problem encountered: No TLS backends
> enabled. Please enable at least one TLS backend
> > >>>>
> > >>>> * add an option to replace gnutls with openssl
> > >>>>
> > >>>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > >>>> ---
> > >>>>    meta/recipes-core/glib-networking/glib-networking_2.60.1.bb | 1
> +
> > >>>>    1 file changed, 1 insertion(+)
> > >>>>
> > >>>> diff --git a/meta/recipes-core/glib-networking/
> glib-networking_2.60.1.bb b/meta/recipes-core/glib-networking/
> glib-networking_2.60.1.bb
> > >>>> index 09af229d69..e2b4cffb2b 100644
> > >>>> --- a/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> > >>>> +++ b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> > >>>> @@ -15,6 +15,7 @@ SRC_URI[archive.sha256sum] =
> "d71c6b2faa5ac29100314f08a1be020a2afd0291f025614c0a
> > >>>>    PACKAGECONFIG ??= "gnutls"
> > >>>>
> > >>>>    PACKAGECONFIG[gnutls] =
> "-Dgnutls=enabled,-Dgnutls=disabled,gnutls"
> > >>>> +PACKAGECONFIG[openssl] =
> "-Dopenssl=enabled,-Dopenssl=disabled,openssl"
> > >>>>    PACKAGECONFIG[libproxy] =
> "-Dlibproxy=enabled,-Dlibproxy=disabled,libproxy"
> > >>>>
> > >>>>    EXTRA_OEMESON = "-Dgnome_proxy=disabled"
> > >>>
> > >> --
> > >> _______________________________________________
> > >> Openembedded-core mailing list
> > >> Openembedded-core@lists.openembedded.org
> > >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 6829 bytes --]

Re: [PATCH] glib-networking: add PACKAGECONFIG for openssl

[Adrian Bunk]

On Fri, May 10, 2019 at 04:00:45PM -0700, Andre McCurdy wrote:
>...
> It wasn't possible to build glib-networking with openssl until very
> recently but now that it's supported upstream I think we should
> switch.
> 
>   https://github.com/GNOME/glib-networking/blob/master/NEWS

This states clearly that we should not switch:

  This is the first stable release featuring the new OpenSSL backend.
  Please be advised that this new backend is still experimental and
  known to not work on some systems, including Debian. Linux
  distributions are encouraged to stick to the default build options,
  where OpenSSL is not yet enabled.


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH] glib-networking: add PACKAGECONFIG for openssl

[Adrian Bunk]

On Fri, May 10, 2019 at 08:17:50PM -0500, Joshua Watt wrote:
> On Fri, May 10, 2019, 8:04 PM Martin Jansa <martin.jansa@gmail.com> wrote:
> 
> > On Fri, May 10, 2019 at 04:54:57PM -0700, Khem Raj wrote:
> > >
> > >
> > > On 5/10/19 4:00 PM, Andre McCurdy wrote:
> > > > On Fri, May 10, 2019 at 3:16 PM Khem Raj <raj.khem@gmail.com> wrote:
> > > >>
> > > >> On 5/10/19 3:13 PM, akuster808 wrote:
> > > >>> should we change the default to openssl ?
> > > >>
> > > >> I dont think so. Since newer versions of gnuTLS works okay.
> > > >
> > > > Isn't one of the goals for OE 2.8 to replace dependencies on [L]GPLv3
> > > > components with non-[L]GPLv3 alternatives so that meta-gplv2 can be
> > > > deprecated? This would seem to fit that goal exactly.
> > >
> > > Is that stated somewhere ? while I like the goal probably I missed the
> > > memo, my suggestion was just to give openssl backend some time to mature
> > > since its relatively new, and maybe give it some soak time
> > >
> > > >
> > > > It wasn't possible to build glib-networking with openssl until very
> > > > recently but now that it's supported upstream I think we should
> > > > switch.
> > > >
> > > >    https://github.com/GNOME/glib-networking/blob/master/NEWS
> >
> > I don't have strong opinion either way.
> >
> > I didn't want to change the default, because my only motivation was the
> > license issue with the newer gnutls, with the PACKAGECONFIG available
> > it's easy to change the TLS backend and that's all I need.
> >
> > Will send v2 if there is some consensus from glib-networking users that
> > it should be changed and someone provides me the reasoning for the
> > commit message.
> >
> 
> FWIW, moving away from GPLv3 and/or meta-gplv2 has been discussed in the
> 2.8 planning meetings:
> https://docs.google.com/document/d/1CNEKA4d0eT6-e0hnS2pwi7xdZ5_t6smpZO2HbaJGXbU/edit?usp=drivesdk
> 
> Not that it needs to be done right now. It is nice to at least have the
> option.

It doesn't read as if "replace dependencies on [L]GPLv3 components" or
"moving away from GPLv3" would charcterize it correctly.

It says to create a *configuration* for the small subset of Yocto users 
who do not want to have GPLv3 code on their target.

For these users it is clear that they want to use openssl if they use
glib-networking,[1] and that they want to stick with busybox applets
instead of bash and all the GNU utilities.

For everyone else nothing has to change.

cu
Adrian

[1] Which BTW creates its own licence headaches due to OpenSSL having
    a GPL-incompatible licence.

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH] glib-networking: add PACKAGECONFIG for openssl

[Joshua Watt]

[-- Attachment #1: Type: text/plain, Size: 3269 bytes --]

On Sat, May 11, 2019, 2:20 AM Adrian Bunk <bunk@stusta.de> wrote:

> On Fri, May 10, 2019 at 08:17:50PM -0500, Joshua Watt wrote:
> > On Fri, May 10, 2019, 8:04 PM Martin Jansa <martin.jansa@gmail.com>
> wrote:
> >
> > > On Fri, May 10, 2019 at 04:54:57PM -0700, Khem Raj wrote:
> > > >
> > > >
> > > > On 5/10/19 4:00 PM, Andre McCurdy wrote:
> > > > > On Fri, May 10, 2019 at 3:16 PM Khem Raj <raj.khem@gmail.com>
> wrote:
> > > > >>
> > > > >> On 5/10/19 3:13 PM, akuster808 wrote:
> > > > >>> should we change the default to openssl ?
> > > > >>
> > > > >> I dont think so. Since newer versions of gnuTLS works okay.
> > > > >
> > > > > Isn't one of the goals for OE 2.8 to replace dependencies on
> [L]GPLv3
> > > > > components with non-[L]GPLv3 alternatives so that meta-gplv2 can be
> > > > > deprecated? This would seem to fit that goal exactly.
> > > >
> > > > Is that stated somewhere ? while I like the goal probably I missed
> the
> > > > memo, my suggestion was just to give openssl backend some time to
> mature
> > > > since its relatively new, and maybe give it some soak time
> > > >
> > > > >
> > > > > It wasn't possible to build glib-networking with openssl until very
> > > > > recently but now that it's supported upstream I think we should
> > > > > switch.
> > > > >
> > > > >    https://github.com/GNOME/glib-networking/blob/master/NEWS
> > >
> > > I don't have strong opinion either way.
> > >
> > > I didn't want to change the default, because my only motivation was the
> > > license issue with the newer gnutls, with the PACKAGECONFIG available
> > > it's easy to change the TLS backend and that's all I need.
> > >
> > > Will send v2 if there is some consensus from glib-networking users that
> > > it should be changed and someone provides me the reasoning for the
> > > commit message.
> > >
> >
> > FWIW, moving away from GPLv3 and/or meta-gplv2 has been discussed in the
> > 2.8 planning meetings:
> >
> https://docs.google.com/document/d/1CNEKA4d0eT6-e0hnS2pwi7xdZ5_t6smpZO2HbaJGXbU/edit?usp=drivesdk
> >
> > Not that it needs to be done right now. It is nice to at least have the
> > option.
>
> It doesn't read as if "replace dependencies on [L]GPLv3 components" or
> "moving away from GPLv3" would charcterize it correctly.
>
> It says to create a *configuration* for the small subset of Yocto users
> who do not want to have GPLv3 code on their target.
>
> For these users it is clear that they want to use openssl if they use
> glib-networking,[1] and that they want to stick with busybox applets
> instead of bash and all the GNU utilities.
>

Right, I was a little too strong there; I didn't mean to imply that anyone
is proposing to completely remove GPLv3, just provide alternatives that
aren't meta-gplv2.


> For everyone else nothing has to change.
>
> cu
> Adrian
>
> [1] Which BTW creates its own licence headaches due to OpenSSL having
>     a GPL-incompatible licence.
>
> --
>
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
>
>

[-- Attachment #2: Type: text/html, Size: 4917 bytes --]

Re: [PATCH] glib-networking: add PACKAGECONFIG for openssl

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1731 bytes --]

Thanks all, I think the discussion made it clear that we shouldn't change
the default yet.

Makes it easier for me as I'll need this PACKAGECONFIG backported to
warrior as well (and we shouldn't change the default there for sure).

RP: please take this for some next master-next.

On Fri, May 10, 2019 at 11:54 PM Martin Jansa <martin.jansa@gmail.com>
wrote:

> * gnutls from meta-gplv2 isn't new enough for this version of
> glib-networking:
>   meson.build:74:0: ERROR:  Invalid version of dependency, need 'gnutls'
> ['>= 3.4.6'] found '3.3.30'
>
> * disabling gnutls PACKAGECONFIG isn't an option either:
>   meson.build:131:2: ERROR:  Problem encountered: No TLS backends enabled.
> Please enable at least one TLS backend
>
> * add an option to replace gnutls with openssl
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/recipes-core/glib-networking/glib-networking_2.60.1.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> index 09af229d69..e2b4cffb2b 100644
> --- a/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> +++ b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> @@ -15,6 +15,7 @@ SRC_URI[archive.sha256sum] =
> "d71c6b2faa5ac29100314f08a1be020a2afd0291f025614c0a
>  PACKAGECONFIG ??= "gnutls"
>
>  PACKAGECONFIG[gnutls] = "-Dgnutls=enabled,-Dgnutls=disabled,gnutls"
> +PACKAGECONFIG[openssl] = "-Dopenssl=enabled,-Dopenssl=disabled,openssl"
>  PACKAGECONFIG[libproxy] =
> "-Dlibproxy=enabled,-Dlibproxy=disabled,libproxy"
>
>  EXTRA_OEMESON = "-Dgnome_proxy=disabled"
> --
> 2.17.1
>
>

[-- Attachment #2: Type: text/html, Size: 2671 bytes --]

Re: [PATCH] glib-networking: add PACKAGECONFIG for openssl

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

On Tue, May 14, 2019 at 02:02:10PM +0200, Martin Jansa wrote:
> Thanks all, I think the discussion made it clear that we shouldn't change
> the default yet.
> 
> Makes it easier for me as I'll need this PACKAGECONFIG backported to
> warrior as well (and we shouldn't change the default there for sure).
> 
> RP: please take this for some next master-next.

Ping?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]