All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pankaj Gupta <pagupta@redhat.com>
To: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org,
	qemu-devel@nongnu.org, linux-ext4@vger.kernel.org,
	linux-xfs@vger.kernel.org, dm-devel@redhat.com
Cc: rdunlap@infradead.org, jack@suse.cz, snitzer@redhat.com,
	mst@redhat.com, jasowang@redhat.com, david@fromorbit.com,
	lcapitulino@redhat.com, adilger.kernel@dilger.ca,
	zwisler@kernel.org, aarcange@redhat.com, jstaron@google.com,
	darrick.wong@oracle.com, david@redhat.com, willy@infradead.org,
	hch@infradead.org, nilal@redhat.com, lenb@kernel.org,
	kilobyte@angband.pl, riel@surriel.com, yuval.shaia@oracle.com,
	stefanha@redhat.com, pbonzini@redhat.com, kwolf@redhat.com,
	tytso@mit.edu, xiaoguangrong.eric@gmail.com, cohuck@redhat.com,
	rjw@rjwysocki.net, imammedo@redhat.com
Subject: [PATCH v10 4/7] dm: enable synchronous dax
Date: Tue, 21 May 2019 19:07:10 +0530	[thread overview]
Message-ID: <20190521133713.31653-5-pagupta@redhat.com> (raw)
In-Reply-To: <20190521133713.31653-1-pagupta@redhat.com>

 This patch sets dax device 'DAXDEV_SYNC' flag if all the target
 devices of device mapper support synchrononous DAX. If device
 mapper consists of both synchronous and asynchronous dax devices,
 we don't set 'DAXDEV_SYNC' flag. 

Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
---
 drivers/md/dm-table.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index cde3b49b2a91..1cce626ff576 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -886,10 +886,17 @@ static int device_supports_dax(struct dm_target *ti, struct dm_dev *dev,
 	return bdev_dax_supported(dev->bdev, PAGE_SIZE);
 }
 
+static int device_synchronous(struct dm_target *ti, struct dm_dev *dev,
+			       sector_t start, sector_t len, void *data)
+{
+	return dax_synchronous(dev->dax_dev);
+}
+
 static bool dm_table_supports_dax(struct dm_table *t)
 {
 	struct dm_target *ti;
 	unsigned i;
+	bool dax_sync = true;
 
 	/* Ensure that all targets support DAX. */
 	for (i = 0; i < dm_table_get_num_targets(t); i++) {
@@ -901,7 +908,14 @@ static bool dm_table_supports_dax(struct dm_table *t)
 		if (!ti->type->iterate_devices ||
 		    !ti->type->iterate_devices(ti, device_supports_dax, NULL))
 			return false;
+
+		/* Check devices support synchronous DAX */
+		if (dax_sync &&
+		    !ti->type->iterate_devices(ti, device_synchronous, NULL))
+			dax_sync = false;
 	}
+	if (dax_sync)
+		set_dax_synchronous(t->md->dax_dev);
 
 	return true;
 }
-- 
2.20.1

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Pankaj Gupta <pagupta@redhat.com>
To: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org,
	qemu-devel@nongnu.org, linux-ext4@vger.kernel.org,
	linux-xfs@vger.kernel.org, dm-devel@redhat.com
Cc: dan.j.williams@intel.com, zwisler@kernel.org,
	vishal.l.verma@intel.com, dave.jiang@intel.com, mst@redhat.com,
	jasowang@redhat.com, willy@infradead.org, rjw@rjwysocki.net,
	hch@infradead.org, lenb@kernel.org, jack@suse.cz, tytso@mit.edu,
	adilger.kernel@dilger.ca, darrick.wong@oracle.com,
	lcapitulino@redhat.com, kwolf@redhat.com, imammedo@redhat.com,
	jmoyer@redhat.com, nilal@redhat.com, riel@surriel.com,
	stefanha@redhat.com, aarcange@redhat.com, david@redhat.com,
	david@fromorbit.com, cohuck@redhat.com,
	xiaoguangrong.eric@gmail.com, pagupta@redhat.com,
	pbonzini@redhat.com, yuval.shaia@oracle.com, kilobyte@angband.pl,
	jstaron@google.com, rdunlap@infradead.org, snitzer@redhat.com
Subject: [PATCH v10 4/7] dm: enable synchronous dax
Date: Tue, 21 May 2019 19:07:10 +0530	[thread overview]
Message-ID: <20190521133713.31653-5-pagupta@redhat.com> (raw)
In-Reply-To: <20190521133713.31653-1-pagupta@redhat.com>

 This patch sets dax device 'DAXDEV_SYNC' flag if all the target
 devices of device mapper support synchrononous DAX. If device
 mapper consists of both synchronous and asynchronous dax devices,
 we don't set 'DAXDEV_SYNC' flag. 

Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
---
 drivers/md/dm-table.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index cde3b49b2a91..1cce626ff576 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -886,10 +886,17 @@ static int device_supports_dax(struct dm_target *ti, struct dm_dev *dev,
 	return bdev_dax_supported(dev->bdev, PAGE_SIZE);
 }
 
+static int device_synchronous(struct dm_target *ti, struct dm_dev *dev,
+			       sector_t start, sector_t len, void *data)
+{
+	return dax_synchronous(dev->dax_dev);
+}
+
 static bool dm_table_supports_dax(struct dm_table *t)
 {
 	struct dm_target *ti;
 	unsigned i;
+	bool dax_sync = true;
 
 	/* Ensure that all targets support DAX. */
 	for (i = 0; i < dm_table_get_num_targets(t); i++) {
@@ -901,7 +908,14 @@ static bool dm_table_supports_dax(struct dm_table *t)
 		if (!ti->type->iterate_devices ||
 		    !ti->type->iterate_devices(ti, device_supports_dax, NULL))
 			return false;
+
+		/* Check devices support synchronous DAX */
+		if (dax_sync &&
+		    !ti->type->iterate_devices(ti, device_synchronous, NULL))
+			dax_sync = false;
 	}
+	if (dax_sync)
+		set_dax_synchronous(t->md->dax_dev);
 
 	return true;
 }
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Pankaj Gupta <pagupta@redhat.com>
To: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org,
	qemu-devel@nongnu.org, linux-ext4@vger.kernel.org,
	linux-xfs@vger.kernel.org, dm-devel@redhat.com
Cc: pagupta@redhat.com, rdunlap@infradead.org, jack@suse.cz,
	snitzer@redhat.com, mst@redhat.com, jasowang@redhat.com,
	david@fromorbit.com, lcapitulino@redhat.com,
	adilger.kernel@dilger.ca, zwisler@kernel.org,
	aarcange@redhat.com, dave.jiang@intel.com, jstaron@google.com,
	darrick.wong@oracle.com, vishal.l.verma@intel.com,
	david@redhat.com, willy@infradead.org, hch@infradead.org,
	jmoyer@redhat.com, nilal@redhat.com, lenb@kernel.org,
	kilobyte@angband.pl, riel@surriel.com, yuval.shaia@oracle.com,
	stefanha@redhat.com, pbonzini@redhat.com,
	dan.j.williams@intel.com, kwolf@redhat.com, tytso@mit.edu,
	xiaoguangrong.eric@gmail.com, cohuck@redhat.com,
	rjw@rjwysocki.net, imammedo@redhat.com
Subject: [Qemu-devel] [PATCH v10 4/7] dm: enable synchronous dax
Date: Tue, 21 May 2019 19:07:10 +0530	[thread overview]
Message-ID: <20190521133713.31653-5-pagupta@redhat.com> (raw)
In-Reply-To: <20190521133713.31653-1-pagupta@redhat.com>

 This patch sets dax device 'DAXDEV_SYNC' flag if all the target
 devices of device mapper support synchrononous DAX. If device
 mapper consists of both synchronous and asynchronous dax devices,
 we don't set 'DAXDEV_SYNC' flag. 

Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
---
 drivers/md/dm-table.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index cde3b49b2a91..1cce626ff576 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -886,10 +886,17 @@ static int device_supports_dax(struct dm_target *ti, struct dm_dev *dev,
 	return bdev_dax_supported(dev->bdev, PAGE_SIZE);
 }
 
+static int device_synchronous(struct dm_target *ti, struct dm_dev *dev,
+			       sector_t start, sector_t len, void *data)
+{
+	return dax_synchronous(dev->dax_dev);
+}
+
 static bool dm_table_supports_dax(struct dm_table *t)
 {
 	struct dm_target *ti;
 	unsigned i;
+	bool dax_sync = true;
 
 	/* Ensure that all targets support DAX. */
 	for (i = 0; i < dm_table_get_num_targets(t); i++) {
@@ -901,7 +908,14 @@ static bool dm_table_supports_dax(struct dm_table *t)
 		if (!ti->type->iterate_devices ||
 		    !ti->type->iterate_devices(ti, device_supports_dax, NULL))
 			return false;
+
+		/* Check devices support synchronous DAX */
+		if (dax_sync &&
+		    !ti->type->iterate_devices(ti, device_synchronous, NULL))
+			dax_sync = false;
 	}
+	if (dax_sync)
+		set_dax_synchronous(t->md->dax_dev);
 
 	return true;
 }
-- 
2.20.1



  parent reply	other threads:[~2019-05-21 13:42 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 13:37 [PATCH v10 0/7] virtio pmem driver Pankaj Gupta
2019-05-21 13:37 ` [Qemu-devel] " Pankaj Gupta
2019-05-21 13:37 ` Pankaj Gupta
2019-05-21 13:37 ` [PATCH v10 1/7] libnvdimm: nd_region flush callback support Pankaj Gupta
2019-05-21 13:37   ` [Qemu-devel] " Pankaj Gupta
2019-05-21 13:37   ` Pankaj Gupta
2019-05-21 13:37 ` Pankaj Gupta
2019-05-21 13:37 ` [PATCH v10 2/7] virtio-pmem: Add virtio pmem driver Pankaj Gupta
2019-05-21 13:37 ` Pankaj Gupta
2019-05-21 13:37   ` [Qemu-devel] " Pankaj Gupta
2019-05-21 13:37   ` Pankaj Gupta
2019-05-21 13:51   ` Michael S. Tsirkin
2019-05-21 13:51   ` Michael S. Tsirkin
2019-05-21 13:51     ` Michael S. Tsirkin
2019-05-21 13:51     ` [Qemu-devel] " Michael S. Tsirkin
2019-05-21 13:51     ` Michael S. Tsirkin
2019-05-21 16:24     ` [Qemu-devel] " Pankaj Gupta
2019-05-21 16:24       ` Pankaj Gupta
2019-05-21 16:24       ` Pankaj Gupta
2019-05-21 16:24       ` Pankaj Gupta
2019-05-21 16:24     ` Pankaj Gupta
2019-05-21 13:37 ` [PATCH v10 3/7] libnvdimm: add dax_dev sync flag Pankaj Gupta
2019-05-21 13:37   ` Pankaj Gupta
2019-05-21 13:37   ` [Qemu-devel] " Pankaj Gupta
2019-05-21 13:37   ` Pankaj Gupta
2019-05-21 13:37 ` [PATCH v10 4/7] dm: enable synchronous dax Pankaj Gupta
2019-05-21 13:37 ` Pankaj Gupta [this message]
2019-05-21 13:37   ` [Qemu-devel] " Pankaj Gupta
2019-05-21 13:37   ` Pankaj Gupta
2019-06-01  6:28   ` Dan Williams
2019-06-01  6:28   ` Dan Williams
2019-06-01  6:28     ` Dan Williams
2019-06-01  6:28     ` [Qemu-devel] " Dan Williams
2019-06-01  6:28     ` Dan Williams
2019-06-10  5:08     ` Pankaj Gupta
2019-06-10  5:08       ` Pankaj Gupta
2019-06-10  5:08       ` [Qemu-devel] " Pankaj Gupta
2019-06-10  5:08       ` Pankaj Gupta
2019-06-10  5:08     ` Pankaj Gupta
2019-05-21 13:37 ` [PATCH v10 5/7] dax: check synchronous mapping is supported Pankaj Gupta
2019-05-21 13:37 ` Pankaj Gupta
2019-05-21 13:37   ` [Qemu-devel] " Pankaj Gupta
2019-05-21 13:37   ` Pankaj Gupta
2019-05-21 13:37 ` [PATCH v10 6/7] ext4: disable map_sync for async flush Pankaj Gupta
2019-05-21 13:37   ` Pankaj Gupta
2019-05-21 13:37   ` [Qemu-devel] " Pankaj Gupta
2019-05-21 13:37   ` Pankaj Gupta
2019-05-21 13:37 ` [PATCH v10 7/7] xfs: " Pankaj Gupta
2019-05-21 13:37 ` Pankaj Gupta
2019-05-21 13:37   ` Pankaj Gupta
2019-05-21 13:37   ` [Qemu-devel] " Pankaj Gupta
2019-05-21 13:37   ` Pankaj Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521133713.31653-5-pagupta@redhat.com \
    --to=pagupta@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=cohuck@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=david@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=hch@infradead.org \
    --cc=imammedo@redhat.com \
    --cc=jack@suse.cz \
    --cc=jasowang@redhat.com \
    --cc=jstaron@google.com \
    --cc=kilobyte@angband.pl \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=nilal@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rdunlap@infradead.org \
    --cc=riel@surriel.com \
    --cc=rjw@rjwysocki.net \
    --cc=snitzer@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=tytso@mit.edu \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=willy@infradead.org \
    --cc=xiaoguangrong.eric@gmail.com \
    --cc=yuval.shaia@oracle.com \
    --cc=zwisler@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.