All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ignore disabled memory-region nodes
@ 2019-05-22  5:35 Puneet Saxena
  2019-05-22  5:35 ` [PATCH] of: resered-memory: " Puneet Saxena
  0 siblings, 1 reply; 4+ messages in thread
From: Puneet Saxena @ 2019-05-22  5:35 UTC (permalink / raw)
  To: pantelis.antoniou, frowand.list, devicetree
  Cc: treding, vdumpa, snikam, Puneet Saxena

While parsing "memory-region" node lists if a node
is "disabled", parsing halts. Therefore the nodes whoes
"status" is "okay" or "ok" are not parsed.

The change ignore disabled nodes in the memory-region
nodes list and continues to initialize the rest of
enabled nodes.

Krishna Reddy (1):
  of: resered-memory: ignore disabled memory-region nodes

 drivers/of/of_reserved_mem.c | 5 +++++
 1 file changed, 5 insertions(+)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] of: resered-memory: ignore disabled memory-region nodes
  2019-05-22  5:35 [PATCH] ignore disabled memory-region nodes Puneet Saxena
@ 2019-05-22  5:35 ` Puneet Saxena
  2019-05-22  6:38   ` Thierry Reding
  0 siblings, 1 reply; 4+ messages in thread
From: Puneet Saxena @ 2019-05-22  5:35 UTC (permalink / raw)
  To: pantelis.antoniou, frowand.list, devicetree; +Cc: treding, vdumpa, snikam

From: Krishna Reddy <vdumpa@nvidia.com>

Ignore disabled nodes in the memory-region nodes list and continue
to initialize the rest of enabled nodes.

Signed-off-by: Krishna Reddy <vdumpa@nvidia.com>
---
 drivers/of/of_reserved_mem.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
index 1977ee0adcb1..58d95d774e3b 100644
--- a/drivers/of/of_reserved_mem.c
+++ b/drivers/of/of_reserved_mem.c
@@ -314,6 +314,7 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
 	struct device_node *target;
 	struct reserved_mem *rmem;
 	int ret;
+	const char *status;
 
 	if (!np || !dev)
 		return -EINVAL;
@@ -322,6 +323,10 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
 	if (!target)
 		return -ENODEV;
 
+	status = of_get_property(target, "status", NULL);
+	if (status && strcmp(status, "okay") != 0 && strcmp(status, "ok") != 0)
+		return 0;
+
 	rmem = __find_rmem(target);
 	of_node_put(target);
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] of: resered-memory: ignore disabled memory-region nodes
  2019-05-22  5:35 ` [PATCH] of: resered-memory: " Puneet Saxena
@ 2019-05-22  6:38   ` Thierry Reding
  2019-05-22  7:21     ` puneet saxena
  0 siblings, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2019-05-22  6:38 UTC (permalink / raw)
  To: Puneet Saxena; +Cc: pantelis.antoniou, frowand.list, devicetree, vdumpa, snikam

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

On Wed, May 22, 2019 at 11:05:53AM +0530, Puneet Saxena wrote:
> From: Krishna Reddy <vdumpa@nvidia.com>
> 
> Ignore disabled nodes in the memory-region nodes list and continue
> to initialize the rest of enabled nodes.
> 
> Signed-off-by: Krishna Reddy <vdumpa@nvidia.com>
> ---
>  drivers/of/of_reserved_mem.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> index 1977ee0adcb1..58d95d774e3b 100644
> --- a/drivers/of/of_reserved_mem.c
> +++ b/drivers/of/of_reserved_mem.c
> @@ -314,6 +314,7 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
>  	struct device_node *target;
>  	struct reserved_mem *rmem;
>  	int ret;
> +	const char *status;
>  
>  	if (!np || !dev)
>  		return -EINVAL;
> @@ -322,6 +323,10 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
>  	if (!target)
>  		return -ENODEV;
>  
> +	status = of_get_property(target, "status", NULL);
> +	if (status && strcmp(status, "okay") != 0 && strcmp(status, "ok") != 0)
> +		return 0;
> +

Does of_device_is_available() not work? Other than that, looks fine to
me.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] of: resered-memory: ignore disabled memory-region nodes
  2019-05-22  6:38   ` Thierry Reding
@ 2019-05-22  7:21     ` puneet saxena
  0 siblings, 0 replies; 4+ messages in thread
From: puneet saxena @ 2019-05-22  7:21 UTC (permalink / raw)
  To: Thierry Reding
  Cc: pantelis.antoniou, frowand.list, devicetree, vdumpa, snikam

Yes, of_device_is_available() will work here. Will incorporate in next PS.

Thanks.

On 22/05/19 12:08 PM, Thierry Reding wrote:
> On Wed, May 22, 2019 at 11:05:53AM +0530, Puneet Saxena wrote:
>> From: Krishna Reddy <vdumpa@nvidia.com>
>>
>> Ignore disabled nodes in the memory-region nodes list and continue
>> to initialize the rest of enabled nodes.
>>
>> Signed-off-by: Krishna Reddy <vdumpa@nvidia.com>
>> ---
>>   drivers/of/of_reserved_mem.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
>> index 1977ee0adcb1..58d95d774e3b 100644
>> --- a/drivers/of/of_reserved_mem.c
>> +++ b/drivers/of/of_reserved_mem.c
>> @@ -314,6 +314,7 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
>>   	struct device_node *target;
>>   	struct reserved_mem *rmem;
>>   	int ret;
>> +	const char *status;
>>   
>>   	if (!np || !dev)
>>   		return -EINVAL;
>> @@ -322,6 +323,10 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
>>   	if (!target)
>>   		return -ENODEV;
>>   
>> +	status = of_get_property(target, "status", NULL);
>> +	if (status && strcmp(status, "okay") != 0 && strcmp(status, "ok") != 0)
>> +		return 0;
>> +
> Does of_device_is_available() not work? Other than that, looks fine to
> me.
>
> Thierry

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-22  7:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-22  5:35 [PATCH] ignore disabled memory-region nodes Puneet Saxena
2019-05-22  5:35 ` [PATCH] of: resered-memory: " Puneet Saxena
2019-05-22  6:38   ` Thierry Reding
2019-05-22  7:21     ` puneet saxena

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.