* [igt-dev] [PATCH i-g-t] lib/igt_audio: fix amplitude for S24_LE and S32_LE
@ 2019-05-22 10:29 Simon Ser
2019-05-22 11:09 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Simon Ser @ 2019-05-22 10:29 UTC (permalink / raw)
To: igt-dev
We need to use signed integers (hence "S" in the format name).
The reason this has gone unnoticed is that we were generating signals with half
of the amplitude they were supposed to have. As a result, using UINT32_MAX
(which is almost INT32_MAX * 2) resulted in the correct amplitude. In other
words, these two bugs were cancelling each other's effects.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Fixes: 42576d710255 ("lib/igt_audio: add support for S24_LE and S32_LE signal generation")
---
lib/igt_audio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/igt_audio.c b/lib/igt_audio.c
index 9937fd02f750..07935e660c5a 100644
--- a/lib/igt_audio.c
+++ b/lib/igt_audio.c
@@ -328,7 +328,7 @@ void audio_signal_fill_s24_le(struct audio_signal *signal, int32_t *buffer,
audio_signal_fill(signal, tmp, samples);
for (i = 0; i < signal->channels * samples; ++i)
- buffer[i] = 0xFFFFFF * tmp[i];
+ buffer[i] = 0x7FFFFF * tmp[i];
free(tmp);
}
@@ -343,7 +343,7 @@ void audio_signal_fill_s32_le(struct audio_signal *signal, int32_t *buffer,
audio_signal_fill(signal, tmp, samples);
for (i = 0; i < signal->channels * samples; ++i)
- buffer[i] = UINT32_MAX * tmp[i];
+ buffer[i] = INT32_MAX * tmp[i];
free(tmp);
}
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_audio: fix amplitude for S24_LE and S32_LE
2019-05-22 10:29 [igt-dev] [PATCH i-g-t] lib/igt_audio: fix amplitude for S24_LE and S32_LE Simon Ser
@ 2019-05-22 11:09 ` Patchwork
2019-05-23 3:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-05-27 10:01 ` [igt-dev] [PATCH i-g-t] " Martin Peres
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-05-22 11:09 UTC (permalink / raw)
To: Simon Ser; +Cc: igt-dev
== Series Details ==
Series: lib/igt_audio: fix amplitude for S24_LE and S32_LE
URL : https://patchwork.freedesktop.org/series/60954/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6118 -> IGTPW_3022
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/60954/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_3022 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_hangcheck:
- fi-apl-guc: [PASS][1] -> [FAIL][2] ([fdo#110623])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/fi-apl-guc/igt@i915_selftest@live_hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/fi-apl-guc/igt@i915_selftest@live_hangcheck.html
#### Possible fixes ####
* igt@gem_exec_basic@readonly-blt:
- {fi-icl-u2}: [INCOMPLETE][3] ([fdo#107713]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/fi-icl-u2/igt@gem_exec_basic@readonly-blt.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/fi-icl-u2/igt@gem_exec_basic@readonly-blt.html
* igt@gem_exec_suspend@basic-s3:
- fi-skl-6700k2: [INCOMPLETE][5] ([fdo#104108]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/fi-skl-6700k2/igt@gem_exec_suspend@basic-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/fi-skl-6700k2/igt@gem_exec_suspend@basic-s3.html
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: [INCOMPLETE][7] ([fdo#107718]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_selftest@live_execlists:
- fi-apl-guc: [INCOMPLETE][9] ([fdo#103927] / [fdo#109720]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/fi-apl-guc/igt@i915_selftest@live_execlists.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/fi-apl-guc/igt@i915_selftest@live_execlists.html
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: [INCOMPLETE][11] ([fdo#108602] / [fdo#108744]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
#### Warnings ####
* igt@runner@aborted:
- fi-apl-guc: [FAIL][13] ([fdo#108622] / [fdo#109720]) -> [FAIL][14] ([fdo#110622])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/fi-apl-guc/igt@runner@aborted.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/fi-apl-guc/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#110622]: https://bugs.freedesktop.org/show_bug.cgi?id=110622
[fdo#110623]: https://bugs.freedesktop.org/show_bug.cgi?id=110623
Participating hosts (52 -> 45)
------------------------------
Additional (1): fi-hsw-peppy
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-pnv-d510 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* IGT: IGT_5002 -> IGTPW_3022
CI_DRM_6118: baf7701210779020b71d4d67f8c0a96afd567c22 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3022: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/
IGT_5002: c27de2a2a3be7302eb8d23a9f0e6d654c64292f0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib/igt_audio: fix amplitude for S24_LE and S32_LE
2019-05-22 10:29 [igt-dev] [PATCH i-g-t] lib/igt_audio: fix amplitude for S24_LE and S32_LE Simon Ser
2019-05-22 11:09 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-05-23 3:38 ` Patchwork
2019-05-27 10:01 ` [igt-dev] [PATCH i-g-t] " Martin Peres
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-05-23 3:38 UTC (permalink / raw)
To: Simon Ser; +Cc: igt-dev
== Series Details ==
Series: lib/igt_audio: fix amplitude for S24_LE and S32_LE
URL : https://patchwork.freedesktop.org/series/60954/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6118_full -> IGTPW_3022_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/60954/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_3022_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-kbl: [PASS][1] -> [INCOMPLETE][2] ([fdo#103665] / [fdo#107807])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-kbl2/igt@i915_pm_rpm@system-suspend-modeset.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-kbl3/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +5 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-apl2/igt@i915_suspend@debugfs-reader.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-apl1/igt@i915_suspend@debugfs-reader.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [PASS][5] -> [FAIL][6] ([fdo#102887] / [fdo#105363])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-iclb: [PASS][7] -> [FAIL][8] ([fdo#103167]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@fbc-tilingchange:
- shard-iclb: [PASS][9] -> [INCOMPLETE][10] ([fdo#107713]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-tilingchange.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-tilingchange.html
* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#108341])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb2/igt@kms_psr@no_drrs.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-iclb1/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109441]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb2/igt@kms_psr@psr2_dpms.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-iclb3/igt@kms_psr@psr2_dpms.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][15] -> [FAIL][16] ([fdo#99912])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-apl1/igt@kms_setmode@basic.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-apl4/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-query-forked-busy:
- shard-glk: [PASS][17] -> [INCOMPLETE][18] ([fdo#103359] / [k.org#198133])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-glk4/igt@kms_vblank@pipe-a-query-forked-busy.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-glk8/igt@kms_vblank@pipe-a-query-forked-busy.html
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-apl: [DMESG-WARN][19] ([fdo#108566]) -> [PASS][20] +7 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-apl8/igt@gem_ctx_isolation@rcs0-s3.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-apl6/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_tiled_swapping@non-threaded:
- shard-glk: [DMESG-WARN][21] ([fdo#108686]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-glk1/igt@gem_tiled_swapping@non-threaded.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-glk8/igt@gem_tiled_swapping@non-threaded.html
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-glk: [INCOMPLETE][23] ([fdo#103359] / [k.org#198133]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-glk1/igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-glk3/igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-hsw: [FAIL][25] ([fdo#103355]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-hsw1/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-hsw1/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
- shard-glk: [FAIL][27] ([fdo#100368]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-glk4/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-glk5/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-apl: [FAIL][29] ([fdo#102887] / [fdo#105363]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-apl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-apl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: [INCOMPLETE][31] ([fdo#103665]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-kbl: [FAIL][33] ([fdo#103167]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
- shard-apl: [FAIL][35] ([fdo#103167]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-apl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-apl5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
- shard-glk: [FAIL][37] ([fdo#103167]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-glk4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-glk8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][39] ([fdo#103167]) -> [PASS][40] +10 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [FAIL][41] ([fdo#103166]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-x.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][43] ([fdo#109642]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb5/igt@kms_psr2_su@frontbuffer.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_sysfs_edid_timing:
- shard-iclb: [FAIL][45] ([fdo#100047]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb2/igt@kms_sysfs_edid_timing.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-iclb7/igt@kms_sysfs_edid_timing.html
#### Warnings ####
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: [FAIL][47] ([fdo#108686]) -> [INCOMPLETE][48] ([fdo#103540])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-hsw7/igt@gem_tiled_swapping@non-threaded.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-hsw6/igt@gem_tiled_swapping@non-threaded.html
* igt@kms_busy@extended-modeset-hang-newfb-render-e:
- shard-apl: [INCOMPLETE][49] ([fdo#103927]) -> [SKIP][50] ([fdo#109271] / [fdo#109278])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-apl3/igt@kms_busy@extended-modeset-hang-newfb-render-e.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/shard-apl5/igt@kms_busy@extended-modeset-hang-newfb-render-e.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* IGT: IGT_5002 -> IGTPW_3022
* Piglit: piglit_4509 -> None
CI_DRM_6118: baf7701210779020b71d4d67f8c0a96afd567c22 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3022: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/
IGT_5002: c27de2a2a3be7302eb8d23a9f0e6d654c64292f0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3022/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/igt_audio: fix amplitude for S24_LE and S32_LE
2019-05-22 10:29 [igt-dev] [PATCH i-g-t] lib/igt_audio: fix amplitude for S24_LE and S32_LE Simon Ser
2019-05-22 11:09 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-05-23 3:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-05-27 10:01 ` Martin Peres
2 siblings, 0 replies; 4+ messages in thread
From: Martin Peres @ 2019-05-27 10:01 UTC (permalink / raw)
To: Simon Ser, igt-dev
On 22/05/2019 13:29, Simon Ser wrote:
> We need to use signed integers (hence "S" in the format name).
>
> The reason this has gone unnoticed is that we were generating signals with half
> of the amplitude they were supposed to have. As a result, using UINT32_MAX
> (which is almost INT32_MAX * 2) resulted in the correct amplitude. In other
> words, these two bugs were cancelling each other's effects.
>
> Signed-off-by: Simon Ser <simon.ser@intel.com>
> Fixes: 42576d710255 ("lib/igt_audio: add support for S24_LE and S32_LE signal generation")
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
> ---
> lib/igt_audio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/igt_audio.c b/lib/igt_audio.c
> index 9937fd02f750..07935e660c5a 100644
> --- a/lib/igt_audio.c
> +++ b/lib/igt_audio.c
> @@ -328,7 +328,7 @@ void audio_signal_fill_s24_le(struct audio_signal *signal, int32_t *buffer,
> audio_signal_fill(signal, tmp, samples);
>
> for (i = 0; i < signal->channels * samples; ++i)
> - buffer[i] = 0xFFFFFF * tmp[i];
> + buffer[i] = 0x7FFFFF * tmp[i];
>
> free(tmp);
> }
> @@ -343,7 +343,7 @@ void audio_signal_fill_s32_le(struct audio_signal *signal, int32_t *buffer,
> audio_signal_fill(signal, tmp, samples);
>
> for (i = 0; i < signal->channels * samples; ++i)
> - buffer[i] = UINT32_MAX * tmp[i];
> + buffer[i] = INT32_MAX * tmp[i];
>
> free(tmp);
> }
> --
> 2.21.0
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-27 10:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-22 10:29 [igt-dev] [PATCH i-g-t] lib/igt_audio: fix amplitude for S24_LE and S32_LE Simon Ser
2019-05-22 11:09 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-05-23 3:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-05-27 10:01 ` [igt-dev] [PATCH i-g-t] " Martin Peres
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.