All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] message/fusion/mptbase.c: Use kmemdup instead of memcpy and kmalloc
@ 2019-05-22 16:01 Bharath Vedartham
  2019-05-30  2:33 ` Martin K. Petersen
  0 siblings, 1 reply; 2+ messages in thread
From: Bharath Vedartham @ 2019-05-22 16:01 UTC (permalink / raw)
  To: sathya.prakash, suganath-prabu.subramani, joe
  Cc: MPT-FusionLinux.pdl, linux-scsi, linux-kernel

Replace kmalloc + memcpy with kmemdup.

This was reported by coccinelle.

Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>

---
Changes since v2:
	Removed the cast from pIoc2.
---
 drivers/message/fusion/mptbase.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
index d8882b0..37876a7 100644
--- a/drivers/message/fusion/mptbase.c
+++ b/drivers/message/fusion/mptbase.c
@@ -6001,13 +6001,12 @@ mpt_findImVolumes(MPT_ADAPTER *ioc)
 	if (mpt_config(ioc, &cfg) != 0)
 		goto out;
 
-	mem = kmalloc(iocpage2sz, GFP_KERNEL);
+	mem = kmemdup(pIoc2, iocpage2sz, GFP_KERNEL);
 	if (!mem) {
 		rc = -ENOMEM;
 		goto out;
 	}
 
-	memcpy(mem, (u8 *)pIoc2, iocpage2sz);
 	ioc->raid_data.pIocPg2 = (IOCPage2_t *) mem;
 
 	mpt_read_ioc_pg_3(ioc);
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] message/fusion/mptbase.c: Use kmemdup instead of memcpy and kmalloc
  2019-05-22 16:01 [PATCH v2] message/fusion/mptbase.c: Use kmemdup instead of memcpy and kmalloc Bharath Vedartham
@ 2019-05-30  2:33 ` Martin K. Petersen
  0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2019-05-30  2:33 UTC (permalink / raw)
  To: Bharath Vedartham
  Cc: sathya.prakash, suganath-prabu.subramani, joe,
	MPT-FusionLinux.pdl, linux-scsi, linux-kernel


Bharath,

> Replace kmalloc + memcpy with kmemdup.

Applied to 5.3/scsi-queue. Thanks.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-30  2:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-22 16:01 [PATCH v2] message/fusion/mptbase.c: Use kmemdup instead of memcpy and kmalloc Bharath Vedartham
2019-05-30  2:33 ` Martin K. Petersen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.