From: Torsten Duwe <duwe@lst.de> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Maxime Ripard <maxime.ripard@bootlin.com>, Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Thierry Reding <thierry.reding@gmail.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Andrzej Hajda <a.hajda@samsung.com>, Icenowy Zheng <icenowy@aosc.io>, Sean Paul <seanpaul@chromium.org>, Vasily Khoruzhick <anarsoul@gmail.com>, Harald Geyer <harald@ccbib.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Thomas Gleixner <tglx@linutronix.de>, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] drm/bridge: Add Analogix anx6345 support Date: Thu, 23 May 2019 14:45:08 +0200 [thread overview] Message-ID: <20190523124508.GC15685@lst.de> (raw) In-Reply-To: <20190523075041.GC4745@pendragon.ideasonboard.com> On Thu, May 23, 2019 at 10:50:41AM +0300, Laurent Pinchart wrote: > Hi Torsten, > > Thank you for the patch. Thank you for the thorough review! > On Thu, May 23, 2019 at 08:53:56AM +0200, Torsten Duwe wrote: > > +{ > > + struct anx6345 *anx6345 = connector_to_anx6345(connector); > > + int err, num_modes = 0; > > + bool power_off = false; > > + > > + mutex_lock(&anx6345->lock); > > + > > + if (!anx6345->edid) { > > Could the chip be used with a hot-pluggable display, or is it guaranteed > that EDID will never change ? The chip itself is capable of (e)DP hot-plugging, so the signals suggest. See the previous discussions about what to expect on the output side. Currently, the driver does not handle hot-plugging. > > + > > + err = drm_of_find_panel_or_bridge(client->dev.of_node, 1, 0, > > + &anx6345->panel, NULL); > > + if (err == -EPROBE_DEFER) > > + return err; > > + > > + if (err) > > + DRM_DEBUG("No panel found\n"); > > Shouldn't this be fatal ? No, basically same as above. On the output side, there can be a panel, another bridge, or some eDP plug. If the DT didn't explicitly specify a panel or a bridge, we can still generate video output as soon as there is valid EDID data. Your other points went straight onto my TODO list. Torsten
WARNING: multiple messages have this Message-ID (diff)
From: Torsten Duwe <duwe@lst.de> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Andrzej Hajda <a.hajda@samsung.com>, Maxime Ripard <maxime.ripard@bootlin.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Harald Geyer <harald@ccbib.org>, Sean Paul <seanpaul@chromium.org>, Thomas Gleixner <tglx@linutronix.de>, linux-arm-kernel@lists.infradead.org, Icenowy Zheng <icenowy@aosc.io> Subject: Re: [PATCH 4/6] drm/bridge: Add Analogix anx6345 support Date: Thu, 23 May 2019 14:45:08 +0200 [thread overview] Message-ID: <20190523124508.GC15685@lst.de> (raw) In-Reply-To: <20190523075041.GC4745@pendragon.ideasonboard.com> On Thu, May 23, 2019 at 10:50:41AM +0300, Laurent Pinchart wrote: > Hi Torsten, > > Thank you for the patch. Thank you for the thorough review! > On Thu, May 23, 2019 at 08:53:56AM +0200, Torsten Duwe wrote: > > +{ > > + struct anx6345 *anx6345 = connector_to_anx6345(connector); > > + int err, num_modes = 0; > > + bool power_off = false; > > + > > + mutex_lock(&anx6345->lock); > > + > > + if (!anx6345->edid) { > > Could the chip be used with a hot-pluggable display, or is it guaranteed > that EDID will never change ? The chip itself is capable of (e)DP hot-plugging, so the signals suggest. See the previous discussions about what to expect on the output side. Currently, the driver does not handle hot-plugging. > > + > > + err = drm_of_find_panel_or_bridge(client->dev.of_node, 1, 0, > > + &anx6345->panel, NULL); > > + if (err == -EPROBE_DEFER) > > + return err; > > + > > + if (err) > > + DRM_DEBUG("No panel found\n"); > > Shouldn't this be fatal ? No, basically same as above. On the output side, there can be a panel, another bridge, or some eDP plug. If the DT didn't explicitly specify a panel or a bridge, we can still generate video output as soon as there is valid EDID data. Your other points went straight onto my TODO list. Torsten _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-23 12:45 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-23 6:50 [PATCH 0/6] Add anx6345 DP/eDP bridge for Olimex Teres-I Torsten Duwe 2019-05-23 6:50 ` Torsten Duwe 2019-05-23 6:53 ` [PATCH 1/6] drm/bridge: move ANA78xx driver to analogix subdirectory Torsten Duwe 2019-05-23 6:53 ` Torsten Duwe 2019-05-23 6:53 ` [PATCH 2/6] drm/bridge: split some definitions of ANX78xx to dedicated headers Torsten Duwe 2019-05-23 6:53 ` Torsten Duwe 2019-05-23 6:53 ` [PATCH 3/6] drm/bridge: extract some Analogix I2C DP common code Torsten Duwe 2019-05-23 6:53 ` Torsten Duwe 2019-05-23 7:40 ` Chen-Yu Tsai 2019-05-23 7:40 ` Chen-Yu Tsai 2019-05-23 7:50 ` Laurent Pinchart 2019-05-23 7:50 ` Laurent Pinchart 2019-05-23 11:52 ` Torsten Duwe 2019-05-23 11:52 ` Torsten Duwe 2019-05-23 7:54 ` Laurent Pinchart 2019-05-23 7:54 ` Laurent Pinchart 2019-05-27 20:11 ` Sam Ravnborg 2019-05-27 20:11 ` Sam Ravnborg 2019-05-23 6:53 ` [PATCH 4/6] drm/bridge: Add Analogix anx6345 support Torsten Duwe 2019-05-23 6:53 ` Torsten Duwe 2019-05-23 7:50 ` Laurent Pinchart 2019-05-23 7:50 ` Laurent Pinchart 2019-05-23 12:45 ` Torsten Duwe [this message] 2019-05-23 12:45 ` Torsten Duwe 2019-05-23 6:54 ` [PATCH 5/6] dt-bindings: Add ANX6345 DP/eDP transmitter binding Torsten Duwe 2019-05-23 6:54 ` Torsten Duwe 2019-05-23 7:31 ` Laurent Pinchart 2019-05-23 7:31 ` Laurent Pinchart 2019-05-23 9:05 ` Maxime Ripard 2019-05-23 9:05 ` Maxime Ripard 2019-05-23 12:30 ` Torsten Duwe 2019-05-23 12:30 ` Torsten Duwe 2019-05-23 6:54 ` [PATCH 6/6] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I Torsten Duwe 2019-05-23 6:54 ` Torsten Duwe 2019-05-23 14:48 ` Vasily Khoruzhick 2019-05-23 14:48 ` Vasily Khoruzhick 2019-05-24 12:13 ` Torsten Duwe 2019-05-24 12:13 ` Torsten Duwe 2019-05-24 13:06 ` Maxime Ripard 2019-05-24 13:06 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190523124508.GC15685@lst.de \ --to=duwe@lst.de \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=anarsoul@gmail.com \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=gregkh@linuxfoundation.org \ --cc=harald@ccbib.org \ --cc=icenowy@aosc.io \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maxime.ripard@bootlin.com \ --cc=robh+dt@kernel.org \ --cc=seanpaul@chromium.org \ --cc=tglx@linutronix.de \ --cc=thierry.reding@gmail.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.