* [PATCH] drm/mediatek: Fix warning about unhandled enum value
@ 2019-05-22 20:21 ` Sean Paul
0 siblings, 0 replies; 8+ messages in thread
From: Sean Paul @ 2019-05-22 20:21 UTC (permalink / raw)
To: dri-devel
Cc: linux-arm-kernel, linux-fbdev, Bartlomiej Zolnierkiewicz,
Maxime Ripard, Hans Verkuil, David Airlie, Uma Shankar,
Sean Paul, Matthias Brugger, linux-mediatek, Sean Paul
From: Sean Paul <seanpaul@chromium.org>
Fixes the following build warning:
drivers/gpu/drm/mediatek/mtk_hdmi.c:327:2: warning: enumeration value ‘HDMI_INFOFRAME_TYPE_DRM’ not handled in switch [-Wswitch]
Introduced with the addition of HDMI_INFOFRAME_TYPE_DRM in the commit
below, but the code really should have been future-proofed from the
start.
Fixes: 2cdbfd66a829 ("drm: Enable HDR infoframe support")
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Hans Verkuil <hansverk@cisco.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
drivers/gpu/drm/mediatek/mtk_hdmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
index e04e6c293d39..10cc9910f164 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
@@ -341,6 +341,9 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi *hdmi, u8 *buffer,
ctrl_frame_en = VS_EN;
ctrl_reg = GRL_ACP_ISRC_CTRL;
break;
+ default:
+ dev_err(hdmi->dev, "Unknown infoframe type %d\n", frame_type);
+ return;
}
mtk_hdmi_clear_bits(hdmi, ctrl_reg, ctrl_frame_en);
mtk_hdmi_write(hdmi, GRL_INFOFRM_TYPE, frame_type);
--
Sean Paul, Software Engineer, Google / Chromium OS
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] drm/mediatek: Fix warning about unhandled enum value
@ 2019-05-22 20:21 ` Sean Paul
0 siblings, 0 replies; 8+ messages in thread
From: Sean Paul @ 2019-05-22 20:21 UTC (permalink / raw)
To: dri-devel
Cc: linux-arm-kernel, linux-fbdev, Bartlomiej Zolnierkiewicz,
Maxime Ripard, Hans Verkuil, David Airlie, Uma Shankar,
Sean Paul, Matthias Brugger, linux-mediatek, Sean Paul
From: Sean Paul <seanpaul@chromium.org>
Fixes the following build warning:
drivers/gpu/drm/mediatek/mtk_hdmi.c:327:2: warning: enumeration value ‘HDMI_INFOFRAME_TYPE_DRM’ not handled in switch [-Wswitch]
Introduced with the addition of HDMI_INFOFRAME_TYPE_DRM in the commit
below, but the code really should have been future-proofed from the
start.
Fixes: 2cdbfd66a829 ("drm: Enable HDR infoframe support")
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Hans Verkuil <hansverk@cisco.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
drivers/gpu/drm/mediatek/mtk_hdmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
index e04e6c293d39..10cc9910f164 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
@@ -341,6 +341,9 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi *hdmi, u8 *buffer,
ctrl_frame_en = VS_EN;
ctrl_reg = GRL_ACP_ISRC_CTRL;
break;
+ default:
+ dev_err(hdmi->dev, "Unknown infoframe type %d\n", frame_type);
+ return;
}
mtk_hdmi_clear_bits(hdmi, ctrl_reg, ctrl_frame_en);
mtk_hdmi_write(hdmi, GRL_INFOFRM_TYPE, frame_type);
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] drm/mediatek: Fix warning about unhandled enum value
@ 2019-05-22 20:21 ` Sean Paul
0 siblings, 0 replies; 8+ messages in thread
From: Sean Paul @ 2019-05-22 20:21 UTC (permalink / raw)
To: dri-devel
Cc: linux-arm-kernel, linux-fbdev, Philipp Zabel,
Bartlomiej Zolnierkiewicz, Maxime Ripard, Maarten Lankhorst,
Hans Verkuil, David Airlie, Uma Shankar, Sean Paul,
Matthias Brugger, Daniel Vetter, CK Hu, linux-mediatek,
Sean Paul, Ville Syrjälä,
Shashank Sharma
From: Sean Paul <seanpaul@chromium.org>
Fixes the following build warning:
drivers/gpu/drm/mediatek/mtk_hdmi.c:327:2: warning: enumeration value ‘HDMI_INFOFRAME_TYPE_DRM’ not handled in switch [-Wswitch]
Introduced with the addition of HDMI_INFOFRAME_TYPE_DRM in the commit
below, but the code really should have been future-proofed from the
start.
Fixes: 2cdbfd66a829 ("drm: Enable HDR infoframe support")
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Hans Verkuil <hansverk@cisco.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
drivers/gpu/drm/mediatek/mtk_hdmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
index e04e6c293d39..10cc9910f164 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
@@ -341,6 +341,9 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi *hdmi, u8 *buffer,
ctrl_frame_en = VS_EN;
ctrl_reg = GRL_ACP_ISRC_CTRL;
break;
+ default:
+ dev_err(hdmi->dev, "Unknown infoframe type %d\n", frame_type);
+ return;
}
mtk_hdmi_clear_bits(hdmi, ctrl_reg, ctrl_frame_en);
mtk_hdmi_write(hdmi, GRL_INFOFRM_TYPE, frame_type);
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/mediatek: Fix warning about unhandled enum value
2019-05-22 20:21 ` Sean Paul
@ 2019-05-23 6:13 ` CK Hu
-1 siblings, 0 replies; 8+ messages in thread
From: CK Hu @ 2019-05-23 6:13 UTC (permalink / raw)
To: Sean Paul
Cc: linux-fbdev, Daniel Vetter, Bartlomiej Zolnierkiewicz,
Maxime Ripard, Maarten Lankhorst, dri-devel, Hans Verkuil,
David Airlie, Uma Shankar, Sean Paul, Ville Syrjälä,
Philipp Zabel, Matthias Brugger, linux-mediatek,
linux-arm-kernel, Shashank Sharma
Hi, Sean:
On Wed, 2019-05-22 at 16:21 -0400, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
>
> Fixes the following build warning:
> drivers/gpu/drm/mediatek/mtk_hdmi.c:327:2: warning: enumeration value ‘HDMI_INFOFRAME_TYPE_DRM’ not handled in switch [-Wswitch]
>
> Introduced with the addition of HDMI_INFOFRAME_TYPE_DRM in the commit
> below, but the code really should have been future-proofed from the
> start.
Acked-by: CK Hu <ck.hu@mediatek.com>
>
> Fixes: 2cdbfd66a829 ("drm: Enable HDR infoframe support")
I think "drm: Enable HDR infoframe support" exist only in drm-misc tree,
could you just merge this patch to "drm: Enable HDR infoframe support"?
Regards,
CK
> Cc: Uma Shankar <uma.shankar@intel.com>
> Cc: Shashank Sharma <shashank.sharma@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> Cc: Hans Verkuil <hansverk@cisco.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-fbdev@vger.kernel.org
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index e04e6c293d39..10cc9910f164 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -341,6 +341,9 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi *hdmi, u8 *buffer,
> ctrl_frame_en = VS_EN;
> ctrl_reg = GRL_ACP_ISRC_CTRL;
> break;
> + default:
> + dev_err(hdmi->dev, "Unknown infoframe type %d\n", frame_type);
> + return;
> }
> mtk_hdmi_clear_bits(hdmi, ctrl_reg, ctrl_frame_en);
> mtk_hdmi_write(hdmi, GRL_INFOFRM_TYPE, frame_type);
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/mediatek: Fix warning about unhandled enum value
@ 2019-05-23 6:13 ` CK Hu
0 siblings, 0 replies; 8+ messages in thread
From: CK Hu @ 2019-05-23 6:13 UTC (permalink / raw)
To: Sean Paul
Cc: linux-fbdev, Daniel Vetter, Bartlomiej Zolnierkiewicz,
Maxime Ripard, Maarten Lankhorst, dri-devel, Hans Verkuil,
David Airlie, Uma Shankar, Sean Paul, Ville Syrjälä,
Philipp Zabel, Matthias Brugger, linux-mediatek,
linux-arm-kernel, Shashank Sharma
Hi, Sean:
On Wed, 2019-05-22 at 16:21 -0400, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
>
> Fixes the following build warning:
> drivers/gpu/drm/mediatek/mtk_hdmi.c:327:2: warning: enumeration value ‘HDMI_INFOFRAME_TYPE_DRM’ not handled in switch [-Wswitch]
>
> Introduced with the addition of HDMI_INFOFRAME_TYPE_DRM in the commit
> below, but the code really should have been future-proofed from the
> start.
Acked-by: CK Hu <ck.hu@mediatek.com>
>
> Fixes: 2cdbfd66a829 ("drm: Enable HDR infoframe support")
I think "drm: Enable HDR infoframe support" exist only in drm-misc tree,
could you just merge this patch to "drm: Enable HDR infoframe support"?
Regards,
CK
> Cc: Uma Shankar <uma.shankar@intel.com>
> Cc: Shashank Sharma <shashank.sharma@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> Cc: Hans Verkuil <hansverk@cisco.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-fbdev@vger.kernel.org
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index e04e6c293d39..10cc9910f164 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -341,6 +341,9 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi *hdmi, u8 *buffer,
> ctrl_frame_en = VS_EN;
> ctrl_reg = GRL_ACP_ISRC_CTRL;
> break;
> + default:
> + dev_err(hdmi->dev, "Unknown infoframe type %d\n", frame_type);
> + return;
> }
> mtk_hdmi_clear_bits(hdmi, ctrl_reg, ctrl_frame_en);
> mtk_hdmi_write(hdmi, GRL_INFOFRM_TYPE, frame_type);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/mediatek: Fix warning about unhandled enum value
2019-05-23 6:13 ` CK Hu
(?)
@ 2019-05-23 17:13 ` Sean Paul
-1 siblings, 0 replies; 8+ messages in thread
From: Sean Paul @ 2019-05-23 17:13 UTC (permalink / raw)
To: CK Hu
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, Maxime Ripard, dri-devel,
Hans Verkuil, David Airlie, Uma Shankar, Sean Paul,
Matthias Brugger, linux-mediatek, Sean Paul, linux-arm-kernel
On Thu, May 23, 2019 at 02:13:20PM +0800, CK Hu wrote:
> Hi, Sean:
>
> On Wed, 2019-05-22 at 16:21 -0400, Sean Paul wrote:
> > From: Sean Paul <seanpaul@chromium.org>
> >
> > Fixes the following build warning:
> > drivers/gpu/drm/mediatek/mtk_hdmi.c:327:2: warning: enumeration value ‘HDMI_INFOFRAME_TYPE_DRM’ not handled in switch [-Wswitch]
> >
> > Introduced with the addition of HDMI_INFOFRAME_TYPE_DRM in the commit
> > below, but the code really should have been future-proofed from the
> > start.
>
> Acked-by: CK Hu <ck.hu@mediatek.com>
>
> >
> > Fixes: 2cdbfd66a829 ("drm: Enable HDR infoframe support")
>
> I think "drm: Enable HDR infoframe support" exist only in drm-misc tree,
> could you just merge this patch to "drm: Enable HDR infoframe support"?
Yes, I've applied it to drm-misc-next. Thanks for your Ack!
Sean
>
> Regards,
> CK
>
> > Cc: Uma Shankar <uma.shankar@intel.com>
> > Cc: Shashank Sharma <shashank.sharma@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> > Cc: Sean Paul <sean@poorly.run>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> > Cc: Hans Verkuil <hansverk@cisco.com>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: linux-fbdev@vger.kernel.org
> > Signed-off-by: Sean Paul <seanpaul@chromium.org>
> > ---
> > drivers/gpu/drm/mediatek/mtk_hdmi.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > index e04e6c293d39..10cc9910f164 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > @@ -341,6 +341,9 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi *hdmi, u8 *buffer,
> > ctrl_frame_en = VS_EN;
> > ctrl_reg = GRL_ACP_ISRC_CTRL;
> > break;
> > + default:
> > + dev_err(hdmi->dev, "Unknown infoframe type %d\n", frame_type);
> > + return;
> > }
> > mtk_hdmi_clear_bits(hdmi, ctrl_reg, ctrl_frame_en);
> > mtk_hdmi_write(hdmi, GRL_INFOFRM_TYPE, frame_type);
>
>
--
Sean Paul, Software Engineer, Google / Chromium OS
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/mediatek: Fix warning about unhandled enum value
@ 2019-05-23 17:13 ` Sean Paul
0 siblings, 0 replies; 8+ messages in thread
From: Sean Paul @ 2019-05-23 17:13 UTC (permalink / raw)
To: CK Hu
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, Maxime Ripard, dri-devel,
Hans Verkuil, David Airlie, Uma Shankar, Sean Paul,
Matthias Brugger, linux-mediatek, Sean Paul, linux-arm-kernel
On Thu, May 23, 2019 at 02:13:20PM +0800, CK Hu wrote:
> Hi, Sean:
>
> On Wed, 2019-05-22 at 16:21 -0400, Sean Paul wrote:
> > From: Sean Paul <seanpaul@chromium.org>
> >
> > Fixes the following build warning:
> > drivers/gpu/drm/mediatek/mtk_hdmi.c:327:2: warning: enumeration value ‘HDMI_INFOFRAME_TYPE_DRM’ not handled in switch [-Wswitch]
> >
> > Introduced with the addition of HDMI_INFOFRAME_TYPE_DRM in the commit
> > below, but the code really should have been future-proofed from the
> > start.
>
> Acked-by: CK Hu <ck.hu@mediatek.com>
>
> >
> > Fixes: 2cdbfd66a829 ("drm: Enable HDR infoframe support")
>
> I think "drm: Enable HDR infoframe support" exist only in drm-misc tree,
> could you just merge this patch to "drm: Enable HDR infoframe support"?
Yes, I've applied it to drm-misc-next. Thanks for your Ack!
Sean
>
> Regards,
> CK
>
> > Cc: Uma Shankar <uma.shankar@intel.com>
> > Cc: Shashank Sharma <shashank.sharma@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> > Cc: Sean Paul <sean@poorly.run>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> > Cc: Hans Verkuil <hansverk@cisco.com>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: linux-fbdev@vger.kernel.org
> > Signed-off-by: Sean Paul <seanpaul@chromium.org>
> > ---
> > drivers/gpu/drm/mediatek/mtk_hdmi.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > index e04e6c293d39..10cc9910f164 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > @@ -341,6 +341,9 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi *hdmi, u8 *buffer,
> > ctrl_frame_en = VS_EN;
> > ctrl_reg = GRL_ACP_ISRC_CTRL;
> > break;
> > + default:
> > + dev_err(hdmi->dev, "Unknown infoframe type %d\n", frame_type);
> > + return;
> > }
> > mtk_hdmi_clear_bits(hdmi, ctrl_reg, ctrl_frame_en);
> > mtk_hdmi_write(hdmi, GRL_INFOFRM_TYPE, frame_type);
>
>
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/mediatek: Fix warning about unhandled enum value
@ 2019-05-23 17:13 ` Sean Paul
0 siblings, 0 replies; 8+ messages in thread
From: Sean Paul @ 2019-05-23 17:13 UTC (permalink / raw)
To: CK Hu
Cc: linux-fbdev, Daniel Vetter, Bartlomiej Zolnierkiewicz,
Maxime Ripard, Maarten Lankhorst, dri-devel, Hans Verkuil,
David Airlie, Uma Shankar, Sean Paul, Ville Syrjälä,
Philipp Zabel, Matthias Brugger, linux-mediatek, Sean Paul,
linux-arm-kernel, Shashank Sharma
On Thu, May 23, 2019 at 02:13:20PM +0800, CK Hu wrote:
> Hi, Sean:
>
> On Wed, 2019-05-22 at 16:21 -0400, Sean Paul wrote:
> > From: Sean Paul <seanpaul@chromium.org>
> >
> > Fixes the following build warning:
> > drivers/gpu/drm/mediatek/mtk_hdmi.c:327:2: warning: enumeration value ‘HDMI_INFOFRAME_TYPE_DRM’ not handled in switch [-Wswitch]
> >
> > Introduced with the addition of HDMI_INFOFRAME_TYPE_DRM in the commit
> > below, but the code really should have been future-proofed from the
> > start.
>
> Acked-by: CK Hu <ck.hu@mediatek.com>
>
> >
> > Fixes: 2cdbfd66a829 ("drm: Enable HDR infoframe support")
>
> I think "drm: Enable HDR infoframe support" exist only in drm-misc tree,
> could you just merge this patch to "drm: Enable HDR infoframe support"?
Yes, I've applied it to drm-misc-next. Thanks for your Ack!
Sean
>
> Regards,
> CK
>
> > Cc: Uma Shankar <uma.shankar@intel.com>
> > Cc: Shashank Sharma <shashank.sharma@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> > Cc: Sean Paul <sean@poorly.run>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> > Cc: Hans Verkuil <hansverk@cisco.com>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: linux-fbdev@vger.kernel.org
> > Signed-off-by: Sean Paul <seanpaul@chromium.org>
> > ---
> > drivers/gpu/drm/mediatek/mtk_hdmi.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > index e04e6c293d39..10cc9910f164 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > @@ -341,6 +341,9 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi *hdmi, u8 *buffer,
> > ctrl_frame_en = VS_EN;
> > ctrl_reg = GRL_ACP_ISRC_CTRL;
> > break;
> > + default:
> > + dev_err(hdmi->dev, "Unknown infoframe type %d\n", frame_type);
> > + return;
> > }
> > mtk_hdmi_clear_bits(hdmi, ctrl_reg, ctrl_frame_en);
> > mtk_hdmi_write(hdmi, GRL_INFOFRM_TYPE, frame_type);
>
>
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-05-23 17:13 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-22 20:21 [PATCH] drm/mediatek: Fix warning about unhandled enum value Sean Paul
2019-05-22 20:21 ` Sean Paul
2019-05-22 20:21 ` Sean Paul
2019-05-23 6:13 ` CK Hu
2019-05-23 6:13 ` CK Hu
2019-05-23 17:13 ` Sean Paul
2019-05-23 17:13 ` Sean Paul
2019-05-23 17:13 ` Sean Paul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.