* [Qemu-devel] [PATCH] configure: Only enable iconv if curses is enabled
@ 2019-05-17 21:18 Kumar Gala
2019-05-24 7:07 ` Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: Kumar Gala @ 2019-05-17 21:18 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, Kumar Gala, kraxel
iconv is only used with if curses is enabled, there's no need to do any
configure checking for iconv, if curses is disabled. Also, ignore
--enable-iconv if curses is already disabled.
Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
---
configure | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index d2fc346302..a1b60fa977 100755
--- a/configure
+++ b/configure
@@ -1235,13 +1235,18 @@ for opt do
;;
--disable-stack-protector) stack_protector="no"
;;
- --disable-curses) curses="no"
+ --disable-curses)
+ curses="no"
+ iconv="no"
;;
--enable-curses) curses="yes"
;;
--disable-iconv) iconv="no"
;;
- --enable-iconv) iconv="yes"
+ --enable-iconv)
+ if test "$curses" != "no" ; then
+ iconv="yes"
+ fi
;;
--disable-curl) curl="no"
;;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Only enable iconv if curses is enabled
2019-05-17 21:18 [Qemu-devel] [PATCH] configure: Only enable iconv if curses is enabled Kumar Gala
@ 2019-05-24 7:07 ` Gerd Hoffmann
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2019-05-24 7:07 UTC (permalink / raw)
To: Kumar Gala; +Cc: peter.maydell, qemu-devel
On Fri, May 17, 2019 at 04:18:05PM -0500, Kumar Gala wrote:
> iconv is only used with if curses is enabled, there's no need to do any
> configure checking for iconv, if curses is disabled. Also, ignore
> --enable-iconv if curses is already disabled.
How about just doing this ...
--- a/configure
+++ b/configure
@@ -3551,6 +3551,7 @@ EOF
feature_not_found "curses" "Install ncurses devel"
fi
curses=no
+ iconv=no # curses is the only user
fi
fi
... instead?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-24 7:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-17 21:18 [Qemu-devel] [PATCH] configure: Only enable iconv if curses is enabled Kumar Gala
2019-05-24 7:07 ` Gerd Hoffmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.