[PATCH 0/2] Fixes for staging/kpc2000's Kconfig

[PATCH 0/2] Fixes for staging/kpc2000's Kconfig

[Simon Sandström]

Hi,

Here are two patches that fixes issues in kpc2000's Kconfig.

The first one is a typo fix (I'm guessing Kaktronics is a typo...).

The second one is a fix for a dependency issues I met when trying to
build kpc2000 on a default x86_64 config. I'm not familiar with neither
MFD nor UIO, so I'm not sure that I solved it correctly. Maybe there are
some other things to consider as this is in staging?


- Simon

Simon Sandström (2):
  staging: kpc2000: fix typo in Kconfig
  staging: kpc2000: add missing dependencies for kpc2000

 drivers/staging/kpc2000/Kconfig | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

-- 
2.20.1

[PATCH 1/2] staging: kpc2000: fix typo in Kconfig

[Simon Sandström]

Fixes two minor typos in kpc2000's Kconfig: s/Kaktronics/Daktronics

Signed-off-by: Simon Sandström <simon@nikanor.nu>
---
 drivers/staging/kpc2000/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/kpc2000/Kconfig b/drivers/staging/kpc2000/Kconfig
index fb5922928f47..c463d232f2b4 100644
--- a/drivers/staging/kpc2000/Kconfig
+++ b/drivers/staging/kpc2000/Kconfig
@@ -21,7 +21,7 @@ config KPC2000_CORE
 	  If unsure, say N.
 
 config KPC2000_SPI
-	tristate "Kaktronics KPC SPI device"
+	tristate "Daktronics KPC SPI device"
 	depends on KPC2000 && SPI
 	help
 	  Say Y here if you wish to support the Daktronics KPC PCI
@@ -33,7 +33,7 @@ config KPC2000_SPI
 	  If unsure, say N.
 
 config KPC2000_I2C
-	tristate "Kaktronics KPC I2C device"
+	tristate "Daktronics KPC I2C device"
 	depends on KPC2000 && I2C
 	help
 	  Say Y here if you wish to support the Daktronics KPC PCI
-- 
2.20.1

[PATCH 2/2] staging: kpc2000: add missing dependencies for kpc2000

[Simon Sandström]

Fixes build errors:

ERROR: "mfd_remove_devices" [kpc2000.ko] undefined!
ERROR: "uio_unregister_device" [kpc2000.ko] undefined!
ERROR: "mfd_add_devices" [kpc2000.ko] undefined!
ERROR: "__uio_register_device" [kpc2000.ko] undefined!

Signed-off-by: Simon Sandström <simon@nikanor.nu>
---
 drivers/staging/kpc2000/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/kpc2000/Kconfig b/drivers/staging/kpc2000/Kconfig
index c463d232f2b4..5188b56123ab 100644
--- a/drivers/staging/kpc2000/Kconfig
+++ b/drivers/staging/kpc2000/Kconfig
@@ -3,6 +3,8 @@
 config KPC2000
 	bool "Daktronics KPC Device support"
 	depends on PCI
+	select MFD_CORE
+	select UIO
 	help
 	  Select this if you wish to use the Daktronics KPC PCI devices
 
-- 
2.20.1

Re: [PATCH 2/2] staging: kpc2000: add missing dependencies for kpc2000

[Greg KH]

On Fri, May 24, 2019 at 10:30:58PM +0200, Simon Sandström wrote:
> Fixes build errors:
> 
> ERROR: "mfd_remove_devices" [kpc2000.ko] undefined!
> ERROR: "uio_unregister_device" [kpc2000.ko] undefined!
> ERROR: "mfd_add_devices" [kpc2000.ko] undefined!
> ERROR: "__uio_register_device" [kpc2000.ko] undefined!
> 
> Signed-off-by: Simon Sandström <simon@nikanor.nu>
> ---
>  drivers/staging/kpc2000/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/kpc2000/Kconfig b/drivers/staging/kpc2000/Kconfig
> index c463d232f2b4..5188b56123ab 100644
> --- a/drivers/staging/kpc2000/Kconfig
> +++ b/drivers/staging/kpc2000/Kconfig
> @@ -3,6 +3,8 @@
>  config KPC2000
>  	bool "Daktronics KPC Device support"
>  	depends on PCI
> +	select MFD_CORE
> +	select UIO
>  	help
>  	  Select this if you wish to use the Daktronics KPC PCI devices
>  

This is already in linux-next (in a different form), are you sure you
are working against the latest kernel tree?

thanks,

greg k-h

Re: [PATCH 2/2] staging: kpc2000: add missing dependencies for kpc2000

[Simon Sandström]

On Sat, May 25, 2019 at 07:00:17AM +0200, Greg KH wrote:
> On Fri, May 24, 2019 at 10:30:58PM +0200, Simon Sandström wrote:
> > Fixes build errors:
> > 
> > ERROR: "mfd_remove_devices" [kpc2000.ko] undefined!
> > ERROR: "uio_unregister_device" [kpc2000.ko] undefined!
> > ERROR: "mfd_add_devices" [kpc2000.ko] undefined!
> > ERROR: "__uio_register_device" [kpc2000.ko] undefined!
> > 
> > Signed-off-by: Simon Sandström <simon@nikanor.nu>
> > ---
> >  drivers/staging/kpc2000/Kconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/staging/kpc2000/Kconfig b/drivers/staging/kpc2000/Kconfig
> > index c463d232f2b4..5188b56123ab 100644
> > --- a/drivers/staging/kpc2000/Kconfig
> > +++ b/drivers/staging/kpc2000/Kconfig
> > @@ -3,6 +3,8 @@
> >  config KPC2000
> >  	bool "Daktronics KPC Device support"
> >  	depends on PCI
> > +	select MFD_CORE
> > +	select UIO
> >  	help
> >  	  Select this if you wish to use the Daktronics KPC PCI devices
> >  
> 
> This is already in linux-next (in a different form), are you sure you
> are working against the latest kernel tree?
> 
> thanks,
> 
> greg k-h

It's based on your staging tree. I think that I have to go back and read
about next trees again, because I thought it took longer time for things
to get from staging-next to linux-next.

Anyway, neither the MFD_CORE nor the typo fix is in linux-next so I
guess that I could just rebase this on linux-next and re-send as v2.
I'm not sure if MFD_CORE should be "depends on" or "select" though...


- Simon

Re: [PATCH 2/2] staging: kpc2000: add missing dependencies for kpc2000

[Simon Sandström]

On Sat, May 25, 2019 at 10:39:18AM +0200, Simon Sandström wrote:
> On Sat, May 25, 2019 at 07:00:17AM +0200, Greg KH wrote:
> > 
> > This is already in linux-next (in a different form), are you sure you
> > are working against the latest kernel tree?
> > 
> > thanks,
> > 
> > greg k-h
> 
> It's based on your staging tree. I think that I have to go back and read
> about next trees again, because I thought it took longer time for things
> to get from staging-next to linux-next.
> 
> Anyway, neither the MFD_CORE nor the typo fix is in linux-next so I
> guess that I could just rebase this on linux-next and re-send as v2.
> I'm not sure if MFD_CORE should be "depends on" or "select" though...
> 
> 
> - Simon

Oh, it must be "select MFD_CORE" because there is no prompt for
MFD_CORE? Should I just rebase it on linux-next and re-send as v2 then?


- Simon

Re: [PATCH 2/2] staging: kpc2000: add missing dependencies for kpc2000

[Greg KH]

On Sat, May 25, 2019 at 11:24:04AM +0200, Simon Sandström wrote:
> On Sat, May 25, 2019 at 10:39:18AM +0200, Simon Sandström wrote:
> > On Sat, May 25, 2019 at 07:00:17AM +0200, Greg KH wrote:
> > > 
> > > This is already in linux-next (in a different form), are you sure you
> > > are working against the latest kernel tree?
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > It's based on your staging tree. I think that I have to go back and read
> > about next trees again, because I thought it took longer time for things
> > to get from staging-next to linux-next.
> > 
> > Anyway, neither the MFD_CORE nor the typo fix is in linux-next so I
> > guess that I could just rebase this on linux-next and re-send as v2.
> > I'm not sure if MFD_CORE should be "depends on" or "select" though...
> > 
> > 
> > - Simon
> 
> Oh, it must be "select MFD_CORE" because there is no prompt for
> MFD_CORE? Should I just rebase it on linux-next and re-send as v2 then?

Yes please.