All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH/next 1/1] package/iputils: fix build with nettle
@ 2019-05-21 17:23 Fabrice Fontaine
  2019-05-21 19:41 ` Petr Vorel
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2019-05-21 17:23 UTC (permalink / raw)
  To: buildroot

Fixes:
 - http://autobuild.buildroot.org/results/e86555090e27b631ba35214ef100aa9331844684

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 ...-ninfod_name.c-fix-build-with-nettle.patch | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/iputils/0001-ninfod-ninfod_name.c-fix-build-with-nettle.patch

diff --git a/package/iputils/0001-ninfod-ninfod_name.c-fix-build-with-nettle.patch b/package/iputils/0001-ninfod-ninfod_name.c-fix-build-with-nettle.patch
new file mode 100644
index 0000000000..796185011a
--- /dev/null
+++ b/package/iputils/0001-ninfod-ninfod_name.c-fix-build-with-nettle.patch
@@ -0,0 +1,38 @@
+From f209ebb91e65980bcdddce8cc12b00ec11623f76 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Tue, 21 May 2019 19:14:18 +0200
+Subject: [PATCH] ninfod/ninfod_name.c: fix build with nettle
+
+Build of ninfod with nettle fails on:
+/home/test/autobuild/run/instance-1/output/host/bin/mips64el-linux-gcc  -o ninfod/ninfod 'ninfod/0cb6efe@@ninfod at exe/ni_ifaddrs.c.o' 'ninfod/0cb6efe@@ninfod at exe/ninfod.c.o' 'ninfod/0cb6efe@@ninfod at exe/ninfod_addrs.c.o' 'ninfod/0cb6efe@@ninfod at exe/ninfod_core.c.o' 'ninfod/0cb6efe@@ninfod at exe/ninfod_name.c.o' -Wl,--no-undefined -Wl,--as-needed -Wl,-O1 -Wl,--start-group libcommon.a -lcap /home/test/autobuild/run/instance-1/output/host/usr/bin/../mips64el-buildroot-linux-uclibc/sysroot/usr/lib/libnettle.so -Wl,--end-group -pthread '-Wl,-rpath,$ORIGIN/..:/home/test/autobuild/run/instance-1/output/host/usr/bin/../mips64el-buildroot-linux-uclibc/sysroot/usr/lib' -Wl,-rpath-link,/home/test/autobuild/run/instance-1/output/build/iputils-s20190515/build/:/home/test/autobuild/run/instance-1/output/host/usr/bin/../mips64el-buildroot-linux-uclibc/sysroot/usr/lib
+ninfod/0cb6efe@@ninfod at exe/ninfod_name.c.o: In function `init_nodeinfo_nodename':
+ninfod_name.c:(.text+0x378): undefined reference to `MD5_Init'
+
+This error is raised because MD5_Init is not defined by nettle.
+To fix this error, include iputils_md5dig.h if USE_NETTLE is defined.
+
+Fixes:
+ - http://autobuild.buildroot.org/results/e86555090e27b631ba35214ef100aa9331844684
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Upstream status: https://github.com/iputils/iputils/pull/181]
+---
+ ninfod/ninfod_name.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/ninfod/ninfod_name.c b/ninfod/ninfod_name.c
+index daf606d..525c93d 100644
+--- a/ninfod/ninfod_name.c
++++ b/ninfod/ninfod_name.c
+@@ -95,7 +95,7 @@
+ 
+ #include <arpa/inet.h>
+ 
+-#if defined(HAVE_GCRYPT_H) || defined(USE_KERNEL_CRYPTO_API)
++#if defined(HAVE_GCRYPT_H) || defined(USE_KERNEL_CRYPTO_API) || defined(USE_NETTLE)
+ # include "iputils_md5dig.h"
+ #elif defined(HAVE_GNUTLS_OPENSSL_H)
+ # include <gnutls/openssl.h>
+-- 
+2.20.1
+
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH/next 1/1] package/iputils: fix build with nettle
  2019-05-21 17:23 [Buildroot] [PATCH/next 1/1] package/iputils: fix build with nettle Fabrice Fontaine
@ 2019-05-21 19:41 ` Petr Vorel
  2019-05-22  6:40 ` Petr Vorel
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2019-05-21 19:41 UTC (permalink / raw)
  To: buildroot

Hi Fabrice,

> Fixes:
>  - http://autobuild.buildroot.org/results/e86555090e27b631ba35214ef100aa9331844684

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Acked-by: Petr Vorel <petr.vorel@gmail.com>

Thanks for your fix!
...
> +Fixes:
> + - http://autobuild.buildroot.org/results/e86555090e27b631ba35214ef100aa9331844684
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +[Upstream status: https://github.com/iputils/iputils/pull/181]
Actually merged as f209ebb ("ninfod/ninfod_name.c: fix build with nettle")
Upstream status: f209ebb91e65980bcdddce8cc12b00ec11623f76

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH/next 1/1] package/iputils: fix build with nettle
  2019-05-21 17:23 [Buildroot] [PATCH/next 1/1] package/iputils: fix build with nettle Fabrice Fontaine
  2019-05-21 19:41 ` Petr Vorel
@ 2019-05-22  6:40 ` Petr Vorel
  2019-05-24 11:26 ` Petr Vorel
  2019-05-26 12:32 ` Thomas Petazzoni
  3 siblings, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2019-05-22  6:40 UTC (permalink / raw)
  To: buildroot

Hi,

> Fixes:
>  - http://autobuild.buildroot.org/results/e86555090e27b631ba35214ef100aa9331844684

FYI this fixes failures for other archs (I guess incomplete list):
      riscv64 |              iputils-s20190515 | http://autobuild.buildroot.net/results/f78ac0d3c9a679a584bd54ac7f908390f5a4087b
       xtensa |              iputils-s20190515 | http://autobuild.buildroot.net/results/a15323897950f8166f2b14f235a36cd88387d5de

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH/next 1/1] package/iputils: fix build with nettle
  2019-05-21 17:23 [Buildroot] [PATCH/next 1/1] package/iputils: fix build with nettle Fabrice Fontaine
  2019-05-21 19:41 ` Petr Vorel
  2019-05-22  6:40 ` Petr Vorel
@ 2019-05-24 11:26 ` Petr Vorel
  2019-05-26 12:32 ` Thomas Petazzoni
  3 siblings, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2019-05-24 11:26 UTC (permalink / raw)
  To: buildroot

Hi Peter,

can you please merge this fix to next?
Thanks a lot.

Kind regards,
Petr

> Fixes:
>  - http://autobuild.buildroot.org/results/e86555090e27b631ba35214ef100aa9331844684

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...-ninfod_name.c-fix-build-with-nettle.patch | 38 +++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 package/iputils/0001-ninfod-ninfod_name.c-fix-build-with-nettle.patch

> diff --git a/package/iputils/0001-ninfod-ninfod_name.c-fix-build-with-nettle.patch b/package/iputils/0001-ninfod-ninfod_name.c-fix-build-with-nettle.patch
> new file mode 100644
> index 0000000000..796185011a
> --- /dev/null
> +++ b/package/iputils/0001-ninfod-ninfod_name.c-fix-build-with-nettle.patch
> @@ -0,0 +1,38 @@
> +From f209ebb91e65980bcdddce8cc12b00ec11623f76 Mon Sep 17 00:00:00 2001
> +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Date: Tue, 21 May 2019 19:14:18 +0200
> +Subject: [PATCH] ninfod/ninfod_name.c: fix build with nettle
> +
> +Build of ninfod with nettle fails on:
> +/home/test/autobuild/run/instance-1/output/host/bin/mips64el-linux-gcc  -o ninfod/ninfod 'ninfod/0cb6efe@@ninfod at exe/ni_ifaddrs.c.o' 'ninfod/0cb6efe@@ninfod at exe/ninfod.c.o' 'ninfod/0cb6efe@@ninfod at exe/ninfod_addrs.c.o' 'ninfod/0cb6efe@@ninfod at exe/ninfod_core.c.o' 'ninfod/0cb6efe@@ninfod at exe/ninfod_name.c.o' -Wl,--no-undefined -Wl,--as-needed -Wl,-O1 -Wl,--start-group libcommon.a -lcap /home/test/autobuild/run/instance-1/output/host/usr/bin/../mips64el-buildroot-linux-uclibc/sysroot/usr/lib/libnettle.so -Wl,--end-group -pthread '-Wl,-rpath,$ORIGIN/..:/home/test/autobuild/run/instance-1/output/host/usr/bin/../mips64el-buildroot-linux-uclibc/sysroot/usr/lib' -Wl,-rpath-link,/home/test/autobuild/run/instance-1/output/build/iputils-s20190515/build/:/home/test/autobuild/run/instance-1/output/host/usr/bin/../mips64el-buildroot-linux-uclibc/sysroot/usr/lib
> +ninfod/0cb6efe@@ninfod at exe/ninfod_name.c.o: In function `init_nodeinfo_nodename':
> +ninfod_name.c:(.text+0x378): undefined reference to `MD5_Init'
> +
> +This error is raised because MD5_Init is not defined by nettle.
> +To fix this error, include iputils_md5dig.h if USE_NETTLE is defined.
> +
> +Fixes:
> + - http://autobuild.buildroot.org/results/e86555090e27b631ba35214ef100aa9331844684
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +[Upstream status: https://github.com/iputils/iputils/pull/181]
> +---
> + ninfod/ninfod_name.c | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/ninfod/ninfod_name.c b/ninfod/ninfod_name.c
> +index daf606d..525c93d 100644
> +--- a/ninfod/ninfod_name.c
> ++++ b/ninfod/ninfod_name.c
> +@@ -95,7 +95,7 @@
> + 
> + #include <arpa/inet.h>
> + 
> +-#if defined(HAVE_GCRYPT_H) || defined(USE_KERNEL_CRYPTO_API)
> ++#if defined(HAVE_GCRYPT_H) || defined(USE_KERNEL_CRYPTO_API) || defined(USE_NETTLE)
> + # include "iputils_md5dig.h"
> + #elif defined(HAVE_GNUTLS_OPENSSL_H)
> + # include <gnutls/openssl.h>
> +-- 
> +2.20.1
> +

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH/next 1/1] package/iputils: fix build with nettle
  2019-05-21 17:23 [Buildroot] [PATCH/next 1/1] package/iputils: fix build with nettle Fabrice Fontaine
                   ` (2 preceding siblings ...)
  2019-05-24 11:26 ` Petr Vorel
@ 2019-05-26 12:32 ` Thomas Petazzoni
  3 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2019-05-26 12:32 UTC (permalink / raw)
  To: buildroot

On Tue, 21 May 2019 19:23:25 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fixes:
>  - http://autobuild.buildroot.org/results/e86555090e27b631ba35214ef100aa9331844684
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...-ninfod_name.c-fix-build-with-nettle.patch | 38 +++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 package/iputils/0001-ninfod-ninfod_name.c-fix-build-with-nettle.patch

Applied to next, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-05-26 12:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-21 17:23 [Buildroot] [PATCH/next 1/1] package/iputils: fix build with nettle Fabrice Fontaine
2019-05-21 19:41 ` Petr Vorel
2019-05-22  6:40 ` Petr Vorel
2019-05-24 11:26 ` Petr Vorel
2019-05-26 12:32 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.