From: Vinod Koul <vkoul@kernel.org> To: Sascha Hauer <s.hauer@pengutronix.de> Cc: yibin.gong@nxp.com, robh@kernel.org, shawnguo@kernel.org, festevam@gmail.com, mark.rutland@arm.com, dan.j.williams@intel.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 6/7] dmaengine: fsl-edma: add i.mx7ulp edma2 version support Date: Mon, 27 May 2019 15:40:03 +0530 [thread overview] Message-ID: <20190527101003.GI15118@vkoul-mobl> (raw) In-Reply-To: <20190527090553.lek7tm3lyst3bhrd@pengutronix.de> On 27-05-19, 11:05, Sascha Hauer wrote: > On Mon, May 27, 2019 at 04:51:17PM +0800, yibin.gong@nxp.com wrote: > > From: Robin Gong <yibin.gong@nxp.com> > > > > +static const struct of_device_id fsl_edma_dt_ids[] = { > > + { .compatible = "fsl,vf610-edma", .data = (void *)v1 }, > > + { .compatible = "fsl,imx7ulp-edma", .data = (void *)v3 }, > > + { /* sentinel */ } > > Please put a struct type behind the .data pointer so that you can > configure... Yeah that was the idea behind the suggestion in previous version. Something like struct fsl_edma_driver_data { unsigned int channels; ... }; and then you have const struct fsl_edma_driver_data v1_data { .channels = 1; ... }; > > > +}; > > +MODULE_DEVICE_TABLE(of, fsl_edma_dt_ids); > > + > > @@ -218,6 +272,22 @@ static int fsl_edma_probe(struct platform_device *pdev) > > fsl_edma_setup_regs(fsl_edma); > > regs = &fsl_edma->regs; > > > > + if (fsl_edma->version == v3) { > > + fsl_edma->dmamux_nr = 1; You can store the struct in driver context or store the values, so here it becomes driver->data->channel; and so on for other data, you can also point function pointers (hint edma/2_irq_init) > > ...things like this... > > > @@ -264,7 +334,11 @@ static int fsl_edma_probe(struct platform_device *pdev) > > } > > > > edma_writel(fsl_edma, ~0, regs->intl); > > - ret = fsl_edma_irq_init(pdev, fsl_edma); > > + > > + if (fsl_edma->version == v3) > > + ret = fsl_edma2_irq_init(pdev, fsl_edma); > > + else > > + ret = fsl_edma_irq_init(pdev, fsl_edma); > > ...and this one in that struct rather than littering the code more and > more with such version tests. > > Sascha > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org> To: Sascha Hauer <s.hauer@pengutronix.de> Cc: mark.rutland@arm.com, robh@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, dmaengine@vger.kernel.org, dan.j.williams@intel.com, yibin.gong@nxp.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 6/7] dmaengine: fsl-edma: add i.mx7ulp edma2 version support Date: Mon, 27 May 2019 15:40:03 +0530 [thread overview] Message-ID: <20190527101003.GI15118@vkoul-mobl> (raw) In-Reply-To: <20190527090553.lek7tm3lyst3bhrd@pengutronix.de> On 27-05-19, 11:05, Sascha Hauer wrote: > On Mon, May 27, 2019 at 04:51:17PM +0800, yibin.gong@nxp.com wrote: > > From: Robin Gong <yibin.gong@nxp.com> > > > > +static const struct of_device_id fsl_edma_dt_ids[] = { > > + { .compatible = "fsl,vf610-edma", .data = (void *)v1 }, > > + { .compatible = "fsl,imx7ulp-edma", .data = (void *)v3 }, > > + { /* sentinel */ } > > Please put a struct type behind the .data pointer so that you can > configure... Yeah that was the idea behind the suggestion in previous version. Something like struct fsl_edma_driver_data { unsigned int channels; ... }; and then you have const struct fsl_edma_driver_data v1_data { .channels = 1; ... }; > > > +}; > > +MODULE_DEVICE_TABLE(of, fsl_edma_dt_ids); > > + > > @@ -218,6 +272,22 @@ static int fsl_edma_probe(struct platform_device *pdev) > > fsl_edma_setup_regs(fsl_edma); > > regs = &fsl_edma->regs; > > > > + if (fsl_edma->version == v3) { > > + fsl_edma->dmamux_nr = 1; You can store the struct in driver context or store the values, so here it becomes driver->data->channel; and so on for other data, you can also point function pointers (hint edma/2_irq_init) > > ...things like this... > > > @@ -264,7 +334,11 @@ static int fsl_edma_probe(struct platform_device *pdev) > > } > > > > edma_writel(fsl_edma, ~0, regs->intl); > > - ret = fsl_edma_irq_init(pdev, fsl_edma); > > + > > + if (fsl_edma->version == v3) > > + ret = fsl_edma2_irq_init(pdev, fsl_edma); > > + else > > + ret = fsl_edma_irq_init(pdev, fsl_edma); > > ...and this one in that struct rather than littering the code more and > more with such version tests. > > Sascha > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-27 10:10 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-27 8:51 [PATCH v2 0/7] add edma2 for i.mx7ulp yibin.gong 2019-05-27 8:51 ` yibin.gong 2019-05-27 8:51 ` [PATCH v2 1/7] dmaengine: fsl-edma: add dmamux_nr for next version yibin.gong 2019-05-27 8:51 ` yibin.gong 2019-05-27 8:51 ` yibin.gong 2019-05-27 8:51 ` [PATCH v2 2/7] dmaengine: mcf-edma: update to 'dmamux_nr' yibin.gong 2019-05-27 8:51 ` yibin.gong 2019-05-27 8:51 ` [PATCH v2 3/7] dmaengine: fsl-edma-common: move dmamux register to another single function yibin.gong 2019-05-27 8:51 ` yibin.gong 2019-05-27 8:51 ` [PATCH v2 4/7] dmaengine: fsl-edma-common: version check for v2 instead yibin.gong 2019-05-27 8:51 ` yibin.gong 2019-05-27 9:08 ` Sascha Hauer 2019-05-27 9:08 ` Sascha Hauer 2019-05-27 9:52 ` Robin Gong 2019-05-27 9:52 ` Robin Gong 2019-05-27 9:52 ` Robin Gong 2019-05-27 8:51 ` [PATCH v2 5/7] dt-bindings: dma: fsl-edma: add new i.mx7ulp-edma yibin.gong 2019-05-27 8:51 ` yibin.gong 2019-05-27 8:51 ` [PATCH v2 6/7] dmaengine: fsl-edma: add i.mx7ulp edma2 version support yibin.gong 2019-05-27 8:51 ` yibin.gong 2019-05-27 9:05 ` Sascha Hauer 2019-05-27 9:05 ` Sascha Hauer 2019-05-27 10:04 ` Robin Gong 2019-05-27 10:04 ` Robin Gong 2019-05-27 10:04 ` Robin Gong 2019-05-27 10:10 ` Vinod Koul [this message] 2019-05-27 10:10 ` Vinod Koul 2019-05-27 8:51 ` [PATCH v2 7/7] ARM: dts: imx7ulp: add edma device node yibin.gong 2019-05-27 8:51 ` yibin.gong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190527101003.GI15118@vkoul-mobl \ --to=vkoul@kernel.org \ --cc=dan.j.williams@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=yibin.gong@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.